Re: [PATCH v4 1/2] ARC: IRQ: Do not use hwirq as virq and vice versa

2016-11-07 Thread Vineet Gupta
Hi Noam, I'm planning to merge this valid patch. Please look at arc mailing list for more context ! Can you please check if this doesn't break ur platform and/or requires a fixup. Thx, -Vineet On 11/07/2016 11:08 PM, Yuriy Kolerov wrote: > At first smp_ipi_irq_setup() takes a cpu number and a

[PATCH v4 0/2] ARC: Set of patches for IRQ subsystem

2016-11-07 Thread Yuriy Kolerov
The first patch fixes misuse of IRQ numbers. In some places of the Linux kernel for ARC hardware IRQ numbers are used as virtual IRQ numbers and obviously it is wrong. The second patch forces the kernel to set a simple distribution mode for common interrupts in cases when such interrupts are route

[PATCH v4 2/2] ARCv2: MCIP: Use IDU_M_DISTRI_DEST mode if there is only 1 destination core

2016-11-07 Thread Yuriy Kolerov
ARC linux uses 2 distribution modes for common interrupts: round robin mode (IDU_M_DISTRI_RR) and a simple destination mode (IDU_M_DISTRI_DEST). The first one is used when more than 1 cores may handle a common interrupt and the second one is used when only 1 core may handle a common interrupt. How

[PATCH v4 1/2] ARC: IRQ: Do not use hwirq as virq and vice versa

2016-11-07 Thread Yuriy Kolerov
At first smp_ipi_irq_setup() takes a cpu number and a hwirq number for the per core local interrupt line in the root interrupt controller and registers an appropriate IPI handler per cpu. However this function tries to bind a handler to the hwirq as virtual IRQ number and it is a wrong behavior. It

RE: [PATCH v3 2/3] ARCv2: MCIP: Use hwirq instead of virq for resolution of IDU IRQ handlers

2016-11-07 Thread Yuriy Kolerov
Yes, theoretically this may not work with 1/3 and 2/3. I will merge those patches. > -Original Message- > From: Vineet Gupta [mailto:vgu...@synopsys.com] > Sent: Tuesday, November 08, 2016 4:59 AM > To: Yuriy Kolerov ; linux-snps- > a...@lists.infradead.org > Cc: alexey.brod...@synopsys.c

Re: [PATCH v3 2/3] ARCv2: MCIP: Use hwirq instead of virq for resolution of IDU IRQ handlers

2016-11-07 Thread Vineet Gupta
On 11/03/2016 05:23 AM, Yuriy Kolerov wrote: > Multicore ARC configurations use IDU (Interrupt Distribution Unit) for > distributing of common interrupts. In fact IDU is a interrupt controller > on top of main per core interrupt controller. > > All common IRQs are physically and linearly mapped to

[PATCH v4 07/10] ARC: breakout aux handling into a separate header

2016-11-07 Thread Vineet Gupta
ARC timers use aux registers for programming and this paves way for moving ARC timer drivers into drivers/clocksource Reviewed-by: kbuild test robot Signed-off-by: Vineet Gupta --- v3 -> v4 - rolled back update of nps header to use the new aux header as that requires prior fixing. --- arch/

[PATCH v4 07/10] ARC: breakout aux handling into a separate header

2016-11-07 Thread Vineet Gupta
ARC timers use aux registers for programming and this paves way for moving ARC timer drivers into drivers/clocksource Reviewed-by: kbuild test robot Signed-off-by: Vineet Gupta --- v3 -> v4 - rolled back update of nps header to use the new aux header as that requires prior fixing. --- arch/

Re: [PATCH] ARC: [plat-eznps] remove IPI clear from SMP operations

2016-11-07 Thread Vineet Gupta
On 11/06/2016 11:34 PM, Noam Camus wrote: > From: Noam Camus > > Generic IRQ mechanism is already acknowledge the IPI IRQ. > Doing this once more time in IPI handler is not needed. Changelog can be improved ! Generic IRQ mechanism can't ack the irq. The NPQ irqchip driver does this for all irqs

[PATCH] ARC: tweak semantics of userspace cmpxchg assist

2016-11-07 Thread Vineet Gupta
The original code only used to return errno to indicate if cmpxchg succeeded. It was not returning the "previous" value which typical cmpxhg callers are interested in to build their slowpaths or retry loops. Given user preemption in syscall return path etc, it is not wise to check this in userspace

Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

2016-11-07 Thread Andy Shevchenko
On Wed, 2016-11-02 at 11:55 +, Eugeniy Paltsev wrote: > Hi Andy, > Could you possibly tell me your ideas about these changes? > Thanks. Thanks for an update, but, please, answer to all my comments to your patch v2. Either you are okay with them, then you didn't address few, or you are not okay