RE: [RFC 1/2] mmc: core: support UHS-II in core stack.

2015-01-21 Thread Sun, Yi Y
Hi, > On 27 December 2014 at 10:27, Yi Sun > wrote: >> This patch adds the UHS-II support in core layer. This is a RFC patch for >> community review. >> >> Signed-off-by: Yi Sun > >> --- >> drivers/mmc/core/Makefile |3 +- >> drivers/mmc/core/bus.c|5 +- >> drivers/mmc/core/core.c |

Re: [PATCH v4 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-01-21 Thread Jaehoon Chung
Hi. On 01/21/2015 11:12 PM, Alim Akhtar wrote: > Hi Jaehoon > > On Wed, Jan 21, 2015 at 4:32 AM, Jaehoon Chung wrote: >> Hi, >> >> If you want to enable the hs400 mode, need to add "mmc-hs400-1_8v" or >> "mmc-hs400-1_2v". >> But this patch didn't add them. do you have any other plan? >> > Yes,

Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

2015-01-21 Thread Olof Johansson
Hi, On Thu, Nov 27, 2014 at 2:41 AM, Peter Ujfalusi wrote: > include/linux/platform_data/ is not a correct place to keep the API > definitions for edma, it is meant to be only for the pdata for the device. > Clean up this by moving the API to include/linux/edma.h It's a nice net improvement, but

Re: [PATCH v4 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-01-21 Thread Alim Akhtar
Hi Jaehoon On Wed, Jan 21, 2015 at 4:32 AM, Jaehoon Chung wrote: > Hi, > > This patch can be separated. > When i tested on my board, it's not working fine. > I think it depends on my timing, so i will check after change the timing. > > On 01/14/2015 07:30 PM, Alim Akhtar wrote: >> From: Seungwon

[RFC PATCH 0/1] mmc: dw_mmc: Add runtime pm to dw_mmc

2015-01-21 Thread Karol Wrona
Hello, This patch adds runtime pm for dwmmc host. Runtime PM is enabled for dwmmc-exynos. This is RFC because I need some opinion about the host state detection and handling and is not finished. The runtime pm suspend and resume callback are empty for now because the main goal of this path is a

[RFC PATCH 1/1] mmc: dw_mmc: Add runtime pm to dw_mmc

2015-01-21 Thread Karol Wrona
This patch adds runtime pm handling to dw_mmc and enables it for dw_mmc-exynos. It mainly uses mci_request/mci_request_end for mmc host state information. Signed-off-by: Karol Wrona --- drivers/mmc/host/dw_mmc-exynos.c | 69 -- drivers/mmc/host/dw_mmc.c

Re: [PATCH 2/7] mmc: sdhci-pxav3: Fix Armada 38x controller's caps according to erratum ERR-7878951

2015-01-21 Thread Gregory CLEMENT
Hi Marcin, On 21/01/2015 15:52, Marcin Wojtas wrote: > Hi Gregory, > > 2015-01-21 10:32 GMT+01:00 Gregory CLEMENT > : >> According to erratum 'ERR-7878951' Armada 38x SDHCI controller has >> different capabilities than the ones shown in its registers: >> >> - it doesn't support the voltage switc

[PATCH] mmc: block: Remove unnecessary temporary variable

2015-01-21 Thread Tobias Klauser
Directly return the result of mmc_blk_alloc_req() instead of assigning and returning the variable md. Signed-off-by: Tobias Klauser --- drivers/mmc/card/block.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 4409d7

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-21 Thread Tomeu Vizoso
On 21 January 2015 at 15:15, Ulf Hansson wrote: > On 21 January 2015 at 14:54, Tomeu Vizoso wrote: >> On 01/21/2015 11:44 AM, Ulf Hansson wrote: >>> On 15 January 2015 at 18:33, Stephen Warren wrote: On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: > > Signed-off-by: Tomeu Vizoso >

Re: [PATCH 2/7] mmc: sdhci-pxav3: Fix Armada 38x controller's caps according to erratum ERR-7878951

2015-01-21 Thread Marcin Wojtas
Hi Gregory, 2015-01-21 10:32 GMT+01:00 Gregory CLEMENT : > According to erratum 'ERR-7878951' Armada 38x SDHCI controller has > different capabilities than the ones shown in its registers: > > - it doesn't support the voltage switching: it can work either with > 3.3V or 1.8V supply > - it doesn'

Re: [PATCH 0/7] Fixes and improvements for SDHCI on Armada 38x

2015-01-21 Thread Gregory CLEMENT
On 21/01/2015 10:31, Gregory CLEMENT wrote: > Hi, > > this series brings fixes and improvements for the SDHCI controller of > the Armada 38x SoCs. > > The first two patches are fixes and should be also applied on the > stable branch (I added stable in copy for this). > > The first one removes th

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-21 Thread Ulf Hansson
On 21 January 2015 at 14:54, Tomeu Vizoso wrote: > On 01/21/2015 11:44 AM, Ulf Hansson wrote: >> On 15 January 2015 at 18:33, Stephen Warren wrote: >>> On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: Signed-off-by: Tomeu Vizoso >>> >>> >>> Ah, having read the explanation in the next patch,

Re: [PATCH v4 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-01-21 Thread Alim Akhtar
Hi Jaehoon On Wed, Jan 21, 2015 at 4:32 AM, Jaehoon Chung wrote: > Hi, > > If you want to enable the hs400 mode, need to add "mmc-hs400-1_8v" or > "mmc-hs400-1_2v". > But this patch didn't add them. do you have any other plan? > Yes, right, plan is to send separate patch to enable hs400, as of n

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-21 Thread Tomeu Vizoso
On 01/21/2015 11:44 AM, Ulf Hansson wrote: > On 15 January 2015 at 18:33, Stephen Warren wrote: >> On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: >>> >>> Signed-off-by: Tomeu Vizoso >> >> >> Ah, having read the explanation in the next patch, I think ... >> >>> diff --git a/Documentation/devicetree/b

Re: [PATCH next] mmc: sdhci-pxav3: Remove checks for optional core clock in error/remove path

2015-01-21 Thread Ulf Hansson
On 5 January 2015 at 08:59, Jisheng Zhang wrote: > Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to > clk_{unprepare, disable}()") allows NULL or error pointer to be passed > unconditionally. > > This patch is to simplify probe error and remove code paths. > > However, we reserv

Re: [PATCH 0/2] mmc: rtsx: add check before sending request

2015-01-21 Thread Ulf Hansson
On 14 January 2015 at 04:09, wrote: > From: Micky Ching > > Add check before sending request can make request return faster. > - finish request if no card exist > This can make request finish faster, especial for some sdio card, > when card removed, there still a lot of command pending, >

[PATCH] mmc: sdhci-pxav3: fix race between runtime pm and irq

2015-01-21 Thread Jisheng Zhang
This patch is to fix a race condition that may cause an unhandled irq, which results in big sdhci interrupt numbers and endless "mmc1: got irq while runtime suspended" msgs before v3.15. Consider following scenario: CPU0CPU1 sdhci_px

Re: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings

2015-01-21 Thread Vincent Yang
2015-01-21 19:37 GMT+08:00 Ulf Hansson : > On 21 January 2015 at 12:19, kbuild test robot wrote: >> drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, >> PTR_ERR on line 144 >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Semantic patch information: >>

Re: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings

2015-01-21 Thread Ulf Hansson
On 21 January 2015 at 12:19, kbuild test robot wrote: > drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, > PTR_ERR on line 144 > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, w

Re: [PATCH] mmc: vub300: remove unreachable return value handling

2015-01-21 Thread Ulf Hansson
On 18 January 2015 at 02:51, Nicholas Mc Guire wrote: > Signed-off-by: Nicholas Mc Guire Thanks! Applied for next. Kind regards Uffe > --- > > The return value of wait_for_completion_timeout is unsigned long, > as it is used here for wait_for_completion_timeout only the type > of commretval wa

[PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings

2015-01-21 Thread kbuild test robot
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/c

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-21 Thread Ulf Hansson
On 15 January 2015 at 18:33, Stephen Warren wrote: > On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: >> >> Signed-off-by: Tomeu Vizoso > > > Ah, having read the explanation in the next patch, I think ... > >> diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt >> b/Documentation/

Re: [RFC 1/2] mmc: core: support UHS-II in core stack.

2015-01-21 Thread Ulf Hansson
On 27 December 2014 at 10:27, Yi Sun wrote: > This patch adds the UHS-II support in core layer. This is a RFC patch for > community review. > > Signed-off-by: Yi Sun > --- > drivers/mmc/core/Makefile |3 +- > drivers/mmc/core/bus.c|5 +- > drivers/mmc/core/core.c | 89 - > dr

Re: [PATCH 2/4] sdhci-st: Add support for stih407 family silicon.

2015-01-21 Thread Ulf Hansson
On 20 January 2015 at 16:32, Peter Griffin wrote: > This patch adds support for the extra registers found on > stih407 family silicon which has the flashSS subsystem. > > This mainly consists of some extra glue registers which are > used to correctly configure the controller hardware. > > This pat

[PATCH RESEND] mmc: mmci: Get rid of dead code in mmci_dma_setup

2015-01-21 Thread Pramod Gurav
DMA configuration has been removed from function mmci_dma_setup but the local mask variable was not removed. This remains unused hence remove it from the function and operations on it Signed-off-by: Pramod Gurav --- drivers/mmc/host/mmci.c |5 - 1 file changed, 5 deletions(-) diff --git

[PATCH 6/7] ARM: mvebu: Update the SDHCI node on Armada 38x

2015-01-21 Thread Gregory CLEMENT
The binding of the armada-380-sdhci has been extended with a new register in order to be able to use the SDR50 and DDR50 mode. This commit add the resource associated to this new register for the Armada 38x. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-38x.dtsi | 5 - 1 file c

[PATCH 0/7] Fixes and improvements for SDHCI on Armada 38x

2015-01-21 Thread Gregory CLEMENT
Hi, this series brings fixes and improvements for the SDHCI controller of the Armada 38x SoCs. The first two patches are fixes and should be also applied on the stable branch (I added stable in copy for this). The first one removes the SDR50 and DDR50 mode timing from the capabilities of the con

[PATCH 2/7] mmc: sdhci-pxav3: Fix Armada 38x controller's caps according to erratum ERR-7878951

2015-01-21 Thread Gregory CLEMENT
According to erratum 'ERR-7878951' Armada 38x SDHCI controller has different capabilities than the ones shown in its registers: - it doesn't support the voltage switching: it can work either with 3.3V or 1.8V supply - it doesn't support the SDR104 mode - SDR50 mode doesn't need tuning The SDHCI

[PATCH 7/7] ARM: mvebu: Add Device Tree description of SDHCI for Armada 388 RD

2015-01-21 Thread Gregory CLEMENT
The Device Tree description of SDHCI on Armada 388 RD board was missing. This commit adds the node for it. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-rd.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/armada-388-rd.dts b/arch/arm/boot/d

[PATCH 3/7] mmc: sdhci-pxav3: Extend binding with SDIO3 conf reg for the Armada 38x

2015-01-21 Thread Gregory CLEMENT
The SDHCI unit used on the Armada 38x needs using an extra register to do specific clock adjustments in order to support the SDR50 and DDR50 modes. This patch extends the binding to allow using this register. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/mmc/sdhci-pxa.txt

[PATCH 4/7] mmc: sdhci-pxav3: Modify clock settings for the SDR50 and DDR50 modes

2015-01-21 Thread Gregory CLEMENT
According to erratum 'FE-2946959' both SDR50 and DDR50 modes require specific clock adjustments in SDIO3 Configuration register. This commit add the support of this register and for SDR50 or DDR50 mode use it as suggested by the erratum: - Set the SDIO3 Clock Inv field in SDIO3 Configuration regis

[PATCH 5/7] ARM: mvebu: Use macros for interrupt flags on Armada 38x sdhci node

2015-01-21 Thread Gregory CLEMENT
Instead of hardcoding the values of the interrupt flags, use the macros provided by and for the Armada 38x SDHCI node. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-38x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/a

[PATCH 1/7] mmc: sdhci-pxav3: Fix SDR50 and DDR50 capabilities for the Armada 38x flavor

2015-01-21 Thread Gregory CLEMENT
According to erratum 'FE-2946959' both SDR50 and DDR50 modes require specific clock adjustments in SDIO3 Configuration register. However, this register was not part of the device tree binding. Even if the binding can (and will) be extended we still need handling the case where this register was not

Re: [PATCH] mmc: block: fix format string warning

2015-01-21 Thread Ulf Hansson
On 20 January 2015 at 17:33, Asaf Vertz wrote: > Fixed the following warning (reported by cppcheck): > [drivers/mmc/card/block.c:2149]: (warning) %d in format string (no. 1) > requires 'int' but the argument type is 'unsigned int'. > > Signed-off-by: Asaf Vertz Thanks! Applied for next. Kind re