Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Jean Delvare
On Thu, 13 Jan 2011 12:07:34 -0500, Devin Heitmueller wrote: > On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare wrote: > > On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: > >> How should clock stretches by slaves be handled using i2c-algo-bit? > > > > It is already handled. But hdpvr-i2c doesn

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare wrote: > On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: >> How should clock stretches by slaves be handled using i2c-algo-bit? > > It is already handled. But hdpvr-i2c doesn't use i2c-algo-bit. I2C > support is done with USB commands instead. M

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 11:34 AM, Andy Walls wrote: > Devin, > > You've seen the clock stretch with your I2C analyzer? The Beagle I was using when I did the captures doesn't show clock stretch. My "Logic" logic analyzer does, but I wasn't using that at the time. That said, I can say with some a

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Andy Walls
Jean, Yes, however, I asked because ivtv and cx18 use i2c-algo-bit and also provide Zilog z8 IR I2C clients for lirc_zilog to use. So if those get clock stretch handling "for free", that's great. Regards, Andy Jean Delvare wrote: >On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: >>

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Jean Delvare
On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: > How should clock stretches by slaves be handled using i2c-algo-bit? It is already handled. But hdpvr-i2c doesn't use i2c-algo-bit. I2C support is done with USB commands instead. Maybe the hardware implementation doesn't support clock stretchi

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Andy Walls
Devin, You've seen the clock stretch with your I2C analyzer? Jean, How should clock stretches by slaves be handled using i2c-algo-bit? Regards, Andy Devin Heitmueller wrote: >On Thu, Jan 13, 2011 at 8:21 AM, Jean Delvare wrote: >> My bet is that register at 0x00 is a control register, and w

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 8:21 AM, Jean Delvare wrote: > My bet is that register at 0x00 is a control register, and writing bit > 7 (value 0x80) makes the chip busy enough that it can't process I2C > requests at the same time. The following naks would be until the > chip is operational again. Corre

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Jean Delvare
On Wed, 05 Jan 2011 20:02:41 -0200, Mauro Carvalho Chehab wrote: > Em 05-01-2011 19:51, Jean Delvare escreveu: > > If you have specific cases you don't know how to solve, please point me > > to them and I'll take a look. > > You can take a look at saa7134-cards.c, for example. saa7134_tuner_setup(

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Jean Delvare
On Wed, 05 Jan 2011 19:46:20 -0500, Andy Walls wrote: > If you look at more of the dumps, it appears that accesses to I2C > addresses 0x70 and 0x71 can be interleaved, so it looks like the > IR.ir_lock might not be needed. Although looking further I see this: > > 2.035mS: 70 W 61 00 00 00 . .

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Jean Delvare
Hi Andy, On Wed, 05 Jan 2011 20:20:35 -0500, Andy Walls wrote: > The cx18 driver has a function scope i2c_client for reading the EEPROM, > and there's a good reason for it. We don't want to register the EEPROM > with the I2C system and make it visible to the rest of the system, > including i2c-de

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 20:02 -0200, Mauro Carvalho Chehab wrote: > Em 05-01-2011 19:51, Jean Delvare escreveu: > > Hi Mauro, > > > > On Wed, 05 Jan 2011 15:34:28 -0200, Mauro Carvalho Chehab wrote: > >> Hi Jean, > >> > >> Thanks for your acks for patches 1 and 2. I've already applied the patches >

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 15:45 +0100, Jean Delvare wrote: > Hi Andy, > > On Tue, 28 Dec 2010 20:49:50 -0500, Andy Walls wrote: > > Remove use of deprecated struct i2c_adapter.id field. In the process, > > perform different detection of the HD PVR's Z8 IR microcontroller versus > > the other Hauppaug

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Mauro Carvalho Chehab
Em 05-01-2011 19:51, Jean Delvare escreveu: > Hi Mauro, > > On Wed, 05 Jan 2011 15:34:28 -0200, Mauro Carvalho Chehab wrote: >> Hi Jean, >> >> Thanks for your acks for patches 1 and 2. I've already applied the patches >> on my tree and at linux-next. I'll try to add the acks on it before sending

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Jean Delvare
Hi Mauro, On Wed, 05 Jan 2011 15:34:28 -0200, Mauro Carvalho Chehab wrote: > Hi Jean, > > Thanks for your acks for patches 1 and 2. I've already applied the patches > on my tree and at linux-next. I'll try to add the acks on it before sending > upstream. If you can't, it's fine. I merely wanted

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Mauro Carvalho Chehab
Hi Jean, Thanks for your acks for patches 1 and 2. I've already applied the patches on my tree and at linux-next. I'll try to add the acks on it before sending upstream. Em 05-01-2011 12:45, Jean Delvare escreveu: > Hi Andy, > > On Tue, 28 Dec 2010 20:49:50 -0500, Andy Walls wrote: >> Remove us

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Jean Delvare
Hi Andy, On Tue, 28 Dec 2010 20:49:50 -0500, Andy Walls wrote: > Remove use of deprecated struct i2c_adapter.id field. In the process, > perform different detection of the HD PVR's Z8 IR microcontroller versus > the other Hauppauge cards with the Z8 IR microcontroller. Thanks a lot for doing thi

[PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2010-12-28 Thread Andy Walls
Remove use of deprecated struct i2c_adapter.id field. In the process, perform different detection of the HD PVR's Z8 IR microcontroller versus the other Hauppauge cards with the Z8 IR microcontroller. Also added a comment about probe() function behavior that needs to be fixed. Signed-off-by: And