Re: [PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-28 Thread Jean-Francois Moine
On Sat, 28 Nov 2009 08:14:57 +0100 Németh Márton wrote: > what do you think about the latest version of this patchset? Hello Márton, I wonder why you did not include the input functions directly in the file gspca.c instead of adding new files and changing the Makefile. Below are more remarks.

Re: [PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-27 Thread Németh Márton
Hello, what do you think about the latest version of this patchset? Regards, Márton Németh Németh Márton wrote: > From: Márton Németh > > Add helper functions for interrupt endpoint based input handling. > > Signed-off-by: Márton Németh > --- > diff -r bc16afd1e7a4 linux/drivers/med

[PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-22 Thread Németh Márton
From: Márton Németh Add helper functions for interrupt endpoint based input handling. Signed-off-by: Márton Németh --- diff -r bc16afd1e7a4 linux/drivers/media/video/gspca/Makefile --- a/linux/drivers/media/video/gspca/Makefile Sat Nov 21 12:01:36 2009 +0100 +++ b/linux/drivers/media/video/gsp

Re: [RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-22 Thread Németh Márton
Németh Márton wrote: > Jean-Francois Moine wrote: >> On Fri, 20 Nov 2009 08:14:10 +0100 >> Németh Márton wrote: >>> Unfortunately I still get the following error when I start streaming, >>> stop streaming or unplug the device: >>> >>> [ 6876.780726] uhci_hcd :00:10.1: dma_pool_free buffer-32,

Re: [RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-21 Thread Németh Márton
Hi, first of all: Hans and Jef, thank you for your helping guidance with this patchset. Jean-Francois Moine wrote: > Hi, > On Fri, 20 Nov 2009 08:14:10 +0100 > Németh Márton wrote: >> Hans de Goede wrote: > [snip] >>> I'm personally not a big fan of adding more configuration options, >>> w

Re: [RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-20 Thread Jean-Francois Moine
Hi, On Fri, 20 Nov 2009 08:14:10 +0100 Németh Márton wrote: > Hans de Goede wrote: > > On 11/19/2009 08:46 AM, Németh Márton wrote: > >> Add helper functions for interrupt endpoint based input handling. > > First of all many many thanks for doing this! > > You are welcome :-) . My goal is

Re: [RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-19 Thread Németh Márton
Hi, Hans de Goede wrote: > Hi Márton, > > On 11/19/2009 08:46 AM, Németh Márton wrote: >> Add helper functions for interrupt endpoint based input handling. > First of all many many thanks for doing this! You are welcome :-) . My goal is to just make my webcam working properly... >> maybe a new c

Re: [RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-19 Thread Hans de Goede
Hi Márton, On 11/19/2009 08:46 AM, Németh Márton wrote: From: Márton Németh Add helper functions for interrupt endpoint based input handling. First of all many many thanks for doing this! Signed-off-by: Márton Németh --- Hi, maybe a new configuration option should bealso introduced? I'm

[RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-18 Thread Németh Márton
From: Márton Németh Add helper functions for interrupt endpoint based input handling. Signed-off-by: Márton Németh --- Hi, maybe a new configuration option should be also introduced? Regards, Márton Németh --- diff -r 182b5f8fa160 linux/drivers/media/video/gspca/Makefile --- a/linux/