.
>
> Signed-off-by: Sean Young
Acked-by: Sean Wang
> ---
> drivers/media/rc/mtk-cir.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c
> index 9dc467ebae24..8027181de985 100644
> --- a/drivers/
>
> Signed-off-by: Sean Young
Acked-by: Sean Wang
> ---
> drivers/media/rc/mtk-cir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c
> index 46101efe017b..9dc467ebae24 100644
> --- a/
Hello,
Can anyone please confirm this bug and apply the patch? Thanks!
Wenwen
On Thu, Oct 4, 2018 at 11:00 AM Wenwen Wang wrote:
>
> In vpfe_isif_init(), there is a while loop to get the ISIF base address and
> linearization table0 and table1 address. In the loop body, the
Hello,
Can anyone confirm this bug? Thanks!
Wenwen
On Fri, Oct 19, 2018 at 9:12 AM Wenwen Wang wrote:
>
> In dvb_audio_write(), the first byte of the user-space buffer 'buf' is
> firstly copied and checked to see whether this is a TS packet, which always
> starts with 0x
py contains the expected value. Otherwise, an
error code EINVAL will be returned.
Signed-off-by: Wenwen Wang
---
drivers/media/pci/ttpci/av7110_av.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/pci/ttpci/av7110_av.c
b/drivers/media/pci/ttpci/av7110_av.c
index ef1bc17..1ff6062
med tacksamhet
Jag har en stor aff"arsportf"olj att diskutera med dig
sn"alla kontakta mig.
H"alsningar,
Wang
On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter wrote:
> On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote:
>> At the end of atomisp_subdev_set_selection(), the function
>> atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since
>> this funct
as null pointer
dereference.
This patch saves the pointer returned by the first invocation and removes
the second invocation. If the returned pointer is not NULL, the memory
content is copied according to the original code.
Signed-off-by: Wenwen Wang
---
drivers/staging/media/atomisp/pci
as null pointer
dereference.
This patch saves the pointer returned by the first invocation and removes
the second invocation. If the returned pointer is not NULL, the memory
content is copied according to the original code.
Signed-off-by: Wenwen Wang
---
drivers/staging/media/atomisp/pci
as null pointer
dereference.
This patch saves the pointer returned by the first invocation and removes
the second invocation. If the returned pointer is not NULL, the memory
content is copied according to the original code.
Signed-off-by: Wenwen Wang
---
drivers/staging/media/atomisp/pci
truct platform_device *pdev)
> return -ENOMEM;
>
> ir->dev = dev;
> - ir->data = of_id->data;
> + ir->data = of_device_get_match_data(dev);
>
> ir->clk = devm_clk_get(dev, "clk");
> if (IS_ERR(ir->clk)) {
Acked-by: Sean Wang
From: Xiongfeng Wang
gcc-8 reports
drivers/media/dvb-frontends/dibx000_common.c: In function
'i2c_adapter_init':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 48 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make
From: Xiongfeng Wang
gcc-8 reports
drivers/media/media-device.c: In function 'media_device_get_topology':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make sure th
raw mode for more compatibility with different protocols
> > as previously SoC did. Before adding support to MT7622 SoC, extra
> > code refactor is done since there're major differences in register and
> > field definition from the previous SoC.
> >
> > Sean Wang (4
On Wed, 2017-01-18 at 16:42 -0600, Rob Herring wrote:
> On Wed, Jan 18, 2017 at 4:23 PM, Rob Herring wrote:
> > On Fri, Jan 13, 2017 at 03:35:38PM +0800, sean.w...@mediatek.com wrote:
> >> From: Sean Wang
> >>
> >> This patch adds documentation for devicetree
okay, I will continue to work based on your changes unless someone else
has concerns
On Wed, 2017-01-11 at 07:45 +0900, Andi Shyti wrote:
> Hi Sean,
>
> >include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address':
> > unknown attribute
> > >> drivers/media/rc/mtk-cir.c:215:41: s
EV;
> > > > + }
> > > > +
> > > > + /* Enable interrupt after proper hardware
> > > > +* setup and IRQ handler registration
> > > > +*/
> > > > + if (clk_prepare_enable(ir->clk)) {
> > > > + dev_err(dev
; > +*/
> > + if (clk_prepare_enable(ir->clk)) {
> > + dev_err(dev, "try to enable ir_clk failed\n");
> > + ret = -EINVAL;
> > + goto exit_clkdisable_clk;
> > + }
> > +
> > + mtk_irq_disable(ir, MTK_IRIN
Hi Rob,
thanks for your effort for reviewing. I added comments inline.
On Mon, 2017-01-09 at 12:32 -0600, Rob Herring wrote:
> On Fri, Jan 06, 2017 at 12:06:23AM +0800, sean.w...@mediatek.com wrote:
> > From: Sean Wang
> >
> > This patch adds documentation for de
On Sun, 2017-01-08 at 21:16 +, Sean Young wrote:
> Hi Sean,
>
> On Fri, Jan 06, 2017 at 03:31:25PM +0800, Sean Wang wrote:
> > On Thu, 2017-01-05 at 17:12 +, Sean Young wrote:
> > > On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote:
> > &
Hi Andi,
Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.
Sean
On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
> Hi Sean,
>
> > + ir->rc = rc_allocate_device();
>
> Yes, you should use devm_rc_allocate_device(...)
>
> Bes
Hi Sean,
Thanks for your effort for code reviewing. I add comments inline.
On Thu, 2017-01-05 at 17:12 +, Sean Young wrote:
> Hi Sean,
>
> Some review comments.
>
> On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote:
> > From: Sean Wang
> >
media will hide all the changes in drivers/media.
Signed-off-by: Wang YanQing
---
I don't know whether it is still acceptable to patch dontdiff,
so I add Linus to CC list.
Documentation/dontdiff | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/dontdiff b/Document
america and Oceania, Welcome to
contact if you have inquiry, I am Jay, thank you for your time.
Sincerely
Jay Wang
Sales Department, Skype ID: sonier-pins
Sonier Pins Co.,Ltd
Add : No.2, JiXi ShunCheng Center,
Xiaolan Town,Zhongshan City 528400,Guangdong ,China.
Tel：（86 -760）22123680 Fax：（86
Move dereference of sdesc after NULL pointer checker.
Signed-off-by: Wang YanQing
---
drivers/media/platform/soc_camera/soc_camera.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform/soc_camera
t_ioctl32' makes pointer from integer
without a cast [enabled by default]
drivers/media/v4l2-core/v4l2-subdev.c:379:2: note: expected 'void *'
but argument is of type 'long unsigned int'
2014/1/15 Hans Verkuil :
> On 01/15/14 09:02, Jianle Wang wrote:
>> Hi H
Hi Hans:
Thanks for your patch.
How do we handle the private ioctl defined in struct v4l2_subdev_core.ioctl?
These ioctls are also not supported for compat_ioctl.
2014/1/15 Hans Verkuil :
> Hi Jianle,
>
> On 01/15/2014 07:28 AM, Jianle Wang wrote:
>> Hi all, :
>> I use th
Hi all, :
I use the media-ctl from http://git.ideasonboard.org/media-ctl.git
It is compiled into a 32 bit application. Run on a 64 bit CPU. The
version of kernel is 3.10.
When call ioctl(, VIDIOC_SUBDEV_S_SELECTION,), meet the below warning:
[ 97.186338] c0 707 (drv_test) compat_ioctl32: unknown
On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote:
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2
receiver and MIPI DSI transmitter DPHYs.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
Changes since v2:
- adapted to the generic PHY API v9: use phy_set
On 06/28/2013 01:58 PM, Jingoo Han wrote:
On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:
Hi,
On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:
Add PHY provider node for the DP PHY.
Signed-off-by: Jingoo Han
---
arch/arm/boot/dts/exynos5250.dtsi | 13 -
1
From: Wenbing Wang
in soc_camera_close(), if ici->ops->remove() removes device firstly,
and then call __soc_camera_power_off(), it has logic error. Since
if remove device, it should disable subdev clk. but in __soc_camera_
power_off(), it will callback v4l2 s_power function which will
read
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 06 March, 2013 23:02
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: RE: [REVIEW PATCH V4 12/12] [media] marvell
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 06 March, 2013 23:00
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: RE: [REVIEW PATCH V4 02/12] [media] marvell-cc
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 22:17
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 12/12] [media] marvell-ccic: a
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 18:43
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 09/12] [media] marvell-ccic
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 21:33
>To: Albert Wang
>Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang
>Subject: Re: [REVIEW PATCH V4 10/12] [media] marvell-ccic: add so
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 18:18
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 07/12] [media] marvell-ccic:
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 17:51
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 02/12] [media] marvell-cc
Hi, Guennadi
Thank you very much for your review and comments!
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 05:35
>To: Albert Wang
>Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang
>Subject: Re: [
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 18:21
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 01/12] [media] marvell-ccic: ad
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 05 March, 2013 18:08
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [REVIEW PATCH V4 05/12] [media] marvell-cci
Patch set V1 - Log:
- add mmp register definition
- add soc_camera support on mcam core and mmp driver
- add 3 frames buffers support in DMA_CONTIG mode
Thanks
Albert Wang
--
Albert Wang (7):
[media] marvell-ccic: reset ccic phy when stop streaming for stability
[media
MAX_FRAME_BUFS 2
in mcam-core.h.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam-core.c | 59 +--
drivers/media/platform/marvell-ccic/mcam-core.h | 13 +
2 files changed, 57 insertions(+), 15
This patch adds the soc_camera mode support in marvell-ccic driver.
It also removes the old mode for maintaining single mode in the future.
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
---
drivers/media/platform/Makefile |4 +-
drivers/media/platform/marvell-ccic
This patch adds the dma burst size config support for marvell-ccic.
Developer can set the dma burst size in specified board driver.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam-core.c |3 ++-
drivers/media
This patch uses unsigned int type replace int type in marvell-ccic.
These variables: frame number, buf number, irq... should be unsigned.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam-core.c | 22
This patch switchs to resource managed allocation and request in mmp-driver.
It can remove free resource operations.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 65 --
1 file
This patch renames the B_vmalloc/B_DMA_contig/B_DMA_sg to
B_VMALLOC/B_DMA_CONTIG/B_DMA_SG variables to avoid CamelCase warning
reported by the checkpatch.pl script.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/cafe-driver.c |2 +-
drivers
.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan Corbet
Acked-by: Guennadi Liakhovetski
---
drivers/media/platform/marvell-ccic/mcam-core.c | 30 ---
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam
From: Libin Yang
This patch adds the new formats support for marvell-ccic.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 189 +++
drivers/media/platform/marvell-ccic/mcam-core.h |6 +
2 files changed, 162
From: Libin Yang
This patch refines mcam_set_contig_buffer() in mcam core.
It can remove redundant code line and enhance readability.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Guennadi Liakhovetski
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam
This patch adds the reset ccic phy operation when stop streaming.
Stop streaming without reset ccic phy, the next start streaming
may be unstable.
Also need add CCIC2 definition when PXA688/PXA2128 support dual ccics.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Jonathan
From: Libin Yang
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 66 +
drivers/media/platform/marvell-ccic
From: Libin Yang
This patch adds the clock tree support for marvell-ccic.
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
Acked-by: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam-core.h |4 ++
drivers/media/platform/marvell-ccic/mmp-driver.c | 47
Hi, Jonathan
Thanks a lot for explaining it. :)
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Tuesday, 05 February, 2013 11:14
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 10/1
mode on our platform, and this buffer mode can
work only if we comment these 2 lines.
Could you please help us take a look if you have time?
Thank you very much for your help! :)
Thanks
Albert Wang
86-21-61092656
>-Original Message-
>From: Albert Wang
>Sent: Wednesday, 19 De
>> Then use #modprobe pciehp pciehp_force=1 pciehp_debug=1 to load pciehp
>> modules.
>> After above actions, enter /sys/bus/pci_express/devices/ directory and
>> /sys/bus/pci/slots/
>> Some slots and pcie port devices should be there now.
>>
> Sorry, I've tried your suggestion, but the two direc
Hi Chris,
Sorry for the delay reply. It seems like my reply last night was missed.
>From the sysinfo you provide, there are no pcie port devices under
>/sys/bus/pci_express/devices.
Maybe because there are some problems with _OSC in your laptop, so pcie port
driver won't create pcie port devi
于 2013-01-27 19:19, Chris Clayton 写道:
> Hi Yijing
>
> On 01/27/13 02:45, Yijing Wang wrote:
>> 于 2013-01-27 4:54, Chris Clayton 写道:
>>> Hi Martin,
>>>
>>> On 01/24/13 19:21, Martin Mokrejs wrote:
>>>> Hi Chris,
>>>>
于 2013-01-27 4:54, Chris Clayton 写道:
> Hi Martin,
>
> On 01/24/13 19:21, Martin Mokrejs wrote:
>> Hi Chris,
>>try to include in kernel only acpiphp and omit pciehp. Don't use modules
>> but include
>> them statically. And try, in addition, check whether "pcie_aspm=off" in
>> grub.conf helped
Hi, Nicolas
Thank you for your reminder. :)
Happy New Year!
>-Original Message-
>From: Nicolas THERY [mailto:nicolas.th...@st.com]
>Sent: Friday, 04 January, 2013 01:38
>To: Albert Wang
>Cc: Jonathan Corbet; g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin
>
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 02 January, 2013 00:56
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 06/15] [media] marvell-ccic: add n
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 02 January, 2013 00:06
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 03/15] [media] marvell-ccic: add
Hi, Guennadi
Happy New Year!
Thank you for your review!
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 01 January, 2013 23:28
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: R
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Wednesday, 19 December, 2012 03:15
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 10/15] [media] marvell-ccic: spli
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 23:29
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 10/15] [media] marvell-ccic: split mcam-c
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 06:55
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 15/15] [media] marvell-ccic: add 3 frame
Hi, Jonathan
Thank you very much for taking your weekend time to review our patches! :)
Thanks
Albert Wang
86-21-61092656
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:58
>To: Albert Wang
>Cc: g.liakhovet...@gmx.
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:56
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 15/15] [media] marvell-ccic: add 3 frame
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:49
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 13/15] [media] marvell-ccic: add dma
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:46
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 12/15] [media] marvell-ccic: add soc
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:37
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 10/15] [media] marvell-ccic: split mcam-c
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:25
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 09/15] [media] marvell-ccic: add get
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:19
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 07/15] [media] marvell-ccic: add SOF / EO
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:17
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 06/15] [media] marvell-ccic: add new f
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:07
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 05/15] [media] marvell-ccic: refine
>m
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Monday, 17 December, 2012 00:03
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 03/15] [media] marvell-ccic: add cloc
Hi, Jonathan
>-Original Message-
>From: Jonathan Corbet [mailto:cor...@lwn.net]
>Sent: Sunday, 16 December, 2012 23:55
>To: Albert Wang
>Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH V3 02/15] [media] marvell-ccic: add MIPI sup
This patch adds the soc_camera support in mcam core.
It creates the file mcam-core-soc.c and mcam-core-soc.h
to support soc_camera in mcam core.
To use the soc_camera feature, platform driver, such as mmp-driver.c,
should also be modified.
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
.
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
---
drivers/media/platform/marvell-ccic/Makefile |4 +-
.../platform/marvell-ccic/mcam-core-standard.c | 820 +
.../platform/marvell-ccic/mcam-core-standard.h | 26 +
drivers/media/platform/marvell-ccic/mcam
From: Libin Yang
This patch adds the new formats support for marvell-ccic.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 175 ++-
drivers/media/platform/marvell-ccic/mcam-core.h |6 +
2 files changed, 149
This patch use unsigned int type replace int type in marvell-ccic.
These variables: frame number, buf number, irq... should be unsigned.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
.../media/platform/marvell-ccic/mcam-core-soc.h|2 +-
.../platform/marvell-ccic/mcam-core
MAX_FRAME_BUFS 3
in mcam-core.h
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 59 +--
drivers/media/platform/marvell-ccic/mcam-core.h | 11 +
2 files changed, 55 insertions(+), 15 deletions(-)
diff --git a
Yang
Signed-off-by: Albert Wang
---
drivers/media/platform/Makefile |4 +-
drivers/media/platform/marvell-ccic/Kconfig | 22
drivers/media/platform/marvell-ccic/mmp-driver.c | 147 ++
include/media/mmp-camera.h |2 +
4
This patch adds the dma burst size config support for marvell-ccic.
Developer can set the dma burst size in specified board driver.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
.../media/platform/marvell-ccic/mcam-core-soc.c|2 +-
drivers/media/platform/marvell-ccic/mcam
From: Libin Yang
This patch adds the reset ccic phy operation when stop streaming.
Without reset ccic phy, the next start streaming may be unstable.
Also need add CCIC2 definition when PXA688/PXA2128 support dual ccics.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media
This patch adds get_mcam() inline function which is prepared for
adding soc_camera support in marvell-ccic driver
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 27 ++-
drivers/media/platform/marvell-ccic/mcam
-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 30 ---
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c
b/drivers/media/platform/marvell-ccic/mcam-core.c
From: Libin Yang
This patch refines mcam_set_contig_buffer() in mcam core
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
Acked-by: Guennadi Liakhovetski
---
drivers/media/platform/marvell-ccic/mcam-core.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions
From: Libin Yang
This patch switchs to resource managed allocation and request in mmp-driver.
It can remove free resource operations.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 56 --
1 file changed, 20
From: Libin Yang
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 70
drivers/media/platform/marvell
From: Libin Yang
This patch adds the clock tree support for marvell-ccic.
Each board may require different clk enabling sequence.
Developer need add the clk_name in correct sequence in board driver
to use this feature.
Signed-off-by: Libin Yang
Signed-off-by: Albert Wang
---
drivers/media
- add 3 frames buffers support in DMA_CONTIG mode
Thanks
Albert Wang
--
Albert Wang (7):
[media] marvell-ccic: add get_mcam function for marvell-ccic driver
[media] marvell-ccic: split mcam-core into 2 parts for soc_camera
support
[media] marvell-ccic: add soc_camera support in mcam
From: Libin Yang
This patch replaces the global frame stats variables by using
internal variables in mcam_camera structure.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 30 ++-
drivers/media/platform/marvell
Hi, Geunnadi
Thank you very much for your review!
Your help is very valuable for us.
We will work out the next version based on your suggestion!
I hope to get back to you on the review of the version 3 patch series next
week. :)
Have a nice day!
Thanks
Albert Wang
86-21-61092656
Thanks
Albert Wang
86-21-61092656
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 28 November, 2012 00:50
>To: Albert Wang
>Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang
>Subject: RE: [PATCH 11/15] [media]
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 28 November, 2012 00:39
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: RE: [PATCH 10/15] [media] marvell-ccic: spli
Hi, Guennadi
Thanks a lot for your review! :)
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 28 November, 2012 00:30
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [P
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Wednesday, 28 November, 2012 00:02
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH 14/15] [media] marvell-ccic: use
Hi, Guennadi
>-Original Message-
>From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
>Sent: Tuesday, 27 November, 2012 23:56
>To: Albert Wang
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH 13/15] [media] marvell-ccic: add dma
1 - 100 of 189 matches
Mail list logo
