On Fri, Dec 6, 2013 at 6:17 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Fix most checkpatch errors/warnings.
>
> It's mostly whitespace changes, except for replacing msleep with
> usleep_range and the jiffies comparison with time_is_after_jiffies().
>
> Signed-off-by: Hans Verkuil
Acked-by
Hello,
On Tue, Nov 5, 2013 at 10:18 AM, edubez...@gmail.com
wrote:
> Dinesh
>
> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>> This is the USB driver for the Silicon Labs development board.
>> It contains the Si4713 FM transmitter chip.
>>
>
> I tr
Hans, Dinesh,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
> Hello Eduardo,
>
> In this patch series, I have addressed the comments by you
> concerning my last patch series.
> In the resulting patches, I have corrected most of the
> style issues and adding of comments. However, some warnin
On Thu, Nov 7, 2013 at 3:40 AM, Hans Verkuil wrote:
> On 11/05/2013 03:18 PM, edubez...@gmail.com wrote:
>> Dinesh
>>
>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>>> This is the USB driver for the Silicon Labs development board.
>>> It
Dinesh
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
> This is the USB driver for the Silicon Labs development board.
> It contains the Si4713 FM transmitter chip.
>
I tried this driver again. The system attempts to probe the device but
it fails because the product revision read out of the
On Tue, Nov 5, 2013 at 4:38 AM, Hans Verkuil wrote:
> Hi,
>
> On 11/04/13 15:07, edubez...@gmail.com wrote:
>> Hi,
>>
>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>>> The supply list is needed by the platform driver, but not by the usb driver.
&g
h itself as it moves the macro definition, but still uses it in
the board file.
>
>
> On Mon, Nov 4, 2013 at 3:13 PM, Hans Verkuil wrote:
>>
>> On 11/04/2013 03:09 PM, edubez...@gmail.com wrote:
>> > Hans,
>> >
>> > On Mon, Nov 4, 2013 at 5:33
Hans,
On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil wrote:
> On 10/15/2013 07:37 PM, edubez...@gmail.com wrote:
>> Hello Dinesh,
>>
>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>>> Hello Eduardo,
>>>
>>> In this patch series, I have addr
Hi,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
> The supply list is needed by the platform driver, but not by the usb driver.
> So this information belongs to the platform data and should not be hardcoded
> in the subdevice driver.
>
> Signed-off-by: Hans Verkuil
Dinesh, could you plea
Hello Dinesh,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
> Hello Eduardo,
>
> In this patch series, I have addressed the comments by you
> concerning my last patch series.
> In the resulting patches, I have corrected most of the
> style issues and adding of comments. However, some warnin
that adds the USB driver. Besides reviewing I will be also
testing your patches.
All best,
>
> Regards,
> Dinesh
>
> From: Hans Verkuil [hverk...@xs4all.nl]
> Sent: 02 September 2013 09:11
> To: edubez...@gmail.com
> Cc: Dinesh Ram;
Hi Dinesh,
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
> This is the USB driver for the Silicon Labs development board.
> It contains the Si4713 FM transmitter chip.
>
Can you please fix the list of errors and warnings checkpatch.pl
outputs on your patch?
total: 73 errors, 63 warnings, 8
Hello Hans,
On Sun, Sep 1, 2013 at 7:04 AM, Hans Verkuil wrote:
> On 08/31/2013 01:49 PM, edubez...@gmail.com wrote:
>> Hi Dinesh,
>>
>> On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
>>> In the si4713_tx_tune_power() method, the args array element '
Hi Dinesh,
On Sun, Sep 1, 2013 at 10:42 AM, dinesh ram wrote:
> Hi Eduardo,
> Hi Hans,
>
>
> From: Hans Verkuil
> To: "edubez...@gmail.com"
> Cc: Dinesh Ram ; Linux-Media
> ; dinesh@cern.ch
> Sent: Sunday, 1 September 20
Hi Hans,
On Sun, Sep 1, 2013 at 7:00 AM, Hans Verkuil wrote:
> On 08/31/2013 01:32 PM, edubez...@gmail.com wrote:
>> On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
>>> Checks have been introduced at several places in the code to test if an
>>> interrupt is set or
Hello Hans,
On Sun, Sep 1, 2013 at 6:57 AM, Hans Verkuil wrote:
>
> On 08/31/2013 01:31 PM, edubez...@gmail.com wrote:
> > Dinesh, Hi
> >
> >
> > On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
> >>
> >> Checks have been introduced at several
Hi Dinesh,
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
> In the si4713_tx_tune_power() method, the args array element 'power' can take
> values between
> SI4713_MIN_POWER and SI4713_MAX_POWER. power = 0 is also valid.
> All the values (0 > power < SI4713_MIN_POWER) are illegal and hence
>
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
> Checks have been introduced at several places in the code to test if an
> interrupt is set or not.
> For devices which do not use the interrupt, to get a valid response, within a
> specified timeout,
> the device is polled instead.
>
> Signed-
Dinesh, Hi
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram wrote:
>
> Checks have been introduced at several places in the code to test if an
> interrupt is set or not.
> For devices which do not use the interrupt, to get a valid response, within a
> specified timeout,
> the device is polled inste
Imre,
On Tue, May 14, 2013 at 10:48 AM, Imre Deak wrote:
> Use usecs_to_jiffies_timeout instead of open-coding the same.
>
> Signed-off-by: Imre Deak
Acked-by: Eduardo Valentin
> ---
> drivers/media/radio/si4713-i2c.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --
Arnd,
On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann wrote:
> It is not possible to select SND_SOC_SI476X if we have not also
> enabled SND_SOC.
>
> warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet
> direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC)
>
> Cc: Han
Hey Hans,
On Mon, Apr 8, 2013 at 11:46 AM, edubez...@gmail.com
wrote:
> Hi Hans,
>
> On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Signed-off-by: Hans Verkuil
>
> Acked-by: Eduardo Valentin
> Tested-by: Eduardo V
Hi Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo Valentin
Output of v4l2-compliant:
is radio
Driver Info:
Driver name : radio-si4713
Card type : Silicon Labs
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo Valentin
Output of v4l2-compliant:
is radio
Driver Info:
Driver name : radio-si4713
Card type : Silicon Labs Si471
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> - check for invalid modulators.
> - clamp frequency to valid range.
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo Valentin
Here is the output of v4l2-compliant:
is radio
Driver I
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Simplify locking by using the V4L2 core lock mechanism. This allows us to
> remove all locking from the i2c module. This will also simplify the upcoming
> conversion to the control framework.
>
> Signed-off-by: Hans
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Set bus_info and fill in device_caps.
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo Valentin
Here is the output of v4l2-compliant
is radio
Driver Info:
Driver name : r
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Also set the v4l2_dev pointer in struct video_device as this was missing.
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo Valentin
Output of v4l2-compliant is the same as in patch
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The audout ioctls are not appropriate for radio transmitters, they apply to
> video output devices only. Remove them from this driver.
>
> Signed-off-by: Hans Verkuil
Acked-by: Eduardo Valentin
Tested-by: Eduardo
Hans,
On Mon, Apr 8, 2013 at 8:03 AM, edubez...@gmail.com wrote:
> Hans,
>
>
>
> On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
>> This patch series makes radio-si4713 compliant with v4l2-compliance.
>>
>
> Thanks for your patches.
>
>> Eduardo, th
Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote:
> This patch series makes radio-si4713 compliant with v4l2-compliance.
>
Thanks for your patches.
> Eduardo, thanks for testing the previous code. I hope this version resolves
> all the issues we found. Can you test again?
>
Of course
Hans,
On Fri, Mar 22, 2013 at 12:45 PM, Hans Verkuil wrote:
> On Fri March 22 2013 17:26:57 edubez...@gmail.com wrote:
>> Hello Hans,
>>
>> On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil wrote:
>>
>>
>> >>
>> >> # on your branch on
Hello Hans,
On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil wrote:
>>
>> # on your branch on the other hand I get a NULL pointer:
>
> I've fixed that (v4l2_dev was never initialized), and I've also rebased my
> tree
> to the latest code. Can you try again?
>
This time I get a kernel crash at _
Hans,
>> > Are you still able to test the si4713 driver? Because I have patches
>>
>>
>>
>> I see. In fact that is my next step on my todo list for si4713. I
>> still have an n900 that I can fetch from my drobe, so just a matter of
>> booting it with newer kernel.
>>
>> > outstanding that I wou
Hi Hans,
My last email didn't reach the list, so re-sending.
On Wed, Mar 20, 2013 at 5:04 AM, Hans Verkuil wrote:
>
> Hi Eduardo!
>
> On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote:
> > Hello Mauro and Hans,
> >
> > Here are a couple of minor changes for si4713 FM transmitter driver.
>
> T
35 matches
Mail list logo
