Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-25 Thread Sascha Hauer
On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote: > > On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: > > > + > > > /* > > > * Bitfield of

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-24 Thread Sascha Hauer
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: > Signed-off-by: Denis Carikli > --- > ChangeLog v13->v14: > - Rebased > ChangeLog 12->v13: > - No changes > ChangeLog 11->v12: > - Improved the define names to match the hardware: > ENABLE_POL is not a clock signal but instead an en

Re: [PATCH 08/43] imx-drm: ipu-v3: Add units required for video capture

2014-06-10 Thread Sascha Hauer
On Sat, Jun 07, 2014 at 02:56:10PM -0700, Steve Longerbeam wrote: > Adds the following new IPU units: > > - Camera Sensor Interface (csi) > - Sensor Multi FIFO Controller (smfc) > - Image Converter (ic) > - Image Rotator (irt) > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/imx-drm/

Re: [PATCH 30/43] ARM: dts: imx6: add pin groups for imx6q/dl for IPU1 CSI0

2014-06-10 Thread Sascha Hauer
On Sat, Jun 07, 2014 at 02:56:32PM -0700, Steve Longerbeam wrote: > Signed-off-by: Steve Longerbeam > Signed-off-by: Jiada Wang > --- > arch/arm/boot/dts/imx6qdl.dtsi | 52 > > 1 file changed, 52 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qd

Re: [PATCH 04/43] imx-drm: ipu-v3: Add solo/dual-lite IPU device type

2014-06-10 Thread Sascha Hauer
Hi Steve, On Sat, Jun 07, 2014 at 02:56:06PM -0700, Steve Longerbeam wrote: > Signed-off-by: Jiada Wang > --- > drivers/staging/imx-drm/ipu-v3/ipu-common.c | 18 ++ > include/linux/platform_data/imx-ipu-v3.h|1 + > 2 files changed, 19 insertions(+) > > diff --git a/dri

Re: [PATCH] media: mx1_camera: Remove driver

2014-05-11 Thread Sascha Hauer
, mx1_camera > is now removed from the tree. > > Signed-off-by: Alexander Shiyan I remember this driver was in the way of further cleanups. We should remove it. Acked-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Industrial

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-17 Thread Sascha Hauer
Hi Grant, On Mon, Feb 17, 2014 at 06:14:51PM +, Grant Likely wrote: > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel > > wrote: > > > From: Philipp Zabel > > > > > > This patch moves the parsing helpers used to parse connected grap

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sascha Hauer
On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: > On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > > On Sat, 20 Jul 2013, Greg KH wrote: > > > > > > >>That should be passed using platform data. > > > > > > > > > >Ick, don't pass strings around, pass pointers. If you have pla

Re: [PATCH 2/2] Print parser position on error

2013-06-18 Thread Sascha Hauer
Hi Laurent, On Wed, Jun 19, 2013 at 02:39:48AM +0200, Laurent Pinchart wrote: > Hi Sascha, > > On Monday 10 June 2013 15:56:01 Laurent Pinchart wrote: > > Hi Sascha, > > > > I'm sorry for the late reply. > > > > Great patch set, thank you. It's very helpful. > > Should I got ahead and apply th

Re: [PATCH] media: i2c: mt9p031: add OF support

2013-05-27 Thread Sascha Hauer
nt Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Sakari Ailus > Cc: Grant Likely > Cc: Sascha Hauer > Cc: Rob Herring > Cc: Rob Landley > Cc: Arnd Bergmann > Cc: devicetree-disc...@lists.ozlabs.org > Cc: d

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-13 Thread Sascha Hauer
On Tue, May 14, 2013 at 12:59:27AM +0200, Laurent Pinchart wrote: > Hi Sascha, > > On Monday 13 May 2013 12:46:04 Sascha Hauer wrote: > > On Wed, May 08, 2013 at 12:37:29PM +0200, Laurent Pinchart wrote: > > > Hi Prabhakar, > > > > > > On Wednesda

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-13 Thread Sascha Hauer
On Wed, May 08, 2013 at 12:37:29PM +0200, Laurent Pinchart wrote: > Hi Prabhakar, > > On Wednesday 08 May 2013 10:19:57 Prabhakar Lad wrote: > > On Wed, May 8, 2013 at 7:32 AM, Laurent Pinchart wrote: > > > On Tuesday 07 May 2013 15:10:36 Prabhakar Lad wrote: > > >> On Mon, May 6, 2013 at 8:29 PM,

Re: [PATCH 1/2] Print more detailed parse error messages

2013-05-08 Thread Sascha Hauer
On Wed, May 08, 2013 at 03:27:53PM +0200, Sascha Hauer wrote: > The following errors usually resulted in the same 'Unable to parse link' > message: > > - one of the given entities does not exist > - one of the pads of a given entity does not exist > - No link exists b

[PATCH 2/2] Print parser position on error

2013-05-08 Thread Sascha Hauer
: Sascha Hauer --- src/mediactl.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/src/mediactl.c b/src/mediactl.c index c65de50..04ade15 100644 --- a/src/mediactl.c +++ b/src/mediactl.c @@ -40,6 +40,22 @@ #include "media

[PATCH] media-ctl error messages

2013-05-08 Thread Sascha Hauer
27;1' on entity "mt9p031 0-0048". Maximum pad number is 0 media_parse_setup_link: Unable to parse link "mt9p031 0-0048":1->"/soc/cammultiplex@plx0":1[0] ^ Please consider applying. Sascha ------

[PATCH 1/2] Print more detailed parse error messages

2013-05-08 Thread Sascha Hauer
e the user a clue what is going wrong. Signed-off-by: Sascha Hauer --- src/mediactl.c | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/src/mediactl.c b/src/mediactl.c index 4783a58..c65de50 100644 --- a/src/mediactl.c +++ b/src/mediactl.c

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-01 Thread Sascha Hauer
nt Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Sakari Ailus > Cc: Grant Likely > Cc: Sascha Hauer > Cc: Rob Herring > Cc: Rob Landley > Cc: devicetree-disc...@lists.ozlabs.org > Cc: davinci-linux-open-sou...@lin

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-30 Thread Sascha Hauer
Hi Guennadi, On Fri, Apr 12, 2013 at 05:40:22PM +0200, Guennadi Liakhovetski wrote: > Currently bridge device drivers register devices for all subdevices > synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor > is attached to a video bridge device, the bridge driver will crea

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Sascha Hauer
Hi, One more point for your devicetree conversions, On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > +static struct mt9p031_platform_data > + *mt9p031_get_pdata(struct i2c_client *client) > + > +{ >

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-29 Thread Sascha Hauer
On Fri, Apr 26, 2013 at 11:07:24PM +0200, Guennadi Liakhovetski wrote: > Hi Sascha > > On Fri, 26 Apr 2013, Sascha Hauer wrote: > > > Hi Guennadi, > > > > On Fri, Apr 12, 2013 at 05:40:22PM +0200, Guennadi Liakhovetski wrote: > > > + > > > +

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Sascha Hauer
On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrock

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-26 Thread Sascha Hauer
On Fri, Apr 26, 2013 at 10:43:28AM +0200, Guennadi Liakhovetski wrote: > Hi Sascha > > On Fri, 26 Apr 2013, Sascha Hauer wrote: > > > > > > > > > That information should be conveyed by platform/DT data for the host, > > > > and be > > >

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-26 Thread Sascha Hauer
Hi Guennadi, On Fri, Apr 12, 2013 at 05:40:22PM +0200, Guennadi Liakhovetski wrote: > + > +static bool match_i2c(struct device *dev, struct v4l2_async_hw_info *hw_dev) > +{ > + struct i2c_client *client = i2c_verify_client(dev); > + return client && > + hw_dev->bus_type == V4L2

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-26 Thread Sascha Hauer
Hi Guennadi, On Mon, Apr 22, 2013 at 02:39:57PM +0200, Guennadi Liakhovetski wrote: > On Mon, 22 Apr 2013, Laurent Pinchart wrote: > > > Hi Guennadi, > > > > On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: > > > On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: > > > > Adding str

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Sascha Hauer
On Thu, Mar 14, 2013 at 01:58:05PM +, Arnd Bergmann wrote: > On Thursday 14 March 2013, Fabio Porcedda wrote: > > This patch converts the drivers to use the > > module_platform_driver_probe() macro which makes the code smaller and > > a bit simpler. > > > > Signed-off-by: Fabio Porcedda > > C

Re: [PATCH 09/15] media: coda: don't build on multiplatform

2013-01-22 Thread Sascha Hauer
On Mon, Jan 21, 2013 at 05:16:02PM +, Arnd Bergmann wrote: > The coda video codec driver depends on a mach-imx or mach-mxs specific > header file "mach/iram.h". This is not available when building for > multiplatform, so let us disable this driver for v3.8 when building > multiplatform, and hop

[PATCH] [media] coda: Fix build due to iram.h rename

2013-01-07 Thread Sascha Hauer
ers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free' Since the content of iram.h is not imx specific, move it to include/linux/platform_data/imx-iram.h instead. This is an intermediate solution until the i.MX iram allocator is converted to the generic SRAM

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2013-01-02 Thread Sascha Hauer
Hi Mauro, On Thu, Dec 27, 2012 at 08:15:12PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 17 Dec 2012 10:37:14 +0100 > Sascha Hauer escreveu: > > > On Wed, Nov 14, 2012 at 11:04:42AM -0200, Fabio Estevam wrote: > > > commit c045e3f13 (ARM: imx: include iram.h

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 01:57:56PM -0600, Rob Clark wrote: > On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > > > > This implies that the mas

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 10:04:22AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart > wrote: > > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: > >> It just seems to me that, at least from a DRM/KMS perspective, adding > >> another layer (=CDF) for HDMI or DP

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > wrote: > > Hi Rob, > > > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: > >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: > >> >> Many developers showed interest in th

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2012-12-17 Thread Sascha Hauer
On Wed, Nov 14, 2012 at 11:04:42AM -0200, Fabio Estevam wrote: > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed > the > location of iram.h, which causes the following build error when building the > coda > driver: > > drivers/media/platform/coda.c:27:23: error: mach/

Re: [RFC v2 0/5] Common Display Framework

2012-11-23 Thread Sascha Hauer
Hi Laurent, On Thu, Nov 22, 2012 at 10:45:31PM +0100, Laurent Pinchart wrote: > From: Laurent Pinchart > > The CDF models this using a Russian doll's model. From the display controller > point of view only the first external entity (LVDS to DSI converter) is > visible. The display controller t

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Sascha Hauer
Hi Laurent, On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: > Hi Steffen, > > > + > > + htotal = vm->hactive + vm->hfront_porch + vm->hback_porch + > > +vm->hsync_len; > > + vtotal = vm->vactive + vm->vfront_porch + vm->vback_porch + > > +vm->vsync_le

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Sascha Hauer
On Thu, Nov 22, 2012 at 09:50:10AM +0100, Laurent Pinchart wrote: > Hi Sascha, > > On Thursday 22 November 2012 07:20:00 Sascha Hauer wrote: > > On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: > > > Hi Steffen, > > > > > > >

Re: [PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-16 Thread Sascha Hauer
On Mon, Nov 05, 2012 at 04:59:44PM +0100, Javier Martin wrote: > Add support for IRAM to i.MX27 non-DT platforms using > iram_init() function. > > Signed-off-by: Javier Martin > --- > arch/arm/mach-imx/mm-imx27.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-imx/m

Re: [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-11-14 Thread Sascha Hauer
On Wed, Nov 14, 2012 at 04:22:40PM -0200, Fabio Estevam wrote: > Hi Sascha, > > On Wed, Oct 31, 2012 at 9:57 AM, Mauro Carvalho Chehab > wrote: > > > As it seems that those patches depend on some patches at the arm tree, > > the better is to merge them via -arm tree. > > > > So, > > > > Acked-by

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Sascha Hauer
Hi Steffen, You lose memory in several places: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: > +static struct display_timing *of_get_display_timing(struct device_node *np) > +{ > + struct display_timing *dt; > + int ret = 0; > + > + dt = kzalloc(sizeof(*dt), GFP_KE

Re: [PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-06 Thread Sascha Hauer
On Tue, Nov 06, 2012 at 12:37:35PM +0100, Guennadi Liakhovetski wrote: > Hi Javier > > On Mon, 5 Nov 2012, Javier Martin wrote: > > > Add support for IRAM to i.MX27 non-DT platforms using > > iram_init() function. > > I'm not sure this belongs in a camera driver. Can IRAM not be used for > anyt

Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-31 Thread Sascha Hauer
On Wed, Oct 31, 2012 at 04:53:03PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2012 14:53:47 +0100 (CET) > Guennadi Liakhovetski escreveu: > > > On Wed, 31 Oct 2012, Fabio Estevam wrote: > > > > > Hi Sascha, > > > > > > On Wed, Oct

Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-31 Thread Sascha Hauer
-camera driver. > > > > In the old mx27 clock driver we used to have: > > > > DEFINE_CLOCK1(csi_clk, 0, NULL, 0, parent, &csi_clk1, &per4_clk); > > > > ,so does the same in the new clock driver > > > > Signed-off-by: Fabio Estevam > &

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-25 Thread Sascha Hauer
(csi_clk, 0, NULL, 0, parent, &csi_clk1, &per4_clk); > > ,so does the same in the new clock driver. > > Signed-off-by: Fabio Estevam I'm fine with merging this through the media tree. Acked-by: Sascha Hauer Sascha > --- > arch/arm/mach-imx/clk-imx27.c |1 + >

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-10 Thread Sascha Hauer
On Wed, Oct 10, 2012 at 05:51:27PM +0900, Mark Brown wrote: > On Wed, Oct 10, 2012 at 10:40:06AM +0200, Sascha Hauer wrote: > > > Mark, when do we get the same for aSoC? ;) > > Well, I'm unlikely to work on it as I don't have any systems which can > boot with devi

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-10 Thread Sascha Hauer
Hi Guennadi, On Mon, Oct 08, 2012 at 09:58:58AM +0200, Guennadi Liakhovetski wrote: > On Fri, 5 Oct 2012, Sascha Hauer wrote: > > > On Fri, Oct 05, 2012 at 05:41:00PM +0200, Guennadi Liakhovetski wrote: > > > Hi Sascha > > > > > > > > > > >

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-05 Thread Sascha Hauer
On Fri, Oct 05, 2012 at 05:41:00PM +0200, Guennadi Liakhovetski wrote: > Hi Sascha > > > > + > > > + ceu0: ceu@0xfe91 { > > > + compatible = "renesas,sh-mobile-ceu"; > > > + reg = <0xfe91 0xa0>; > > > + interrupts = <0x880>; > > > + > > > + mclk: master_cloc

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-05 Thread Sascha Hauer
Hi Guennadi, Some comments inline. On Thu, Sep 27, 2012 at 04:07:23PM +0200, Guennadi Liakhovetski wrote: > This patch adds a document, describing common V4L2 device tree bindings. > > Co-authored-by: Sylwester Nawrocki > Signed-off-by: Guennadi Liakhovetski > --- > Documentation/devicetree/

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-18 Thread Sascha Hauer
Hi Shawn, On Mon, Sep 17, 2012 at 01:34:29PM +0800, Shawn Guo wrote: > The series enables multi-platform support for imx. Since the required > frameworks (clk, pwm) and spare_irq have already been adopted on imx, > the series is all about cleaning up mach/* headers. Along with the > changes, arc

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-17 Thread Sascha Hauer
ks. The config should be updated with the last patch. I'm fine with the changes to mx2-camera, but Javier should give his ok to it, he has worked on it quite a lot recently. One other issue related to imx-dma, see comment to that patch. Otherwise

Re: [RFC 1/5] video: Add generic display panel core

2012-09-13 Thread Sascha Hauer
On Thu, Sep 13, 2012 at 03:40:40AM +0200, Laurent Pinchart wrote: > Hi Sascha, > > > > +int panel_get_modes(struct panel *panel, const struct fb_videomode > > > **modes) > > > +{ > > > + if (!panel->ops || !panel->ops->get_modes) > > > + return 0; > > > + > > > + return panel->ops->get_mod

Re: [RFC 1/5] video: Add generic display panel core

2012-09-04 Thread Sascha Hauer
Hi Laurent, On Fri, Aug 17, 2012 at 02:49:39AM +0200, Laurent Pinchart wrote: > +/** > + * panel_get_modes - Get video modes supported by the panel > + * @panel: The panel > + * @modes: Pointer to an array of modes > + * > + * Fill the modes argument with a pointer to an array of video modes. The

[PATCH 1/2] media v4l2-mem2mem: Use list_first_entry

2012-08-31 Thread Sascha Hauer
Use list_first_entry instead of list_entry which makes the intention of the code more clear. Signed-off-by: Sascha Hauer --- drivers/media/video/v4l2-mem2mem.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/v4l2-mem2mem.c b/drivers/media/video

[PATCH 2/2] media v4l2-mem2mem: fix src/out and dst/cap num_rdy

2012-08-31 Thread Sascha Hauer
src bufs belong to out queue, dst bufs belong to in queue. Currently this is not a real problem since all users currently need exactly one input and one output buffer. Signed-off-by: Sascha Hauer --- include/media/v4l2-mem2mem.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] v4l2 mem2mem

2012-08-31 Thread Sascha Hauer
Two small patches, one fix and one more or less cosmetic patch for the v4l2 mem2mem framework. Comments welcome. Thanks, Sascha Sascha Hauer (2): media v4l2-mem2mem: Use list_first_entry media v4l2-mem2mem: fix src

Re: [PATCH] media: mx2_camera: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags.

2012-08-28 Thread Sascha Hauer
longer and can be safely removed since: | commit 8a76e5383fb5f58868fdd3a2fe1f4b95988f10a8 | Author: Javier Martin | Date: Wed Jul 11 17:34:54 2012 +0200 | |media: mx2_camera: Fix mbus format handling Signed-off-by: Javier Martin Acked-by: Laurent Pinchart

Re: Vacations.

2012-08-07 Thread Sascha Hauer
On Fri, Aug 03, 2012 at 05:09:15PM +0200, Guennadi Liakhovetski wrote: > Hi Javier > > On Fri, 3 Aug 2012, javier Martin wrote: > > > Hi, > > I will be out of the office until August the 19th. > > > > I just wanted to send a reminder of some patches that I have pending. > > > > For Mauro 3.7: >

Re: [PATCH 2/2 v2] i.MX27: Visstrim_M10: Add support for deinterlacing driver.

2012-08-03 Thread Sascha Hauer
On Thu, Jul 12, 2012 at 01:35:29PM +0200, Javier Martin wrote: > Visstrim_M10 have a tvp5150 whose video output must be deinterlaced. > The new mem2mem deinterlacing driver is very useful for that purpose. > > Signed-off-by: Javier Martin > --- > Changes since v1: > - Removed commented out code.

Re: [PATCH 4/4] media: mx2_camera: Fix clock handling for i.MX27.

2012-07-31 Thread Sascha Hauer
Hi Guennadi, On Tue, Jul 31, 2012 at 05:14:25PM +0200, Guennadi Liakhovetski wrote: > Hi Javier > > > @@ -436,7 +436,8 @@ static void mx2_camera_deactivate(struct mx2_camera_dev > > *pcdev) > > { > > unsigned long flags; > > > > - clk_disable(pcdev->clk_csi); > > + if (cpu_is_mx27())

Re: "[PULL] video_visstrim for 3.6"

2012-07-31 Thread Sascha Hauer
>> arch/arm/plat-mxc/devices/Kconfig |6 +- > >> arch/arm/plat-mxc/devices/Makefile |1 + > >> arch/arm/plat-mxc/devices/platform-imx27-coda.c | 37 + > >> arch/arm/plat-mxc/include/mach/devices-common.h |8 + > > >

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread Sascha Hauer
On Mon, Jul 09, 2012 at 09:46:03AM +0200, javier Martin wrote: > On 9 July 2012 09:43, Sascha Hauer wrote: > > On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: > >> On 9 July 2012 09:28, Sascha Hauer wrote: > >> > On Fri, Jul 06, 2012 at 12:56:0

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread Sascha Hauer
On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: > On 9 July 2012 09:28, Sascha Hauer wrote: > > On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > >> This driver wasn't converted to the new clock changes > >> (clk_prepare_enable/clk

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread Sascha Hauer
On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > This driver wasn't converted to the new clock changes > (clk_prepare_enable/clk_disable_unprepare). Also naming > of emma-prp related clocks for the i.MX27 was not correct. > --- > Enable clocks only for i.MX27. > Indeed, > > -

Re: [PATCH] [v2] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread Sascha Hauer
On Fri, Jul 06, 2012 at 09:46:46AM +0200, javier Martin wrote: > On 6 July 2012 09:34, Sascha Hauer wrote: > > On Fri, Jul 06, 2012 at 09:13:11AM +0200, Javier Martin wrote: > >> if (cpu_is_mx27()) { > >> free_irq(pcdev->irq_emma, pcdev); > &

Re: [PATCH] [v2] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread Sascha Hauer
On Fri, Jul 06, 2012 at 09:13:11AM +0200, Javier Martin wrote: > This driver wasn't converted to the new clock changes > (clk_prepare_enable/clk_disable_unprepare). Also naming > of emma-prp related clocks for the i.MX27 was not correct. > > Signed-off-by: Javier Martin > --- > arch/arm/mach-imx

Re: media: i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-05 Thread Sascha Hauer
Hi Javier, On Fri, Jul 06, 2012 at 08:31:49AM +0200, Javier Martin wrote: > This driver wasn't converted to the new clock changes > (clk_prepare_enable/clk_disable_unprepare). Also naming > of emma-prp related clocks for the i.MX27 was not correct. Thanks for fixing this. Sorry for breaking this

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-02 Thread Sascha Hauer
On Mon, Jul 02, 2012 at 12:36:46PM +0200, javier Martin wrote: > Hi Sascha, > I almost have a final version ready which includes multi-instance > support (not tested though) [1]. As I stated, we assumed the extra > effort of looking at your code in [2] in order to provide a mechanism > that preserv

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-20 Thread Sascha Hauer
On Wed, Jun 20, 2012 at 10:25:50PM +0800, Shawn Guo wrote: > On Wed, Jun 20, 2012 at 04:10:27PM +0200, javier Martin wrote: > > If I drop this platform data it is OK with you if I don't add device > > tree support by now? > > > I'm fine. Sascha? Fine with me. Sascha -- Pengutronix e.K.

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-20 Thread Sascha Hauer
On Wed, Jun 20, 2012 at 09:51:32AM +0200, javier Martin wrote: > Hi Sascha, > thank you for your review. > > > > > Since we all move to devicetree shouldn't we stop adding new > > platform devices? > > Our platfrom, 'visstrim_m10' doesn't currently support devicetree yet, > so it would be highly

Re: [RFC] Support for H.264/MPEG4 encoder (VPU) in i.MX27.

2012-06-08 Thread Sascha Hauer
On Fri, Jun 08, 2012 at 01:32:27PM +0200, javier Martin wrote: > On 8 June 2012 11:23, Sascha Hauer wrote: > > On Fri, Jun 08, 2012 at 11:02:31AM +0200, javier Martin wrote: > > Hi Sascha, > > From our point of view the current situation is the following: > We have a

Re: [RFC] Support for H.264/MPEG4 encoder (VPU) in i.MX27.

2012-06-08 Thread Sascha Hauer
On Fri, Jun 08, 2012 at 11:02:31AM +0200, javier Martin wrote: > Hi, > I've checked this matter with a colleague and we have several reasons > to doubt that the i.MX27 and the i.MX53 can share the same driver for > their Video Processing Units (VPU): > > 1. The VPU in the i.MX27 is a "codadx6" wit

Re: [RFC] Support for H.264/MPEG4 encoder (VPU) in i.MX27.

2012-06-08 Thread Sascha Hauer
On Fri, Jun 08, 2012 at 09:39:15AM +0200, javier Martin wrote: > Hi Robert, > > On 8 June 2012 09:26, Robert Schwebel wrote: > > Hi Javier, > > > > On Fri, Jun 08, 2012 at 09:21:13AM +0200, javier Martin wrote: > >> If you refer to driver in [1] I have some concerns: i.MX27 VPU should > >> be imp

Re: [PATCH 08/15] video: mx2_emmaprp: Use clk_prepare_enable/clk_disable_unprepare

2012-05-29 Thread Sascha Hauer
On Fri, May 25, 2012 at 08:14:49PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Prepare the clock before enabling it. > > Cc: Guennadi Liakhovetski > Cc: > Signed-off-by: Fabio Estevam Acked-by: Sascha Hauer > --- > drivers/media/video/mx2_emmap

Re: [PATCH 07/15] video: mx2_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-29 Thread Sascha Hauer
On Fri, May 25, 2012 at 08:14:48PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Prepare the clock before enabling it. > > Cc: Guennadi Liakhovetski > Cc: > Signed-off-by: Fabio Estevam Acked-by: Sascha Hauer > --- > drivers/media/video/mx2_camera.c |

Re: [PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-29 Thread Sascha Hauer
On Fri, May 25, 2012 at 08:14:47PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Prepare the clock before enabling it. > > Cc: Guennadi Liakhovetski > Cc: > Signed-off-by: Fabio Estevam Acked-by: Sascha Hauer > --- > drivers/media/video/mx1_came

Re: [PATCH v2 2/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

2012-04-02 Thread Sascha Hauer
On Mon, Mar 26, 2012 at 03:17:47PM +0200, Javier Martin wrote: > > Signed-off-by: Javier Martin Acked-by: Sascha Hauer Should go via the media tree. Sascha > --- > arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) &g

Re: [PATCH] ARM: i.MX35: Add set_rate and round_rate calls to csi_clk

2012-03-20 Thread Sascha Hauer
On Tue, Mar 20, 2012 at 12:29:52PM +0200, Alex Gershgorin wrote: > This patch add set_rate and round_rate calls to csi_clk. This is needed > to give mx3-camera control over master clock rate to camera. The file you are patching is scheduled for removal in favour for the common clock framework, so

Re: [PATCH v1] i.MX35-PDK: Add Camera support

2012-03-19 Thread Sascha Hauer
On Mon, Mar 19, 2012 at 07:43:32PM -0300, Fabio Estevam wrote: > Hi Sascha, > > On Mon, Mar 19, 2012 at 7:37 PM, Sascha Hauer wrote: > > > It's scheduled there. I should have responded with an applied message. > > Please apply this one too: http://patchwork.ozlabs.

Re: [PATCH v1] i.MX35-PDK: Add Camera support

2012-03-19 Thread Sascha Hauer
On Mon, Mar 19, 2012 at 07:17:27PM -0300, Mauro Carvalho Chehab wrote: > Em 19-03-2012 19:03, Mauro Carvalho Chehab escreveu: > > Em 13-03-2012 12:05, Alex Gershgorin escreveu: > >> In i.MX35-PDK, OV2640 camera is populated on the > >> personality board. This camera is registered as a subdevice vi

Re: [PATCH] i.MX35-PDK: Add Camera support

2012-03-13 Thread Sascha Hauer
On Mon, Mar 12, 2012 at 06:28:51PM +0200, Alex wrote: > In i.MX35-PDK, OV2640 camera is populated on the > personality board. This camera is registered as a subdevice via soc-camera > interface. > > Signed-off-by: Alex Gershgorin > --- > arch/arm/mach-imx/mach-mx35_3ds.c | 87 >

Re: [PATCH] V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA mandatory

2012-02-20 Thread Sascha Hauer
On Mon, Feb 20, 2012 at 04:17:39PM +0100, Guennadi Liakhovetski wrote: > From: Sascha Hauer > > The i.MX27 DMA support was introduced with the initial commit of this > driver and originally created by me. However, I never got this stable > due to the racy DMA engine and used

Re: [PATCH 1/2] media/video mx2_camera: make using emma mandatory for i.MX27

2012-02-17 Thread Sascha Hauer
On Fri, Feb 17, 2012 at 10:24:13AM +0100, Guennadi Liakhovetski wrote: > Hi Sascha > > Thanks for the patch. Just one question: > > On Fri, 17 Feb 2012, Sascha Hauer wrote: > > > The i.MX27 dma support was introduced with the initial commit of > > this drive

Re: [PATCH] media: video: mx2_camera: Remove ifdef's

2012-02-17 Thread Sascha Hauer
Hi Guennadi, On Thu, Feb 16, 2012 at 08:06:16PM +0100, Guennadi Liakhovetski wrote: > Hi > > On Thu, 16 Feb 2012, Baruch Siach wrote: > > > Hi Fabio, > > > > On Thu, Feb 16, 2012 at 04:25:39PM -0200, Fabio Estevam wrote: > > > As we are able to build a same kernel that supports both mx27 and mx

[PATCH 2/2] media/video mx2_camera: remove now unused code

2012-02-17 Thread Sascha Hauer
As the i.MX27 dma code was disabled in the last patch we can now remove the resulting dead code. I tried to do this as mechanically as possible as I currently have no setup to test this. Signed-off-by: Sascha Hauer --- drivers/media/video/mx2_camera.c | 225

[PATCH 1/2] media/video mx2_camera: make using emma mandatory for i.MX27

2012-02-17 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/media/video/mx2_camera.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 04aab0c..65709e4 100644 --- a/drivers/media/video/mx2_camera.

i.MX27 camera: remove i.MX27 DMA support

2012-02-17 Thread Sascha Hauer
i.MX27 DMA support was initially introduced by me and I never got this to work properly. As this is also uses a legacy DMA API and is the source of ifdeffery in the driver, remove it. Sascha Hauer (2): media/video mx2_camera: make using emma mandatory for i.MX27 media/video

Re: [PATCH] media: video: mx2_camera: Remove ifdef's

2012-02-17 Thread Sascha Hauer
On Thu, Feb 16, 2012 at 04:25:39PM -0200, Fabio Estevam wrote: > As we are able to build a same kernel that supports both mx27 and mx25, we > should remove > the ifdef's for CONFIG_MACH_MX27 in the mx2_camera driver. It's not that simple. Yes, we are able to build a kernel for both i.MX25 and i.M

Re: [PATCH v3 1/2] MX2: Add platform definitions for eMMa-PrP device.

2011-12-09 Thread Sascha Hauer
iver, so it should be applied via > the > media tree, and likely as patch 2, in order to avoid breaking git bisect. > > Yet, I'd like to have the mach-imx maintainer's ack on this. Acked-by: Sascha Hauer Sascha > > Regards, > Mauro. > > > > >Ch

Re: [PATCH v2 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations.

2011-11-23 Thread Sascha Hauer
On Wed, Nov 23, 2011 at 01:32:29PM +0100, javier Martin wrote: > Hi Sascha, > I was just trying to fix the issues you pointed previously and I have > a question for you. > > On 22 November 2011 21:55, Sascha Hauer wrote: > > Hi Javier, > >> + > >> +static i

Re: [PATCH v2 1/2] MX2: Add platform definitions for eMMa-PrP device.

2011-11-22 Thread Sascha Hauer
On Tue, Nov 22, 2011 at 01:01:55PM +0100, Javier Martin wrote: > eMMa-PrP device included in Freescale i.MX2 chips can also > be used separately to process memory buffers. > > Signed-off-by: Javier Martin > --- > arch/arm/mach-imx/devices-imx27.h |2 + > arch/arm/plat-mxc/devic

Re: [PATCH v2 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations.

2011-11-22 Thread Sascha Hauer
Hi Javier, On Tue, Nov 22, 2011 at 01:01:56PM +0100, Javier Martin wrote: > Changes since v1: > - Embed queue data in ctx structure to allow multi instance. > - Remove redundant job_ready callback. > - Adjust format against device capabilities. > - Register/unregister video device at the right tim

Re: [PATCH] media i.MX27 camera: remove legacy dma support

2011-08-24 Thread Sascha Hauer
Hi Guennadi, On Wed, Aug 24, 2011 at 09:19:24AM +0200, Guennadi Liakhovetski wrote: > Sure, if it's broken, let's remove it. But there are a couple of points, > that we have to fix in this patch. Sorry, a stupid question: has this been > tested on i.MX27? Nope, I currently do not have mainline

[PATCH] media i.MX27 camera: remove legacy dma support

2011-08-23 Thread Sascha Hauer
helps us to get rid of another user of the legacy i.MX DMA support, Also, remove the dependency on ARCH_MX* macros as these are scheduled for removal. Signed-off-by: Sascha Hauer Cc: Baruch Siach Cc: linux-media@vger.kernel.org Cc: Guennadi Liakhovetski --- drivers/media/video/Kconfig

[PATCH 1/6] media/video i.MX: use IMX_HAVE_PLATFORM_* macros

2011-03-03 Thread Sascha Hauer
The i.MX architecture provides IMX_HAVE_PLATFORM_* macros to signal that a selected SoC supports a certain hardware. Use them instead of depending on ARCH_* directly. Signed-off-by: Sascha Hauer Acked-by: Uwe Kleine-König Cc: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab Cc: Hans

[PATCH] soc-camera: Compile fixes for mx2-camera

2010-11-08 Thread Sascha Hauer
mx2-camera got broken during the last merge window. This patch fixes this and removes some unused variables. Signed-off-by: Sascha Hauer --- drivers/media/video/mx2_camera.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b

Re: [PATCH 1/5] mx2_camera: change to register and probe

2010-08-04 Thread Sascha Hauer
On Wed, Aug 04, 2010 at 01:01:34AM +0200, Guennadi Liakhovetski wrote: > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > On Tue, Aug 03, 2010 at 08:22:13PM +0200, Guennadi Liakhovetski wrote: > > > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > > > > > change this driver back to register a

Re: [PATCH 2/4] mx2_camera: return IRQ_NONE when doing nothing

2010-07-27 Thread Sascha Hauer
On Tue, Jul 27, 2010 at 03:06:08PM +0300, Baruch Siach wrote: > Signed-off-by: Baruch Siach > --- > drivers/media/video/mx2_camera.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/video/mx2_camera.c > b/drivers/media/video/mx2_camera.c > index

Re: Pull request mxc

2010-07-26 Thread Sascha Hauer
[Added Guennadi, Baruch and linux-media to cc] On Mon, Jul 26, 2010 at 11:32:19AM +0100, Russell King - ARM Linux wrote: > On Mon, Jul 26, 2010 at 10:28:55AM +0100, Russell King - ARM Linux wrote: > > On Mon, Jul 26, 2010 at 11:00:14AM +0200, Sascha Hauer wrote: > > > 160 f

Re: [PATCHv6] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-07-16 Thread Sascha Hauer
On Sun, Jul 11, 2010 at 01:18:27PM +0200, Guennadi Liakhovetski wrote: > On Sun, 4 Jul 2010, Baruch Siach wrote: > > > This is the soc_camera support developed by Sascha Hauer for the i.MX27. > > Alan > > Carvalho de Assis modified the original driver to get it wor

Re: [PATCHv4 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-06-21 Thread Sascha Hauer
Hi Baruch, > > Baruch Siach (3): > mx2_camera: Add soc_camera support for i.MX25/i.MX27 > mx27: add support for the CSI device > mx25: add support for the CSI device applied 2/3 and 3/3 for 2.6.36. Sascha > > arch/arm/mach-mx2/clock_imx27.c |2 +- > arch/arm/mach-mx2/devi

Re: mt9m111 swap_rgb_red_blue

2010-05-31 Thread Sascha Hauer
On Mon, May 31, 2010 at 08:46:00AM +0200, Guennadi Liakhovetski wrote: > On Mon, 31 May 2010, Robert Jarzmik wrote: > > > Sascha Hauer writes: > > > > > Hi Robert, > > > > > > I have digged around in the Datasheet and if I understand it correctly &g

Re: mt9m111 swap_rgb_red_blue

2010-05-27 Thread Sascha Hauer
Hi Robert, On Wed, May 26, 2010 at 10:19:21PM +0200, Robert Jarzmik wrote: > Sascha Hauer writes: > > > Hi, > > > > The mt9m111 soc-camera driver has a swap_rgb_red_blue variable which is > > hardcoded to 1. This results in, well the name says it, red and blue b

  1   2   >