cron job: media_tree daily build: OK

2019-02-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 16 05:00:11 CET 2019 media-tree git hash:6fd369dd1cb65a032f1ab9227033ecb7b759656d media_build git

[PATCH -next] media: vimc: remove set but not used variable 'frame_size'

2019-02-15 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/media/platform/vimc/vimc-sensor.c: In function 'vimc_sen_process_frame': drivers/media/platform/vimc/vimc-sensor.c:208:15: warning: variable 'frame_size' set but not used [-Wunused-but-set-variable] It's never used since introduction. Signe

v4l2 mem2mem compose support?

2019-02-15 Thread Tim Harvey
Greetings, What is needed to be able to take advantage of hardware video composing capabilities and make them available in something like GStreamer? Philipp's mem2mem driver [1] exposes the IMX IC and GStreamer's v4l2convert element uses this nicely for hardware accelerated scaling/csc/flip/rotat

Re: [PATCH v7] media: imx: add mem2mem device

2019-02-15 Thread Tim Harvey
On Fri, Feb 15, 2019 at 8:24 AM Nicolas Dufresne wrote: > > Le vendredi 15 février 2019 à 12:10 +0100, Philipp Zabel a écrit : > > > I'm also not sure how to specify hflip/vflip... I don't think > > > extra-controls parses 'hflip', 'vflip' as ipu_csc_scaler_s_ctrl gets > > > called with V4L2_CID_H

Re: [PATCH v7] media: imx: add mem2mem device

2019-02-15 Thread Tim Harvey
On Fri, Feb 15, 2019 at 3:10 AM Philipp Zabel wrote: > > Hi Tim, > > On Tue, 2019-02-12 at 11:01 -0800, Tim Harvey wrote: > > On Thu, Jan 17, 2019 at 7:50 AM Philipp Zabel > > wrote: > > > > > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > > (image converter post proce

Re: [PATCH v2 07/10] media: vicodec: Register another node for stateless decoder

2019-02-15 Thread kbuild test robot
Hi Dafna, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190215] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[GIT PULL FOR v5.1] Small vicodec update

2019-02-15 Thread Hans Verkuil
Just one patch for vicodec which will help a lot with the upcoming stateless codec implementation in this driver which will need this information. Regards, Hans The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: media: vimc: fill in bus_info in media_device_i

[PATCH v2] media: vicodec: Add a flag for I-frames in fwht header

2019-02-15 Thread Dafna Hirschfeld
Add a flag 'FWHT_FL_I_FRAME' that indicates that this is an I-frame. This requires incrementing to version 3 Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.h | 3 ++- drivers/media/platform/vicodec/codec-v4l2-fwht.c | 4 +++- drivers/media/platform/vicodec/vic

Re: [linux-uvc-devel] metadata device file

2019-02-15 Thread Kieran Bingham
Hi Moritz, On 15/02/2019 08:45, Moritz Dötterl wrote: > Hello > > Recently we updated the Kernel on our Ubuntu machines from 4.15 to 4.18 > because the OS was randomly freezing. However with the new Kernel we ran > into a problem regarding our two webcams. We had two /dev/video device > files per

[PATCH] media: vicodec: Add a flag for I-frames in fwht header

2019-02-15 Thread Dafna Hirschfeld
Add a flag 'FWHT_FL_I_FRAME' that indicates that this is an I-frame. This requires incrementing to version 3 Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.h | 3 ++- drivers/media/platform/vicodec/codec-v4l2-fwht.c | 2 +- drivers/media/platform/vicodec/vicod

Re: [PATCH V2 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-15 Thread Ira Weiny
> NOTE: This series depends on my clean up patch to remove the write parameter > from gup_fast_permitted()[1] > > HFI1, qib, and mthca, use get_user_pages_fast() due to it performance > advantages. These pages can be held for a significant time. But > get_user_pages_fast() does not protect again

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
On 2/15/19 5:27 PM, Nicolas Dufresne wrote: > Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : >> Hi Stanimir, >> >> I never paid much attention to this patch series since others were busy >> discussing it and I had a lot of other things on my plate, but then I heard >> that this p

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Nicolas Dufresne
Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : > Hi Stanimir, > > I never paid much attention to this patch series since others were busy > discussing it and I had a lot of other things on my plate, but then I heard > that this patch made G_FMT blocking. > > That's a no-go. App

Re: [PATCH v7] media: imx: add mem2mem device

2019-02-15 Thread Nicolas Dufresne
Le vendredi 15 février 2019 à 12:10 +0100, Philipp Zabel a écrit : > > I'm also not sure how to specify hflip/vflip... I don't think > > extra-controls parses 'hflip', 'vflip' as ipu_csc_scaler_s_ctrl gets > > called with V4L2_CID_HFLIP/V4L2_CID_VFLIP but ctrl->val is always 0. > > You can use v4l

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Ezequiel Garcia
On Fri, 2019-02-15 at 17:05 +0100, Hans Verkuil wrote: > On 2/15/19 4:52 PM, Ezequiel Garcia wrote: > > On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: > > > The for loop to reset the memory of the plane reserved fields runs over > > > num_planes provided by the user without validating it. E

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Hans Verkuil
On 2/15/19 4:52 PM, Ezequiel Garcia wrote: > On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: >> The for loop to reset the memory of the plane reserved fields runs over >> num_planes provided by the user without validating it. Ensure num_planes >> is no more than VIDEO_MAX_PLANES before the l

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Ezequiel Garcia
On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: > The for loop to reset the memory of the plane reserved fields runs over > num_planes provided by the user without validating it. Ensure num_planes > is no more than VIDEO_MAX_PLANES before the loop. > > Fixes: 4e1e0eb0e074 ("media: v4l2-ioct

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
Hi Stanimir, I never paid much attention to this patch series since others were busy discussing it and I had a lot of other things on my plate, but then I heard that this patch made G_FMT blocking. That's a no-go. Apparently s5p-mfc does that as well, and that's against the V4L2 spec as well (cle

Re: [PATCH v2 09/10] media: vicodec: add a flag FWHT_FL_P_FRAME to fwht header

2019-02-15 Thread Hans Verkuil
Hi Dafna, On 2/15/19 2:05 PM, Dafna Hirschfeld wrote: > Add the flag 'FWHT_FL_P_FRAME' to indicate that > the frame is a p-frame so it needs the previous buffer > as a reference frame. This is needed for the stateless > codecs. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/

[PATCH v2 08/10] media: vicodec: call v4l2_m2m_buf_copy_metadata also upon error

2019-02-15 Thread Dafna Hirschfeld
call v4l2_m2m_buf_copy_metadata also if decoding/encoding ends with status VB2_BUF_STATE_ERROR. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/vicodec-core.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/vicodec/v

[PATCH v2 04/10] media: vicodec: keep the ref frame according to the format in decoder

2019-02-15 Thread Dafna Hirschfeld
In the decoder, save the inner reference frame in the same format as the capture buffer. The decoder writes directly to the capture buffer and then the capture buffer is copied to the reference buffer. This will simplify the stateless decoder. Signed-off-by: Dafna Hirschfeld --- drivers/media/pl

[PATCH v2 05/10] media: vicodec: add struct for encoder/decoder instance

2019-02-15 Thread Dafna Hirschfeld
Add struct 'vicodec_dev_instance' for the fields in vicodec_dev that have have both decoder and encoder versions. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/vicodec-core.c | 194 +- 1 file changed, 92 insertions(+), 102 deletions(-) diff --git a/drivers/m

[PATCH v2 03/10] media: vicodec: add field 'buf' to fwht_raw_frame

2019-02-15 Thread Dafna Hirschfeld
Add the field 'buf' to fwht_raw_frame to indicate the start of the raw frame buffer. This field will be used to copy the capture buffer to the reference buffer in the next patch. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.h | 1 + drivers/media/platform/vicod

[PATCH v2 02/10] media: vicodec: Move raw frame preparation code to a function

2019-02-15 Thread Dafna Hirschfeld
Introduce 'prepare_raw_frame' function that fills the values of a raw frame struct according to the format. Signed-off-by: Dafna Hirschfeld --- .../media/platform/vicodec/codec-v4l2-fwht.c | 140 ++ 1 file changed, 75 insertions(+), 65 deletions(-) diff --git a/drivers/media/pl

[PATCH v2 06/10] media: vicodec: Introducing stateless fwht defs and structs

2019-02-15 Thread Dafna Hirschfeld
Add structs and definitions needed to implement stateless decoder for fwht. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/vicodec-core.c | 12 drivers/media/v4l2-core/v4l2-ctrls.c | 6 ++ include/uapi/linux/v4l2-controls.h| 13 +

[PATCH v2 01/10] media: v4l2-ctrl: v4l2_ctrl_request_setup returns with error upon failure

2019-02-15 Thread Dafna Hirschfeld
If one of the controls fails to set, then 'v4l2_ctrl_request_setup' immediately returns with the error code. Signed-off-by: Dafna Hirschfeld --- drivers/media/v4l2-core/v4l2-ctrls.c | 18 +++--- include/media/v4l2-ctrls.h | 2 +- 2 files changed, 12 insertions(+), 8 deleti

[PATCH v2 07/10] media: vicodec: Register another node for stateless decoder

2019-02-15 Thread Dafna Hirschfeld
Add stateless decoder instance field to the dev struct and register another node for the statelsess decoder. The stateless API for the node will be implemented in further patches. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/vicodec-core.c | 46 +-- 1 file c

[PATCH v2 10/10] media: vicodec: Add support for stateless decoder.

2019-02-15 Thread Dafna Hirschfeld
Implement a stateless decoder for the new node. Signed-off-by: Dafna Hirschfeld --- .../media/platform/vicodec/codec-v4l2-fwht.h | 1 + drivers/media/platform/vicodec/vicodec-core.c | 325 -- include/uapi/linux/v4l2-controls.h| 1 + 3 files changed, 291 insertion

[PATCH v2 09/10] media: vicodec: add a flag FWHT_FL_P_FRAME to fwht header

2019-02-15 Thread Dafna Hirschfeld
Add the flag 'FWHT_FL_P_FRAME' to indicate that the frame is a p-frame so it needs the previous buffer as a reference frame. This is needed for the stateless codecs. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.h | 1 + drivers/media/platform/vicodec/codec-v

[PATCH v2 00/10] add support to stateless decoder

2019-02-15 Thread Dafna Hirschfeld
Changes from v1: 2 new patches 0001: media: v4l2-ctrl: v4l2_ctrl_request_setup returns with error upon failure 0009: media: vicodec: add a flag FWHT_FL_P_FRAME to fwht header changed patches according to reviews: 0005,0007,0010 Dafna Hirschfeld (10): media: v4l2-ctrl: v4l2_ctrl_request_setup re

Re: [PATCH] media: tda1997: fix get-edid

2019-02-15 Thread Hans Verkuil
Hi Tim, On 2/5/19 5:23 PM, Tim Harvey wrote: I merged this patch and added my own commit log message. Just remember to provide it in the future... Regards, Hans > Signed-off-by: Tim Harvey > --- > drivers/media/i2c/tda1997x.c | 4 > 1 file changed, 4 insertions(+) > > diff --g

[GIT PULL FOR v5.1] Various fixes/improvements

2019-02-15 Thread Hans Verkuil (hansverk)
Hi Mauro, I decided to include Jacopo's arch/sh patch since there hasn't been a reply for 10 days, and it is a simple fix for an annoying problem. I also merged Ezequiel's 'Correct return type' series: it's a bit painful as it touches on more sources than you would expect, but this is a good time

Re: [PATCH v7] media: imx: add mem2mem device

2019-02-15 Thread Philipp Zabel
Hi Tim, On Tue, 2019-02-12 at 11:01 -0800, Tim Harvey wrote: > On Thu, Jan 17, 2019 at 7:50 AM Philipp Zabel wrote: > > > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > (image converter post processing) task for scaling and colorspace > > conversion. > > On i.MX6Q/DL S

Re: [PATCHv2] media-ctl: support a bus-info string as argument to -d

2019-02-15 Thread Hans Verkuil
On 2/15/19 10:22 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Fri, Feb 15, 2019 at 09:10:24AM +0100, Hans Verkuil wrote: >> If the device passed to the -d option is not found, then interpret it >> as a bus-info string and try to open all media devices and see which o

Re: [PATCHv2] media-ctl: support a bus-info string as argument to -d

2019-02-15 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Fri, Feb 15, 2019 at 09:10:24AM +0100, Hans Verkuil wrote: > If the device passed to the -d option is not found, then interpret it > as a bus-info string and try to open all media devices and see which one > reports a bus-info string equal to the -d argument.

[PATCH] media:staging/intel-ipu3: parameter buffer refactoring

2019-02-15 Thread bingbu . cao
From: Bingbu Cao Current ImgU driver processes and releases the parameter buffer immediately after queued from user. This does not align with other image buffers which are grouped in sets and used for the same frame. If user queues multiple parameter buffers continuously, only the last one will t

[PATCH] media: atmel: atmel-isc: reworked driver and formats

2019-02-15 Thread Eugen.Hristev
From: Eugen Hristev This change is a redesign in the formats and the way the ISC is configured w.r.t. sensor format and the output format from the ISC. I have changed the splitting between sensor output (which is also ISC input) and ISC output. The sensor format represents the way the sensor is c

Re: [PATCH 3/3] media: mx2-emmaprp: Add DT bindings documentation

2019-02-15 Thread Hans Verkuil
Rob, Can you take a look at this? Thanks! Hans On 12/16/18 4:49 AM, Alexander Shiyan wrote: > This patch adds DT binding documentation for the Freescale enhanced > Multimedia Accelerator (eMMA) video Pre-processor (PrP). > > Signed-off-by: Alexander Shiyan > --- > .../devicetree/bind

[PATCHv2] media-ctl: support a bus-info string as argument to -d

2019-02-15 Thread Hans Verkuil
If the device passed to the -d option is not found, then interpret it as a bus-info string and try to open all media devices and see which one reports a bus-info string equal to the -d argument. That makes it possible to open a specific media device without having to know the name of the media dev