On 02/27/2018 12:39 AM, Douglas Fischer wrote:
> Hans,
>
> See comments below. Thank you for the quick response on this and all
> your patience and help in general with these patches.
My pleasure!
>
> On Mon, 26 Feb 2018 12:57:26 +0100
> Hans Verkuil wrote:
>
>> On 02/26/2018 03:27 AM, Dougla
On 02/27/2018 02:53 AM, Quytelda Kahja wrote:
> Hans,
>
> Thank you very much for your input on the patch; however this patch
> has already been applied to the staging tree. Additionally:
I have no record of this being applied through linux-media. Did someone
else pick this up? Greg perhaps?
>>
On Tue, Feb 27, 2018 at 10:12:46AM +0800, Yong Deng wrote:
> Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
> interface and CSI1 is used for parallel interface. This is not
> documented in datasheet but by test and guess.
>
> This patch implement a v4l2 framework driver for
Define the device tree bindings for the panasonic,amg88xx i2c
video driver.
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
Signed-off-by: Matt Ranostay
---
.../bindings/media/i2c/panasonic,amg88xx.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644
Docum
There are several thermal sensors that only have a low-speed bus
interface but output valid video data. This patchset enables support
for the AMG88xx "Grid-Eye" sensor family.
Cc: Luca Barbato
Cc: Laurent Pinchart
Signed-off-by: Matt Ranostay
---
MAINTAINERS | 6 +
drivers/
Add support for video-i2c polling driver
Changes from v1:
* Switch to SPDX tags versus GPLv2 license text
* Remove unneeded zeroing of data structures
* Add video_i2c_try_fmt_vid_cap call in video_i2c_s_fmt_vid_cap function
Changes from v2:
* Add missing linux/kthread.h include that broke x86_64
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Feb 27 05:00:15 CET 2018
media-tree git hash:15ea2df9143729a2b722d4ca2b52cfa14a819d8e
media_build git
Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
interface and CSI1 is used for parallel interface. This is not
documented in datasheet but by test and guess.
This patch implement a v4l2 framework driver for it.
Currently, the driver only support the parallel interface. MIPI
Add binding documentation for Allwinner V3s CSI.
Acked-by: Maxime Ripard
Acked-by: Sakari Ailus
Reviewed-by: Rob Herring
Signed-off-by: Yong Deng
---
.../devicetree/bindings/media/sun6i-csi.txt| 59 ++
1 file changed, 59 insertions(+)
create mode 100644 Documentat
This patchset add initial support for Allwinner V3s CSI.
Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
interface and CSI1 is used for parallel interface. This is not
documented in datasheet but by test and guess.
This patchset implement a v4l2 framework driver and add a b
Hans,
Thank you very much for your input on the patch; however this patch
has already been applied to the staging tree. Additionally:
> What coding style problem? You should give a short description of
> what you are fixing.
The subject of the patch (which becomes the subject of the email when
u
Hi,
On Mon, 26 Feb 2018 12:06:37 +0100
Hans Verkuil wrote:
> Hi all,
>
> On 01/30/2018 03:48 AM, Yong wrote:
> > Hi,
> >
> > On Mon, 29 Jan 2018 13:49:14 -0800
> > Randy Dunlap wrote:
> >
> >> On 01/29/2018 01:21 AM, Yong Deng wrote:
> >>> Allwinner V3s SoC features two CSI module. CSI0 is u
Hans,
See comments below. Thank you for the quick response on this and all
your patience and help in general with these patches.
On Mon, 26 Feb 2018 12:57:26 +0100
Hans Verkuil wrote:
> On 02/26/2018 03:27 AM, Douglas Fischer wrote:
> > Fixed si470x_start() disabling the interrupt signal, causi
Added the call to v4l2_device_register() required to add a new radio device.
Without this patch, it is impossible for the driver to load. This does not
affect USB devices.
Fixed cleanup order from v2.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si47
The VSPDL variant drives two DU channels through two LIF and two
blenders, BRU and BRS. The DU channels thus share the five available
VSPDL inputs and expose them as five KMS planes.
The current implementation assigns the BRS to the second LIF and thus
artificially limits the number of planes for
The vsp1_drm_pipeline enabled field is set but never used. Remove it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 4
drivers/media/platform/vsp1/vsp1_drm.h | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drm.c
b/driver
In order to make the vsp1_du_setup_lif() easier to read, and for
symmetry with the DRM pipeline input setup, move the pipeline output
setup code to a separate function.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 107 +++--
1 file chan
Move the duplicated DRM pipeline configuration code to a function and
call it from vsp1_du_setup_lif() and vsp1_du_atomic_flush().
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 95 +++---
1 file changed, 43 insertions(+), 52 deletions(-)
When disabling a DRM plane, the corresponding RPF is only marked as
removed from the pipeline in the atomic update handler, with the actual
removal happening when configuring the pipeline at atomic commit time.
This is required as the RPF has to be disabled in the hardware, which
can't be done from
Some VSP instances have two blending units named BRU (Blend/ROP Unit)
and BRS (Blend/ROP Sub unit). The BRS is a smaller version of the BRU
with only two inputs, but otherwise offers similar features and offers
the same register interface. The BRU and BRS can be used exchangeably in
VSP pipelines (
Various types of objects subclassing vsp1_entity currently store a
pointer to the pipeline. Move the pointer to vsp1_entity to simplify the
code and avoid storing the pipeline in more entity subclasses later.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c| 20
The entities in the pipeline are all started when the LIF is setup.
Remove the outdated comment that state otherwise.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/vsp1/vs
To implement fully dynamic plane assignment to pipelines, we need to
reassign the BRU and BRS to the DRM pipelines in the atomic commit
handler. In preparation for this setup factor out the BRU source pad
code and call it both at LIF setup and atomic commit time.
Signed-off-by: Laurent Pinchart
-
The vsp1_du_setup_lif() function setups the DRM pipeline input manually.
This duplicates the code from the vsp1_du_pipeline_setup_input()
function. Replace the manual implementation by a call to the function.
As the pipeline has no enabled input in vsp1_du_setup_lif(), the
vsp1_du_pipeline_setup_i
Hello,
On R-Car H3 ES2.0+ and M3-N SoCs, two display pipelines are served by the same
VSP instance (named VSPDL). The VSPDL includes two blending units named BRU
and BRS, unlike the other display-related VSPD that serves a single display
channel with a single blending unit.
The VSPDL has five inp
Display list completion is already reported to the frame end handler,
but that mechanism is global to all display lists. In order to implement
BRU and BRS reassignment in DRM pipelines we will need to wait for
completion of a particular display list. Extend the display list and
frame end handler AP
Dynamic assignment of the BRU and BRS to pipelines is prone to
regressions, add messages to make debugging easier. Keep it as a
separate commit to ease removal of those messages once the code will
deem to be completely stable.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_
The DRM pipeline setup code used at atomic commit time is similar to the
setup code used when enabling the pipeline. Move it to a separate
function in order to share it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 347 +
1 file cha
The DRM support code manages a pipeline of VSP entities, each backed by
a media entity. When starting or stopping the pipeline, it starts and
stops the media pipeline through the media API in order to store the
pipeline pointer in every entity.
The driver doesn't use the pipe pointer in media enti
The DRM pipeline handling code uses the entity's pipe list head to check
whether the entity is already included in a pipeline. This method is a
bit fragile in the sense that it uses list_empty() on a list_head that
is a list member. Replace it by a simpler check for the entity pipe
pointer.
Signed
VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
As ARCH_RENESAS implies OF, the latter can be dropped.
Signed-off-by: Geert Uytterhoeven
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platfor
tree/branch: git://git.ragnatech.se/linux media-tree
branch HEAD: 52e17089d1850774d2ef583cdef2b060b84fca8c media: imx: Don't
initialize vars that won't be used
elapsed time: 203m
configs tested: 133
The following configs have been built successfully.
More configs may be tested in the coming d
We don't want a separate module for vb2-trace.
That fixes this warning:
WARNING: modpost: missing MODULE_LICENSE() in
drivers/media/common/videobuf2/vb2-trace.o
When building as module.
While here, add a SPDX header.
Reported-by: Stephen Rothwell
Signed-off-by: Mauro Carvalho Chehab
Hi Linus,
thanks for catching these things :-) .
Am Montag, 26. Februar 2018, 11:12:30 CET schrieb Linus Walleij:
> On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan wrote:
> > + pdata->grf_gpio2b_iomux = ioremap((resource_size_t)
> > + (GRF_
Hi Hans,
Em Wed, 21 Feb 2018 16:32:09 +0100
Hans Verkuil escreveu:
> The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums.
>
> Signed-off-by: Hans Verkuil
> Acked-by: Sakari Ailus
Thanks for your patch. I have one comment about it, though. See below.
> ---
> Documentati
The following changes since commit 52e17089d1850774d2ef583cdef2b060b84fca8c:
media: imx: Don't initialize vars that won't be used (2018-02-26 08:38:57
-0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v4.17b
for you to fetch changes up to c35d71cf
As we're adding this as a new driver, make checkpatch happier by
solving several style issues, using --fix-inplace at strict mode.
Some issues required manual work.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/tw9910.c | 32
1 file changed, 16 inse
As we're adding this as a new driver, make checkpatch happier by
solving some whitespace issues, using --fix-inplace.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/ov772x.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/ov7
On 26.02.2018 11:57, Jani Nikula wrote:
> On Thu, 22 Feb 2018, Daniel Thompson wrote:
>> On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote:
>>> Add PWM mode to pwm_config() function. The drivers which uses pwm_config()
>>> were adapted to this change.
>>>
>>> Signed-off-by: Claudiu
Without CONFIG_PM, we get a harmless build warning:
drivers/media/i2c/ov2685.c:516:12: error: 'ov2685_runtime_suspend' defined but
not used [-Werror=unused-function]
static int ov2685_runtime_suspend(struct device *dev)
^~
drivers/media/i2c/ov2685.c:507:12: error:
Without CONFIG_PM, we get a harmless build warning:
drivers/media/i2c/ov5695.c:1033:12: error: 'ov5695_runtime_suspend' defined but
not used [-Werror=unused-function]
static int ov5695_runtime_suspend(struct device *dev)
^~
drivers/media/i2c/ov5695.c:1024:12: erro
On 02/22/2018 10:51 AM, Hugues Fruchet wrote:
> Add DCMI JPEG support.
Does this patch depend on the 'fix lock scheme' patch?
It looks good to me except for one small thing (see below), but I think this
depends on the 'fix lock scheme' patch, right?
>
> Signed-off-by: Hugues Fruchet
> ---
> d
Hi Hugo,
Thanks for this patch, but I am a bit hesitant to apply it. Did you test
that PAL and NTSC still work after this change?
Unless you've tested it then I'm inclined to just apply the second patch that
adds the SECAM sequence.
Regards,
Hans
On 02/24/2018 07:24 PM, Hugo Grostabuss
On 02/22/2018 10:49 AM, Hugues Fruchet wrote:
> Fix lock scheme leading to spurious freeze.
Can you elaborate a bit more? It's hard to review since you don't
describe what was wrong and why this fixes the problem.
Regards,
Hans
>
> Signed-off-by: Hugues Fruchet
> ---
> version 2:
>
On 02/20/2018 07:53 AM, Quytelda Kahja wrote:
> Fix a coding style problem.
What coding style problem? You should give a short description of
what you are fixing.
>
> Signed-off-by: Quytelda Kahja
> ---
> This is the patch without the unnecessary fixes for line length.
>
> drivers/staging/med
Solve the following warnings:
+ drivers/media/i2c/tvp514x.c: warning: Excess function parameter 'a'
description in 'tvp514x_g_frame_interval': => 759
+ drivers/media/i2c/tvp514x.c: warning: Excess function parameter 'a'
description in 'tvp514x_s_frame_interval': => 784
+ drivers/media/i2c
As reported by gcc:
+ drivers/staging/media/imx/imx-media-csi.c: warning: variable 'input_fi' set
but not used [-Wunused-but-set-variable]: => 671:33
+ drivers/staging/media/imx/imx-media-csi.c: warning: variable 'pinctrl' set
but not used [-Wunused-but-set-variable]: => 1742:18
input_fi
Fix this warning regression:
drivers/media/i2c/ov7740.c: warning: variable 'ret' set but not used
[-Wunused-but-set-variable]: => 276:6
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/ov7740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/o
On 02/26/2018 03:27 AM, Douglas Fischer wrote:
> Fixed si470x_start() disabling the interrupt signal, causing tune
> operations to never complete. This does not affect USB radios
> because they poll the registers instead of using the IRQ line.
>
> Stylistic and comment changes from v2.
>
> Signed
On 02/24/2018 12:05 PM, Matt Ranostay wrote:
> There are several thermal sensors that only have a low-speed bus
> interface but output valid video data. This patchset enables support
> for the AMG88xx "Grid-Eye" sensor family.
>
> Cc: Luca Barbato
> Cc: Laurent Pinchart
> Signed-off-by: Matt Ran
On Wed, Feb 21, 2018 at 11:38:24PM +, James Hogan wrote:
> Now that arch/metag/ has been removed, remove the METAG dependency from
> the IMG IR device driver. The hardware is also present on MIPS SoCs so
> the driver still has value.
>
> Signed-off-by: James Hogan
> Cc: Mauro Carvalho Chehab
On 02/26/2018 03:25 AM, Douglas Fischer wrote:
> Added the call to v4l2_device_register() required to add a new radio
> device. Without this patch, it is impossible for the driver to load.
> This does not affect USB devices.
>
> Fixed cleanup order from v2.
>
> Signed-off-by: Douglas Fischer
> -
Hi all,
On 01/30/2018 03:48 AM, Yong wrote:
> Hi,
>
> On Mon, 29 Jan 2018 13:49:14 -0800
> Randy Dunlap wrote:
>
>> On 01/29/2018 01:21 AM, Yong Deng wrote:
>>> Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
>>> interface and CSI1 is used for parallel interface. This is
On Mon, Feb 26, 2018 at 9:25 AM, Wen Nuan wrote:
> From: Leo Wen
>
> Add DT bindings documentation for Rockchip RK1608.
>
> Changes V2:
> - Delete spi-min-frequency property.
> - Add the external sensor's control pin and clock properties.
> - Delete the '&pinctrl' node.
>
> Signed-off-by: Leo We
On Mon, Feb 26, 2018 at 9:16 AM, Wen Nuan wrote:
> +#include
Please do not use this old API in new drivers.
Just use GPIO descriptors and only
#include
There is documentation in
Documentation/gpio/consumer.txt
> +static int rk1608_pin_power(struct rk1608_state *pdata, int on)
> +{
> +
On Thu, 22 Feb 2018, Daniel Thompson wrote:
> On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote:
>> Add PWM mode to pwm_config() function. The drivers which uses pwm_config()
>> were adapted to this change.
>>
>> Signed-off-by: Claudiu Beznea
>> ---
>> arch/arm/mach-s3c24xx/mach-rx
Hi Leo,
Thank you for this patch series!
Here is a quick review of this driver:
On 02/26/2018 09:16 AM, Wen Nuan wrote:
> From: Leo Wen
>
> Rk1608 is used as a PreISP to link on Soc, which mainly has two functions.
> One is to download the firmware of RK1608, and the other is to match the
> ex
From: Hans Verkuil
Add two new ops (error_inj_show and error_inj_parse_line) to support
error injection functionality for CEC adapters. If both are present,
then the core will add a new error-inj debugfs file that can be used
to see the current error injection commands and to set error injection
From: Hans Verkuil
Implement all the error injection commands.
The state machine gets new states for the various error situations,
helper functions are added to detect whether an error injection is
active and the actual error injections are implemented.
Signed-off-by: Hans Verkuil
---
drivers
From: Hans Verkuil
Document the new core error injection callbacks.
Signed-off-by: Hans Verkuil
---
Documentation/media/kapi/cec-core.rst | 72 ++-
1 file changed, 71 insertions(+), 1 deletion(-)
diff --git a/Documentation/media/kapi/cec-core.rst
b/Documentati
From: Hans Verkuil
This function will be needed for injecting a custom pulse.
Signed-off-by: Hans Verkuil
---
drivers/media/cec/cec-pin-priv.h | 2 ++
drivers/media/cec/cec-pin.c | 21 +
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/media/cec
From: Hans Verkuil
The CEC Pin framework adds support for Error Injection.
Document all the error injections commands and how to use it.
Signed-off-by: Hans Verkuil
---
.../media/cec-drivers/cec-pin-error-inj.rst| 321 +
Documentation/media/cec-drivers/index.rst
From: Hans Verkuil
This patch series adds support for CEC error injection for drivers
using the CEC Pin Framework (cec-pin.c). There are two CEC drivers
currently using this framework: the sun4i Allwinner A10/A20 driver
and the cec-gpio driver. This patch series was developed with the
cec-gpio dr
From: Hans Verkuil
Add support to the CEC Pin framework to parse error injection commands
and to show them.
The next patch will do the actual implementation of this.
Signed-off-by: Hans Verkuil
---
drivers/media/cec/Kconfig | 6 +
drivers/media/cec/Makefile| 4 +
d
From: Leo Wen
Add DT bindings documentation for Rockchip RK1608.
Changes V2:
- Delete spi-min-frequency property.
- Add the external sensor's control pin and clock properties.
- Delete the '&pinctrl' node.
Signed-off-by: Leo Wen
---
Documentation/devicetree/bindings/media/rk1608.txt | 97
From: Leo Wen
Rk1608 is used as a PreISP to link on Soc, which mainly has two functions.
One is to download the firmware of RK1608, and the other is to match the
extra sensor such as camera and enable sensor by calling sensor's s_power.
use below v4l2-ctl command to capture frames.
v4l2-ctl
From: Leo Wen
You can use the v4l2-ctl command to capture frames for RK1608.
Add DT-bindings documentation for Rockchip RK1608.
Add the information of the MAINTAINERS.
Leo Wen (2):
[media] Add Rockchip RK1608 driver
dt-bindings: Document the Rockchip RK1608 bindings
Documentation/devicetre
I'll rebase it on latest for-next in next version.
Thank you,
Claudiu Beznea
On 24.02.2018 22:49, kbuild test robot wrote:
> Hi Claudiu,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on pwm/for-next]
> [also build test WARNING on v4.16-rc2 next-20180223
68 matches
Mail list logo
