Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 16:50:52 +0200, Tomi Valkeinen wrote: > On 26/02/14 16:57, Philipp Zabel wrote: > > Hi Tomi, > > > > Am Mittwoch, den 26.02.2014, 15:14 +0200 schrieb Tomi Valkeinen: > >> On 25/02/14 16:58, Philipp Zabel wrote: > >> > >>> +Optional endpoint properties > >>> +-

Re: [PATCH v6 6/8] of: Implement simplified graph binding for single port devices

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:40 +0100, Philipp Zabel wrote: > For simple devices with only one port, it can be made implicit. > The endpoint node can be a direct child of the device node. > > Signed-off-by: Philipp Zabel Ergh... I think this is too loosely defined. The caller really should be exp

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 27 Feb 2014 10:36:36 +0200, Tomi Valkeinen wrote: > On 26/02/14 16:48, Philipp Zabel wrote: > > >> I would like the document to acknowledge the difference from the > >> phandle+args pattern used elsewhere and a description of when it would > >> be appropriate to use this instead of a sim

Re: [PATCH v6 2/8] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel wrote: > The device tree graph bindings as used by V4L2 and documented in > Documentation/device-tree/bindings/media/video-interfaces.txt contain > generic parts that are not media specific but could be useful for any > subsystem with data flow be

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 15:14:17 +0200, Tomi Valkeinen wrote: > On 25/02/14 16:58, Philipp Zabel wrote: > > > +Optional endpoint properties > > + > > + > > +- remote-endpoint: phandle to an 'endpoint' subnode of a remote device > > node. > > Why is that optional? What u

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:38 +0100, Philipp Zabel wrote: > A 'return endpoint;' at the end of the (!prev) case allows to > reduce the indentation level of the (prev) case. > > Signed-off-by: Philipp Zabel Acked-by: Grant Likely > --- > drivers/of/base.c | 42 ++--

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel wrote: > Hi Grant, > > thank you for the comments. Hi Philipp, I've got lots of comments and quesitons below, but I must say thank you for doing this. It is a helpful description. > > Am Mittwoch, den 26.02.2014, 11:01 + schrieb Grant Lik

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 06 Mar 2014 12:17:21 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 06 Mar 2014 14:16:57 + > Russell King - ARM Linux escreveu: > > > On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: > > > Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: > > > > Hi, > >

Re: [PATCH v6 5/8] [media] of: move common endpoint parsing to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:39 +0100, Philipp Zabel wrote: > This patch adds a new struct of_endpoint which is then embedded in struct > v4l2_of_endpoint and contains the endpoint properties that are not V4L2 > (or even media) specific: the port number, endpoint id, local device tree > node and rem

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel wrote: > Hi Grant, > > Am Mittwoch, den 26.02.2014, 11:37 + schrieb Grant Likely: > [...] > > > drivers/media/v4l2-core/v4l2-of.c | 117 > > > -- > > > drivers/of/Makefile | 1 + >

Re: [PATCH v6 3/8] of: Warn if of_graph_get_next_endpoint is called with the root node

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:37 +0100, Philipp Zabel wrote: > If of_graph_get_next_endpoint is given a parentless node instead of an > endpoint node, it is clearly a bug. > > Signed-off-by: Philipp Zabel Acked-by: Grant Likely > --- > Changes since v5: > - Added parentless previous endpoint's

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 6 Mar 2014 15:50:18 +, Russell King - ARM Linux wrote: > On Thu, Mar 06, 2014 at 04:39:39PM +0100, Philipp Zabel wrote: > > Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM > > Linux: > > > On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: > > > > thi

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel wrote: > Hi Mauro, Russell, > > I have temporarily removed the simplified bindings at Sylwester's > request and updated the branch with the acks. The following changes > since commit 0414855fdc4a40da05221fc6062cccbc0c30f169: > > Linux 3.14-rc5

Re: [PATCH v6 1/8] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:35 +0100, Philipp Zabel wrote: > This patch moves the parsing helpers used to parse connected graphs > in the device tree, like the video interface bindings documented in > Documentation/devicetree/bindings/media/video-interfaces.txt, from > drivers/media/v4l2-core/v4l2-

cron job: media_tree daily build: ERRORS

2014-03-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 8 04:00:37 CET 2014 git branch: test git hash: 5f9551ee5d9b2580712ea3c3b0f32b304191668b gcc versio

Re: [PATCH 1/3] lm3560: remove FSF address from the license

2014-03-07 Thread Sakari Ailus
On Wed, Feb 12, 2014 at 11:02:05AM +0200, Andy Shevchenko wrote: > There is no need to keep the FSF address inside each file. Moreover, it might > change in future which will make this one obsolete. > > There is no functional change. > > Signed-off-by: Andy Shevchenko Thanks, Andy! Patches appl

Re: [RFC v7 0/3] add new Dual LED FLASH LM3646

2014-03-07 Thread Sakari Ailus
Hi Daniel, On Mon, Mar 03, 2014 at 06:52:07PM +0900, Daniel Jeong wrote: > This patch is to add new dual led flash, lm3646. > LM3646 is the product of ti and it has two 1.5A sync. boost > converter with dual white current source. > 2 files are created and 4 files are modified. > And 3 patch

Re: sound dropouts with DVB

2014-03-07 Thread pinguin74
> The mediaplayer is using a codec for decoding/unpacking the compressed > digital stream. Oh, I just see my TV provider sends two video streams for each channel, a H264 encoded video stream and an MPEG2 video stream, both in each channel. No matter if a channel is HD or not, there is always a H2

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-07 Thread Bryan Wu
On Fri, Mar 7, 2014 at 3:10 AM, Ben Dooks wrote: > On 06/03/14 23:12, Bryan Wu wrote: >> >> On Mon, Feb 24, 2014 at 10:19 PM, Guennadi Liakhovetski >> wrote: >>> >>> Hi Bryan, >>> >>> On Mon, 24 Feb 2014, Bryan Wu wrote: >>> On Tue, Feb 18, 2014 at 10:40 AM, Bryan Wu wrote: > > On W

Re: sound dropouts with DVB

2014-03-07 Thread pinguin74
Am 07.03.2014 00:36, schrieb Markus Rechberger: >> I will try with mplayer later. What does codec issue mean? I think the >> audio stream in DVB-C is a digital stream that does not need to be >> changed or encoded in any way? I thought DVB playback simply is a kind >> of pass thru the digital stre

Re: [PATCH/RFC v2 1/5] Split media_device creation and opening

2014-03-07 Thread Sakari Ailus
On Fri, Mar 07, 2014 at 09:34:02AM +0200, Sakari Ailus wrote: > Hi Laurent, > > Thanks for the set. With the proposed chaanges, for the whole set: Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Philipp Zabel
Hi Laurent, Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. > > I've submitted a fix for the of_graph_get_next_endpoint() function, but it > hasn't been applied yet due to the patch series that contained it needing > more > work. >

Re: [PATCH v3] em28xx: Only deallocate struct em28xx after finishing all extensions

2014-03-07 Thread Mauro Carvalho Chehab
Em Fri, 07 Mar 2014 18:04:52 +0100 Frank Schäfer escreveu: > > Am 05.03.2014 15:22, schrieb Mauro Carvalho Chehab: > > We can't free struct em28xx while one of the extensions is still > > using it. > > > > So, add a kref() to control it, freeing it only after the > > extensions fini calls. > > >

Re: [PATCH v3] em28xx: Only deallocate struct em28xx after finishing all extensions

2014-03-07 Thread Frank Schäfer
Am 05.03.2014 15:22, schrieb Mauro Carvalho Chehab: > We can't free struct em28xx while one of the extensions is still > using it. > > So, add a kref() to control it, freeing it only after the > extensions fini calls. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/usb/em28xx/em28

Re: [patch v2] [patch] [media] em28xx-cards: remove a wrong indent level

2014-03-07 Thread Dan Carpenter
On Fri, Mar 07, 2014 at 05:46:28PM +0100, Frank Schäfer wrote: > > Am 05.03.2014 12:09, schrieb Dan Carpenter: > > This code is correct but the indenting is wrong and triggers a static > > checker warning "add curly braces?". > > > > Signed-off-by: Dan Carpenter > > --- > > v2: in v1 I added curl

Re: [patch v2] [patch] [media] em28xx-cards: remove a wrong indent level

2014-03-07 Thread Frank Schäfer
Am 05.03.2014 12:09, schrieb Dan Carpenter: > This code is correct but the indenting is wrong and triggers a static > checker warning "add curly braces?". > > Signed-off-by: Dan Carpenter > --- > v2: in v1 I added curly braces. > > diff --git a/drivers/media/usb/em28xx/em28xx-cards.c > b/drivers

Re: [PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Philipp Zabel
Hi Russell, Am Freitag, den 07.03.2014, 15:49 + schrieb Russell King - ARM Linux: > On Fri, Mar 07, 2014 at 04:06:10PM +0100, Philipp Zabel wrote: > > I have also updated the git branch. The following changes since commit > > d484700a36952c6675aa47dec4d7a536929aa922: > > > > of: Warn if of_

Re: [PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Sergei Shtylyov
On 03/07/2014 07:06 PM, Ben Dooks wrote: Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you think? diff --git a/arch/arm/boot/dts/r8a7790-lager.d

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-07 Thread Sergei Shtylyov
Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -

[PATCH 3/7] [media] adv7180: Remove unnecessary v4l2_device_unregister_subdev() from probe error path

2014-03-07 Thread Lars-Peter Clausen
The device can't possibly be registered at this point, so no need to to call v4l2_device_unregister_subdev(). Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 2359f

[PATCH 7/7] [media] adv7180: Add support for power down

2014-03-07 Thread Lars-Peter Clausen
The adv7180 has a low power mode in which the analog and the digital processing section are shut down. Implement the s_power callback to let bridge drivers put the part into low power mode when not needed. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 52 +++

[PATCH 5/7] [media] adv7180: Use threaded IRQ instead of IRQ + workqueue

2014-03-07 Thread Lars-Peter Clausen
The proper way to handle IRQs that need to be able to sleep in their IRQ handler is to use a threaded IRQ. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 33 + 1 file changed, 5 insertions(+), 28 deletions(-) diff --git a/drivers/media/i2c/ad

[PATCH 1/7] [media] adv7180: Fix remove order

2014-03-07 Thread Lars-Peter Clausen
The mutex is used in the subdev callbacks, so unregister the subdev before the mutex is destroyed. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c i

[PATCH 4/7] [media] adv7180: Remove duplicated probe error message

2014-03-07 Thread Lars-Peter Clausen
The device driver core already prints out a very similar message when a driver fails to probe. No need to print one in the driver itself. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/med

[PATCH 6/7] [media] adv7180: Add support for async device registration

2014-03-07 Thread Lars-Peter Clausen
Add support for async device registration to the adv7180 driver. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index c750aae..623cec5 100644 --- a/drivers

[PATCH 2/7] [media] adv7180: Free control handler on remove()

2014-03-07 Thread Lars-Peter Clausen
Make sure to free the control handler when the device is removed. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 1a3622a..2359fd8 100644 --- a/drivers/media/i2c/

Re: [PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Ben Dooks
On 07/03/14 16:50, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you think?

Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
On 07/03/14 16:45, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you think? Giv

Re: [PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Sergei Shtylyov
Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you think? diff --git a/arch/arm/boot/dts/r8a7790-

Re: [PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 04:06:10PM +0100, Philipp Zabel wrote: > I have also updated the git branch. The following changes since commit > d484700a36952c6675aa47dec4d7a536929aa922: > > of: Warn if of_graph_parse_endpoint is called with the root node > (2014-03-06 17:41:54 +0100) > > are availabl

Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Sergei Shtylyov
Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you think? diff --git a/arch/arm/boot/dts/r8a7790.dtsi b

Re: uvcvideo: logitech C920 resets controls during VIDIOC_STREAMON

2014-03-07 Thread William Manley
On 06/03/14 13:04, William Manley wrote: > On 06/03/14 12:09, Paulo Assis wrote: >> Hi, >> >> 2014-03-05 23:01 GMT+00:00 William Manley : >>> Hi All >>> >>> I've been attempting to use the Logitech C920 with the uvcvideo driver. >>> I set the controls with v4l2-ctl but some of them change during >

Re: [PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Philipp Zabel
Am Freitag, den 07.03.2014, 15:57 +0100 schrieb Philipp Zabel: > This patch fixes the following build error: > >In file included from drivers/media/i2c/adv7343.c:29:0: > >> include/linux/of_graph.h:41:1: error: expected identifier or '(' before > >> '{' token > { > ^ >include/linu

[PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Philipp Zabel
This patch fixes the following build error: In file included from drivers/media/i2c/adv7343.c:29:0: >> include/linux/of_graph.h:41:1: error: expected identifier or '(' before '{' >> token { ^ include/linux/of_graph.h:39:19: warning: 'of_graph_parse_endpoint' declared 'static' but n

Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

2014-03-07 Thread Hans Verkuil
Hi Laurent, Thanks for reviewing this series so quickly. I've added your nitpick to my tree and I plan to post the pull request on Monday. Regards, Hans On 03/07/2014 03:25 PM, Laurent Pinchart wrote: > Hi Hans, > > On Friday 07 March 2014 15:19:07 Hans Verkuil wrote: >> On 03/07/2014

[RFCv1 PATCH 5/5] DocBook media: clarify v4l2_pix_format and v4l2_pix_format_mplane fields

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Be more specific with regards to how some of these fields are interpreted. In particular height vs field and which fields can be set by the application. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/pixfmt.xml | 33 +++--- 1 file cha

[RFCv1 PATCH 1/5] DocBook media: update STREAMON/OFF documentation.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- .../DocBook/media/v4l/vidioc-streamon.xml | 28 +- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-streamon.xml b/Documentation/DocBook/media/v4l/vidioc-streamo

[RFCv1 PATCH 4/5] DocBook media: fix broken FIELD_ALTERNATE description.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil The sizeimage is that of a single field, not that of a full frame. That makes no sense, and in fact all drivers supporting ALTERNATE will set sizeimage to that of a field. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/io.xml | 7 +++ 1 file changed, 3 i

[RFCv1 PATCH 3/5] DocBook media: clarify v4l2_buffer/plane fields.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Be more specific as to who has to fill in each field/flag: the driver or the application. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/io.xml | 54 ++ 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/Documenta

[RFCv1 PATCH 2/5] DocBook: fix incorrect code example

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil The code said for (i = 0; i > 30; ++i) instead of i < 30. Fix this and clean it up a bit at the same time. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/dev-osd.xml | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[RFCv1 PATCH 0/5] DocBook media updates

2014-03-07 Thread Hans Verkuil
After doing a lot of work on v4l2-compliance I found some wrong and some missing information in the spec. This patch series fixes and clarifies them. The first clarifies two corner cases: what happens with queued buffers is STREAMON fails, and what happens if buffers are queued, STREAMON was never

Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

2014-03-07 Thread Laurent Pinchart
Hi Hans, On Friday 07 March 2014 15:19:07 Hans Verkuil wrote: > On 03/07/2014 03:09 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > Thank you for the patch. > > > > On Friday 07 March 2014 11:21:19 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Document that it is now possible to call

Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

2014-03-07 Thread Hans Verkuil
On 03/07/2014 03:09 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Friday 07 March 2014 11:21:19 Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document that it is now possible to call G/S_EDID from video nodes, not >> just sub-device nodes. Add a note that -EINVAL w

Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

2014-03-07 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 07 March 2014 11:21:19 Hans Verkuil wrote: > From: Hans Verkuil > > Document that it is now possible to call G/S_EDID from video nodes, not > just sub-device nodes. Add a note that -EINVAL will be returned if > the pad does not support EDIDs. > > Sig

Re: [REVIEWv1 PATCH 4/5] adv*: replace the deprecated v4l2_subdev_edid by v4l2_edid.

2014-03-07 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 07 March 2014 11:21:18 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil Acked-by: Laurent Pinchart > --- > drivers/media/i2c/ad9389b.c | 2 +- > drivers/media/i2c/adv7511.c | 2 +- > drivers/media/i2c/adv7604.c | 4 ++-- >

Re: [REVIEWv1 PATCH 3/5] v4l2: add VIDIOC_G/S_EDID support to the v4l2 core.

2014-03-07 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 07 March 2014 11:21:17 Hans Verkuil wrote: > From: Hans Verkuil > > Support this ioctl as part of the v4l2 core. Use the new ioctl > name and struct v4l2_edid type in the existing core code. > > Signed-off-by: Hans Verkuil Acked-by: Laurent Pinchar

Re: [REVIEWv1 PATCH 2/5] v4l2: allow v4l2_subdev_edid to be used with video nodes

2014-03-07 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 07 March 2014 11:21:16 Hans Verkuil wrote: > From: Hans Verkuil > > Struct v4l2_subdev_edid and the VIDIOC_SUBDEV_G/S_EDID ioctls were > specific for subdevices, but for hardware with a simple video pipeline > you do not need/want to create subdevice

Re: [REVIEWv1 PATCH 1/5] v4l2-compat-ioctl32: fix wrong VIDIOC_SUBDEV_G/S_EDID32 support.

2014-03-07 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 07 March 2014 11:21:15 Hans Verkuil wrote: > From: Hans Verkuil > > The wrong ioctl numbers were used due to a copy-and-paste error. > > Signed-off-by: Hans Verkuil > Cc: sta...@vger.kernel.org # for v3.7 and up Acked-by: Laurent Pinchart >

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: On 03/07/2014 02:22 PM, Archit Taneja wrote: Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fi

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 02:22 PM, Archit Taneja wrote: > Hi, > > On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: >>> >>> Do you think I can go ahead with posting the v3 patch set for 3.15, and >>> work on fixing the compliance issue for the -rc fixes? >> >> It's fine to upstream this in staging, but w

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 09:20:31AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 07 Mar 2014 11:55:17 + > Russell King - ARM Linux escreveu: > > > On Thu, Mar 06, 2014 at 06:13:20PM +0100, Philipp Zabel wrote: > > > Hi Mauro, Russell, > > > > > > I have temporarily removed the simplified bin

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fine to upstream this in staging, but while not all compliance errors are fixed it can't go to drivers/

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-07 Thread Geert Uytterhoeven
On Fri, Mar 7, 2014 at 2:01 PM, Ben Dooks wrote: > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > +family of devices. The current blocks are always slaves and suppot one input support Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

[PATCH 3/5] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras

2014-03-07 Thread Ben Dooks
From: Phil Edworthy Signed-off-by: Phil Edworthy --- drivers/media/platform/soc_camera/rcar_vin.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c index 3b1c05a..702dc47 100644 --- a/drivers

soc_camera rcar_vin support for device-tree binding

2014-03-07 Thread Ben Dooks
This is a series of patches to get towards the point the renesas rcar_vin driver can be bound via device-tree. Patches 1 and 2 add the device tree nodes, patch 3 is one which has been in my tree for a while and the last two modify the rcar_vin driver. -- To unsubscribe from this list: send the lin

[PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790-lager.dts | 38 + 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts

[PATCH 4/5] rcar_vin: copy flags from pdata

2014-03-07 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_camera/rcar_vi

[PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index a1e7c39..4c3eafb 100

[PATCH 5/5] rcar_vin: add devicetree support

2014-03-07 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140 insertions(+), 6 deletions(-) c

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 12:50 PM, Archit Taneja wrote: > Hi Hans, > > On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: >> On 03/04/14 12:25, Archit Taneja wrote: >>> I had a minor question about the selection API: >>> >>> Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding >>> 'BOUNDS' tar

RE: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Kamil Debski
Hi Arun, > From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] > Sent: Friday, March 07, 2014 12:10 PM > > Hi Sylwester, > > On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki > wrote: > > Hi, > > > > On 07/03/14 09:31, Arun Kumar K wrote: > >> From: avnd kiran > >> > >> Latest MFC v6 firmwa

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Mauro Carvalho Chehab
Em Fri, 07 Mar 2014 11:55:17 + Russell King - ARM Linux escreveu: > On Thu, Mar 06, 2014 at 06:13:20PM +0100, Philipp Zabel wrote: > > Hi Mauro, Russell, > > > > I have temporarily removed the simplified bindings at Sylwester's > > request and updated the branch with the acks. The following

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 05:50:30PM +0100, Philipp Zabel wrote: > Am Donnerstag, den 06.03.2014, 17:32 +0100 schrieb Sylwester Nawrocki: > > On 06/03/14 17:21, Philipp Zabel wrote: > > > Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: > > >> Yes, it's going to conflict with my

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 06:13:20PM +0100, Philipp Zabel wrote: > Hi Mauro, Russell, > > I have temporarily removed the simplified bindings at Sylwester's > request and updated the branch with the acks. The following changes > since commit 0414855fdc4a40da05221fc6062cccbc0c30f169: > > Linux 3.14

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Archit Taneja
Hi Hans, On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so, what's th

[GIT PULL FOR v3.15] Various fixes for 3.15

2014-03-07 Thread Hans Verkuil
The following changes since commit bfd0306462fdbc5e0a8c6999aef9dde0f9745399: [media] v4l: Document timestamp buffer flag behaviour (2014-03-05 16:48:28 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.15d for you to fetch changes up to fa7d917

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
Hi Sylwester, On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki wrote: > Hi, > > On 07/03/14 09:31, Arun Kumar K wrote: >> From: avnd kiran >> >> Latest MFC v6 firmware requires tile mode and loop filter >> setting to be done as part of Init buffer command, in sync >> with v7. So, move these se

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-07 Thread Ben Dooks
On 06/03/14 23:12, Bryan Wu wrote: On Mon, Feb 24, 2014 at 10:19 PM, Guennadi Liakhovetski wrote: Hi Bryan, On Mon, 24 Feb 2014, Bryan Wu wrote: On Tue, Feb 18, 2014 at 10:40 AM, Bryan Wu wrote: On Wed, Feb 12, 2014 at 12:05 PM, Bryan Wu wrote: From: Guennadi Liakhovetski With OF we ar

[REVIEW PATCH for v3.14 0/3] Three fixes

2014-03-07 Thread Hans Verkuil
This fixes three bugs that have been there for a long time: 1/3: since 3.7 2/3: since 3.12 3/3: since forever (at least 2.6.31, the oldest I checked) I'll make a pull request for this on Monday if there are no comments. Regards, Hans -- To unsubscribe from this list: send the line "uns

[REVIEW PATCH for v3.14 1/3] v4l2-compat-ioctl32: fix wrong VIDIOC_SUBDEV_G/S_EDID32 support.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil The wrong ioctl numbers were used due to a copy-and-paste error. Signed-off-by: Hans Verkuil Cc: sta...@vger.kernel.org # for v3.7 and up --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/me

[REVIEW PATCH for v3.14 3/3] saa7134: fix WARN_ON during resume.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Do not attempt to reload the tuner modules when resuming after a suspend. This triggers a WARN_ON in kernel/kmod.c:148 __request_module. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=69581. This has always been wrong, but it was never noticed until the WARN_ON was ad

[REVIEW PATCH for v3.14 2/3] v4l2-dv-timings: add module name, description, license.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dv-timings.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c index 41bf3f9..37ad777 100644 --- a/drivers/media/v4l2-core

[REVIEWv1 PATCH 2/5] v4l2: allow v4l2_subdev_edid to be used with video nodes

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Struct v4l2_subdev_edid and the VIDIOC_SUBDEV_G/S_EDID ioctls were specific for subdevices, but for hardware with a simple video pipeline you do not need/want to create subdevice nodes to just get/set the EDID. Move the v4l2_subdev_edid struct to v4l2-common.h and rename as v4

[REVIEWv1 PATCH 3/5] v4l2: add VIDIOC_G/S_EDID support to the v4l2 core.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Support this ioctl as part of the v4l2 core. Use the new ioctl name and struct v4l2_edid type in the existing core code. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 32 +-- drivers/media/v4l2-core/v4l2-dev.c

[REVIEWv1 PATCH 1/5] v4l2-compat-ioctl32: fix wrong VIDIOC_SUBDEV_G/S_EDID32 support.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil The wrong ioctl numbers were used due to a copy-and-paste error. Signed-off-by: Hans Verkuil Cc: sta...@vger.kernel.org # for v3.7 and up --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/me

[REVIEWv1 PATCH 4/5] adv*: replace the deprecated v4l2_subdev_edid by v4l2_edid.

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/i2c/ad9389b.c | 2 +- drivers/media/i2c/adv7511.c | 2 +- drivers/media/i2c/adv7604.c | 4 ++-- drivers/media/i2c/adv7842.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ad9389b.c b/dri

[REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

2014-03-07 Thread Hans Verkuil
From: Hans Verkuil Document that it is now possible to call G/S_EDID from video nodes, not just sub-device nodes. Add a note that -EINVAL will be returned if the pad does not support EDIDs. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/v4l2.xml | 2 +- .../DocBook

[REVIEWv1 PATCH 0/5] Add G/S_EDID support for video nodes

2014-03-07 Thread Hans Verkuil
Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev APIs. However, that's in reality quite annoying since for simple video pipelines there is no need to create v4l-subdev device nodes for anything else except for setting or getting EDIDs. What happens in practice is that v4

Re: [PATCH v6 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-03-07 Thread Sylwester Nawrocki
Hi Kukjin, On 06/03/14 17:20, Sylwester Nawrocki wrote: > This patch enables the rear facing camera (s5c73m3) on TRATS2 board > by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver > and the sensor's voltage regulator supply nodes. > > Signed-off-by: Andrzej Hajda > Acked-by: K

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Sylwester Nawrocki
Hi, On 07/03/14 09:31, Arun Kumar K wrote: > From: avnd kiran > > Latest MFC v6 firmware requires tile mode and loop filter > setting to be done as part of Init buffer command, in sync > with v7. So, move these settings out of decode options reg. > Also, make this register definition applicable

[PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
From: avnd kiran Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. So, move these settings out of decode options reg. Also, make this register definition applicable from v6 onwards. Signed-off-by: avnd kiran Signed-off-

[PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-07 Thread Arun Kumar K
From: Pawel Osciak Currently, for formats that are not H264, MFC driver will check the consumed stream size returned by the firmware and, based on that, will try to decide whether the bitstream buffer contained more than one frame. If the size of the buffer is larger than the consumed stream, it