Hello.

On 03/07/2014 04:01 PM, Ben Dooks wrote:

Add nodes for the four video input channels on the R8A7790.

Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>

This patch should have been preceded by the VIN driver patch and bindings description, don't you think?

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index a1e7c39..4c3eafb 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -395,6 +395,38 @@
                status = "disabled";
        };

+       vin0: vin@0xe6ef0000 {

   ePAPR standard [1] tells us that:

The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model.

So, I would suggest something like "video". And remove "0x" from the address part of the node name please.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to