Re: [RFC PATCH 1/3] s5p-g2d: fix compiler warning

2012-10-03 Thread Hans Verkuil
On Wed October 3 2012 12:16:48 Sylwester Nawrocki wrote: > On 10/02/2012 10:57 AM, Hans Verkuil wrote: > > drivers/media/platform/s5p-g2d/g2d.c:535:2: warning: passing argument 3 of > > 'vidioc_try_crop' discards 'const' qualifier from pointer target type > > [enabled by default] > > drivers/medi

[GIT PULL FOR v3.7] v4l2-ctrl feature enhancement

2012-10-03 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patches which adds a new feature and a new control to v4l2-ctrl framework. One of the patch includes usage of the new control in the driver. Thanks and Regards, --Prabhakar Lad The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e

Re: [PATCH v5] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-10-03 Thread Prabhakar Lad
Hi Laurent, On Wed, Oct 3, 2012 at 7:43 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Wednesday 03 October 2012 19:23:05 Prabhakar wrote: >> From: Lad, Prabhakar >> >> V4L2_CID_TEST_PATTERN is now a standard control. >> This patch replaces the user defined control for test >> pattern to mak

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Kay Sievers
On Thu, Oct 4, 2012 at 12:58 AM, Linus Torvalds wrote: > That said, there's clearly enough variation here that I think that for > now I won't take the step to disable the udev part. I'll do the patch > to support "direct filesystem firmware loading" using the udev default > paths, and that hopeful

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 6:33 PM, Ming Lei wrote: > > Yes, the patch will make firmware cache not working, I would like to fix > that when I return from one trip next week. > > BTW, firmware cache is still needed even direct loading is taken. I agree 100%, I'd have liked to do the caching for the d

Re: udev breakages -

2012-10-03 Thread Nix
On 3 Oct 2012, Al Viro spake thusly: > Looks sane. TBH, I'd still prefer to see udev forcibly taken over and put > into > usr/udev in kernel tree - I don't trust that crowd at all and the fewer > critical userland bits they can play leverage games with, the safer we are. > > Al, that -><- clos

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 3:48 PM, Andy Walls wrote: > > I don't know if you can remove the /sys/.../firmware ABI altogether, because > there is at least one, somewhat popular udev replacement that also uses it: > mdev > > http://git.busybox.net/busybox/plain/docs/mdev.txt Heh. That web doc docume

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Stephen Rothwell
Hi Linus, On Wed, 3 Oct 2012 13:39:23 -0700 Linus Torvalds wrote: > > Ok, I wish this had been getting more testing in Linux-next or > something If you ever want a patch tested for a few days, just send it to me and I will put it in my "fixes" tree which is merged into linux-next immediately on

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Andy Walls
Linus Torvalds wrote: >On Wed, Oct 3, 2012 at 12:50 PM, Greg KH >wrote: >>> >>> Ok, like this? >> >> This looks good to me. Having udev do firmware loading and tieing it >to >> the driver model may have not been such a good idea so many years >ago. >> Doing it this way makes more sense. > >Ok,

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 2:58 PM, Lucas De Marchi wrote: > > So maintaining the fallback or adding a configurable entry to set the > firmware paths might be good. Yeah, I do think we need to make it configurable. Probably both at kernel compile time and dynamically. The aim of having a user-mode d

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Lucas De Marchi
On Tue, Oct 2, 2012 at 7:37 PM, Linus Torvalds wrote: > On Tue, Oct 2, 2012 at 2:03 PM, Ivan Kalvachev wrote: >> >> I'm not kernel developer and probably my opinion would be a little >> naive, but here it is. >> >> Please, make the kernel load firmware from the filesystem on its own. > > We proba

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Lucas De Marchi
On Wed, Oct 3, 2012 at 5:39 PM, Linus Torvalds wrote: > On Wed, Oct 3, 2012 at 12:50 PM, Greg KH wrote: >>> >>> Ok, like this? >> >> This looks good to me. Having udev do firmware loading and tieing it to >> the driver model may have not been such a good idea so many years ago. >> Doing it this

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Alan Cox
On Wed, 3 Oct 2012 23:18:06 +0200 Kay Sievers wrote: > On Wed, Oct 3, 2012 at 11:05 PM, Greg KH wrote: > > > As for the firmware path, maybe we should > > change that to be modified by userspace (much like /sbin/hotplug was) in > > a proc file so that distros can override the location if they n

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Kay Sievers
On Wed, Oct 3, 2012 at 11:05 PM, Greg KH wrote: > As for the firmware path, maybe we should > change that to be modified by userspace (much like /sbin/hotplug was) in > a proc file so that distros can override the location if they need to. If that's needed, a CONFIG_FIRMWARE_PATH= with the array

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Andy Walls
Greg KH wrote: >On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote: >> On Wed, Oct 3, 2012 at 10:09 AM, Al Viro >wrote: >> > >> > + if (!S_ISREG(inode->i_mode)) >> > + return false; >> > + size = i_size_read(inode); >> > >> > Probably better to do vfs_getatt

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 01:39:23PM -0700, Linus Torvalds wrote: > On Wed, Oct 3, 2012 at 12:50 PM, Greg KH wrote: > >> > >> Ok, like this? > > > > This looks good to me. Having udev do firmware loading and tieing it to > > the driver model may have not been such a good idea so many years ago. > >

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Kay Sievers
On Wed, Oct 3, 2012 at 10:39 PM, Linus Torvalds wrote: > On Wed, Oct 3, 2012 at 12:50 PM, Greg KH wrote: >>> >>> Ok, like this? >> >> This looks good to me. Having udev do firmware loading and tieing it to >> the driver model may have not been such a good idea so many years ago. >> Doing it this

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-03 Thread Rob Herring
On 10/02/2012 09:33 AM, Guennadi Liakhovetski wrote: > Hi Rob > > On Tue, 2 Oct 2012, Rob Herring wrote: > >> On 09/27/2012 09:07 AM, Guennadi Liakhovetski wrote: >>> This patch adds a document, describing common V4L2 device tree bindings. >>> >>> Co-authored-by: Sylwester Nawrocki >>> Signed-of

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 12:50 PM, Greg KH wrote: >> >> Ok, like this? > > This looks good to me. Having udev do firmware loading and tieing it to > the driver model may have not been such a good idea so many years ago. > Doing it this way makes more sense. Ok, I wish this had been getting more te

Re: Access files from kernel

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 12:48 PM, Kirill A. Shutemov wrote: > > AFAIK, accessing files on filesystem form kernel directly was no-go for a > long time. What's the new rule here? Oh, we've *always* accessed files from the kernel. What we don't want is random drivers doing so directly and without a

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote: > On Wed, Oct 3, 2012 at 10:09 AM, Al Viro wrote: > > > > + if (!S_ISREG(inode->i_mode)) > > + return false; > > + size = i_size_read(inode); > > > > Probably better to do vfs_getattr() and check mode and siz

Access files from kernel

2012-10-03 Thread Kirill A. Shutemov
On Wed, Oct 03, 2012 at 09:38:52AM -0700, Linus Torvalds wrote: >+static bool fw_get_filesystem_firmware(struct firmware *fw, const char *name) >+{ >+ int i; >+ bool success = false; >+ const char *fw_path[] = { "/lib/firmware/update", "/firmware", >"/lib/firmware" }; >+ char *

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2012 13:57, Greg KH escreveu: > On Wed, Oct 03, 2012 at 04:36:53PM +0200, Kay Sievers wrote: >> On Wed, Oct 3, 2012 at 12:12 AM, Greg KH wrote: >> >>> Mauro, what version of udev are you using that is still showing this >>> issue? >>> >>> Kay, didn't you resolve this already? If not, wha

cron job: media_tree daily build: ERRORS

2012-10-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Oct 3 19:00:34 CEST 2012 git hash:2425bb3d4016ed95ce83a90b53bd92c7f31091e4 gcc version: i686-linux-gcc (GC

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Al Viro
On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote: > On Wed, Oct 3, 2012 at 10:09 AM, Al Viro wrote: > > > > + if (!S_ISREG(inode->i_mode)) > > + return false; > > + size = i_size_read(inode); > > > > Probably better to do vfs_getattr() and check mode and siz

Re: [PATCH] Add toggle to the tt3650_rc_query function of the ttusb2 driver

2012-10-03 Thread Hans Petter Selasky
On Wednesday 03 October 2012 20:57:07 Hans Petter Selasky wrote: > On Tuesday 02 October 2012 21:52:11 Hans Petter Selasky wrote: > > On Saturday 08 September 2012 19:08:22 Jose Alberto Reguero wrote: > > > This patch add the toggle bit to the tt3650_rc_query function of the > > > ttusb2 driver. >

Re: [PATCH] Add toggle to the tt3650_rc_query function of the ttusb2 driver

2012-10-03 Thread Hans Petter Selasky
On Tuesday 02 October 2012 21:52:11 Hans Petter Selasky wrote: > On Saturday 08 September 2012 19:08:22 Jose Alberto Reguero wrote: > > This patch add the toggle bit to the tt3650_rc_query function of the > > ttusb2 driver. > > > > Signed-off-by: Jose Alberto Reguero > > > > Jose Alberto > > Hi

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 10:24 AM, Kay Sievers wrote: > > Nothing really "breaks", It's "slow" and it will surely be fixed when > we know what's the right fix, which we haven't sorted out at this > moment. A thirty-second pause at bootup is easily long enough that some people might think the machin

[PATCH] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-03 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- lib/include/libv4lconvert.h | 20 ++-- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/lib/include/libv4lconvert.h b/lib/include/libv4lconvert.h index 167b57d..509655e 100644 --- a/lib/include/libv4lconvert.h +++ b/

Re: qv4l2-bug / libv4lconvert API issue

2012-10-03 Thread Frank Schäfer
Am 03.10.2012 15:32, schrieb Hans Verkuil: > On Wed 3 October 2012 12:22:48 Frank Schäfer wrote: >> Hi Hans, >> >> Am 30.09.2012 11:54, schrieb Hans de Goede: >>> Hi, >>> >>> On 09/28/2012 07:09 PM, Frank Schäfer wrote: Hi, Am 27.09.2012 21:41, schrieb Hans de Goede: > Hi, >

[GIT PULL FOR v3.7] V4L: s5p-fimc: support for interleaved image data capture

2012-10-03 Thread Sylwester Nawrocki
Hi Mauro, The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e4: em28xx: regression fix: use DRX-K sync firmware requests on em28xx (2012-10-02 17:15:22 -0300) are available in the git repository at: git://git.infradead.org/users/kmpark/linux-samsung v4l_for_mauro fo

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 10:09 AM, Al Viro wrote: > > + if (!S_ISREG(inode->i_mode)) > + return false; > + size = i_size_read(inode); > > Probably better to do vfs_getattr() and check mode and size in kstat; if > it's sufficiently hot for that to hurt, we are fucked anyway.

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Kay Sievers
On Wed, Oct 3, 2012 at 6:57 PM, Greg KH wrote: >> It's the same in the current release, we still haven't wrapped our >> head around how to fix it/work around it. > > Ick, as this is breaking people's previously-working machines, shouldn't > this be resolved quickly? Nothing really "breaks", It's

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Al Viro
On Wed, Oct 03, 2012 at 09:38:52AM -0700, Linus Torvalds wrote: > Yeah, that bugzilla shows the problem with Kay as a maintainer too, > not willing to own up to problems he caused. > > Can you actually see the problem? I did add the attached patch as an > attachment to the bugzilla, so the reporte

[PATCH v10 6/7] [media] s5p-mfc: MFCv6 register definitions

2012-10-03 Thread Arun Kumar K
From: Jeongtae Park Adds register definitions for MFC v6.x firmware Signed-off-by: Jeongtae Park Signed-off-by: Janghyuck Kim Signed-off-by: Jaeryul Oh Signed-off-by: Naveen Krishna Chatradhi Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h | 408 ++

[PATCH v10 5/7] [media] s5p-mfc: Add MFC variant data to device context

2012-10-03 Thread Arun Kumar K
MFC variant data replaces various macros used in the driver which will change in a different version of MFC hardware. Also does a cleanup of MFC context structure and common files. Signed-off-by: Jeongtae Park Signed-off-by: Janghyuck Kim Signed-off-by: Jaeryul Oh Signed-off-by: Naveen Krishna

[PATCH v10 2/7] [media] v4l: Add control definitions for new H264 encoder features

2012-10-03 Thread Arun Kumar K
New controls are added for supporting H264 encoding features like - MVC frame packing - Flexible macroblock ordering - Arbitrary slice ordering - Hierarchical coding Signed-off-by: Jeongtae Park Signed-off-by: Naveen Krishna Chatradhi Signed-off-by: Arun Kumar K --- Documentation/DocBook/media

[PATCH v10 1/7] [media] v4l: Add fourcc definitions for new formats

2012-10-03 Thread Arun Kumar K
Adds the following new fourcc definitions. For multiplanar YCbCr - V4L2_PIX_FMT_NV21M - V4L2_PIX_FMT_NV12MT_16X16 and compressed formats - V4L2_PIX_FMT_H264_MVC - V4L2_PIX_FMT_VP8 Signed-off-by: Jeongtae Park Signed-off-by: Naveen Krishna Chatradhi Signed-off-by:

[PATCH v10 0/7] Update MFC v4l2 driver to support MFC6.x

2012-10-03 Thread Arun Kumar K
The patchset adds support for MFCv6 firmware in s5p-mfc driver. The patches are rebased to the latest media-tree. Changelog v10 - Rebased onto latest media-tree 3.7 staging - Split driver rearchitecture patch into two Changelog v9 - Addressed review comments by Hans Verkuil http://www.mail-archiv

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 9:38 AM, Linus Torvalds wrote: > > Anyway. Attached is a really stupid patch that tries to do the "direct > firmware load" as suggested by Ivan. It has not been tested very > extensively at all (but I did test that it loaded the brcmsmac > firmware images on my laptop so it

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 04:36:53PM +0200, Kay Sievers wrote: > On Wed, Oct 3, 2012 at 12:12 AM, Greg KH wrote: > > > Mauro, what version of udev are you using that is still showing this > > issue? > > > > Kay, didn't you resolve this already? If not, what was the reason why? > > It's the same i

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 8:13 AM, Mauro Carvalho Chehab wrote: > > Yes. The issue was noticed with media drivers when people started using the > drivers on Fedora 17, witch came with udev-182. There's an open > bugzilla there: > https://bugzilla.redhat.com/show_bug.cgi?id=827538 Yeah, that

Re: [PATCH v5] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-10-03 Thread Sakari Ailus
Prabhakar wrote: From: Lad, Prabhakar V4L2_CID_TEST_PATTERN is now a standard control. This patch replaces the user defined control for test pattern to make use of standard control V4L2_CID_TEST_PATTERN. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Acked-by: Laurent Pinchart

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Mauro Carvalho Chehab
Em 02-10-2012 19:47, Linus Torvalds escreveu: > On Tue, Oct 2, 2012 at 3:23 PM, Greg KH wrote: >> >> which went into udev release 187 which I think corresponds to the place >> when people started having problems, right Mauro? > > According to what I've seen, people started complaining in 182, not

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Linus Torvalds
On Wed, Oct 3, 2012 at 7:36 AM, Kay Sievers wrote: > > If that unfortunate module_init() lockup can't be solved properly in > the kernel Stop this idiocy. The kernel doesn't have a lockup problem. udev does. As even you admit, it is *udev* that has the whole serialization issue, and does exces

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Kay Sievers
On Wed, Oct 3, 2012 at 12:12 AM, Greg KH wrote: > Mauro, what version of udev are you using that is still showing this > issue? > > Kay, didn't you resolve this already? If not, what was the reason why? It's the same in the current release, we still haven't wrapped our head around how to fix it

Re: [PATCH v5] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-10-03 Thread Laurent Pinchart
Hi Prabhakar, On Wednesday 03 October 2012 19:23:05 Prabhakar wrote: > From: Lad, Prabhakar > > V4L2_CID_TEST_PATTERN is now a standard control. > This patch replaces the user defined control for test > pattern to make use of standard control V4L2_CID_TEST_PATTERN. > > Signed-off-by: Lad, Prabh

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Mauro Carvalho Chehab
Em 02-10-2012 19:23, Greg KH escreveu: > On Tue, Oct 02, 2012 at 03:12:39PM -0700, Greg KH wrote: >> On Tue, Oct 02, 2012 at 09:33:03AM -0700, Linus Torvalds wrote: >>> I don't know where the problem started in udev, but the report I saw >>> was that udev175 was fine, and udev182 was broken, and wo

[PATCH v5] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-10-03 Thread Prabhakar
From: Lad, Prabhakar V4L2_CID_TEST_PATTERN is now a standard control. This patch replaces the user defined control for test pattern to make use of standard control V4L2_CID_TEST_PATTERN. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Acked-by: Laurent Pinchart Cc: Sakari Ailus

[PATCH] media: davinci: vpif: Add return code check at vb2_queue_init()

2012-10-03 Thread Prabhakar
From: Lad, Prabhakar from commit with id 896f38f582730a19eb49677105b4fe4c0270b82e it's mandatory to check the return code of vb2_queue_init(). Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Cc: Hans Verkuil --- drivers/media/platform/davinci/vpif_capture.c |8 ++-- driv

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 02:46 PM, Maarten Lankhorst wrote: Op 03-10-12 12:53, Thomas Hellstrom schreef: On 10/03/2012 10:53 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom wrote: So if I understand you correctly, the reservation changes in TTM are motivated by the fact that o

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Maarten Lankhorst
Op 03-10-12 12:53, Thomas Hellstrom schreef: > On 10/03/2012 10:53 AM, Daniel Vetter wrote: >> On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom >> wrote: > So if I understand you correctly, the reservation changes in TTM are > motivated by the > fact that otherwise, in the generic re

Re: [Linaro-mm-sig] [RFC] New dma_buf -> EGLImage EGL extension

2012-10-03 Thread Rob Clark
On Tue, Oct 2, 2012 at 2:10 PM, Maarten Lankhorst wrote: > How do you want to deal with the case where Y' and CbCr are different > hardware buffers? > Could some support for 2d arrays be added in case Y' and CbCr are separated > into top/bottom fields? > How are semi-planar/planar formats handle

Re: [PATCH 4/5] reservation: cross-device reservation support

2012-10-03 Thread Thomas Hellstrom
I took a quick look on the fencing and added some thoughts on shared fences: On 09/28/2012 02:43 PM, Maarten Lankhorst wrote: This adds support for a generic reservations framework that can be hooked up to ttm and dma-buf and allows easy sharing of reservations across devices. The idea is that

Re: qv4l2-bug / libv4lconvert API issue

2012-10-03 Thread Hans Verkuil
On Wed 3 October 2012 12:22:48 Frank Schäfer wrote: > Hi Hans, > > Am 30.09.2012 11:54, schrieb Hans de Goede: > > Hi, > > > > On 09/28/2012 07:09 PM, Frank Schäfer wrote: > >> Hi, > >> > >> Am 27.09.2012 21:41, schrieb Hans de Goede: > >>> Hi, > >>> > >>> On 09/27/2012 03:20 PM, Frank Schäfer wro

[GIT PULL] for 3.7 (technisat-usb2)

2012-10-03 Thread Patrick Boettcher
Hi Mauro, The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e4: em28xx: regression fix: use DRX-K sync firmware requests on em28xx are available in the git repository at: http://linuxtv.org/git/pb/media_tree.git staging/for_v3.7 for you to fetch changes up to e196a3

Re: ITE9135 on AMD SB700 - ehci_hcd bug

2012-10-03 Thread Antti Palosaari
On 10/03/2012 01:55 PM, Marx wrote: On 23.09.2012 18:22, Antti Palosaari wrote: On 09/16/2012 05:23 PM, Antti Palosaari wrote: On 09/12/2012 09:32 AM, Marx wrote: Hello I'm trying to use dual DVB-T tuner based on ITE9135 tuner. I use Debian kernel 3.5-trunk-686-pae. My motherboard is AsRock E3

Re: qv4l2-bug / libv4lconvert API issue

2012-10-03 Thread Frank Schäfer
Hi Hans, Am 30.09.2012 11:54, schrieb Hans de Goede: > Hi, > > On 09/28/2012 07:09 PM, Frank Schäfer wrote: >> Hi, >> >> Am 27.09.2012 21:41, schrieb Hans de Goede: >>> Hi, >>> >>> On 09/27/2012 03:20 PM, Frank Schäfer wrote: >>> >>> >>> > What you've found is a qv4l2 bug (do you have the lat

Re: ITE9135 on AMD SB700 - ehci_hcd bug

2012-10-03 Thread Marx
On 23.09.2012 18:22, Antti Palosaari wrote: On 09/16/2012 05:23 PM, Antti Palosaari wrote: On 09/12/2012 09:32 AM, Marx wrote: Hello I'm trying to use dual DVB-T tuner based on ITE9135 tuner. I use Debian kernel 3.5-trunk-686-pae. My motherboard is AsRock E350M1 (no USB3 ports). Tuner is detect

Re: [PATCH 1/2] of: add helper to parse display specs

2012-10-03 Thread Steffen Trumtrar
On Mon, Oct 01, 2012 at 10:53:08AM -0600, Stephen Warren wrote: > On 09/24/2012 09:35 AM, Steffen Trumtrar wrote: > > Parse a display-node with timings and hardware-specs from devictree. > > > diff --git a/Documentation/devicetree/bindings/video/display > > b/Documentation/devicetree/bindings/vid

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 10:53 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom wrote: So if I understand you correctly, the reservation changes in TTM are motivated by the fact that otherwise, in the generic reservation code, lockdep can only be annotated for a trylock and not a

Re: [PATCH] [media] s5p-jpeg: use clk_prepare_enable and clk_disable_unprepare

2012-10-03 Thread Sylwester Nawrocki
On 10/03/2012 01:55 AM, Thomas Abraham wrote: > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Thomas Abraham Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-media" i

Re: [RFC PATCH 2/3] s5p-fimc: fix compiler warning

2012-10-03 Thread Sylwester Nawrocki
On 10/02/2012 10:57 AM, Hans Verkuil wrote: > drivers/media/platform/s5p-fimc/fimc-m2m.c:561:2: warning: passing argument 2 > of 'fimc_m2m_try_crop' discards 'const' qualifier from pointer target type > [enabled by default] > drivers/media/platform/s5p-fimc/fimc-m2m.c:502:12: note: expected 'stru

Re: [RFC PATCH 1/3] s5p-g2d: fix compiler warning

2012-10-03 Thread Sylwester Nawrocki
On 10/02/2012 10:57 AM, Hans Verkuil wrote: > drivers/media/platform/s5p-g2d/g2d.c:535:2: warning: passing argument 3 of > 'vidioc_try_crop' discards 'const' qualifier from pointer target type > [enabled by default] > drivers/media/platform/s5p-g2d/g2d.c:510:12: note: expected 'struct v4l2_crop

[GIT PULL FOR v3.7] Davinci VPBE feature enhancement and fixes

2012-10-03 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patches for davinci VPBE driver. Some of the patches include platform changes for which Sekhar has Acked it. Thanks and Regards, --Prabhakar Lad The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e4: em28xx: regression fix: use

[GIT PULL FOR v3.7] small af9033 correction

2012-10-03 Thread Antti Palosaari
The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e4: em28xx: regression fix: use DRX-K sync firmware requests on em28xx (2012-10-02 17:15:22 -0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git for_v3.7_mauro-4 for you to fetch ch

Re: [GIT PULL FOR 3.7] Samsung Exynos MFC driver update

2012-10-03 Thread Sylwester Nawrocki
Hi Arun, On 10/03/2012 07:38 AM, Arun Kumar K wrote: >> Indeed it looks like big blob patch. I think this reflects how these patches >> were created, were one person creates practically new driver for new device >> revision, with not much care about the old one, and then somebody else is >> trying

Re: [PATCH] af9033: prevent unintended underflow

2012-10-03 Thread Antti Palosaari
On 10/03/2012 12:25 PM, Hans-Frieder Vogt wrote: As spotted by Dan Carpenter (thanks!), we have improperly used an unsigned variable in a calculation that may result in a negative number. This may cause an unintended underflow if the interface frequency of the tuner is > approx. 40MHz. This patc

[PATCH] af9033: prevent unintended underflow

2012-10-03 Thread Hans-Frieder Vogt
As spotted by Dan Carpenter (thanks!), we have improperly used an unsigned variable in a calculation that may result in a negative number. This may cause an unintended underflow if the interface frequency of the tuner is > approx. 40MHz. This patch should resolve the issue, following an approach s

Re: [PATCH] davinci: vpbe: replace V4L2_OUT_CAP_CUSTOM_TIMINGS with V4L2_OUT_CAP_DV_TIMINGS

2012-10-03 Thread Sekhar Nori
On 10/3/2012 12:02 PM, Prabhakar wrote: > From: Lad, Prabhakar > > This patch replaces V4L2_OUT_CAP_CUSTOM_TIMINGS macro with > V4L2_OUT_CAP_DV_TIMINGS. As V4L2_OUT_CAP_CUSTOM_TIMINGS is being phased > out. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Sekhar Nori >

Re: [RFCv2 PATCH 13/14] davinci: move struct vpif_interface to chan_cfg.

2012-10-03 Thread Sekhar Nori
On 9/20/2012 5:36 PM, Hans Verkuil wrote: > From: Hans Verkuil > > struct vpif_interface is channel specific, not subdev specific. > Move it to the channel config. > > Signed-off-by: Hans Verkuil For the DaVinci platform changes: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from t

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Daniel Vetter
On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom wrote: >>> So if I understand you correctly, the reservation changes in TTM are >>> motivated by the >>> fact that otherwise, in the generic reservation code, lockdep can only be >>> annotated for a trylock and not a waiting lock, when it *is* in f

Re: [RFCv2 PATCH 06/14] vpif_capture: move routing info from subdev to input.

2012-10-03 Thread Sekhar Nori
On 9/20/2012 5:36 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Routing information is a property of the input, not of the subdev. > One subdev may provide multiple inputs, each with its own routing > information. > > Signed-off-by: Hans Verkuil For the DaVinci platform change: Acked-by: S

Re: [RFCv2 PATCH 05/14] vpif_capture: remove unnecessary can_route flag.

2012-10-03 Thread Sekhar Nori
On 9/20/2012 5:36 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Calling a subdev op that isn't implemented will just return -ENOIOCTLCMD > No need to have a flag for that. > > Signed-off-by: Hans Verkuil For the DaVinci platform change: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscr

Re: [PATCH 1/2] drxk: allow loading firmware synchrousnously

2012-10-03 Thread Antti Palosaari
On 10/03/2012 10:13 AM, Oliver Endriss wrote: Mauro Carvalho Chehab wrote: Due to udev-182, the firmware load was changed to be async, as otherwise udev would give up of loading a firmware. Add an option to return to the previous behaviour, async firmware loads cause failures with the tda18271

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 09:54 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 9:45 AM, Thomas Hellstrom wrote: On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 09:57 AM, Maarten Lankhorst wrote: Hey, Op 03-10-12 09:45, Thomas Hellstrom schreef: On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I '

[GIT PULL FOR v3.7] Davinci VPFE bug fix

2012-10-03 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patch for VPFE, Which fixes build error for VPFE driver. Thanks and Regards, --Prabhakar Lad The following changes since commit 2425bb3d4016ed95ce83a90b53bd92c7f31091e4: em28xx: regression fix: use DRX-K sync firmware requests on em28xx (2012-10-02

[PATCH RFC v3] dvb: LNA implementation changes

2012-10-03 Thread Antti Palosaari
* use dvb property cache * implement get (thus API minor++) * PCTV 290e: 1=LNA ON, all the other values LNA OFF Also fix PCTV 290e LNA comment, it is disabled by default Hans and Mauro proposed use of cache implementation of get as they were planning to extend LNA usage for analog side too. Rep

Re: [PATCH RFC v2] dvb: LNA implementation changes

2012-10-03 Thread Antti Palosaari
On 10/03/2012 09:21 AM, Hans Verkuil wrote: On Wed October 3 2012 01:49:47 Antti Palosaari wrote: * use dvb property cache * implement get (thus API minor++) * PCTV 290e: 1=LNA ON, all the other values LNA OFF Also fix PCTV 290e LNA comment, it is disabled by default Hans and Mauro proposed

RE: Previewing PAL fields on framebuffer

2012-10-03 Thread Guennadi Liakhovetski
Please, don't drop the mailing list from the CC list. On Wed, 3 Oct 2012, Alex Pollard wrote: > Thanks! > > I have found that in their demo application the capture board developer > (e-consystems) supports various interlacing options thru ioctl calls. So > I think I will find a solution. Isn'

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Maarten Lankhorst
Hey, Op 03-10-12 09:45, Thomas Hellstrom schreef: > On 10/02/2012 10:03 AM, Daniel Vetter wrote: >> On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: >>> On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I 'released' lru_lock to lockdep before >>>

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Daniel Vetter
On Wed, Oct 3, 2012 at 9:45 AM, Thomas Hellstrom wrote: > On 10/02/2012 10:03 AM, Daniel Vetter wrote: >> >> On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: >>> >>> On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I 'released' lru_lock to l

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I 'released' lru_lock to lockdep before doing the annotation for a blocking acquire, and left trylock an

Re: [PATCH 1/2] drxk: allow loading firmware synchrousnously

2012-10-03 Thread Oliver Endriss
Mauro Carvalho Chehab wrote: > Due to udev-182, the firmware load was changed to be async, as > otherwise udev would give up of loading a firmware. > > Add an option to return to the previous behaviour, async firmware > loads cause failures with the tda18271 driver. > > Signed-off-by: Mauro Carv

Re: Previewing PAL fields on framebuffer

2012-10-03 Thread Guennadi Liakhovetski
Hi Alex (added linux-media to CC on your request) On Wed, 3 Oct 2012, Alex Pollard wrote: > Hi, > > I am wondering if it is possible to use the DMA features in > drivers/dma/ipu/ipu_idmac.c to write the top field of a PAL frame into a > framebuffer on alternating lines, and write the bottom f