Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Hans Verkuil
On Thu July 26 2012 21:13:08 Gregor Jasny wrote: > On 7/25/12 7:44 PM, Konke Radlow wrote: > > > +static void print_rds_af(struct v4l2_rds_af_set *af_set) > > +{ > > + int counter = 0; > > + > > + printf("\nAnnounced AFs: %u", af_set->announced_af); > > + for (int i = 0; i < af_set->size &&

RE: [PATCH] [media] davinci: vpfe: Add documentation

2012-07-26 Thread Hadli, Manjunath
Laurent, Thank you for your comments. On Thu, Jul 26, 2012 at 05:55:31, Laurent Pinchart wrote: > Hi Manjunath, > > On Tuesday 17 July 2012 10:43:54 Hadli, Manjunath wrote: > > On Sun, Jul 15, 2012 at 18:16:25, Laurent Pinchart wrote: > > > On Wednesday 11 July 2012 21:09:26 Manjunath Hadli wrot

Re: [PATCH] pvrusb2: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Mike Isely
Acked-By: Mike Isely -Mike On Thu, 26 Jul 2012, Tim Gardner wrote: > Cc: Mike Isely > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/pvrusb2/pvrusb2-devattr.c | 17 - > 1 file changed, 12 insertions(

Re: [RFC] omap3-isp G_FMT & ENUM_FMT

2012-07-26 Thread Laurent Pinchart
Hi Michael, On Thursday 26 July 2012 16:22:17 Michael Jones wrote: > On 07/26/2012 04:05 PM, Laurent Pinchart wrote: > > On Thursday 26 July 2012 13:59:54 Michael Jones wrote: > >> Hello, > >> > >> I would like to (re)submit a couple of patches to support V4L2 behavior > >> at the V4L2 device nod

Re: [PATCH v2] mt9v032: Export horizontal and vertical blanking as V4L2 controls

2012-07-26 Thread Laurent Pinchart
Hi Sakari, On Thursday 26 July 2012 23:54:01 Sakari Ailus wrote: > On Tue, Jul 24, 2012 at 01:10:42AM +0200, Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > --- > > > > drivers/media/video/mt9v032.c | 36 +--- > > 1 files changed, 33 insertions(

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Thursday 26 July 2012 22:39:31 Sylwester Nawrocki wrote: > On 07/26/2012 05:21 PM, Laurent Pinchart wrote: > > On Friday 25 May 2012 21:52:48 Sylwester Nawrocki wrote: > >> The driver initializes all board related properties except the s_power() > >> callback to board code. The pl

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Thursday 26 July 2012 21:51:30 Sylwester Nawrocki wrote: > On 07/26/2012 04:38 PM, Laurent Pinchart wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/mipi.txt > @@ -0,0 +1,5 @@ > +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and >

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/ivtv/ivtv-firmware.c |4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 11:21 -0600, Tim Gardner wrote: > Missed a firmware file in cx18-av-firmware.c > > rtg Please send patches in-line vs. an attachment. This is still missing the firmware file in cx18-dvb.c. Regards, Andy > From 9b4be013f173efc12bb2776394bf6a5abb8725b6 Mon Sep 17 00:00:00 2

Re: [PATCH] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 11:05 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner You missed v4l-cx23418-dig.fw, in cx18-av-firmware.c, which is required by all CX23418 devices. You

Re: [PATCH] cx25840: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote: > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/cx25840/cx25840-firmware.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/dri

Re: [PATCH 0/4] Aptinate sensors patches

2012-07-26 Thread Sakari Ailus
On Mon, Jul 23, 2012 at 08:34:58PM +0200, Laurent Pinchart wrote: > Hi everybody, > > Here are three fixes/patches for the MT9P031 and MT9V032 sensor drivers. The > second patch (mt9v032 pixel rate control) requires a control framework > modification (1/4) that has already been reviewed. > > Saka

Re: [PATCH v2] mt9v032: Export horizontal and vertical blanking as V4L2 controls

2012-07-26 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. On Tue, Jul 24, 2012 at 01:10:42AM +0200, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart > --- > drivers/media/video/mt9v032.c | 36 +--- > 1 files changed, 33 insertions(+), 3 deletions(-) > > Changes since v1: >

Re: Advice on extending libv4l for media controller support

2012-07-26 Thread Robert Abel
Hi, Sorry to be late to the party... I wanted to follow up on this discussion, but forgot and haven't read anything about it since... On 10.05.2012 17:09, Ivan T. Ivanov wrote: > On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre > wrote: >> I want to create some sort of plugin with specific media >

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/26/2012 05:21 PM, Laurent Pinchart wrote: > On Friday 25 May 2012 21:52:48 Sylwester Nawrocki wrote: >> The driver initializes all board related properties except the s_power() >> callback to board code. The platforms that require this callback are not >> supported by this driver

[PATCH] v4l-dev.c: Use 'ret' variable to return release() exit code

2012-07-26 Thread Ezequiel Garcia
Commit 65d9ff9c85d3c2e06d22aed78efee8404563eff6: "V4L/DVB (11390): 2-dev.c: return 0 for NULL open and release callbacks", introduced this bug. The bug this patch fixes is almost innocuous because nobody really cares about release() exit code. Signed-off-by: Ezequiel Garcia --- drivers/media/vi

Re: [RFC/PATCH 01/13] ARM: Samsung: Extend MIPI PHY callback with an index argument

2012-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/26/2012 04:42 PM, Laurent Pinchart wrote: Hi Sylwester, On Friday 25 May 2012 21:52:40 Sylwester Nawrocki wrote: For systems instantiated from device tree struct platform_device id field is always -1, add an 'id' argument to the s5p_csis_phy_enable() function so the MIPI-CSIS

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/mipi.txt @@ -0,0 +1,5 @@ +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and transmitters + + - data-lanes : number of differential data lan

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Konke Radlow
1. > +#ifdef HAVE_SYS_KLOG_H > +#include > +#endif I'll drop those lines 2. > + case OptSetDevice: > + strncpy(params.fd_name, optarg, 80); > + if (optarg[0] >= '0' && optarg[0] <= '9' && optarg[1] > == 0) { I didn't know about the isalpha fu

cron job: media_tree daily build: ERRORS

2012-07-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Jul 26 19:00:18 CEST 2012 git hash:931efdf58bd83af8d0578a6cc53421675daf6d41 gcc version: i686-linux-gcc (GC

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > +static void print_rds_af(struct v4l2_rds_af_set *af_set) > +{ > + int counter = 0; > + > + printf("\nAnnounced AFs: %u", af_set->announced_af); > + for (int i = 0; i < af_set->size && i < af_set->announced_af; i++, > counter++) { > +

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > --- /dev/null > +++ b/utils/rds-ctl/rds-ctl.cpp > @@ -0,0 +1,978 @@ > +/* > + * rds-ctl.cpp is based on v4l2-ctl.cpp > + * > + * the following applies for all RDS related parts: > + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights >

[PATCH] pvrusb2: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Mike Isely Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/pvrusb2/pvrusb2-devattr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.c b/drivers

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > --- /dev/null > +++ b/lib/libv4l2rds/Makefile.am > @@ -0,0 +1,11 @@ > +if WITH_LIBV4L > +lib_LTLIBRARIES = libv4l2rds.la > +include_HEADERS = ../include/libv4l2rds.h > +pkgconfig_DATA = libv4l2rds.pc > +else > +noinst_LTLIBRARIES = libv4l2rds.la > +endif >

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > diff --git a/configure.ac b/configure.ac > index 8ddcc9d..1d7eb29 100644 > --- a/configure.ac > +++ b/configure.ac ... > @@ -146,13 +148,17 @@ AC_ARG_WITH(libv4l2subdir, > AS_HELP_STRING(--with-libv4l2subdir=DIR,set libv4l2 l > AC_ARG_WITH(libv4lconvertsu

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-26 Thread Gregor Jasny
Hello Konke, On 7/25/12 7:43 PM, Konke Radlow wrote: > The latest version of the code can always be found in my github repository: > https://github.com/koradlow/v4l2-rds-ctl In the github dir is a lib/include/libv4l2rd.h file. I cannot find it in the patchset. It also looks like you're bases on a

[PATCH] Add support for Prof Revolution DVB-S2 8000 PCI-E card

2012-07-26 Thread Mariusz Bialonczyk
The device is based on STV0903 demodulator, STB6100 tuner and CX23885 chipset; subsystem id: 8000:3034 Signed-off-by: Mariusz Bialonczyk --- drivers/media/video/cx23885/Kconfig |1 + drivers/media/video/cx23885/cx23885-cards.c | 10 + drivers/media/video/cx23885/cx23885-dvb.c

[PATCH] cx23885: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Mauro Carvalho Chehab Cc: Steven Toth Cc: Hans Verkuil Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/cx23885/cx23885-417.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/

[PATCH] cx231xx: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/cx231xx/cx231xx-417.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/cx231xx/cx231xx-417.c b/drivers/media/video/cx231xx/cx231xx-417.c ind

[PATCH] ivtv: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Andy Walls Cc: Mauro Carvalho Chehab Cc: ivtv-de...@ivtvdriver.org Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/vid

Re: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Missed a firmware file in cx18-av-firmware.c rtg -- Tim Gardner tim.gard...@canonical.com >From 9b4be013f173efc12bb2776394bf6a5abb8725b6 Mon Sep 17 00:00:00 2001 From: Tim Gardner Date: Thu, 26 Jul 2012 11:03:51 -0600 Subject: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage Cc: Andy Walls Cc: M

Re: cx231xx interlace-like artifacts

2012-07-26 Thread Devin Heitmueller
On Wed, Jul 25, 2012 at 8:51 PM, Yan Seiner wrote: > Yan Seiner wrote: >> >> I just recently changed my vidcap to a Hauppage . Now I get these >> interlace-like artifacts: >> >> >> http://seiner.com/cz/rtpictures/2012_07_25T14h20m46sZ_0.451651_44.090619_-123.126059.jpg >> >> http://seiner.com/cz/

[PATCH] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Andy Walls Cc: Mauro Carvalho Chehab Cc: ivtv-de...@ivtvdriver.org Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/cx18/cx18-driver.c |1 + drivers/media/video/cx18/cx18-firmware.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-)

[PATCH] cx25840: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Tim Gardner
Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/cx25840/cx25840-firmware.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-firmware.c b/drivers/media/video/cx2

Re: [PATCH] omap3isp: #include videodev2.h in omap3isp.h

2012-07-26 Thread Laurent Pinchart
Hi Michael, On Thursday 26 July 2012 17:31:51 Michael Jones wrote: > include/linux/omap3isp.h uses BASE_VIDIOC_PRIVATE from > include/linux/videodev2.h but didn't include this file. > > Signed-off-by: Michael Jones Acked-by: Laurent Pinchart I've added the patch to my tree. > --- > include/

[PATCH] omap3isp: #include videodev2.h in omap3isp.h

2012-07-26 Thread Michael Jones
include/linux/omap3isp.h uses BASE_VIDIOC_PRIVATE from include/linux/videodev2.h but didn't include this file. Signed-off-by: Michael Jones --- include/linux/omap3isp.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/omap3isp.h b/include/linux/omap3isp.h in

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Friday 25 May 2012 21:52:48 Sylwester Nawrocki wrote: > The driver initializes all board related properties except the s_power() > callback to board code. The platforms that require this callback are not > supported by this driver yet for CONFIG_OF=y. > > Signed-off-by: Sylwester

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Wednesday 18 July 2012 11:18:33 Sylwester Nawrocki wrote: > On 07/16/2012 11:42 AM, Guennadi Liakhovetski wrote: > > On Fri, 25 May 2012, Sylwester Nawrocki wrote: > >> The driver initializes all board related properties except the s_power() > >> callback to board code. The platfo

Re: [PATCH] mceusb: Add Twisted Melon USB IDs

2012-07-26 Thread Mark Lord
On 12-07-11 06:53 PM, Mark Lord wrote: > Add USB identifiers for MCE compatible I/R transceivers from Twisted Melon. > > Signed-off-by: Mark Lord > --- > Mauro, please queue this up for inclusion in linux-3.6. > Patch is also attached to bypass emailer mangling. > Thanks. > > --- linux-3.5-rc6/d

Re: [RFC/PATCH 05/13] media: s5p-fimc: Add device tree support for FIMC devices

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Wednesday 18 July 2012 21:53:34 Sylwester Nawrocki wrote: > On 07/18/2012 10:17 AM, Guennadi Liakhovetski wrote: > > On Tue, 17 Jul 2012, Sylwester Nawrocki wrote: > >> On 07/16/2012 11:13 AM, Guennadi Liakhovetski wrote: > >>> On Fri, 25 May 2012, Sylwester Nawrocki wrote: >

Re: [PATCH] v4l2: typos

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 16:48:25 Michael Jones wrote: > > Signed-off-by: Michael Jones Acked-by: Hans Verkuil Yup, all typos :-) Thanks, Hans > --- > Documentation/video4linux/v4l2-framework.txt |2 +- > drivers/media/video/omap3isp/ispqueue.c |2 +- > drivers/media/video/

[PATCH] v4l2: typos

2012-07-26 Thread Michael Jones
Signed-off-by: Michael Jones --- Documentation/video4linux/v4l2-framework.txt |2 +- drivers/media/video/omap3isp/ispqueue.c |2 +- drivers/media/video/omap3isp/ispresizer.c|6 +++--- drivers/media/video/v4l2-common.c|2 +- include/media/v4l2-common.h

Re: [RFC/PATCH 01/13] ARM: Samsung: Extend MIPI PHY callback with an index argument

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Friday 25 May 2012 21:52:40 Sylwester Nawrocki wrote: > For systems instantiated from device tree struct platform_device id > field is always -1, add an 'id' argument to the s5p_csis_phy_enable() > function so the MIPI-CSIS hardware instance index can be passed in > by driver, for

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Ezequiel Garcia
On Thu, Jul 26, 2012 at 11:39 AM, Hans Verkuil wrote: > On Thu 26 July 2012 16:28:20 Ezequiel Garcia wrote: >> Hi Konke, >> >> > + >> > +libv4l2rds_la_SOURCES = libv4l2rds.c >> > +libv4l2rds_la_CPPFLAGS = -fvisibility=hidden $(ENFORCE_LIBV4L_STATIC) >> > -std=c99 >> > +libv4l2rds_la_LDFLAGS = -ve

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 16:28:20 Ezequiel Garcia wrote: > Hi Konke, > > > + > > +libv4l2rds_la_SOURCES = libv4l2rds.c > > +libv4l2rds_la_CPPFLAGS = -fvisibility=hidden $(ENFORCE_LIBV4L_STATIC) > > -std=c99 > > +libv4l2rds_la_LDFLAGS = -version-info 0 -lpthread $(DLOPEN_LIBS) > > $(ENFORCE_LIBV4L_STA

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 17 July 2012 20:16:23 Sylwester Nawrocki wrote: > On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: > > Hi Sylwester > > > > Thanks for your comments to my RFC and for pointing out to this your > > earlier patch series. Unfortunately, I missed in in May, let me try to

Re: [PATCH v3 3/5] media: gscaler: Add core functionality for the G-Scaler driver

2012-07-26 Thread Sylwester Nawrocki
Hi Shaik, Thank you for addressing my comments. On 07/25/2012 02:26 PM, Shaik Ameer Basha wrote: > +static int gsc_probe(struct platform_device *pdev) > +{ > + struct gsc_dev *gsc; > + struct resource *res; > + struct gsc_driverdata *drv_data = gsc_get_drv_data(pdev); > + struct d

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Ezequiel Garcia
Hi Konke, > + > +libv4l2rds_la_SOURCES = libv4l2rds.c > +libv4l2rds_la_CPPFLAGS = -fvisibility=hidden $(ENFORCE_LIBV4L_STATIC) > -std=c99 > +libv4l2rds_la_LDFLAGS = -version-info 0 -lpthread $(DLOPEN_LIBS) > $(ENFORCE_LIBV4L_STATIC) > diff --git a/lib/libv4l2rds/libv4l2rds.c b/lib/libv4l2rds/lib

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Konke Radlow
PATCH 1/2 was missing the public header for the rds library. I'm sorry for that mistake: diff --git a/lib/include/libv4l2rds.h b/lib/include/libv4l2rds.h new file mode 100644 index 000..04843d3 --- /dev/null +++ b/lib/include/libv4l2rds.h @@ -0,0 +1,203 @@ +/* + * Copyright 2012 Cisco Systems

Re: [RFC] omap3-isp G_FMT & ENUM_FMT

2012-07-26 Thread Michael Jones
Hi Laurent, Thanks for the reply. On 07/26/2012 04:05 PM, Laurent Pinchart wrote: Hi Michael, On Thursday 26 July 2012 13:59:54 Michael Jones wrote: Hello, I would like to (re)submit a couple of patches to support V4L2 behavior at the V4L2 device nodes of the omap3-isp driver, but I'm guessi

Re: [RFC] omap3-isp G_FMT & ENUM_FMT

2012-07-26 Thread Laurent Pinchart
Hi Michael, On Thursday 26 July 2012 13:59:54 Michael Jones wrote: > Hello, > > I would like to (re)submit a couple of patches to support V4L2 behavior at > the V4L2 device nodes of the omap3-isp driver, but I'm guessing they require > some discussion first. Indeed. The main reason why the OMAP

Re: [PATCH] mt9v032: Provide link frequency control

2012-07-26 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Thursday 26 July 2012 15:16:04 Hans Verkuil wrote: > On Thu 26 July 2012 14:56:56 Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > --- > > > > drivers/media/video/mt9v032.c | 48 > > include/media/mt9v032.

Re: [PATCH] mt9v032: Provide link frequency control

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 14:56:56 Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart > --- > drivers/media/video/mt9v032.c | 48 > include/media/mt9v032.h |3 ++ > 2 files changed, 46 insertions(+), 5 deletions(-) > > diff --git a/drivers/me

[PATCH] mt9v032: Provide link frequency control

2012-07-26 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- drivers/media/video/mt9v032.c | 48 include/media/mt9v032.h |3 ++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/mt9v032.c b/drivers/media/video/mt9v032.c index 2203a6f..

Re: tda18271 driver power consumption

2012-07-26 Thread Michael Krufky
On Wed, Jul 25, 2012 at 11:18 PM, Michael Krufky wrote: > On Tue, Jul 24, 2012 at 8:43 PM, Antti Palosaari wrote: >> On 07/25/2012 03:15 AM, Michael Krufky wrote: >>> >>> On Tue, Jul 24, 2012 at 6:17 PM, Michael Krufky >>> wrote: On Tue, Jul 24, 2012 at 6:12 PM, Antti Palosaari wrote:

Re: [Workshop-2011] Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-26 Thread Laurent Pinchart
Hi Rémi, On Thursday 26 July 2012 14:05:51 Rémi Denis-Courmont wrote: > On Thu, 26 Jul 2012 11:42:15 +0200, Hans Verkuil wrote: > >> > It's timed with the kernel summit and it will be on Tuesday. So you > >> > > >> > should have ample time. > >> > >> Oh? Is this firm yet? There's some pressure t

Re: [Workshop-2011] Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 14:05:51 Rémi Denis-Courmont wrote: > On Thu, 26 Jul 2012 11:42:15 +0200, Hans Verkuil > wrote: > >> > It's timed with the kernel summit and it will be on Tuesday. So you > >> > should have ample time. > >> > >> Oh? Is this firm yet? There's some pressure to book flights early

Re: [RFC] omap3-isp G_FMT & ENUM_FMT

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 13:59:54 Michael Jones wrote: > Hello, > > I would like to (re)submit a couple of patches to support V4L2 behavior at the > V4L2 device nodes of the omap3-isp driver, but I'm guessing they require some > discussion first. > > I've previously submitted one of them here [1] to s

Re: [PATCH for v3.6] v4l2-dev.c: Move video_put() after debug printk

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 13:59:04 Ezequiel Garcia wrote: > It is possible that video_put() releases video_device struct, > provoking a panic when debug printk wants to get video_device node name. > > Signed-off-by: Ezequiel Garcia Acked-by: Hans Verkuil Good catch! Regards, Hans > --- >

Re: [Workshop-2011] Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-26 Thread Rémi Denis-Courmont
On Thu, 26 Jul 2012 11:42:15 +0200, Hans Verkuil wrote: >> > It's timed with the kernel summit and it will be on Tuesday. So you >> > should have ample time. >> >> Oh? Is this firm yet? There's some pressure to book flights early here... > > Yes, that's firm. Sorry again... Does that

[PATCH for v3.6] v4l2-dev.c: Move video_put() after debug printk

2012-07-26 Thread Ezequiel Garcia
It is possible that video_put() releases video_device struct, provoking a panic when debug printk wants to get video_device node name. Signed-off-by: Ezequiel Garcia --- drivers/media/video/v4l2-dev.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/med

[PATCH 2/2] [media] omap3isp: support G_FMT

2012-07-26 Thread Michael Jones
This allows a V4L2 application which has no knowledge of the media controller to open a video device node of the already-configured ISP and query what it will deliver. Previously, G_FMT only worked after a S_FMT had already been done. Signed-off-by: Michael Jones --- drivers/media/video/omap3isp

[PATCH 1/2] [media] omap3isp: implement ENUM_FMT

2012-07-26 Thread Michael Jones
ENUM_FMT will not enumerate all formats that the ISP is capable of, it will only return the format which has been previously configured using the media controller, because this is the only format available to a V4L2 application which is unaware of the media controller. Signed-off-by: Michael Jones

[RFC] omap3-isp G_FMT & ENUM_FMT

2012-07-26 Thread Michael Jones
Hello, I would like to (re)submit a couple of patches to support V4L2 behavior at the V4L2 device nodes of the omap3-isp driver, but I'm guessing they require some discussion first. I've previously submitted one of them here [1] to support ENUM_FMT for the omap3-isp. This sparked some discussion,

[PATCH 3/4] Schedule removal of i.MX25 support in mx2_camera.c

2012-07-26 Thread Javier Martin
Support for i.MX25 in mx2_camera.c has been broken for a year. Furthermore, i.MX25 video capture HW doesn't have much in common with i.MX27. A separate driver would be desirable. Signed-off-by: Javier Martin --- Documentation/feature-removal-schedule.txt |9 + 1 file changed, 9 inser

[PATCH 4/4] media: mx2_camera: Fix clock handling for i.MX27.

2012-07-26 Thread Javier Martin
This driver wasn't converted to the new clock framework (e038ed50a4a767add205094c035b6943e7b30140). Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 67 ++ 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/drivers/media/video

[PATCH 2/4] media: mx2_camera: Mark i.MX25 support as BROKEN.

2012-07-26 Thread Javier Martin
i.MX25 support is known to have been broken for almost a year. Signed-off-by: Javier Martin --- drivers/media/video/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index c0b9233..af9d2d0 100644 --- a/drivers

[PATCH 1/4] i.MX27: Fix emma-prp and csi clocks.

2012-07-26 Thread Javier Martin
Naming of emma-prp related clocks for the i.MX27 is not correct. Signed-off-by: Javier Martin --- arch/arm/mach-imx/clk-imx27.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/clk-imx27.c b/arch/arm/mach-imx/clk-imx27.c index b1d343c..6e9cb02 1006

[PATCH 0/4] Fix clocks for i.MX27 in mx2_camera.c

2012-07-26 Thread Javier Martin
The following series follows the steps purposed by Guennadi (http://www.spinics.net/lists/arm-kernel/msg18.html) in order to fix clock handlings for i.MX27 in mx2_camera.c [PATCH 1/4] i.MX27: Fix emma-prp and csi clocks. [PATCH 2/4] media: mx2_camera: Mark i.MX25 support as BROKEN. [PATCH 3/4]

Re: [PATCH v2 4/4] fbdev: sh_mobile_lcdc: use dma_mmap_coherent if available

2012-07-26 Thread Laurent Pinchart
Hi Eiraku-san, On Thursday 26 July 2012 20:13:11 Hideki EIRAKU wrote: > fb_mmap() implemented in fbmem.c uses smem_start as the physical > address of the frame buffer. In the sh_mobile_lcdc driver, the > smem_start is a dma_addr_t that is not a physical address when IOMMU is > enabled. dma_mmap_

[PATCH v2 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available

2012-07-26 Thread Hideki EIRAKU
Previously the vb2_dma_contig_mmap() function was using a dma_addr_t as a physical address. The two addressses are not necessarily the same. For example, when using the IOMMU funtion on certain platforms, dma_addr_t addresses are not directly mappable physical address. dma_mmap_coherent() maps the

[PATCH v2 4/4] fbdev: sh_mobile_lcdc: use dma_mmap_coherent if available

2012-07-26 Thread Hideki EIRAKU
fb_mmap() implemented in fbmem.c uses smem_start as the physical address of the frame buffer. In the sh_mobile_lcdc driver, the smem_start is a dma_addr_t that is not a physical address when IOMMU is enabled. dma_mmap_coherent() maps the address correctly. It is available on ARM platforms. Sign

[PATCH v2 2/4] ALSA: pcm - Don't define ARCH_HAS_DMA_MMAP_COHERENT privately for ARM

2012-07-26 Thread Hideki EIRAKU
From: Laurent Pinchart The ARM architecture now defines ARCH_HAS_DMA_MMAP_COHERENT, there's no need to define it privately anymore. Signed-off-by: Laurent Pinchart --- sound/core/pcm_native.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/sound/core/pcm_native.c

[PATCH v2 1/4] ARM: dma-mapping: define ARCH_HAS_DMA_MMAP_COHERENT

2012-07-26 Thread Hideki EIRAKU
ARCH_HAS_DMA_MMAP_COHERENT indicates that there is dma_mmap_coherent() API in this architecture. The name is already defined in PowerPC. Signed-off-by: Hideki EIRAKU --- arch/arm/include/asm/dma-mapping.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/

[PATCH v2 0/4] Use dma_mmap_coherent to support IOMMU mapper

2012-07-26 Thread Hideki EIRAKU
There is a dma_mmap_coherent() API in some architectures. This API provides a mmap function for memory allocated by dma_alloc_coherent(). Some drivers mmap a dma_addr_t returned by dma_alloc_coherent() as a physical address. But such drivers do not work correctly when IOMMU mapper is used. v2: -

Re: [Workshop-2011] Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-26 Thread Hans Verkuil
On Thu 26 July 2012 11:32:56 Rémi Denis-Courmont wrote: > On Wed, 25 Jul 2012 08:21:05 +0200, Hans Verkuil > wrote: > > On Tue July 24 2012 22:37:35 Rémi Denis-Courmont wrote: > >> Le mardi 24 juillet 2012 23:31:42 Andy Walls, vous avez écrit : > >> > >I would strongly be in favor of this. One th

"[PULL] video_visstrim for 3.6"

2012-07-26 Thread Javier Martin
Hi Mauro, this pull request is composed of two series that provide support for two mem2mem devices: - 'm2m-deinterlace' video deinterlacer - 'coda video codec' I've included platform support for them too. The following changes since commit 6887a4131da3adaab011613776d865f4bcfb5678: Linux 3.5-r

Re: [Workshop-2011] Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-26 Thread Rémi Denis-Courmont
On Wed, 25 Jul 2012 08:21:05 +0200, Hans Verkuil wrote: > On Tue July 24 2012 22:37:35 Rémi Denis-Courmont wrote: >> Le mardi 24 juillet 2012 23:31:42 Andy Walls, vous avez écrit : >> > >I would strongly be in favor of this. One thing that we get far to >> > >little of is feedback from actua