Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-27 Thread Hans Verkuil
On Thursday, July 28, 2011 06:11:38 Pawel Osciak wrote: > Hi Guennadi, > > On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski > wrote: > > A possibility to preallocate and initialise buffers of different sizes > > in V4L2 is required for an efficient implementation of asnapshot mode. > > This p

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-27 Thread Pawel Osciak
Hi Guennadi, On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski wrote: > A possibility to preallocate and initialise buffers of different sizes > in V4L2 is required for an efficient implementation of asnapshot mode. > This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and > VIDIOC_PREPARE_BU

Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-27 Thread Mauro Carvalho Chehab
Hi Sylwester, Em 27-07-2011 13:35, Sylwester Nawrocki escreveu: > Hi Mauro, > > The following changes since commit f0a21151140da01c71de636f482f2eddec2840cc: > > Merge tag 'v3.0' into staging/for_v3.1 (2011-07-22 13:33:14 -0300) > > are available in the git repository at: > > git://git.infr

Re: Parallel CMOS Image Sensor with UART Control Interface

2011-07-27 Thread James
Hi Guennadi, >> We both have sensor that output CMOS H/V image and only have >> UART/RS232 for control of the sensor operations via sending/reading >> packet of bytes. i.e. AGC, contrast, brightness etc.. >> >> Since the thread ended on 29-Jun, is there anymore update or information? > > Probably

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Sakari Ailus
On Wed, Jul 27, 2011 at 07:51:36PM +0200, Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, > On Wednesday 27 July 2011 12:13:05 Sakari Ailus wrote: > > Hi Laurent, > > > > Thanks for the patch. I have a few comments below. > > Thanks for the review. Please see my answers to your comments below.

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/28/2011 01:07 AM, Malcolm Priestley wrote: On Wed, 2011-07-27 at 16:06 -0300, Mauro Carvalho Chehab wrote: Em 25-07-2011 21:17, Antti Palosaari escreveu: Signed-off-by: Antti Palosaari +adap->fe[i] = NULL; +/* In error case, do not try register more FEs, +

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Malcolm Priestley
On Wed, 2011-07-27 at 16:06 -0300, Mauro Carvalho Chehab wrote: > Em 25-07-2011 21:17, Antti Palosaari escreveu: > > Signed-off-by: Antti Palosaari > > --- > > drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 85 > > +++--- > > drivers/media/dvb/dvb-usb/dvb-usb-init.c |4

[GIT PATCHES FOR 3.1] Updates for the gspca-stv06xx driver

2011-07-27 Thread Erik Andrén
Hi Mauro, Long time no code. :) Here are some updates to the stv06xx driver. The following changes since commit b0189cd087aa82bd23277cb5c8960ab030e13e5c: Merge branch 'next/devel2' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/linux-arm-soc (2011-07-26 17:42:18 -0700) are available in t

Re: [PATCH] Firmware extraction for IT9135 based devices

2011-07-27 Thread Malcolm Priestley
On Wed, 2011-07-27 at 14:21 +0200, Benjamin Larsson wrote: > MvH > Benjamin Larsson Thanks Benhamin Tested-by: Malcolm Priestley Regards Malcolm -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 0/3] A few DRX-K fixes

2011-07-27 Thread Mauro Carvalho Chehab
The first patch fixes a bug when DVB-K registration fails, potentially causing an OOPS at the caller driver. The second one is a debug printk message fix. The last one fixes a typo a the driver. All patches are trivial. Mauro Carvalho Chehab (3): [media] drxk: Fix error return code during drxk

[PATCH 3/3] [media] drxk: Fix the logic that selects between DVB-C annex A and C

2011-07-27 Thread Mauro Carvalho Chehab
Fix the DRX-K logic that selects between DVB-C annex A and C Fix a typo where DVB-C annex type is set via setEnvParameters, but the driver, uses, instead, setParamParameters[2]. While here, cleans up the code, fixing a bad identation at the fallback code for other types of firmware, and put the m

[PATCH 2/3] [media] drxk: Fix read debug message

2011-07-27 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index 5b22c1f..85332e8 100644 --- a/drivers/media/dvb/frontends/drxk_hard.c +++ b/drivers/media/dvb/frontends/drxk_hard.c @@ -355,13 +355,7 @@ static int i2c_read(s

[PATCH 1/3] [media] drxk: Fix error return code during drxk init

2011-07-27 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index 5694955..5b22c1f 100644 --- a/drivers/media/dvb/frontends/drxk_hard.c +++ b/drivers/media/dvb/frontends/drxk_hard.c @@ -6171,7 +6171,7 @@ error: if (s

Re: Parallel CMOS Image Sensor with UART Control Interface

2011-07-27 Thread Guennadi Liakhovetski
On Wed, 27 Jul 2011, James wrote: > On Wed, Jul 27, 2011 at 3:40 AM, Sakari Ailus wrote: > > On Mon, Jul 25, 2011 at 04:43:21PM +0800, James wrote: > >> Dear all, > >> > >> Does anyone came across a v4l2 Linux Device Driver for an Image Sensor > >> that uses Parallel CMOS H/V and can only be cont

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/27/2011 11:06 PM, Mauro Carvalho Chehab wrote: Em 27-07-2011 16:49, Antti Palosaari escreveu: On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i<= x; i++) { +ret = adap->props.frontend_attach(adap); +if (ret || adap->fe[i] == NULL) { +/* o

Re: [GIT PATCHES FOR 3.1] v4l-dvb: add and use poll_requested_events() function

2011-07-27 Thread Mauro Carvalho Chehab
Hi Hans, Em 17-07-2011 08:19, Hans Verkuil escreveu: > Hi Mauro, > > This patch series adds the poll_requested_events() function and uses it in > the V4L2 core and the ivtv driver. > > The poll patch is unchanged from the RFCv3 patch posted a week ago and the > other patches are unchanged from t

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Mauro Carvalho Chehab
Em 27-07-2011 16:49, Antti Palosaari escreveu: > On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: > >>> +for (i = 0; i<= x; i++) { >>> +ret = adap->props.frontend_attach(adap); >>> +if (ret || adap->fe[i] == NULL) { >>> +/* only print error when there is no FE a

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Antti Palosaari
On 07/27/2011 10:06 PM, Mauro Carvalho Chehab wrote: +for (i = 0; i<= x; i++) { +ret = adap->props.frontend_attach(adap); +if (ret || adap->fe[i] == NULL) { +/* only print error when there is no FE at all */ +if (i == 0) +err("no fronte

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-27 Thread Antti Palosaari
On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: Read without write work as with write. Attached updated patch. ttusb2-6.diff - read = i+1< num&& (msg[i+1].flags& I2C_M_RD); + write_read = i+1< num&& (msg[i+1].flags& I2C_M_RD); + read = ms

Re: [beagleboard] [RFC v1] mt9v113: VGA camera sensor driver and support for BeagleBoard

2011-07-27 Thread Mark Grosen
On Wed, Jul 27, 2011 at 11:49 AM, Joel A Fernandes wrote: Joel, I gave this a try this weekend. I ran into a few problems/questions. I wanted to try with pre-built (tested?) binaries so I grabbed yours (used your uImage): 1. media-ctl binary does not work because

Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-27 Thread Mauro Carvalho Chehab
Em 25-07-2011 21:17, Antti Palosaari escreveu: > Signed-off-by: Antti Palosaari > --- > drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 85 > +++--- > drivers/media/dvb/dvb-usb/dvb-usb-init.c |4 ++ > drivers/media/dvb/dvb-usb/dvb-usb.h | 11 +++- > 3 files change

Re: [PATCH 1/3] IT9137 driver for Kworld UB499-2T T09 (id 1b80:e409) - firmware details

2011-07-27 Thread Benjamin Larsson
> Malcolm, > > You should add a rule like the above at: > Documentation/dvb/get_dvb_firmware My patch does exactly that. [PATCH] Firmware extraction for IT9135 based devices > if you cannot get the distribution rights for such firmware. > > Thanks, > Mauro MvH Benjamin Larsson -- To uns

[cron job] v4l-dvb daily build: ERRORS

2011-07-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Jul 27 19:00:40 CEST 2011 git hash:f0a21151140da01c71de636f482f2eddec2840cc gcc version: i686-linux-gcc (GCC) 4.5

Re: [beagleboard] [RFC v1] mt9v113: VGA camera sensor driver and support for BeagleBoard

2011-07-27 Thread Joel A Fernandes
>>> Joel, >>> >>> I gave this a try this weekend. I ran into a few problems/questions. >>> >>> I wanted to try with pre-built (tested?) binaries so I grabbed yours >>> (used your uImage): >>> 1. media-ctl binary does not work because there is no libmediactl.so >>> on my Angstrom root FS. >>> 2. The

Re: [beagleboard] [RFC v1] mt9v113: VGA camera sensor driver and support for BeagleBoard

2011-07-27 Thread Mark Grosen
On Mon, Jul 25, 2011 at 10:13 AM, Koen Kooi wrote: > > Op 25 jul. 2011, om 18:56 heeft Mark Grosen het volgende geschreven: > >> On Wed, Jul 13, 2011 at 11:22 AM, Joel A Fernandes >> wrote: >>> * Adds support for mt9v113 sensor by borrowing heavily from PSP 2.6.37 >>> kernel patches >>> * Adapt

Re: [PATCH] [resend] usbvision: disable scaling for Nogatech MicroCam

2011-07-27 Thread Mauro Carvalho Chehab
Em 27-07-2011 14:15, Anca Emanuel escreveu: > Offtopic. Mauro is your pull request ready ? the merge window is open. Working on it. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/3] IT9137 driver for Kworld UB499-2T T09 (id 1b80:e409) - firmware details

2011-07-27 Thread Mauro Carvalho Chehab
Em 25-07-2011 15:34, Malcolm Priestley escreveu: > Firmware information for Kworld UB499-2T T09 based on IT913x series. This > device > uses file dvb-usb-it9137-01.fw. > > > Signed-off-by: Malcolm Priestley > > --- > Documentation/dvb/it9137.txt |9 + > 1 files changed, 9 insertio

Re: [GIT PATCHES FOR 3.1] v4l-dvb: add and use poll_requested_events() function

2011-07-27 Thread Mauro Carvalho Chehab
Em 17-07-2011 08:19, Hans Verkuil escreveu: > Hi Mauro, > > This patch series adds the poll_requested_events() function and uses it in > the V4L2 core and the ivtv driver. > > The poll patch is unchanged from the RFCv3 patch posted a week ago and the > other patches are unchanged from the RFCv1 p

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
Hi Sylwester, Thanks for the review. On Wednesday 27 July 2011 19:34:36 Sylwester Nawrocki wrote: > On 07/27/2011 11:13 AM, Laurent Pinchart wrote: [snip] > > +static int mt9p031_probe(struct i2c_client *client, > > + const struct i2c_device_id *did) > > +{ > > + str

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
Hi Sakari, On Wednesday 27 July 2011 12:13:05 Sakari Ailus wrote: > Hi Laurent, > > Thanks for the patch. I have a few comments below. Thanks for the review. Please see my answers to your comments below. Javier, there's one question for you as well. > On Wed, Jul 27, 2011 at 11:13:01AM +0200,

[dvbscan] missing LNB type

2011-07-27 Thread Sergey Mironov
Hi. I want to share experience in the field of using linuxtv-dvb-utils. Dvbscan (that is scan.s from source tarball) has following LNB parameters hardcoded: static struct lnb_types_st lnbs[] = { {"UNIVERSAL", univ_desc, 9750, 10600, 11700 }, {"DBS", dbs_desc, 11250, 0,

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Sylwester Nawrocki
Hi Laurent, Javier, On 07/27/2011 11:13 AM, Laurent Pinchart wrote: > From: Javier Martin > > The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly > Micron) controlled through I2C. > > The driver creates a V4L2 subdevice. It currently supports skipping, > cropping, automatic binning

Re: [PATCH] [resend] usbvision: disable scaling for Nogatech MicroCam

2011-07-27 Thread Anca Emanuel
Offtopic. Mauro is your pull request ready ? the merge window is open. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-27 Thread Sylwester Nawrocki
Hi Mauro, The following changes since commit f0a21151140da01c71de636f482f2eddec2840cc: Merge tag 'v3.0' into staging/for_v3.1 (2011-07-22 13:33:14 -0300) are available in the git repository at: git://git.infradead.org/users/kmpark/linux-2.6-samsung fimc-for-mauro Sylwester Nawrocki (28):

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-27 Thread Mauro Carvalho Chehab
Em 27-07-2011 11:58, Devin Heitmueller escreveu: > On Wed, Jul 27, 2011 at 10:34 AM, Mauro Carvalho Chehab > wrote: >> Btw, what's the video standard that you're using? DTV7? Does your device use >> a xc3028 or xc3028xl? Whats's your demod and board? > > It was in the first sentence of his email.

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-27 Thread Mauro Carvalho Chehab
Em 27-07-2011 11:58, Devin Heitmueller escreveu: > On Wed, Jul 27, 2011 at 10:34 AM, Mauro Carvalho Chehab > wrote: >> Btw, what's the video standard that you're using? DTV7? Does your device use >> a xc3028 or xc3028xl? Whats's your demod and board? > > It was in the first sentence of his email.

Re: [PATCH] [resend] usbvision: disable scaling for Nogatech MicroCam

2011-07-27 Thread Mauro Carvalho Chehab
Em 22-07-2011 18:44, Ondrej Zary escreveu: > On Friday 22 July 2011 23:31:46 Devin Heitmueller wrote: >> On Fri, Jul 22, 2011 at 5:22 PM, Ondrej Zary >> wrote: >>> Seems that this bug is widespread - the same problem appears also in >>> guvcview >>> and adobe flash. I think that the driver is br

Re: DVB-T issues w/ kernel 3.0

2011-07-27 Thread Devin Heitmueller
On Wed, Jul 27, 2011 at 10:57 AM, Steffen Barszus wrote: > Quote: > "The drivers from 2011-02-05 does not run, but the drivers from > 2010-10-16 runs perfectly. " > > should give at least a startingpoint/timeframe for bisecting ... > allthough would be more usefull if based linuxtv git. Bear in m

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-27 Thread Devin Heitmueller
On Wed, Jul 27, 2011 at 10:34 AM, Mauro Carvalho Chehab wrote: > Btw, what's the video standard that you're using? DTV7? Does your device use > a xc3028 or xc3028xl? Whats's your demod and board? It was in the first sentence of his email. He's got an HVR-1400, which uses the xc3028L and dib7000p

Re: DVB-T issues w/ kernel 3.0

2011-07-27 Thread Steffen Barszus
Am 27. Juli 2011 16:37 schrieb Devin Heitmueller : > 2011/7/27 Toralf Förster : >> Hello, >> >> I'm wondering, whether there are known issues with the new kernel version >> just >> b/c of https://forums.gentoo.org/viewtopic.php?p=6766690#6766690 and >> https://bugs.kde.org/show_bug.cgi?id=278561 >

Re: DVB-T issues w/ kernel 3.0

2011-07-27 Thread Rémi Denis-Courmont
Le mercredi 27 juillet 2011 17:30:50 Toralf Förster, vous avez écrit : > Hello, > > I'm wondering, whether there are known issues with the new kernel version > just b/c of https://forums.gentoo.org/viewtopic.php?p=6766690#6766690 and > https://bugs.kde.org/show_bug.cgi?id=278561 On a tangential n

Re: DVB-T issues w/ kernel 3.0

2011-07-27 Thread Devin Heitmueller
2011/7/27 Toralf Förster : > Hello, > > I'm wondering, whether there are known issues with the new kernel version just > b/c of https://forums.gentoo.org/viewtopic.php?p=6766690#6766690 and > https://bugs.kde.org/show_bug.cgi?id=278561 Hello Toralf, I don't think you're the first person to report

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-27 Thread Mauro Carvalho Chehab
Hi Alina, Em 22-07-2011 15:35, Alina Friedrichsen escreveu: > Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work > anymore, and nobody feels responsible to fix it. No. The problem is that fixing it would require someone to travel around the globe with several different boar

DVB-T issues w/ kernel 3.0

2011-07-27 Thread Toralf Förster
Hello, I'm wondering, whether there are known issues with the new kernel version just b/c of https://forums.gentoo.org/viewtopic.php?p=6766690#6766690 and https://bugs.kde.org/show_bug.cgi?id=278561 -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread javier Martin
Hi Laurent, I really was looking forward to your patch. Tomorrow i have the day off, so I will look at this on Friday. I will review and test your patch and send you my comments. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabr

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-27 Thread Sylwester Nawrocki
Hi Gueannadi, On 07/20/2011 10:43 AM, Guennadi Liakhovetski wrote: > A possibility to preallocate and initialise buffers of different sizes > in V4L2 is required for an efficient implementation of asnapshot mode. > This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and > VIDIOC_PREPARE_BUF and d

[PATCH] Firmware extraction for IT9135 based devices

2011-07-27 Thread Benjamin Larsson
MvH Benjamin Larsson >From b3cbee633f5a6403c2460892e64adcb88f6ae4a6 Mon Sep 17 00:00:00 2001 From: Benjamin Larsson Date: Wed, 27 Jul 2011 13:43:38 +0200 Subject: [PATCH 1/1] Firmware extraction for IT9135 based devices Signed-off-by: Benjamin Larsson --- Documentation/dvb/get_dvb_firmware |

RE: Parallel CMOS Image Sensor with UART Control Interface

2011-07-27 Thread Alex Gershgorin
ast develop the driver and test the UART interface. -- Regards, Laurent Pinchart __ Information from ESET NOD32 Antivirus, version of virus signature database 6327 (20110726) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com __ Information from ESET NOD32 Antivirus, version of virus signature database 6328 (20110727) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. I have a few comments below. On Wed, Jul 27, 2011 at 11:13:01AM +0200, Laurent Pinchart wrote: > From: Javier Martin > > The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly > Micron) controlled through I2C. > > The driver creates a V4L2 subdevice

[PATCHv4 05/11] omap3isp: Use *_dec_not_zero instead of *_add_unless

2011-07-27 Thread Sven Eckelmann
atomic_dec_not_zero is defined for each architecture through to provide the functionality of atomic_add_unless(x, -1, 0). Signed-off-by: Sven Eckelmann Cc: Laurent Pinchart Cc: linux-media@vger.kernel.org --- drivers/media/video/omap3isp/ispstat.c |2 +- 1 files changed, 1 insertions(+), 1

Re: Camera Support

2011-07-27 Thread Laurent Pinchart
On Tuesday 26 July 2011 21:43:38 Sakari Ailus wrote: > On Wed, Jul 27, 2011 at 12:53:44AM +0530, Sriram V wrote: > > Hi, > > > > OMAP3 ISP Supports 2 camera ports (csi and parallel) Does the > > > > existing ISP drivers > > > > support both of them at the same time. > > As far as I can see,

[PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
From: Javier Martin The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly Micron) controlled through I2C. The driver creates a V4L2 subdevice. It currently supports skipping, cropping, automatic binning, and gain, exposure, h/v flip and test pattern controls. Signed-off-by: Javier M

Re: Parallel CMOS Image Sensor with UART Control Interface

2011-07-27 Thread Laurent Pinchart
Hi James, On Wednesday 27 July 2011 07:41:59 James wrote: > On Wed, Jul 27, 2011 at 3:40 AM, Sakari Ailus wrote: > > On Mon, Jul 25, 2011 at 04:43:21PM +0800, James wrote: > >> Dear all, > >> > >> Does anyone came across a v4l2 Linux Device Driver for an Image Sensor > >> that uses Parallel CMOS

Re: [PATCH] adp1653: check error code of adp1653_init_controls

2011-07-27 Thread Sakari Ailus
On Wed, Jul 27, 2011 at 10:58:02AM +0300, Andy Shevchenko wrote: > Potentially the adp1653_init_controls could return an error. In our case the > error was ignored, meanwhile it means incorrect initialization of V4L2 > controls. Hi, Andy! Many thanks for the another patch! I'll add this to my nex

[PATCH] adp1653: check error code of adp1653_init_controls

2011-07-27 Thread Andy Shevchenko
Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Signed-off-by: Andy Shevchenko Cc: Mauro Carvalho Chehab Cc: Sakari Ailus --- drivers/media/video/adp1653.c |6 +- 1 files chang