Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-12 Thread Bjorn Andersson
On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- > drivers/crypto/qce/core.h | 2 +- > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-04-01 Thread Bjorn Andersson
On Wed 29 Mar 13:48 PDT 2017, Michael S. Tsirkin wrote: > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > > Signed-off-by: Michael S. Tsirkin Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource

2020-11-17 Thread Bjorn Andersson
#x27; Apart from that, things looks good. Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/dt-bindings/clock/qcom,rpmh.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/clock/qcom,rpmh.h > b/include/dt-bindings/clock/qcom,rpmh.h > inde

Re: [PATCH 2/6] clk:qcom:rpmh: Add CE clock on sdm845.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Qualcomm CE clock resource that is managed by BCM is required > by crypto driver to access the core clock. > ' ' after ':' in $subject With that Reviewed-by: Bjorn Andersson Regards, bjorn &g

Re: [PATCH 3/6] drivers:crypto:qce: Enable support for crypto engine on sdm845.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Add support Qualcomm Crypto Engine accelerated encryption and > authentication algorithms on sdm845. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/cryp

Re: [PATCH 4/6] drivers:crypto:qce: Fix SHA result buffer corruption issues.

2020-11-17 Thread Bjorn Andersson
oisoing. Fix this issue by ensuring that only the final hash value > is copied into the result buffer. > Looks reasonable to me Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/sha.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH 6/6] devicetree:bindings:crypto: Extend qcom-qce binding to add support for crypto engine version 5.4

2020-11-17 Thread Bjorn Andersson
like: "dt-bindings: crypto: qcom-qce: Add v5.4 to binding" With something like that: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/D

Re: [PATCH 5/6] dts:qcom:sdm845: Add dt entries to support crypto engine.

2020-11-17 Thread Bjorn Andersson
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > "sdm845.dtsi". > > Signed-off-by: Thara Gopinath > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 > 1 file changed, 30 insertions(+) > > dif

Re: [PATCH v3 1/6] drivers: crypto: qce: sha: Restore/save ahash state with custom struct in export/import

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: Please drop "drivers: " from $subject. > Export and import interfaces save and restore partial transformation > states. The partial states were being stored and restored in struct > sha1_state for sha1/hmac(sha1) transformations and sha256_state

Re: [PATCH v3 3/6] drivers: crypto: qce: skcipher: Fix regressions found during fuzz testing

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: > This patch contains the following fixes for the supported encryption > algorithms in the Qualcomm crypto engine(CE) > 1. Return unsupported if key1 = key2 for AES XTS algorithm since CE > does not support this and the operation causes the engin

Re: [PATCH v3 4/6] drivers: crypto: qce: common: Set data unit size to message length for AES XTS transformation

2021-01-25 Thread Bjorn Andersson
gone away in the newer chips. I am however not able to find anything about it, so I'm in favor of merging this patch and if anyone actually uses the driver on the older hardware we'd have to go back and quirk it somehow. Acked-by: Bjorn Andersson Regards, Bjorn > - qce_write(qce,

Re: [PATCH v3 5/6] drivers: crypto: qce: Remover src_tbl from qce_cipher_reqctx

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: > src_table is unused and hence remove it from struct qce_cipher_reqctx > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/cipher.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto

Re: [PATCH v3 6/6] drivers: crypto: qce: Remove totallen and offset in qce_start

2021-01-25 Thread Bjorn Andersson
thentication transformations and is always 0. > Remove these two redundant parameters in qce_start. > Please drop "drivers: " from $subject. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 17 +++

Re: [PATCH v3 2/6] drivers: crypto: qce: sha: Hold back a block of data to be transferred as part of final

2021-01-26 Thread Bjorn Andersson
ied to the > destination result buffer. qce_ahash_final cannot be made to alter this > behavior and allowed to proceed if rctx->buflen is 0 because the crypto > engine BAM does not allow for zero length transfers. > Please drop "drivers: " from $subject. Apart from th

Re: [PATCH 1/7] crypto: qce: common: Add MAC failed error checking

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > MAC_FAILED gets set in the status register if authenthication fails > for ccm algorithms(during decryption). Add support to catch and flag > this error. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 11 --- >

Re: [PATCH 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > Add register programming sequence for enabling AEAD > algorithms on the Qualcomm crypto engine. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 155 +++- > 1 file changed, 153 insertion

Re: [PATCH 2/7] crypto: qce: common: Make result dump optional

2021-04-05 Thread Bjorn Andersson
P field optional so that algorithms can choose > whether or not to enable the option. > Note that in this patch, the enabled algorithms always choose > RESULTS_DUMP to be enabled. But later with the introduction of ccm > algorithms, this changes. > > Signed-off-by: Thara Gopinath Rev

Re: [PATCH 3/7] crypto: qce: Add mode for rfc4309

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > rf4309 is the specification that uses aes ccm algorithms with IPsec > security packets. Add a submode to identify rfc4309 ccm(aes) algorithm > in the crypto driver. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.h | 7 ++

Re: [PATCH 3/7] crypto: qce: Add mode for rfc4309

2021-04-13 Thread Bjorn Andersson
On Tue 13 Apr 14:30 CDT 2021, Thara Gopinath wrote: > > > On 4/5/21 6:32 PM, Bjorn Andersson wrote: > > On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > > > > > rf4309 is the specification that uses aes ccm algorithms with IPsec > > > security pac

Re: [PATCH 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-13 Thread Bjorn Andersson
On Tue 13 Apr 16:31 CDT 2021, Thara Gopinath wrote: > > Hi Bjorn, > > On 4/5/21 6:18 PM, Bjorn Andersson wrote: > > On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > > > > > Add register programming sequence for enabling AEAD > > >

Re: [PATCH 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-13 Thread Bjorn Andersson
On Tue 13 Apr 17:27 CDT 2021, Thara Gopinath wrote: > > > On 4/5/21 6:18 PM, Bjorn Andersson wrote: > > On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > > > > > Add register programming sequence for enabling AEAD > > > algorithms on the Qualcomm cr

Re: [PATCH 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-13 Thread Bjorn Andersson
On Tue 13 Apr 17:44 CDT 2021, Thara Gopinath wrote: > > > On 4/13/21 6:20 PM, Bjorn Andersson wrote: > > On Tue 13 Apr 16:31 CDT 2021, Thara Gopinath wrote: > > > > > > > > Hi Bjorn, > > > > > > On 4/5/21 6:18 PM, Bjorn Andersson wr

Re: [Patch v2 1/7] crypto: qce: common: Add MAC failed error checking

2021-04-18 Thread Bjorn Andersson
On Sat 17 Apr 08:24 CDT 2021, Thara Gopinath wrote: > MAC_FAILED gets set in the status register if authenthication fails > for ccm algorithms(during decryption). Add support to catch and flag > this error. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by:

Re: [Patch v2 3/7] crypto: qce: Add mode for rfc4309

2021-04-18 Thread Bjorn Andersson
On Sat 17 Apr 08:24 CDT 2021, Thara Gopinath wrote: > rf4309 is the specification that uses aes ccm algorithms with IPsec > security packets. Add a submode to identify rfc4309 ccm(aes) algorithm > in the crypto driver. > Reviewed-by: Bjorn Andersson > Signed-off-by:

Re: [Patch v2 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-18 Thread Bjorn Andersson
On Sat 17 Apr 08:25 CDT 2021, Thara Gopinath wrote: > Add register programming sequence for enabling AEAD > algorithms on the Qualcomm crypto engine. > > Signed-off-by: Thara Gopinath > --- > > v1->v2: > - Minor fixes like removing not needed initializing of variables > and using

Re: [PATCH 2/2] arm64: dts: qcom: sm6350: Add Crypto Engine

2024-02-16 Thread Bjorn Andersson
On Fri, Feb 16, 2024 at 11:46:49AM +0100, Luca Weiss wrote: > On Fri Jan 5, 2024 at 5:30 PM CET, Stephan Gerhold wrote: > > On Fri, Jan 05, 2024 at 05:15:44PM +0100, Luca Weiss wrote: > > > Add crypto engine (CE) and CE BAM related nodes and definitions for this > > > SoC. > > > > > > For referenc

Re: [PATCH v2] arm64: dts: qcom: sm6350: Add Crypto Engine

2024-03-18 Thread Bjorn Andersson
[1/1] arm64: dts: qcom: sm6350: Add Crypto Engine commit: fd5afa5d7e5259cb2320fbe2cf60250f7336f439 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS

2024-04-04 Thread Bjorn Andersson
Best regards, -- Bjorn Andersson

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-10-06 Thread Bjorn Andersson
pat_ioctl = rpmsg_ctrldev_ioctl, > + .compat_ioctl = generic_compat_ioctl_ptrarg, > }; > For rpmsg part Acked-by: Bjorn Andersson Regards, Bjorn