Testmgr: invalid lock context

2021-01-05 Thread Stephan Mueller
Hi, with the current cryptodev-2.6 tree and the Linus rc-2 tree, I get the following during boot: [0.837048] = [0.837079] [ BUG: Invalid wait context ] [0.837079] 5.11.0-rc1+ #215 Not tainted [0.837079] - [0.837079] crypt

[PATCH] drivers: crypto: marvell: Fix a spelling s/fautly/faultly/ in comment

2021-01-05 Thread Bhaskar Chowdhury
s/fautly/faulty/p Signed-off-by: Bhaskar Chowdhury --- drivers/crypto/marvell/cesa/tdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/marvell/cesa/tdma.c b/drivers/crypto/marvell/cesa/tdma.c index 5d9c48fb72b2..0e0d63359798 100644 --- a/drivers/crypto/m

Re: [PATCH v2 0/5] Enable root to update the blacklist keyring

2021-01-05 Thread Mickaël Salaün
Jarkko, David, what is the status of this patch series? Do you need help to test it? On 11/12/2020 20:03, Mickaël Salaün wrote: > Hi, > > This second patch series includes some minor fixes and remove the 4 fix > patches picked by David Howells. This patch series can then be applied > on top of >

Re: [PATCH] crypto: Rename struct device_private to bcm_device_private

2021-01-05 Thread Qais Yousef
On 01/05/21 00:02, Jiri Olsa wrote: > Renaming 'struct device_private' to 'struct bcm_device_private', > because it clashes with 'struct device_private' from > 'drivers/base/base.h'. > > While it's not a functional problem, it's causing two distinct > type hierarchies in BTF data. It also breaks b

[PATCH 00/10] Remove support for TX49xx

2021-01-05 Thread Thomas Bogendoerfer
I couldn't find any buyable product other than reference boards using TX49xx CPUs. And since nobody showed interest in keeping support for it, it's time to remove it. I've split up the removal into seperate parts for different maintainers. So if the patch fits your needs, please take it via your t

[PATCH 02/10] net: tc35815: Drop support for TX49XX boards

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove support in network drivers for it. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/toshiba/tc35815.c | 29 -- 1 file changed, 29 deletions(-) diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/n

[PATCH 04/10] spi: txx9: Remove driver

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove support SPI driver for it. Signed-off-by: Thomas Bogendoerfer --- drivers/spi/Kconfig| 6 - drivers/spi/Makefile | 1 - drivers/spi/spi-txx9.c | 477 - 3 files changed, 484 deletions(-) delete

[PATCH 03/10] net: 8390: Drop support for TX49XX boards

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove support in network drivers for it. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/8390/Kconfig | 2 +- drivers/net/ethernet/8390/ne.c| 7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ether

[PATCH 05/10] dma: tx49 removal

2021-01-05 Thread Thomas Bogendoerfer
Signed-off-by: Thomas Bogendoerfer --- drivers/dma/Kconfig| 2 +- drivers/dma/txx9dmac.h | 10 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index d242c7632621..22fedfb6f5f9 100644 --- a/drivers/dma/Kconfig +++ b/drivers/d

[PATCH 09/10] ide: tx4938ide: Remove driver

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove IDE support for it. Signed-off-by: Thomas Bogendoerfer --- drivers/ide/Kconfig | 10 - drivers/ide/Makefile| 3 - drivers/ide/tx4938ide.c | 209 - drivers/ide/tx4939ide.c | 628 4

[PATCH 08/10] rtc: tx4939: Remove driver

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove rtc driver for it. Signed-off-by: Thomas Bogendoerfer --- drivers/rtc/Kconfig | 7 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-tx4939.c | 303 --- 3 files changed, 311 deletions(-) delete mod

[PATCH 10/10] ASoC: txx9: Remove driver

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove sound support for it. Signed-off-by: Thomas Bogendoerfer --- sound/soc/Kconfig | 1 - sound/soc/Makefile| 1 - sound/soc/txx9/Kconfig| 30 --- sound/soc/txx9/Makefile | 12 - sound/so

[PATCH 07/10] char: hw_random: Remove tx4939 driver

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove hw_random driver for it. Signed-off-by: Thomas Bogendoerfer --- drivers/char/hw_random/Kconfig | 13 --- drivers/char/hw_random/Makefile | 1 - drivers/char/hw_random/tx4939-rng.c | 157 3 files changed

Re: [PATCH 06/10] mtd: Remove drivers used by TX49xx

2021-01-05 Thread Miquel Raynal
Hi Thomas, Thomas Bogendoerfer wrote on Tue, 5 Jan 2021 15:02:51 +0100: > CPU support for TX49xx is getting removed, so remove MTD support for it. > > Signed-off-by: Thomas Bogendoerfer If the removal happens, you may take this patch through the mips tree. Acked-by: Miquel Raynal One less

[PATCH 06/10] mtd: Remove drivers used by TX49xx

2021-01-05 Thread Thomas Bogendoerfer
CPU support for TX49xx is getting removed, so remove MTD support for it. Signed-off-by: Thomas Bogendoerfer --- drivers/mtd/maps/Kconfig | 6 - drivers/mtd/maps/Makefile| 1 - drivers/mtd/maps/rbtx4939-flash.c| 133 --- drivers/mtd/nand/raw/Kconfig

Re: [PATCH 01/10] MIPS: TX49xx: Drop support

2021-01-05 Thread Guenter Roeck
On 1/5/21 6:02 AM, Thomas Bogendoerfer wrote: > Looks like there are no boards with TX49xx CPUS other than reference > boards available. So it's time to drop Linux support for it. > > Signed-off-by: Thomas Bogendoerfer > --- > drivers/watchdog/Kconfig | 2 +- Acked-by: Gu

Re: (subset) [PATCH 00/10] Remove support for TX49xx

2021-01-05 Thread Mark Brown
On Tue, 5 Jan 2021 15:02:45 +0100, Thomas Bogendoerfer wrote: > I couldn't find any buyable product other than reference boards using > TX49xx CPUs. And since nobody showed interest in keeping support for > it, it's time to remove it. > > I've split up the removal into seperate parts for different

[PATCH v2 00/21] crypto: x86 - remove glue helper module

2021-01-05 Thread Ard Biesheuvel
NOTE: this is a follow-up to '[RFC PATCH 00/10] crypto: x86 - remove XTS and CTR glue helper code' [0]. After applying my performance fixes for AES-NI in XTS mode, the only remaining users of the x86 glue helper module are the niche algorithms camellia, cast5/6, serpent and twofish. It is not cle

[PATCH v2 03/21] crypto: x86/serpent- switch to XTS template

2021-01-05 Thread Ard Biesheuvel
Now that the XTS template can wrap accelerated ECB modes, it can be used to implement Serpent in XTS mode as well, which turns out to be at least as fast, and sometimes even faster Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 48 ---

[PATCH v2 04/21] crypto: x86/twofish - switch to XTS template

2021-01-05 Thread Ard Biesheuvel
Now that the XTS template can wrap accelerated ECB modes, it can be used to implement Twofish in XTS mode as well, which turns out to be at least as fast, and sometimes even faster Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 53

[PATCH v2 06/21] crypto: x86/camellia - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
Camellia in CTR mode is never used by the kernel directly, and is highly unlikely to be relied upon by dm-crypt or algif_skcipher. So let's drop the accelerated CTR mode implementation, and instead, rely on the CTR template and the bare cipher. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel

[PATCH v2 08/21] crypto: x86/cast5 - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
CAST5 in CTR mode is never used by the kernel directly, and is highly unlikely to be relied upon by dm-crypt or algif_skcipher. So let's drop the accelerated CTR mode implementation, and instead, rely on the CTR template and the bare cipher. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel -

[PATCH v2 07/21] crypto: x86/serpent - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
Serpent in CTR mode is never used by the kernel directly, and is highly unlikely to be relied upon by dm-crypt or algif_skcipher. So let's drop the accelerated CTR mode implementation, and instead, rely on the CTR template and the bare cipher. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel

[PATCH v2 12/21] crypto: x86/des - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
DES or Triple DES in counter mode is never used in the kernel, so there is no point in keeping an accelerated implementation around. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/des3_ede_glue.c | 104 crypto/Kconfig | 1 + 2 fi

[PATCH v2 10/21] crypto: x86/twofish - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
Twofish in CTR mode is never used by the kernel directly, and is highly unlikely to be relied upon by dm-crypt or algif_skcipher. So let's drop the accelerated CTR mode implementation, and instead, rely on the CTR template and the bare cipher. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel

[PATCH v2 14/21] crypto: x86 - add some helper macros for ECB and CBC modes

2021-01-05 Thread Ard Biesheuvel
The x86 glue helper module is starting to show its age: - It relies heavily on function pointers to invoke asm helper functions that operate on fixed input sizes that are relatively small. This means the performance is severely impacted by retpolines. - It goes to great lengths to amortize the

[PATCH v2 05/21] crypto: x86/glue-helper - drop XTS helper routines

2021-01-05 Thread Ard Biesheuvel
The glue helper's XTS routines are no longer used, so drop them. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/glue_helper-asm-avx.S | 59 arch/x86/crypto/glue_helper-asm-avx2.S| 78 -- arch/x86/crypto/glue_helper.c | 154 ---

[PATCH v2 13/21] crypto: x86/blowfish - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
Blowfish in counter mode is never used in the kernel, so there is no point in keeping an accelerated implementation around. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/blowfish_glue.c | 107 crypto/Kconfig | 1 + 2 files chang

[PATCH v2 09/21] crypto: x86/cast6 - drop CTR mode implementation

2021-01-05 Thread Ard Biesheuvel
CAST6 in CTR mode is never used by the kernel directly, and is highly unlikely to be relied upon by dm-crypt or algif_skcipher. So let's drop the accelerated CTR mode implementation, and instead, rely on the CTR template and the bare cipher. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel -

[PATCH v2 18/21] crypto: x86/cast6 - drop dependency on glue helper

2021-01-05 Thread Ard Biesheuvel
Replace the glue helper dependency with implementations of ECB and CBC based on the new CPP macros, which avoid the need for indirect calls. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/cast6_avx_glue.c | 61 ++-- crypto/Kconfig | 1

[PATCH v2 15/21] crypto: x86/camellia - drop dependency on glue helper

2021-01-05 Thread Ard Biesheuvel
Replace the glue helper dependency with implementations of ECB and CBC based on the new CPP macros, which avoid the need for indirect calls. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/camellia_aesni_avx2_glue.c | 85 ++-- arch/x86/crypto/camellia_ae

[PATCH v2 11/21] crypto: x86/glue-helper - drop CTR helper routines

2021-01-05 Thread Ard Biesheuvel
The glue helper's CTR routines are no longer used, so drop them. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/glue_helper-asm-avx.S | 45 arch/x86/crypto/glue_helper-asm-avx2.S| 58 arch/x86/crypto/glue_helper.c | 72

[PATCH v2 19/21] crypto: x86/twofish - drop dependency on glue helper

2021-01-05 Thread Ard Biesheuvel
Replace the glue helper dependency with implementations of ECB and CBC based on the new CPP macros, which avoid the need for indirect calls. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/twofish_avx_glue.c | 73 +- arch/x86/crypto/twofish_glue_3way.c

[PATCH v2 21/21] crypto: x86 - use local headers for x86 specific shared declarations

2021-01-05 Thread Ard Biesheuvel
The Camellia, Serpent and Twofish related header files only contain declarations that are shared between different implementations of the respective algorithms residing under arch/x86/crypto, and none of their contents should be used elsewhere. So move the header files into the same location, and u

[PATCH v2 17/21] crypto: x86/cast5 - drop dependency on glue helper

2021-01-05 Thread Ard Biesheuvel
Replace the glue helper dependency with implementations of ECB and CBC based on the new CPP macros, which avoid the need for indirect calls. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/cast5_avx_glue.c | 184 ++-- 1 file changed, 17 insertions(+), 16

[PATCH v2 20/21] crypto: x86 - remove glue helper module

2021-01-05 Thread Ard Biesheuvel
All dependencies on the x86 glue helper module have been replaced by local instantiations of the new ECB/CBC preprocessor helper macros, so the glue helper module can be retired. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/Makefile | 2 - arch/x86

[PATCH v2 02/21] crypto: x86/cast6 - switch to XTS template

2021-01-05 Thread Ard Biesheuvel
Now that the XTS template can wrap accelerated ECB modes, it can be used to implement CAST6 in XTS mode as well, which turns out to be at least as fast, and sometimes even faster Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 56 ---

[PATCH v2 01/21] crypto: x86/camellia - switch to XTS template

2021-01-05 Thread Ard Biesheuvel
Now that the XTS template can wrap accelerated ECB modes, it can be used to implement Camellia in XTS mode as well, which turns out to be at least as fast, and sometimes even faster. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/camellia-aesni-avx-asm_64.S | 181

[PATCH v2 16/21] crypto: x86/serpent - drop dependency on glue helper

2021-01-05 Thread Ard Biesheuvel
Replace the glue helper dependency with implementations of ECB and CBC based on the new CPP macros, which avoid the need for indirect calls. Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/serpent_avx2_glue.c | 73 +- arch/x86/crypto/serpent_avx_glue.c

Re: [PATCH v2] crypto: Fix divide error in do_xor_speed()

2021-01-05 Thread Doug Anderson
Hi, On Wed, Dec 30, 2020 at 1:34 PM Kirill Tkhai wrote: > > crypto: Fix divide error in do_xor_speed() > > From: Kirill Tkhai > > Latest (but not only latest) linux-next panics with divide > error on my QEMU setup. > > The patch at the bottom of this message fixes the problem. > > xor: measuring

Re: [PATCH 05/10] dma: tx49 removal

2021-01-05 Thread Vinod Koul
On 05-01-21, 15:02, Thomas Bogendoerfer wrote: > Signed-off-by: Thomas Bogendoerfer Applied after fixing subsystem name, thanks -- ~Vinod