On 01/05/21 00:02, Jiri Olsa wrote: > Renaming 'struct device_private' to 'struct bcm_device_private', > because it clashes with 'struct device_private' from > 'drivers/base/base.h'. > > While it's not a functional problem, it's causing two distinct > type hierarchies in BTF data. It also breaks build with options: > CONFIG_DEBUG_INFO_BTF=y > CONFIG_CRYPTO_DEV_BCM_SPU=y > > as reported by Qais Yousef [1]. > > [1] https://lore.kernel.org/lkml/20201229151352.6hzmjvu3qh6p2qgg@e107158-lin/ > Signed-off-by: Jiri Olsa <jo...@kernel.org> > --- > drivers/crypto/bcm/cipher.c | 2 +- > drivers/crypto/bcm/cipher.h | 4 ++-- > drivers/crypto/bcm/util.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-)
FWIW, I did reproduce this on v5.9 and v5.10 kernels too, worth adding a fixes tag for stable to pick it up? v5.8 built fine when I tried. Anyway, the patch looks good to me, thanks for the fix! Tested-by: Qais Yousef <qais.you...@arm.com> Cheers -- Qais Yousef