Re: crypto: Add support for the Geode LX HW AES engine

2006-06-06 Thread Herbert Xu
On Tue, Jun 06, 2006 at 09:19:14AM -0600, Jordan Crouse wrote: > > No - but they can run with preempt turned on - so there's always the > risk that we can have two processes in the code at the same time. preempt_disable should take care of both cases. Cheers, -- Visit Openswan at http://www.ope

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-06 Thread Jordan Crouse
On 06/06/06 11:24 +1000, Herbert Xu wrote: > Jordan Crouse <[EMAIL PROTECTED]> wrote: > > > > Is there any way to differentiate if a crypto API call was made in an > > atomic context or not? The problem here, is that I only have one engine, > > so I need to protect it from multiple processes acces

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-06 Thread Evgeniy Polyakov
On Mon, Jun 05, 2006 at 10:11:17AM -0600, Jordan Crouse ([EMAIL PROTECTED]) wrote: > On 03/06/06 14:53 +0400, Evgeniy Polyakov wrote: > > > > +static inline void AWRITE(unsigned long val, unsigned short reg) { > > > +#ifdef DEBUG > > > + printk("[AES] W [%x]=%x\n", reg, val); > > > +#endif > > >

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Evgeniy Polyakov
On Mon, Jun 05, 2006 at 09:45:12AM -0600, Jordan Crouse ([EMAIL PROTECTED]) wrote: > On 03/06/06 14:43 +0400, Evgeniy Polyakov wrote: > > On Sat, Jun 03, 2006 at 09:07:52AM +1000, Herbert Xu ([EMAIL PROTECTED]) > > wrote: > > > On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > >

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Herbert Xu
Jordan Crouse <[EMAIL PROTECTED]> wrote: > > Is there any way to differentiate if a crypto API call was made in an > atomic context or not? The problem here, is that I only have one engine, > so I need to protect it from multiple processes accessing it at the > same time. I can get rid of the sl

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Geoff Thorpe
Jordan Crouse wrote: Is there any way to differentiate if a crypto API call was made in an atomic context or not? The problem here, is that I only have one engine, so I need to protect it from multiple processes accessing it at the same time. I can get rid of the sleep in an atomic context, b

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Jordan Crouse
On 03/06/06 14:53 +0400, Evgeniy Polyakov wrote: > > +static inline void AWRITE(unsigned long val, unsigned short reg) { > > +#ifdef DEBUG > > + printk("[AES] W [%x]=%x\n", reg, val); > > +#endif > > + iowrite32(val, _iobase + reg); > > +} > > + > > +static inline unsigned int AREAD(unsigned

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Jordan Crouse
On 03/06/06 14:43 +0400, Evgeniy Polyakov wrote: > On Sat, Jun 03, 2006 at 09:07:52AM +1000, Herbert Xu ([EMAIL PROTECTED]) > wrote: > > On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > > > > > + /* According to the silicon developers, the status will only > > > + * fail to clea

Re: [PATCH] crypto: Add support for the Geode LX HW AES engine

2006-06-03 Thread Evgeniy Polyakov
On Fri, Jun 02, 2006 at 11:23:41AM -0600, Jordan Crouse ([EMAIL PROTECTED]) wrote: > Greetings - attached is a patch adding a crypto API driver for the hardware > encryption engine on the AMD Geode LX processor, applied against latest > GIT from Linus. This is my first foray into the world of the

Re: [PATCH] crypto: Add support for the Geode LX HW AES engine

2006-06-03 Thread Evgeniy Polyakov
On Sat, Jun 03, 2006 at 09:07:52AM +1000, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > > > + /* According to the silicon developers, the status will only > > +* fail to clear on an catastrophic failure, so an infinite > > +* lo

Re: [PATCH] crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread Herbert Xu
On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > + /* According to the silicon developers, the status will only > + * fail to clear on an catastrophic failure, so an infinite > + * loop is valid here > + */ > + > + do > + status = AREAD(AES_INTR_

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread John Yoder
Michael, Once the upstreamed drivers have been put through are validation cycle, it is our intent to announce this on the AMD website as well as notify our FAE's of this. We are holding back the announcement so we don't "put our foot in it" I should also note that we expect no issue's with the

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread Michael Frey
Jordan, Thanks -- I will check the AMD web site. I would love to move to a new kernel, however there seems to be a few things preventing me. 1: There is no LX frame buffer driver 2: The cimmaron libraries are not present 3: The V4L driver has not been upgraded to support a kernel later th

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread Jordan Crouse
On 02/06/06 13:32 -0400, Michael Frey wrote: > Jordan, > > This looks great, however are you going to release a patch against > 2.6.11-geode? 2.6.11 is the version all geode patches were issued > against. There is a 2.6.11 version of this on the AMD website, if you need it. I think that inc

Re: [PATCH] crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread Michael Frey
Jordan, This looks great, however are you going to release a patch against 2.6.11-geode? 2.6.11 is the version all geode patches were issued against. Michael On Jun 2, 2006, at 1:23 PM, Jordan Crouse wrote: Greetings - attached is a patch adding a crypto API driver for the hardware en

[PATCH] crypto: Add support for the Geode LX HW AES engine

2006-06-02 Thread Jordan Crouse
Greetings - attached is a patch adding a crypto API driver for the hardware encryption engine on the AMD Geode LX processor, applied against latest GIT from Linus. This is my first foray into the world of the Crypto API, so comments are more then welcome. Regards, Jordan -- Jordan Crouse Senio