Re: sha1_mb broken

2016-10-04 Thread Stephan Mueller
Am Dienstag, 4. Oktober 2016, 09:08:42 CEST schrieb Tim Chen: Hi Tim, > There is a spin lock protecting the completion's wait_queue on the processes > waiting for the completion of the job, and the queue head. My suspicion is > if these structures are not initialized properly, we fail to look up

Re: sha1_mb broken

2016-10-04 Thread Tim Chen
On Tue, 2016-10-04 at 16:10 +0200, Stephan Mueller wrote: > Am Dienstag, 4. Oktober 2016, 00:25:07 CEST schrieb Dey, Megha: > > Hi Megha, > > > > > > > > > > > Hi Stephan, > > > > > > Your test code initialized the completion structure incorrectly, that led > > > to the missing completion fro

Re: sha1_mb broken

2016-10-04 Thread Stephan Mueller
Am Dienstag, 4. Oktober 2016, 00:25:07 CEST schrieb Dey, Megha: Hi Megha, > > > Hi Stephan, > > > > Your test code initialized the completion structure incorrectly, that led > > to the missing completion from being received. The init_completion call > > should be made before the crypto_ahash_di

RE: sha1_mb broken

2016-10-03 Thread Dey, Megha
-Original Message- From: Stephan Mueller [mailto:smuel...@chronox.de] Sent: Wednesday, September 28, 2016 10:31 PM To: Dey, Megha Cc: linux-crypto@vger.kernel.org; tim.c.c...@linux.intel.com Subject: Re: sha1_mb broken Am Mittwoch, 28. September 2016, 22:52:46 CEST schrieb Dey, Megha

Re: sha1_mb broken

2016-09-28 Thread Stephan Mueller
Am Mittwoch, 28. September 2016, 22:52:46 CEST schrieb Dey, Megha: Hi Megha, see a self contained example code attached. Ciao Stephan sha1_mb.tar.xz Description: application/xz-compressed-tar

RE: sha1_mb broken

2016-09-28 Thread Dey, Megha
-Original Message- From: Stephan Mueller [mailto:smuel...@chronox.de] Sent: Wednesday, September 28, 2016 11:46 AM To: Dey, Megha Cc: linux-crypto@vger.kernel.org; tim.c.c...@linux.intel.com Subject: Re: sha1_mb broken Am Mittwoch, 28. September 2016, 11:25:47 CEST schrieb Megha Dey

Re: sha1_mb broken

2016-09-28 Thread Stephan Mueller
Am Mittwoch, 28. September 2016, 11:25:47 CEST schrieb Megha Dey: Hi Megha, > Hi Stephan, > > There was a bug fix: Commit ID : 0851561d (introduced in 4.6-rc5). I use the current cryptodev-2.6 tree. > > Assuming that you are using an older kernel than this one, maybe we are > issuing the compl

Re: sha1_mb broken

2016-09-28 Thread Megha Dey
Hi Stephan, There was a bug fix: Commit ID : 0851561d (introduced in 4.6-rc5). Assuming that you are using an older kernel than this one, maybe we are issuing the complete with the wrong pointer, so the original issuer of the request never gets the complete back. If you are using an older kernel

Re: sha1_mb broken

2016-09-28 Thread Megha Dey
Hi Stephan, Could you give me more info on how I could reproduce this issue on my end? Also was this issue there all along? Which is the first kernel version where you see this? Thanks, Megha On Mon, 2016-09-26 at 19:32 +0200, Stephan Mueller wrote: > Am Freitag, 26. August 2016, 03:15:06 CEST

Re: sha1_mb broken

2016-09-26 Thread Stephan Mueller
Am Freitag, 26. August 2016, 03:15:06 CEST schrieb Stephan Mueller: Hi Megha, > Hi, > > I tried to execute tests with sha1_mb. Have you had a chance to look into this one? > > The execution simply stalls when invoking a digest operation -- i.e. the > digest operation does not finish. After som