On Tue, 2016-10-04 at 16:10 +0200, Stephan Mueller wrote: > Am Dienstag, 4. Oktober 2016, 00:25:07 CEST schrieb Dey, Megha: > > Hi Megha, > > > > > > > > > > > Hi Stephan, > > > > > > Your test code initialized the completion structure incorrectly, that led > > > to the missing completion from being received. The init_completion call > > > should be made before the crypto_ahash_digest call. The following change > Thanks a lot for pointing that one out. Can you help me understand why your > code trips over that issue whereas other ahash implementations do not (all > other SHA-1 or SHA-2 implementations work perfectly fine with that code)? >
There is a spin lock protecting the completion's wait_queue on the processes waiting for the completion of the job, and the queue head. My suspicion is if these structures are not initialized properly, we fail to look up the waiting process in the queue properly to call it. For the other tested cases, they may not be a true ahash operation in the sense of passing request through the crypto daemon, and have to context switch to let crypto daemon complete the job. The computation proceeds and returns in the same call chain. Thanks. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
