Re: ctr(aes) broken in CAAM driver

2019-06-17 Thread Sascha Hauer
On Wed, Jun 12, 2019 at 01:35:36PM +0200, Sascha Hauer wrote: > On Wed, Jun 12, 2019 at 10:33:56AM +, Horia Geanta wrote: > > On 6/12/2019 12:40 PM, Sascha Hauer wrote: > > > Hi Horia, > > > > > > On Wed, May 15, 2019 at 01:35:16PM +, Horia Geanta wrote: > > >> For talitos, the problem is

Re: ctr(aes) broken in CAAM driver

2019-06-12 Thread Sascha Hauer
On Wed, Jun 12, 2019 at 10:33:56AM +, Horia Geanta wrote: > On 6/12/2019 12:40 PM, Sascha Hauer wrote: > > Hi Horia, > > > > On Wed, May 15, 2019 at 01:35:16PM +, Horia Geanta wrote: > >> For talitos, the problem is the lack of IV update. > >> > >> For caam, the problem is incorrect IV upd

Re: ctr(aes) broken in CAAM driver

2019-06-12 Thread Horia Geanta
On 6/12/2019 12:40 PM, Sascha Hauer wrote: > Hi Horia, > > On Wed, May 15, 2019 at 01:35:16PM +, Horia Geanta wrote: >> For talitos, the problem is the lack of IV update. >> >> For caam, the problem is incorrect IV update (output IV is equal to last >> ciphertext block, which is correect for c

Re: ctr(aes) broken in CAAM driver

2019-06-12 Thread Sascha Hauer
Hi Horia, On Wed, May 15, 2019 at 01:35:16PM +, Horia Geanta wrote: > For talitos, the problem is the lack of IV update. > > For caam, the problem is incorrect IV update (output IV is equal to last > ciphertext block, which is correect for cbc, but not for ctr mode). > > I am working at a fi

Re: ctr(aes) broken in CAAM driver

2019-05-17 Thread Sascha Hauer
On Wed, May 15, 2019 at 01:35:16PM +, Horia Geanta wrote: > On 5/15/2019 4:22 PM, Sascha Hauer wrote: > > Hi Fabio, > > > > On Wed, May 15, 2019 at 10:17:19AM -0300, Fabio Estevam wrote: > >> Hi Sascha, > >> > >> On Wed, May 15, 2019 at 10:09 AM Sascha Hauer > >> wrote: > >>> > >>> Hi, > >>>

Re: ctr(aes) broken in CAAM driver

2019-05-15 Thread Horia Geanta
On 5/15/2019 4:22 PM, Sascha Hauer wrote: > Hi Fabio, > > On Wed, May 15, 2019 at 10:17:19AM -0300, Fabio Estevam wrote: >> Hi Sascha, >> >> On Wed, May 15, 2019 at 10:09 AM Sascha Hauer wrote: >>> >>> Hi, >>> >>> ctr(aes) is broken in current kernel (v5.1+). It may have been broken >>> for longe

Re: ctr(aes) broken in CAAM driver

2019-05-15 Thread Sascha Hauer
Hi Fabio, On Wed, May 15, 2019 at 10:17:19AM -0300, Fabio Estevam wrote: > Hi Sascha, > > On Wed, May 15, 2019 at 10:09 AM Sascha Hauer wrote: > > > > Hi, > > > > ctr(aes) is broken in current kernel (v5.1+). It may have been broken > > for longer, but the crypto tests now check for a correct ou

Re: ctr(aes) broken in CAAM driver

2019-05-15 Thread Fabio Estevam
Hi Sascha, On Wed, May 15, 2019 at 10:09 AM Sascha Hauer wrote: > > Hi, > > ctr(aes) is broken in current kernel (v5.1+). It may have been broken > for longer, but the crypto tests now check for a correct output IV. The > testmgr answers with: > > alg: skcipher: ctr-aes-caam encryption test faile