RE: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Fernandes, Joel A
Hi Kevin, > have to be created anyway. > > Imagine encrypting a 20M block- this means runtime PM API is called > > 20 * 1024 / 4 =~ 5000 times. The slow down in my opinion doesn't make it > worth it. > > What is your opinion about this? > > OK, I'm not terribly familiar with the crypto API, so I

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Kevin Hilman
er.kernel.org; linux-o...@vger.kernel.org; Mark A. Greer >> Subject: Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt >> operations >> >> Joel A Fernandes writes: >> >> > Calling runtime PM API for every block causes serious perf hit to

RE: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Fernandes, Joel A
Hi Kevin, Thanks for your review. > -Original Message- > From: Kevin Hilman [mailto:khil...@linaro.org] > Sent: Monday, May 13, 2013 11:36 AM > To: Fernandes, Joel A > Cc: linux-crypto@vger.kernel.org; linux-o...@vger.kernel.org; Mark A. Greer > Subject: Re: [PATCH] OMA

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Kevin Hilman
Joel A Fernandes writes: > Calling runtime PM API for every block causes serious perf hit to > crypto operations that are done on a long buffer. > As crypto is performed on a page boundary, encrypting large buffers can > cause a series of crypto operations divided by page. The runtime PM API > is