Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread Ard Biesheuvel
On Tue, 18 Jun 2019 at 06:14, Eric Biggers wrote: > > On Mon, Jun 17, 2019 at 10:09:33AM +0200, Ard Biesheuvel wrote: > > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > > index c23019a3b264..9ea0e71f5c6a 100644 > > --- a/include/linux/tcp.h > > +++ b/include/linux/tcp.h > > @@ -58,12 +58

Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread Eric Biggers
On Mon, Jun 17, 2019 at 10:09:33AM +0200, Ard Biesheuvel wrote: > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index c23019a3b264..9ea0e71f5c6a 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -58,12 +58,7 @@ static inline unsigned int tcp_optlen(const struct sk_buff

Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread Eric Dumazet
On Mon, Jun 17, 2019 at 1:57 PM David Miller wrote: > > From: Eric Dumazet > Date: Mon, 17 Jun 2019 10:00:28 -0700 > > > All our fastopen packetdrill tests pass (after I changed all the cookie > > values in them) > > > > Signed-off-by: Eric Dumazet > > I'm going to apply this to net-next, I wan

Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread David Miller
From: Eric Dumazet Date: Mon, 17 Jun 2019 10:00:28 -0700 > All our fastopen packetdrill tests pass (after I changed all the cookie > values in them) > > Signed-off-by: Eric Dumazet I'm going to apply this to net-next, I want it to sit there for a while. Thanks.

Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread Eric Dumazet
On 6/17/19 1:09 AM, Ard Biesheuvel wrote: > Using a bare block cipher in non-crypto code is almost always a bad idea, > not only for security reasons (and we've seen some examples of this in > the kernel in the past), but also for performance reasons. > > In the TCP fastopen case, we call into

[PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread Ard Biesheuvel
Using a bare block cipher in non-crypto code is almost always a bad idea, not only for security reasons (and we've seen some examples of this in the kernel in the past), but also for performance reasons. In the TCP fastopen case, we call into the bare AES block cipher one or two times (depending o