Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Greg KH
On Mon, Oct 17, 2011 at 12:11:37PM +0300, Kasatkin, Dmitry wrote: > >From Kernel Docbook > > Similar to EXPORT_SYMBOL() except that the > symbols exported by EXPORT_SYMBOL_GPL() can > only be seen by modules with a > MODULE_LICENSE() that specifies a GPL > compatible license.

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread David Howells
James Morris wrote: > > +MPI mpi_alloc(unsigned nlimbs) > > +{ > > + MPI a; > > + > > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL); > > Generally, typedef structs are frowned upon in the kernel. I'd prefer to > see this (and any others) changed to a normal type. In this case, however, it ma

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Kasatkin, Dmitry
On Mon, Oct 17, 2011 at 12:11 PM, Kasatkin, Dmitry wrote: > From Kernel Docbook > >    Similar to EXPORT_SYMBOL() except that the >    symbols exported by EXPORT_SYMBOL_GPL() can >    only be seen by modules with a >    MODULE_LICENSE() that specifies a GPL >    compatible license.  It implies tha

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Kasatkin, Dmitry
>From Kernel Docbook Similar to EXPORT_SYMBOL() except that the symbols exported by EXPORT_SYMBOL_GPL() can only be seen by modules with a MODULE_LICENSE() that specifies a GPL compatible license. It implies that the function is considered an internal implementation issue,

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-14 Thread James Morris
On Fri, 14 Oct 2011, Dmitry Kasatkin wrote: > +MPI mpi_alloc(unsigned nlimbs) > +{ > + MPI a; > + > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL); Generally, typedef structs are frowned upon in the kernel. I'd prefer to see this (and any others) changed to a normal type. Also, kmalloc ret