>From Kernel Docbook
Similar to <function>EXPORT_SYMBOL()</function> except that the
symbols exported by <function>EXPORT_SYMBOL_GPL()</function> can
only be seen by modules with a
<function>MODULE_LICENSE()</function> that specifies a GPL
compatible license. It implies that the function is considered
an internal implementation issue, and not really an interface.
"not really an interface"....
Should it really be EXPORT_SYMBOL_GPL?
- Dmitry
On Sat, Oct 15, 2011 at 3:28 AM, James Morris <[email protected]> wrote:
> On Fri, 14 Oct 2011, Dmitry Kasatkin wrote:
>
>> +MPI mpi_alloc(unsigned nlimbs)
>> +{
>> + MPI a;
>> +
>> + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
>
> Generally, typedef structs are frowned upon in the kernel. I'd prefer to
> see this (and any others) changed to a normal type.
>
> Also, kmalloc return values do not need to be cast, they're void *.
>
>> +EXPORT_SYMBOL(mpi_alloc);
>
> New interfaces should be EXPORT_SYMBOL_GPL.
>
>
> --
> James Morris
> <[email protected]>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
