Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)

2010-04-08 Thread Sebastian Andrzej Siewior
* Herbert Xu | 2010-04-07 17:29:07 [+0800]: >Sebastian, how about precomputing the IV and provide them directly >as a hex array? > >To test arc4_setup_iv itself, you can add an alg_test_arc4 function >(like alg_test_crc32) that tests IV generation specifically. > >Alternatively, just add an alg_te

Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)

2010-04-07 Thread Herbert Xu
On Wed, Apr 07, 2010 at 02:29:53AM -0400, Pavel Roskin wrote: > > Can we avoid those special cases? If the goal is "to make arc4 > compliant with the crypto API", this looks like a step in a wrong > direction. > > The same applies to many other changes in the series. > > I do realize that the or

Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)

2010-04-06 Thread Pavel Roskin
On Sat, 2010-04-03 at 09:49 +0200, Sebastian Andrzej Siewior wrote: > + if (mode == CRYPT_ARC4) > + arc4_setup_iv((struct arc4_iv *)iv, > + template[i].key, template[i].klen); > + else > +

[PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)

2010-04-03 Thread Sebastian Andrzej Siewior
Signed-off-by: Sebastian Andrzej Siewior --- crypto/testmgr.c | 60 +- 1 files changed, 50 insertions(+), 10 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 7620bfc..c471e04 100644 --- a/crypto/testmgr.c +++ b/crypto/testm