Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Gary R Hook
On 6/25/19 8:52 AM, Jonathan Corbet wrote: > On Tue, 25 Jun 2019 13:33:27 + > Gary R Hook wrote: > >>> It's been "valid" since I wrote it...it's just not upstream yet :) I >>> expect it to be in 5.3, though. So the best way to refer to a kernel >>> function, going forward, is just function(

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Jonathan Corbet
On Tue, 25 Jun 2019 13:33:27 + Gary R Hook wrote: > > It's been "valid" since I wrote it...it's just not upstream yet :) I > > expect it to be in 5.3, though. So the best way to refer to a kernel > > function, going forward, is just function() with no markup needed. > > So I'm unclear: >

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Gary R Hook
On 6/24/19 3:37 PM, Jonathan Corbet wrote: > On Mon, 24 Jun 2019 13:29:42 -0700 > Joe Perches wrote: > >>> Finally, would you prefer a v2 of the patch set? Happy to do >>> whatever is preferred, of course. >> >> Whatever Jonathan decides is fine with me. >> Mine was just a plea to avoid unnecessa

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Joe Perches
On Mon, 2019-06-24 at 14:37 -0600, Jonathan Corbet wrote: > On Mon, 24 Jun 2019 13:29:42 -0700 > Joe Perches wrote: > > > > Finally, would you prefer a v2 of the patch set? Happy to do > > > whatever is preferred, of course. > > > > Whatever Jonathan decides is fine with me. > > Mine was just

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Jonathan Corbet
On Mon, 24 Jun 2019 13:29:42 -0700 Joe Perches wrote: > > Finally, would you prefer a v2 of the patch set? Happy to do > > whatever is preferred, of course. > > Whatever Jonathan decides is fine with me. > Mine was just a plea to avoid unnecessarily > making the source text harder to read as >

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Joe Perches
On Mon, 2019-06-24 at 20:06 +, Gary R Hook wrote: Hi Gary. > On 6/24/19 2:30 PM, Joe Perches wrote: > > On Mon, 2019-06-24 at 19:07 +, Hook, Gary wrote: > > > Tidy up the crypto documentation by filling in some variable > > > descriptions, make some grammatical corrections, and enhance >

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Gary R Hook
On 6/24/19 2:30 PM, Joe Perches wrote: > On Mon, 2019-06-24 at 19:07 +, Hook, Gary wrote: >> Tidy up the crypto documentation by filling in some variable >> descriptions, make some grammatical corrections, and enhance >> formatting. > > While this seems generally OK, please try not to make the

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Joe Perches
On Mon, 2019-06-24 at 19:07 +, Hook, Gary wrote: > Tidy up the crypto documentation by filling in some variable > descriptions, make some grammatical corrections, and enhance > formatting. While this seems generally OK, please try not to make the readability of the source _text_ less intelligi

[PATCH 0/3] Clean up crypto documentation

2019-06-24 Thread Hook, Gary
Tidy up the crypto documentation by filling in some variable descriptions, make some grammatical corrections, and enhance formatting. --- Gary R Hook (3): crypto: doc - Add parameter documentation crypto: doc - Describe the crypto engine crypto: doc - Fix formatting of new crypt