Re: [PATCH] crypto: rsa - remove unneeded initializations

2018-04-03 Thread Herbert Xu
On Tue, Apr 03, 2018 at 09:01:02AM +0300, Tudor Ambarus wrote: > > I set the err inside the if branch so that the compiler will > warn me in case of undefined value for err. Like here: > > https://rusty.ozlabs.org/?p=232 Yes but then sometimes the compiler will get it wrong and we will then have

Re: [PATCH] crypto: rsa - remove unneeded initializations

2018-04-02 Thread Tudor Ambarus
On 03/30/2018 08:27 PM, Herbert Xu wrote: On Mon, Mar 26, 2018 at 02:59:06PM +0300, Tudor Ambarus wrote: Remove useless assignment of ret to -ENOMEM in rsa_verify. Remove useless initialization of ret to zero at declaration in rsa_enc/dec/sign/verify. Benefit of the power of undefined values

Re: [PATCH] crypto: rsa - remove unneeded initializations

2018-03-30 Thread Herbert Xu
On Mon, Mar 26, 2018 at 02:59:06PM +0300, Tudor Ambarus wrote: > Remove useless assignment of ret to -ENOMEM in rsa_verify. > Remove useless initialization of ret to zero at declaration in > rsa_enc/dec/sign/verify. > > Benefit of the power of undefined values and set ret in branches in > rsa_enc/

[PATCH] crypto: rsa - remove unneeded initializations

2018-03-26 Thread Tudor Ambarus
Remove useless assignment of ret to -ENOMEM in rsa_verify. Remove useless initialization of ret to zero at declaration in rsa_enc/dec/sign/verify. Benefit of the power of undefined values and set ret in branches in rsa_enc/dec/sign. Reported-by: Benjamin Bales Signed-off-by: Tudor Ambarus ---