On Mon, Mar 26, 2018 at 02:59:06PM +0300, Tudor Ambarus wrote:
> Remove useless assignment of ret to -ENOMEM in rsa_verify.
> Remove useless initialization of ret to zero at declaration in
> rsa_enc/dec/sign/verify.
> 
> Benefit of the power of undefined values and set ret in branches in
> rsa_enc/dec/sign.
> 
> Reported-by: Benjamin Bales <techsupp...@mycode.ai>
> Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com>

The existing code looks fine.  If anything we should move the
assignments out of the if clause.

Thanks,
-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Reply via email to