Re: [PATCH v2 0/6] Fix CAAM hash driver

2015-10-20 Thread Victoria Milhoan
t; + > 1 file changed, 71 insertions(+), 30 deletions(-) > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. Russell, Thanks for putting these patches together. I tested the cont

Re: [PATCH] crypto: caam - Add support for hashing export and import functions

2015-10-17 Thread Victoria Milhoan
On Sat, 17 Oct 2015 10:43:00 +0100 Russell King - ARM Linux wrote: > On Fri, Oct 16, 2015 at 04:19:33PM -0700, Victoria Milhoan wrote: > > @@ -1569,6 +1601,10 @@ static int ahash_import(struct ahash_request *req, > > const void *in) > > struct caam_hash_ctx *ctx = c

[PATCH] crypto: caam - Add support for hashing export and import functions

2015-10-16 Thread Victoria Milhoan
Crypto API. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamhash.c | 82 ++ 1 file changed, 68 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c index 9609f66..bb81ab6 100644 --- a

Re: [PATCH v3 1/5] crypto: ensure algif_hash does not pass a zero-sized state

2015-10-16 Thread Victoria Milhoan
" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Victoria Milhoan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 11/14] ARM: dts: mx6sx: Add CAAM device node

2015-08-06 Thread Victoria Milhoan
Add CAAM device node to the i.MX6SX device tree. Signed-off-by: Victoria Milhoan --- arch/arm/boot/dts/imx6sx.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 708175d..e6223d8 100644 --- a

Re: [PATCH v2 11/14] ARM: dts: mx6sx: Add CAAM device node

2015-08-06 Thread Victoria Milhoan
On Thu, 6 Aug 2015 11:59:34 +0300 Horia Geantă wrote: > On 8/5/2015 9:28 PM, Victoria Milhoan wrote: > > Add CAAM device node to the i.MX6SX device tree. > > > > Signed-off-by: Victoria Milhoan > > --- > > arch/arm/boot/dts/imx6sx.dtsi | 28 +++

[PATCH v2 05/14] crypto: caam - Change kmalloc to kzalloc to avoid residual data

2015-08-05 Thread Victoria Milhoan
. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamalg.c | 12 ++-- drivers/crypto/caam/caamhash.c | 25 - 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam

[PATCH v2 03/14] crypto: caam - Enable and disable clocks on Freescale i.MX platforms

2015-08-05 Thread Victoria Milhoan
ARM-based systems may disable clocking to the CAAM device on the Freescale i.MX platform for power management purposes. This patch enables the required clocks when the CAAM module is initialized and disables the required clocks when the CAAM module is shut down. Signed-off-by: Victoria Milhoan

[PATCH v2 04/14] crypto: caam - Modify Freescale CAAM driver Scatter Gather entry definition

2015-08-05 Thread Victoria Milhoan
Modify the Scatter-Gather entry definitions for the Freescale CAAM driver to include support for both 64- and 32-bit DMA pointers. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/desc.h | 25 + drivers/crypto/caam/sg_sw_sec4.h | 1 - 2 files changed, 21

[PATCH v2 06/14] crypto: caam - Correct DMA unmap size in ahash_update_ctx()

2015-08-05 Thread Victoria Milhoan
80009730>] (do_one_initcall) from [<806dda4c>] (do_init_module+0x5c/0x1a8) [<806dda4c>] (do_init_module) from [<80085308>] (load_module+0x17e0/0x1da0) [<80085308>] (load_module) from [<80085998>] (SyS_init_module+0xd0/0x120) [<80085998>] (SyS_init_module) from

[PATCH v2 07/14] crypto: caam - Use local sg pointers to walk the scatterlist

2015-08-05 Thread Victoria Milhoan
Avoid moving the head of the scatterlist entry by using temporary pointers to walk the scatterlist. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/sg_sw_sec4.h | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/caam/sg_sw_sec4.h

[PATCH v2 10/14] ARM: dts: mx6qdl: Add CAAM device node

2015-08-05 Thread Victoria Milhoan
Add CAAM device node to the i.MX6 device tree. Signed-off-by: Victoria Milhoan --- arch/arm/boot/dts/imx6qdl.dtsi | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index e6d1359

[PATCH v2 01/14] crypto: caam - Add cache coherency support

2015-08-05 Thread Victoria Milhoan
Freescale i.MX6 ARM platforms do not support hardware cache coherency. This patch adds cache coherency support to the CAAM driver. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamhash.c | 2 +- drivers/crypto/caam/caamrng.c | 4 drivers/crypto/caam/jr.c | 18

[PATCH v2 12/14] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig

2015-08-05 Thread Victoria Milhoan
From: Steve Cornelius Allow CAAM to be selected in the kernel for Freescale i.MX devices if ARCH_MXC is enabled. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH v2 14/14] crypto: caam - Detect hardware features during algorithm registration

2015-08-05 Thread Victoria Milhoan
Register only algorithms supported by CAAM hardware, using the CHA version and instantiation registers to identify hardware capabilities. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamalg.c | 68 ++ drivers/crypto/caam/caamhash.c | 38

[PATCH v2 08/14] crypto: caam - Added clocks and clock-names properties to SEC4.0 device tree binding

2015-08-05 Thread Victoria Milhoan
The clocks and clock-names properties describe input clocks that may be required for enablement of CAAM. Signed-off-by: Victoria Milhoan --- Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree

[PATCH v2 09/14] ARM: clk-imx6q: Add CAAM clock support

2015-08-05 Thread Victoria Milhoan
Add CAAM clock support to the i.MX6 clocking infrastructure. Signed-off-by: Victoria Milhoan --- drivers/clk/imx/clk-imx6q.c | 3 +++ include/dt-bindings/clock/imx6qdl-clock.h | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6q.c b

[PATCH v2 13/14] ARM: imx_v6_v7_defconfig: Select CAAM

2015-08-05 Thread Victoria Milhoan
Select CAAM for i.MX6 devices. Signed-off-by: Victoria Milhoan --- arch/arm/configs/imx_v6_v7_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index b47863d..7569b39 100644 --- a/arch/arm

[PATCH v2 02/14] crypto: caam - Add setbits32/clrbits32/clrsetbits primitives for ARM compatibility

2015-08-05 Thread Victoria Milhoan
Add set/clear 32-bit primitives for compatibility with ARM devices since the primitives were previously only defined for the Power architecture. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/ctrl.c | 6 +++--- drivers/crypto/caam/regs.h | 23 +++ 2 files changed

[PATCH v2 00/14] crypto: caam - Add i.MX6 support to the Freescale CAAM driver

2015-08-05 Thread Victoria Milhoan
This patch series adds i.MX6 support to the Freescale CAAM driver. Modifications include: - explicit cache coherency support in the driver - register I/O primitive support - scatter/gather entry modifications - clocking support - i.MX6 device tree support for CAAM - DMA fixes - algorithm registra

[PATCH v2 11/14] ARM: dts: mx6sx: Add CAAM device node

2015-08-05 Thread Victoria Milhoan
Add CAAM device node to the i.MX6SX device tree. Signed-off-by: Victoria Milhoan --- arch/arm/boot/dts/imx6sx.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 708175d..20851cb 100644 --- a

Re: [PATCH 08/12] ARM: clk-imx6q: Add CAAM clock support

2015-07-30 Thread Victoria Milhoan
On Thu, 30 Jul 2015 08:14:11 +0200 Sascha Hauer wrote: > On Wed, Jul 29, 2015 at 08:58:25PM -0700, Victoria Milhoan wrote: > > Add CAAM clock support to the i.MX6 clocking infrastructure. > > > > Signed-off-by: Victoria Milhoan > > --- > > drivers/clk/

Re: [PATCH 03/12] crypto: caam - Enable and disable clocks on Freescale i.MX platforms

2015-07-30 Thread Victoria Milhoan
Hi Sascha, Thank you for the responses. Comments inline. Changes will be in the next version of the patch set. -Victoria On Thu, 30 Jul 2015 08:02:14 +0200 Sascha Hauer wrote: > Hi Victoria, > > comments inline. > > On Wed, Jul 29, 2015 at 08:58:20PM -0700, Victoria Milhoan

[PATCH 04/12] crypto: caam - Modify Freescale CAAM driver Scatter Gather entry definition

2015-07-29 Thread Victoria Milhoan
Modify the Scatter-Gather entry definitions for the Freescale CAAM driver to include support for both 64- and 32-bit DMA pointers. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/desc.h | 25 + drivers/crypto/caam/sg_sw_sec4.h | 1 - 2 files changed, 21

[PATCH 08/12] ARM: clk-imx6q: Add CAAM clock support

2015-07-29 Thread Victoria Milhoan
Add CAAM clock support to the i.MX6 clocking infrastructure. Signed-off-by: Victoria Milhoan --- drivers/clk/imx/clk-imx6q.c | 3 +++ include/dt-bindings/clock/imx6qdl-clock.h | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6q.c b

[PATCH 03/12] crypto: caam - Enable and disable clocks on Freescale i.MX platforms

2015-07-29 Thread Victoria Milhoan
ARM-based systems may disable clocking to the CAAM device on the Freescale i.MX platform for power management purposes. This patch enables the required clocks when the CAAM module is initialized and disables the required clocks when the CAAM module is shut down. Signed-off-by: Victoria Milhoan

[PATCH 10/12] ARM: dts: mx6sx: Add CAAM device node

2015-07-29 Thread Victoria Milhoan
Add CAAM device node to the i.MX6SX device tree. Signed-off-by: Victoria Milhoan --- arch/arm/boot/dts/imx6sx.dtsi | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 708175d..c73cee4 100644 --- a

[PATCH 05/12] crypto: caam - Change kmalloc to kzalloc to avoid residual data

2015-07-29 Thread Victoria Milhoan
. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamalg.c | 20 ++-- drivers/crypto/caam/caamhash.c | 25 - 2 files changed, 22 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto

[PATCH 07/12] crypto: caam - Use local sg pointers to walk the scatterlist

2015-07-29 Thread Victoria Milhoan
Avoid moving the head of the scatterlist entry by using temporary pointers to walk the scatterlist. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/sg_sw_sec4.h | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/caam/sg_sw_sec4.h

[PATCH 09/12] ARM: dts: mx6qdl: Add CAAM device node

2015-07-29 Thread Victoria Milhoan
Add CAAM device node to the i.MX6 device tree. Signed-off-by: Victoria Milhoan --- arch/arm/boot/dts/imx6qdl.dtsi | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index e6d1359

[PATCH 00/12] crypto: caam - Add i.MX6 support to the Freescale CAAM driver

2015-07-29 Thread Victoria Milhoan
This patch series adds i.MX6 support to the Freescale CAAM driver. Modifications include: - explicit cache coherency support in the driver - register I/O primitive support - scatter/gather entry modifications - clocking support - i.MX6 device tree support for CAAM - DMA fixes These patches have

[PATCH 01/12] crypto: caam - Add cache coherency support

2015-07-29 Thread Victoria Milhoan
Freescale i.MX6 ARM platforms do not support hardware cache coherency. This patch adds cache coherency support to the CAAM driver. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamhash.c | 2 +- drivers/crypto/caam/caamrng.c | 4 drivers/crypto/caam/jr.c | 18

[PATCH 12/12] ARM: imx_v6_v7_defconfig: Select CAAM

2015-07-29 Thread Victoria Milhoan
Select CAAM for i.MX6 devices. Signed-off-by: Victoria Milhoan --- arch/arm/configs/imx_v6_v7_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index b47863d..7569b39 100644 --- a/arch/arm

[PATCH 02/12] crypto: caam - Add setbits32/clrbits32/clrsetbits primitives for ARM compatibility

2015-07-29 Thread Victoria Milhoan
Add set/clear 32-bit primitives for compatibility with ARM devices since the primitives were previously only defined for the Power architecture. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/ctrl.c | 6 +++--- drivers/crypto/caam/regs.h | 23 +++ 2 files changed

[PATCH 06/12] crypto: caam - Correct DMA unmap size in ahash_update_ctx()

2015-07-29 Thread Victoria Milhoan
80009730>] (do_one_initcall) from [<806dda4c>] (do_init_module+0x5c/0x1a8) [<806dda4c>] (do_init_module) from [<80085308>] (load_module+0x17e0/0x1da0) [<80085308>] (load_module) from [<80085998>] (SyS_init_module+0xd0/0x120) [<80085998>] (SyS_init_module) from

[PATCH 11/12] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig

2015-07-29 Thread Victoria Milhoan
From: Steve Cornelius Allow CAAM to be selected in the kernel for Freescale i.MX devices if ARCH_MXC is enabled. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto

Re: [PATCH] crypto: caam - fix non-64-bit write/read access

2015-06-17 Thread Victoria Milhoan
On Tue, 16 Jun 2015 12:59:07 +0200 Steffen Trumtrar wrote: > The patch > > crypto: caam - Add definition of rd/wr_reg64 for little endian platform > > added support for little endian platforms to the CAAM driver. Namely a > write and read function for 64 bit registers. > The only user of

RE: [BUG?] crypto: caam: little/big endianness on ARM vs PPC

2015-06-16 Thread Victoria Milhoan
have a series of patches in Freescale's 3.14 git repository. Have you updated those for mainline and published them for review and inclusion in the upstream kernel? If yes to any could you post a link? -Jon On Tue, Jun 16, 2015 at 5:27 AM, Victoria Milhoan wrote: > All, > >

RE: [BUG?] crypto: caam: little/big endianness on ARM vs PPC

2015-06-15 Thread Victoria Milhoan
All, Freescale has been adding i.MX6 support to the CAAM driver and testing on both i.MX6 and QorIQ platforms. The patch series is now available for review. Your feedback for the provided patches is appreciated. Thanks, Victoria -Original Message- From: linux-crypto-ow...@vger.kernel.o

[PATCH RFC 02/11] crypto: caam - Add register I/O primitives for ARM compatibility

2015-06-15 Thread Victoria Milhoan
accomodate __BIG_ENDIAN and __LITTLE_ENDIAN changes] Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/regs.h | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h index 378ddc1..9cca14e 100644 --- a

[PATCH RFC 05/11] crypto: caam - Add cache coherency support to Freescale CAAM scatterlist implementation

2015-06-15 Thread Victoria Milhoan
Add cache coherency support to the CAAM scatterlist implementation. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/sg_sw_sec4.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/caam/sg_sw_sec4.h b/drivers/crypto/caam/sg_sw_sec4.h index

[PATCH RFC 01/11] crypto: caam - Add cache coherency support

2015-06-15 Thread Victoria Milhoan
Freescale i.MX6 ARM platforms do not support hardware cache coherency. This patch adds cache coherency support to the CAAM driver. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamhash.c | 28 +-- drivers/crypto/caam/caamrng.c| 10 +- drivers

[PATCH RFC 03/11] crypto: caam - Enable and disable clocks on Freescale i.MX platforms

2015-06-15 Thread Victoria Milhoan
ARM-based systems may disable clocking to the CAAM device on the Freescale i.MX platform for power management purposes. This patch enables the required clocks when the CAAM module is initialized and disables the required clocks when the CAAM module is shut down. Signed-off-by: Victoria Milhoan

[PATCH RFC 06/11] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig

2015-06-15 Thread Victoria Milhoan
From: Steve Cornelius Allow CAAM to be selected in the kernel for Freescale i.MX6 devices if ARCH_MXC is enabled. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH RFC 09/11] crypto: caam - Fix incorrect size when DMA unmapping buffer

2015-06-15 Thread Victoria Milhoan
The CAAM driver uses two data buffers to store data for a hashing operation, with one buffer defined as active. This change forces switching of the active buffer when executing a hashing operation to avoid a later DMA unmap using the length of the opposite buffer. Signed-off-by: Victoria Milhoan

[PATCH RFC 00/11] crypto: caam - Add i.MX6 support to the Freescale CAAM driver

2015-06-15 Thread Victoria Milhoan
This patch series adds i.MX6 support to the Freescale CAAM driver. Please use these patches with the understanding that changes may occur. The patches are provided for review at this time, in order to incur comments for permanent inclusion. Modifications include: - explicit cache coherency suppo

[PATCH RFC 10/11] crypto: caam - Provide correct value to iounmap() in controller driver

2015-06-15 Thread Victoria Milhoan
Fix a "Trying to vfree() nonexistent vm area" error when unloading the CAAM controller module by providing the correct pointer value to iounmap(). Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH RFC 07/11] crypto: caam - Unmap data prior to displaying data in print statements

2015-06-15 Thread Victoria Milhoan
Move the dma unmap calls for data to occur before printing the data in debug print statements. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamalg.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto

[PATCH RFC 11/11] crypto: caam - fix RNG buffer cache alignment

2015-06-15 Thread Victoria Milhoan
ffers themselves require this. However, a fix would incur the expense of error-handling bloat in the case of allocation failure. Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamrng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/c

[PATCH RFC 04/11] crypto: caam - Modify Freescale CAAM driver Scatter Gather entry definition

2015-06-15 Thread Victoria Milhoan
Modify the Scatter-Gather entry definitions for the Freescale CAAM driver. Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/desc.h | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h index

[PATCH RFC 08/11] crypto: caam - improve initalization for context state saves

2015-06-15 Thread Victoria Milhoan
[<80040a40>] (kernel_thread_exit+0x0/0x8) Code: e59f0010 e1a01003 eb126a8d e3a03000 (e5833000) ---[ end trace d52a403a1d1eaa86 ]--- Signed-off-by: Steve Cornelius Signed-off-by: Victoria Milhoan --- drivers/crypto/caam/caamhash.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv