Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST

On Mon, Nov 25, 2013 at 7:36 AM, Shawn Landden wrote: > Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) > added an internal flag MSG_SENDPAGE_NOTLAST, similar to > MSG_MORE. > > algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages() > and n

[PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST

: also fix udp Cc: Tom Herbert Cc: Eric Dumazet Cc: David S. Miller Cc: # 3.4.x + 3.2.x Reported-and-tested-by: Shawn Landden Original-patch: Richard Weinberger Signed-off-by: Shawn Landden --- crypto/algif_hash.c | 3 +++ crypto/algif_skcipher.c | 3 +++ net/ipv4/udp.c | 3

[PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST

Herbert Cc: Eric Dumazet Cc: David S. Miller Cc: # 3.4.x + 3.2.x Reported-and-tested-by: Shawn Landden Original-patch: Richard Weinberger Signed-off-by: Shawn Landden --- crypto/algif_hash.c | 3 +++ crypto/algif_skcipher.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/crypto

[PATCH] Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE.

algif_hash and algif_skcipher used MSG_MORE from tcp_sendpages() and need to see the new flag as identical to MSG_MORE. This fixes sendfile() on AF_ALG. Cc: Tom Herbert Cc: Eric Dumazet Cc: David S. Miller Cc: # 3.4.x + 3.2.x Reported-and-tested-by: Shawn Landden Original-patch: Richard

Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST

is also set if we set MSG_SENDPAGE_NOTLAST. >> Otherwise users that check against MSG_MORE will not see it. >> >> This fixes sendfile() on AF_ALG. >> >> Cc: Tom Herbert >> Cc: Eric Dumazet >> Cc: David S. Miller >> Cc: # 3.4.x >> Reported-and-te

Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST

heck against MSG_MORE will not see it. > > This fixes sendfile() on AF_ALG. > > Cc: Tom Herbert > Cc: Eric Dumazet > Cc: David S. Miller > Cc: # 3.4.x The offending commit also got backported to the 3.2 stable kernel, so we need this fix there as well. --- Shawn Landden +1 3

Re: AF_ALG buggy with sendfile

@debian-T61:~/git/test$ ./connman_afalg /bin/true send 27080 bytes recv 20 bytes 45384483cf9cd0d82eba164131795b4807c6d39d /bin/true shawn@debian-T61:~/git/test$ sha1sum /bin/true 82667ba2ec681d8e55b0ee3b6db2970f9911680d /bin/true On Sun, Nov 24, 2013 at 2:00 PM, Shawn Landden wrote: > here

Re: AF_ALG buggy with sendfile

heres a version of the test case that builds. Sorry about that. On Sun, Nov 24, 2013 at 9:21 AM, Shawn Landden wrote: > If I use sendfile() to send to a accept()ed AF_ALG socket set up for > "hash", I get the wrong > answer, if I read() and then write() I get the right an

AF_ALG buggy with sendfile

If I use sendfile() to send to a accept()ed AF_ALG socket set up for "hash", I get the wrong answer, if I read() and then write() I get the right answer. None of the system calls return an error. test case attached. -- --- Shawn Landden +1 360 389 3001 (SMS preferred) #include