Removing myself as I'm not longer following QAT development.
Signed-off-by: Salvatore Benedetto
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92df4e8..1171da1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11009,7 +11009,6 @@ F: dr
Make sure CRYPTO_ALG_DEAD bit is cleared before proceeding with
the algorithm registration. This fixes qat-dh registration when
driver is restarted
Signed-off-by: Salvatore Benedetto
---
crypto/algapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/algapi.c b/crypto/algapi.c
index
Make sure CRYPTO_ALG_DEAD is not set when preparing for
alg registration. This fixes qat-dh registration that occurs
when reloading qat_c62x module.
Signed-off-by: Salvatore Benedetto
---
crypto/kpp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/kpp.c b/crypto/kpp.c
index d36ce05
g the structure with akcipher_request_alloc.
Software akcipher implementation is working only because it is
synchronous and it does not use a request context.
Signed-off-by: Salvatore Benedetto
---
crypto/rsa-pkcs1pad.c | 75 ++-
1 file change
There is not need to drop leading zeros from the RSA output
operations results.
Signed-off-by: Salvatore Benedetto
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c
b/drivers
Add DH support under kpp api. Drop struct qat_rsa_request and
introduce a more generic struct qat_asym_request and share it
between RSA and DH requests.
Signed-off-by: Salvatore Benedetto
---
drivers/crypto/qat/Kconfig| 1 +
drivers/crypto/qat/qat_common/qat_asym_algs.c
Extend qat driver to use RSA CRT mode when all CRT related components are
present in the private key. Simplify code in qat_rsa_setkey by adding
qat_rsa_clear_ctx.
Signed-off-by: Salvatore Benedetto
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 234 +++---
1 file
Key generated with openssl. It also contains all fields required
for testing CRT mode
Signed-off-by: Salvatore Benedetto
---
crypto/testmgr.h | 200 ++-
1 file changed, 199 insertions(+), 1 deletion(-)
diff --git a/crypto/testmgr.h b/crypto
When parsing a private key, store all non-optional fields. These
are required for enabling CRT mode for decrypt and verify
Signed-off-by: Salvatore Benedetto
---
crypto/rsa_helper.c | 75 +++
crypto/rsaprivkey.asn1| 10 +++---
include
Hi Herbert,
this patchset add CRT mode to qat driver.
First patch extend the parsing of the private key so that all required CRT
fields are saved. Second patch add a 4K test key. Third patch extend qat
to use CRT. This latest patch is based on my patch that drop asn1 from qat
driver.
Salvatore
Report correct error in case of failure
Signed-off-by: Salvatore Benedetto
---
crypto/testmgr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 8ea0d3f..769cc2a 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -1941,6 +1941,7 @@ static int
Drop all asn1 related code and use the new rsa_helper
functions rsa_parse_[pub|priv]_key for parsing the key
Signed-off-by: Salvatore Benedetto
---
changes from v1:
- Remove testmgr unrelated changes
- Rebased on latest cryptodev-2.6
drivers/crypto/qat/Kconfig| 2
Drop all asn1 related code in qat and use the new rsa_helper
functions rsa_parse_[pub|priv]_key for parsing the key
Signed-off-by: Salvatore Benedetto
---
crypto/testmgr.c | 1 +
drivers/crypto/qat/Kconfig| 2 +-
drivers/crypto/qat
* Convert both smp and selftest to new crypto kpp API
* Remove module ecc as not more required
* Add ecdh_helper functions for wrapping kpp async calls
Signed-off-by: Salvatore Benedetto
---
Patch is based on
http://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
Tested
On Fri, Jun 24, 2016 at 07:23:16AM +0100, Herbert Xu wrote:
> On Fri, Jun 24, 2016 at 02:10:12PM +0800, Herbert Xu wrote:
> > On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote:
> > >
> > > can you squash the following patch?
> >
> > No,
On Fri, Jun 24, 2016 at 02:10:12PM +0800, Herbert Xu wrote:
> On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote:
> >
> > can you squash the following patch?
>
> No, please prune anything that we don't use from ecc.c.
We do use the symbol in question,
--
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Herbert,
can you squash the following patch?
Thanks,
Salvatore
---8<---
Rename ecdh_shared_secret
Signed-off-by: Salvatore
in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH software support
*** BLURB HERE ***
Salvatore Benedetto (3):
crypto: Key-agreement Protocol
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |4 +
crypto/ecc.c| 1018
generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto/Makefile | 1
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 4 +
crypto/dh.c | 189 ++
crypto/dh_helper.c | 95
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 4 +
crypto/dh.c | 189 ++
crypto/dh_helper.c
generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto/Makefile | 1
already present in net/bluetooth and extended it in order to select
different curves at runtime. Code for P192 was taken from tinycrypt.
Changes from v1:
* Change check in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |4 +
crypto/ecc.c| 1018
generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto/Makefile | 1
curves at runtime. Code for P192 was taken from tinycrypt.
Changes from v1:
* Change check in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |4 +
crypto/ecc.c| 1018
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 4 +
crypto/dh.c | 189 ++
crypto/dh_helper.c
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1018
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 189 +++
crypto/testmgr.c
generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto/Makefile | 1
module
already present in net/bluetooth and extended it in order to select
different curves at runtime. Code for P192 was taken from tinycrypt.
Changes from v1:
* Change check in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol
On Wed, Jun 08, 2016 at 10:54:51AM +0800, Herbert Xu wrote:
> On Thu, Jun 02, 2016 at 12:06:48PM +, Benedetto, Salvatore wrote:
> >
> > Off the top of my head, with ECDH when the user gets a EGAIN, he wants
> > to reset the secret key only, not the params.
>
> I don't see any performance benef
* Convert both smp and selftest to crypto kpp API
* Remove module ecc as not more required
* Add ecdh_helper functions for wrapping kpp async calls
Signed-off-by: Salvatore Benedetto
---
Patch based on https://patchwork.kernel.org/patch/9145037/
Changes from v3:
* Patch adjusted to minor
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1011
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 223
crypto/testmgr.c
tinycrypt.
Changes from v1:
* Change check in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH software support
crypto/Kconfig | 23
* Convert both smp and selftest to crypto kpp API
* Remove module ecc as not more required
* Add ecdh_helper functions for wrapping kpp async calls
Signed-off-by: Salvatore Benedetto
---
Patch based on https://patchwork.kernel.org/patch/9065591/
Changes from v2:
* Remove header guard in
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1016
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 224
crypto/testmgr.c
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
.
Changes from v1:
* Change check in dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH software support
crypto/Kconfig | 23
times out. Same behavior is observed without this patch though.
This patch is based on https://patchwork.kernel.org/patch/9050061/
Signed-off-by: Salvatore Benedetto
---
net/bluetooth/Makefile | 2 +-
net/bluetooth/ecc.c | 816
net
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1016
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 224
crypto/testmgr.c
dh_check_params_length based on Stephan review
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH software support
crypto/Kconfig | 23 +
crypto/Makefile |6 +
crypto
This patch has *not* been tested as I don't have the hardware.
It's purpose is to show how to use the kpp API.
Based on https://patchwork.kernel.org/patch/9022371/
Signed-off-by: Salvatore Benedetto
---
v2: Also convert ecc_make_key to kpp API
net/bluetooth/s
This patch has *not* been tested as I don't have the hardware.
It's purpose is to show how to use the kpp API.
Based on https://patchwork.kernel.org/patch/9022371/
Signed-off-by: Salvatore Benedetto
---
net/bluetooth/smp.c | 99 +++
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1038
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 224
crypto/testmgr.c
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
:
* Move curve ID definition to public header ecdh.h as users need to
have access to those ids when selecting the curve
Salvatore Benedetto (3):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto: kpp - Add ECDH software support
crypto
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 224
crypto/testmgr.c
* Implement ECDH under kpp API
* Provide ECC software support for curve P-192 and
P-256.
* Add kpp test for ECDH with data generated by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig |5 +
crypto/Makefile |3 +
crypto/ecc.c| 1037
dh_check_params_length based on Stephan review
Changed from v2:
* Add support for ECDH (curve P192 and P256). I reused the ecc module
already present in net/bluetooth and extended it in order to select
different curves at runtime. Code for P192 was taken from tinycrypt.
Salvatore Benedetto (3
* Implement MPI based Diffie-Hellman under kpp API
* Test provided uses data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 224
crypto/testmgr.c
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
dh_check_params_length based on Stephan review
Salvatore Benedetto (2):
crypto: Key-agreement Protocol Primitives API (KPP)
crypto: kpp - Add DH software implementation
crypto/Kconfig | 18 +++
crypto/Makefile | 3 +
crypto/crypto_user.c| 20
Hi Herb,
the following patchset introduces a new API for abstracting
key-agreement protocols such as DH and ECDH. It provides the primitives
required for implementing the protocol, thus the name KPP (Key-agreement
Protocol Primitives).
Regards,
Salvatore
Salvatore Benedetto (2):
crypto: Key
* Implement MPI based Diffie-Hellman under kpp API
* Add test with data generad by OpenSSL
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 8 ++
crypto/Makefile | 2 +
crypto/dh.c | 233
crypto/testmgr.c
()
* generate_secret() - It generates the shared secret for the session
Other functions such as init() and exit() are provided for allowing
cryptographic hardware to be inizialized properly before use
Signed-off-by: Salvatore Benedetto
---
crypto/Kconfig | 10 ++
crypto
-off-by: Salvatore Benedetto
---
Changes in V2:
* Use dh_get_params where required
* Use key lengths defined in RFC3526
* Set fips_allowed=1 for the test
crypto/Kconfig| 8 ++
crypto/Makefile | 7 ++
crypto/dh.c | 264
On Tue, Mar 01, 2016 at 12:17:15PM +0100, Stephan Mueller wrote:
Hi Stephan,
> Am Dienstag, 1. März 2016, 11:08:34 schrieb Salvatore Benedetto:
>
> Hi Salvatore,
>
> > > > +static int dh_check_params_length(unsigned int p_len)
> > > > +{
> > > &g
s g^xa mod p
> > 4) Call encrypt() by passing the counter part public key (yb) in raw format
> > as input to get back the shared secret calculated as zz = yb^xa mod p
> >
> > A test is included in the patch. Test vector has been generated with
> > openssl
> >
Hi Stephan,
thanks for reviewing.
On Mon, Feb 15, 2016 at 02:57:08PM +0100, Stephan Mueller wrote:
> Am Montag, 15. Februar 2016, 09:01:55 schrieb Salvatore Benedetto:
>
> Hi Salvatore, Herbert,
>
> > Implement Diffie-Hellman primitives required by the scheme under the
>
-off-by: Salvatore Benedetto
---
crypto/Kconfig| 8 ++
crypto/Makefile | 7 ++
crypto/dh.c | 264 ++
crypto/pkcs3.asn1 | 5 ++
crypto/tcrypt.c | 4 +
crypto/testmgr.c | 140 +++--
crypto/testmgr.h
Signed-off-by: Salvatore Benedetto
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c
b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 51c594f..54e386e 100644
--- a/drivers
- ent->device is already checked at the beginning of the function
against the same value. This check is a duplicate.
Signed-off-by: Salvatore Benedetto
---
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 8 +---
drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 +
2 files changed
72 matches
Mail list logo
