[PATCH] crypto: inside-secure - Add support for EIP197 with output classifier

2020-09-11 Thread Pascal van Leeuwen
(using what is formally a debug feature). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 44 ++--- drivers/crypto/inside-secure/safexcel.h | 13 ++ 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/inside

[PATCH] crypto: inside-secure - Prevent missing of processing errors

2020-09-08 Thread Pascal van Leeuwen
want to prevent it from being a possibility at all. So initialize all error bits to error state, so that reading stale status information will always result in errors. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_ring.c | 9 + 1 file changed, 5 insertions

[PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems

2020-09-07 Thread Pascal van Leeuwen
aligned boundary. Also ensuring that the last cacheline of the last buffer is not shared (by overallocating). This was tested by the customer to solve their coherence problems. It was also tested by me on a VCU118 board w/ EIP-197c and Macchiatobin. Signed-off-by: Pascal van Leeuwen --- drivers

RE: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3

2019-10-22 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Tuesday, October 22, 2019 6:17 PM > To: Pascal Van Leeuwen > Cc: Herbert Xu ; David S. Miller > ; Antoine > Tenart ; Ard Biesheuvel > ; Pascal van > Leeuwen ; linux-crypto@vger.kernel.org; > linux-ker...

RE: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3

2019-10-22 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Tuesday, October 22, 2019 4:29 PM > To: Herbert Xu ; David S. Miller > > Cc: Arnd Bergmann ; Antoine Tenart > ; Pascal Van > Leeuwen ; Ard Biesheuvel > ; Pascal van > Leeuwen ; linux-crypto

[PATCH] crypto: inside-secure - Fixed warnings on inconsistent byte order handling

2019-10-22 Thread Pascal van Leeuwen
This fixes a bunch of endianness related sparse warnings reported by the kbuild test robot as well as Ben Dooks. Credits for the fix to safexcel.c go to Ben Dooks. Reported-by: kbuild test robot Reported-by: Ben Dooks Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 9:47 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 21:14, Pas

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 6:15 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 17:55, Pas

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 5:32 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > p[ > > On Mon, 21 Oct 2019 at 17:2

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 2:54 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 14:40, Pas

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 1:59 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 12:56, Pascal Van Leeuwen &

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 2:12 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 14:08, Pascal Van Leeuwen &

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
27;ll probably still have to swap the bytes within words to get those into the correct order towards the HW. Which is not very convenient for fields crossing byte boundaries. (I'd probably want to use the byte swapping facilities of my HW for that and not the CPU) Regards, Pascal van Leeuwen Si

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
but that would require touching a lot of legacy code (unless I use a C11 anonymous union ... not sure if that would be allowed?) and IMHO is a bit silly. Is there some way of telling sparse to _not_ check for "correct" use of these functions for a certain variable? Regards, Pascal van Lee

RE: [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Pascal Van Leeuwen > Sent: Thursday, October 17, 2019 9:46 PM > To: 'Ben Dooks (Codethink)' ; > 'linux-ker...@lists.codethink.co.uk' > > Cc: 'Antoine Tenart' ; 'Herbert Xu' > ; > 'Davi

Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
he byte order of this key data is _CPU byte order_ or always some _fixed byte order_ (e.g. as per algorithm specification). I know I have some customers using big-endian CPU's, so I do care, but I unfortunately don't have any platform available to test this with. Regards, Pascal van

RE: [PATCH] crypto: fix safexcel_hash warning PTR_ERR_OR_ZERO can be used

2019-10-21 Thread Pascal Van Leeuwen
turn PTR_ERR_OR_ZERO(ctx->kaes); > } Thanks for spotting, but a similar patch has already been applied. So this patch is obsolete now. > > static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm) > -- > 2.7.4 Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware

2019-10-17 Thread Pascal Van Leeuwen
> -Original Message- > From: Pascal Van Leeuwen > Sent: Thursday, October 17, 2019 7:14 PM > To: 'Ben Dooks (Codethink)' ; linux- > ker...@lists.codethink.co.uk > Cc: Antoine Tenart ; Herbert Xu > ; David S. Miller ; linux- > cry...@vger.kernel.org; linu

RE: [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware

2019-10-17 Thread Pascal Van Leeuwen
firmware */ > - for (i = 0; i < fw->size / sizeof(u32); i++) > + for (i = 0; i < fw->size / sizeof(__be32); i++) > writel(be32_to_cpu(data[i]), > -priv->base + EIP197_CLASSIFICATION_RAMS + i * > sizeof(u32)); > +

RE: [PATCH] crypto: inside-secure - fix unexported warnings

2019-10-17 Thread Pascal Van Leeuwen
int ofreg_rc = -EINVAL; /* Default safe value */ > #endif > > static int __init safexcel_init(void) > -- > 2.23.0 Actually those variables have already disappeared from the cryptodev tree due to an earlier patch by Arnd. So this patch won't apply anyway. I'll see if I can spin a patch that makes safexcel_pci_remove static. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

[PATCH] crypto: inside-secure - Made locally used safexcel_pci_remove() static

2019-10-17 Thread Pascal van Leeuwen
safexcel_pci_remove() is only used locally in the module and not exported, so added a static function specifier. This fixes a sparse issue reported by Ben Dooks. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] crypto: inside-secure - Fix build error with CONFIG_CRYPTO_SM3=m

2019-10-17 Thread Pascal van Leeuwen
Always take the zero length hash value for SM3 from the local constant to avoid a reported build error when SM3 is configured to be a module. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_hash.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

RE: [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c

2019-10-17 Thread Pascal Van Leeuwen
t CRYPTO_CHACHA20POLY1305 > select CRYPTO_SHA3 > + select CRYPTO_SM3 > help > This driver interfaces with the SafeXcel EIP-97 and EIP-197 > cryptographic > engines designed by Inside Secure. It currently accelerates DES, 3DES > and > I'

RE: [PATCH -next] crypto: inside-secure - Fix randbuild error

2019-10-17 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Tuesday, October 8, 2019 9:57 AM > To: Ard Biesheuvel > Cc: YueHaibing ; herb...@gondor.apana.org.au; > da...@davemloft.net; > pascalv...@gmail.com;

RE: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-17 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Thursday, October 17, 2019 3:48 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Herbert Xu > ; > David S. Miller ; Bjorn Helgaas ; > Pascal van Leeuwen > ; Kelsey Skunberg ; linux- > cry

RE: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks

2019-10-17 Thread Pascal Van Leeuwen
Miller ; Bjorn Helgaas > Cc: Arnd Bergmann ; Pascal Van Leeuwen > ; Pascal van > Leeuwen ; Kelsey Skunberg ; > linux- > cry...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-...@vger.kernel.org > Subject: [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks >

RE: [PATCH -next] crypto: Use PTR_ERR_OR_ZERO in safexcel_xcbcmac_cra_init()

2019-10-09 Thread Pascal Van Leeuwen
Subject: [PATCH -next] crypto: Use PTR_ERR_OR_ZERO in > safexcel_xcbcmac_cra_init() > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: YueHaibing > Acked-by: Pascal van Leeuwen > --- > drivers/crypto/inside-secure/safexcel_hash.c |

RE: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-09 Thread Pascal Van Leeuwen
here? It is also FIPS > compliant and has less latency than TPM RNG. :-) If we go with this > route, lets pick the HRNG that performs best. > There's certification and certification. Not all certificates are created equally. But if it matches your specific requirements, why not. There's a _lot_ of HW out there that's not x86 though ... And: is RDRAND certified for _all_ x86 processors? Or just Intel? Or perhaps even only _specific (server) models_ of CPU's? I also know for a fact that some older AMD processors had a broken RDRAND implementation ... So the choice really should be up to the application or user. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-09 Thread Pascal Van Leeuwen
d, but would Joe Random User?) > Please remember that a trusted key is not a TPM key. The reality > distortion field is strong here it seems. > Agree. But you should not mess with the possibility to generate keys based on _just_ the TPM RNG _where that is required_ (and perhaps _only_ where that is required, if possible) > /Jarkko Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-09 Thread Pascal Van Leeuwen
existing_ use cases. Having said all that, generating _true_ entropy (and, importantly, ensuring it cannot be manipulated) is a very complicated subject and considering how all encryption security ultimately depends on the quality of the random numbers used for key material, I would not trust a

RE: [PATCH][V2][next] crypto: inside-secure: fix spelling mistake "algorithmn" -> "algorithm"

2019-10-08 Thread Pascal Van Leeuwen
t u8 *key, > goto badkey; > break; > default: > - dev_err(priv->dev, "aead: unsupported hash algorithmn"); > + dev_err(priv->dev, "aead: unsupported hash algorithm\n"); > goto bad

RE: [PATCH][next] crypto: inside-secure: fix spelling mistake "algorithmn" -> "algorithm"

2019-10-08 Thread Pascal Van Leeuwen
> -Original Message- > From: Joe Perches > Sent: Tuesday, October 8, 2019 10:29 AM > To: Pascal Van Leeuwen ; Colin King > ; > Antoine Tenart ; Herbert Xu > ; David S . > Miller ; linux-crypto@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-ker..

RE: [PATCH][next] crypto: inside-secure: fix spelling mistake "algorithmn" -> "algorithm"

2019-10-08 Thread Pascal Van Leeuwen
otted, but the fix is not correct. What actually happened here is that a \ got accidentally deleted, there should have been a "\n" at the end of the line ... Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCH -next] crypto: inside-secure - Fix randbuild error

2019-10-08 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, October 8, 2019 9:35 AM > To: Pascal Van Leeuwen > Cc: YueHaibing ; herb...@gondor.apana.org.au; > da...@davemloft.net; > pascalv...@gmail.com; antoine.ten...@bootlin.com; > linux-crypto@vger.

RE: [PATCH -next] crypto: inside-secure - Fix randbuild error

2019-10-08 Thread Pascal Van Leeuwen
ed by Inside Secure. It currently accelerates DES, 3DES > and > -- > 2.7.4 > But ... I don't really want to build SM3 into the kernel for all Inside Secure drivers, since in the majority of cases, the HW will not actually support SM3 and I don't want to bloat the kernel imag

RE: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Monday, September 30, 2019 10:12 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Herbert Xu > ; > David S. Miller ; Pascal van Leeuwen > ; Ard > Biesheuvel ; Eric Biggers ; > linux- >

RE: [PATCH 1/3] crypto: inside-secure - Fix a maybe-uninitialized warning

2019-09-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Monday, September 30, 2019 2:15 PM > To: Antoine Tenart ; Herbert Xu > ; > David S. Miller > Cc: Arnd Bergmann ; Pascal Van Leeuwen > ; Pascal van > Leeuwen ; linux-crypto@vger.kernel.org; > linux-ke

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-30 Thread Pascal Van Leeuwen
> -Original Message > From: Linus Torvalds > Sent: Friday, September 27, 2019 6:24 PM > To: Pascal Van Leeuwen > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; Linux ARM ; > Herbert Xu > ; David Miller ; Greg KH > ; Jason A

RE: [PATCH 2/3] crypto: inside-secure - Reduce stack usage

2019-09-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Monday, September 30, 2019 2:15 PM > To: Antoine Tenart ; Herbert Xu > ; > David S. Miller > Cc: Arnd Bergmann ; Pascal Van Leeuwen > ; Pascal > van Leeuwen ; Ard Biesheuvel > ; Eric Biggers > ; linux

RE: chapoly acceleration hardware [Was: Re: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API]

2019-09-27 Thread Pascal Van Leeuwen
> -Original Message- > From: Dave Taht > Sent: Friday, September 27, 2019 1:14 AM > To: Pascal Van Leeuwen > Cc: Jason A. Donenfeld ; Ard Biesheuvel > ; > Linux Crypto Mailing List ; linux-arm-kernel > ker...@lists.infradead.org>; Herbert Xu ; David &

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-27 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Pascal Van Leeuwen > Sent: Friday, September 27, 2019 12:44 PM > To: Linus Torvalds > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; Linux ARM ; &g

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-27 Thread Pascal Van Leeuwen
> -Original Message- > From: Linus Torvalds > Sent: Friday, September 27, 2019 4:54 AM > To: Pascal Van Leeuwen > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; Linux ARM ; > Herbert Xu > ; David Miller ; Greg KH > ; Jason A

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-27 Thread Pascal Van Leeuwen
> -Original Message- > From: Linus Torvalds > Sent: Friday, September 27, 2019 4:06 AM > To: Pascal Van Leeuwen > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; Linux ARM ; > Herbert Xu > ; David Miller ; Greg KH > ; Jason A

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-27 Thread Pascal Van Leeuwen
e thing. It's actively detrimental for "I have no HW acceleration". > You keep asserting that with no evidence whatsoeever. > And apparently it's not optimal for you guys either. > True, but I accept the fact that it needs to be that way because some _other_

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-26 Thread Pascal Van Leeuwen
> -Original Message- > From: Linus Torvalds > Sent: Thursday, September 26, 2019 6:35 PM > To: Pascal Van Leeuwen > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; Linux ARM ; > Herbert Xu > ; David Miller ; Greg KH > ; Jason A

RE: Chacha-Poly performance on ARM64

2019-09-26 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Thursday, September 26, 2019 4:59 PM > To: Pascal Van Leeuwen > Cc: Linux Crypto Mailing List > Subject: Re: Chacha-Poly performance on ARM64 > > On Thu, 26 Sep 2019 at 16:55, Pascal Van Leeuwen > wro

RE: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API

2019-09-26 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Ard Biesheuvel > Sent: Thursday, September 26, 2019 4:53 PM > To: Pascal Van Leeuwen > Cc: Jason A. Donenfeld ; Linux Crypto Mailing List cry...@vger.kernel.org>; linux-arm-kernel

Chacha-Poly performance on ARM64

2019-09-26 Thread Pascal Van Leeuwen
search in the codebase but couldn't find any ARM64 optimized version ... Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API

2019-09-26 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Thursday, September 26, 2019 3:16 PM > To: Pascal Van Leeuwen > Cc: Jason A. Donenfeld ; Linux Crypto Mailing List cry...@vger.kernel.org>; linux-arm-kernel > ; > Herbert Xu ; David Miller ; > Greg KH >

RE: chapoly acceleration hardware [Was: Re: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API]

2019-09-26 Thread Pascal Van Leeuwen
> -Original Message- > From: Jason A. Donenfeld > Sent: Thursday, September 26, 2019 1:07 PM > To: Pascal Van Leeuwen > Cc: Ard Biesheuvel ; Linux Crypto Mailing List > cry...@vger.kernel.org>; linux-arm-kernel > ; > Herbert Xu ; David Miller ; &

RE: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API

2019-09-26 Thread Pascal Van Leeuwen
o now, and extend that later for async accelerators once people > realize that we really do need that as well. > What's wrong with a step-by-step approach though? i.e. merge it with library calls now and then gradually work towards the goal of integrating (a tweaked version of) the Crypto API where that actually makes sense? Rome wasn't built in one day either ... Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API

2019-09-26 Thread Pascal Van Leeuwen
initely in the embedded (networking) space. And it *will* be much faster than the embedded CPU next to it, so it will be worth using it for something like bulk packet encryption. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [RFC PATCH 18/18] net: wireguard - switch to crypto API for packet encryption

2019-09-26 Thread Pascal Van Leeuwen
t that surely won't consume excessive power like AVX512) > But even if you're right that it might be a power advantage on some > platform, that wouldn't make it an advantage on other platforms. Maybe > it could be done as a config option where you can opt in to the async > inte

[PATCHv4 3/3] crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL

2019-09-18 Thread Pascal van Leeuwen
Due to the addition of Chacha20-Poly1305 support to the inside-secure driver, it now depends on CRYPTO_CHACHA20POLY1305. Added reference. changes since v1: - added missing dependency to crypto/Kconfig changes since v2: - nothing changes since v3: - nothing Signed-off-by: Pascal van Leeuwen

[PATCHv4 2/3] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-18 Thread Pascal van Leeuwen
, and this is actually possible as long as cryptlen is large enough, so made that possible as well. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 2 + drivers/crypto/inside-secure/safexcel.h| 8 + drivers/crypto/inside-secure/safexcel_cipher.c

[PATCHv4 0/3] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-18 Thread Pascal van Leeuwen
l hardware) Pascal van Leeuwen (3): crypto: inside-secure - Added support for the CHACHA20 skcipher crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL drivers/crypto/Kconfig | 3 +

[PATCHv4 1/3] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-18 Thread Pascal van Leeuwen
generic fallback is compiled as well changes since v2: - made switch entry SAFEXCEL_AES explit and added empty default, as requested by Antoine Tenart. Also needed to make SM4 patches apply. changes since v3: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c

[PATCH] crypto: inside-secure - Add support for the EIP196

2019-09-18 Thread Pascal van Leeuwen
(Marvell A8K - EIP197b-ieswx), including the crypto extra tests. Note that this patchset applies on top of the earlier submitted "Add support for eip197f_iewc" series. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 69 ++-

[PATCH 2/2] crypto: inside-secure - Add support for HW with less ring AIC's than rings

2019-09-18 Thread Pascal van Leeuwen
the number of ring AIC's present. This allows it to at least function. (optimization for the future: add ring dispatch functionality in the interrupt service routine such that multiple rings can be supported from one ring AIC, allowing all rings to be used) Signed-off-by: Pascal van Leeuwe

[PATCH 1/2] crypto: inside-secure - Add support for 256 bit wide internal bus

2019-09-18 Thread Pascal van Leeuwen
This patch adds support for large EIP197's with a 256 bit wide internal bus, which affects the format of the result descriptor due to internal alignment requirements. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 101 +++ dr

[PATCH 0/2] crypto: inside-secure - Add support for eip197f_iewc

2019-09-18 Thread Pascal van Leeuwen
h the eip197f_iewc_w8 and eip197c_iewxkbc configurations on the Xilinx VCU118 development board as well as on the Macchiatobin board (Marvell A8K/eip197b_ieswx), including the crypto extra tests. Pascal van Leeuwen (2): crypto: inside-secure - Add support for 256 bit wide internal bus crypto: i

[PATCH 1/3] crypto: inside-secure - Added support for the rfc4106(gcm(aes)) AEAD

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4106(gcm(aes)) for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 112

[PATCH 3/3] crypto: inside-secure - Added support for the rfc4309(ccm(aes)) AEAD

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4309(ccm(aes)) for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 5 +- drivers/crypto/inside-secure/safexcel_cipher.c | 165

[PATCH 0/3] crypto: inside-secure - Add ESP GCM/GMAC/CCM variants

2019-09-17 Thread Pascal van Leeuwen
, including the testmgr extra tests. Pascal van Leeuwen (3): crypto: inside-secure - Added support for the rfc4106(gcm(aes)) AEAD crypto: inside-secure - Added support for the rfc4543(gcm(aes)) "AEAD" crypto: inside-secure - Added support for the rfc4309(ccm(aes)) AEAD drivers/crypto/ins

[PATCH 2/3] crypto: inside-secure - Added support for the rfc4543(gcm(aes)) "AEAD"

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4543(gcm(aes)) - i.e. AES-GMAC - for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 + drivers/crypto/inside-secure/safexcel_cipher.c | 86

[PATCH 2/2] crypto: inside-secure - Fixed corner case TRC admin RAM probing issue

2019-09-17 Thread Pascal van Leeuwen
This patch fixed a corner case admin RAM probing issue witnessed on the Xilinx VCU118 FPGA development board with an EIP197 configuration with 4096 words of admin RAM, of which only 2050 were recognised. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 48

[PATCH 1/2] crypto: inside-secure: [URGENT] Fix stability issue with Macchiatobin

2019-09-17 Thread Pascal van Leeuwen
development board. And since it was a problem with hash table access, it was very dependent on the actual physical context record DMA buffers being used, i.e. with some (bad) luck it could seemingly work quit stable for a while. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c

[PATCH 0/2] crypto: inside-secure: [URGENT] Fix stability issue

2019-09-17 Thread Pascal van Leeuwen
of TRC data RAM and 4096 words of TRC admin RAM on the Xilinx VCU118 development board as well as on the Macchiatobin board (Marvell A8K: EIP197b-ieswx w/ 15350 bytes data RAM & 80 words admin RAM), including the testmgr extra tests. Pascal van Leeuwen (2): crypto: inside-secure: [URGENT]

RE: [PATCH 4/7] crypto: testmgr - Added testvectors for the ofb(sm4) & cfb(sm4) skciphers

2019-09-15 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Sunday, September 15, 2019 10:21 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > antoine.ten...@bootlin.com; herb...@gondor.apana.org.au; da...@davemloft.net > Subject: R

[PATCHv2 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha1),cbc(des)) aead changes since v1: - rebased on top of DES changes made to cryptodev/master Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1

[PATCHv2 3/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des)), authenc(hmac(sha256),cbc(des)), authenc(hmac(sha384),cbc(des)) and authenc(hmac(sha512),cbc(des)) aead's changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c

[PATCH 2/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/3DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des3_ede)), authenc(hmac(sha256),cbc(des3_ede)), authenc(hmac(sha384),cbc(des3_ede)) and authenc(hmac(sha512),cbc(des3_ede)) aead's changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safex

[PATCHv2 0/3] crypto: inside-secure - Added more authenc w/ (3)DES

2019-09-13 Thread Pascal van Leeuwen
since v1: - rebased on top of DES changes made to cryptodev/master Pascal van Leeuwen (3): crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC crypto: inside-secure - Added support for authenc HMAC-SHA2/3DES-CBC crypto: inside-secure - Added support for authenc HMAC-SHA2/DES-CBC

[PATCHv2 2/3] crypto: inside-secure - Add HMAC-SHA3 family of authentication algorithms

2019-09-13 Thread Pascal van Leeuwen
-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 4 + drivers/crypto/inside-secure/safexcel.h | 4 + drivers/crypto/inside-secure/safexcel_hash.c | 441 ++- 3 files changed, 436 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCHv2 0/3] crypto: inside-secure - Add (HMAC) SHA3 support

2019-09-13 Thread Pascal van Leeuwen
fallback is compiled as well Pascal van Leeuwen (3): crypto: inside-secure - Add SHA3 family of basic hash algorithms crypto: inside-secure - Add HMAC-SHA3 family of authentication algorithms crypto: Kconfig - Add CRYPTO_SHA3 to CRYPTO_DEV_SAFEXCEL drivers/crypto/Kconfig

[PATCHv2 3/3] crypto: Kconfig - Add CRYPTO_SHA3 to CRYPTO_DEV_SAFEXCEL

2019-09-13 Thread Pascal van Leeuwen
Due to the addition of SHA3 and HMAC-SHA3 support to the inside-secure driver, it now depends on CRYPTO_SHA3. Added reference. changes since v1: - added missing dependency to crypto/Kconfig Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCHv2 1/3] crypto: inside-secure - Add SHA3 family of basic hash algorithms

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for sha3-224, sha3-256, sha3-384 and sha3-512 basic hashes. The patch has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. changes since v1: - nothing Signed-off-by: Pascal van Leeuwen

[PATCH] crypto: inside-secure - Add SM4 based authenc AEAD ciphersuites

2019-09-13 Thread Pascal van Leeuwen
abovementioned modified testmgr This patch applies on top of "Add support for SM4 ciphers" and needs to be applied before "Add (HMAC) SHA3 support". Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + drivers/crypto/inside-secure/saf

[PATCHv3 0/3] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-13 Thread Pascal van Leeuwen
dded empty default, as requested by Antoine Tenart. Also needed to make SM4 patches apply. Pascal van Leeuwen (3): crypto: inside-secure - Added support for the CHACHA20 skcipher crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD crypto: Kconfig - Add CRYPTO_CHACHA20P

[PATCHv3 2/3] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-13 Thread Pascal van Leeuwen
/Kconfig so that generic fallback is compiled as well changes since v2: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 2 + drivers/crypto/inside-secure/safexcel.h| 8 + drivers/crypto/inside-secure/safexcel_cipher.c | 276

[PATCHv3 3/3] crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL

2019-09-13 Thread Pascal van Leeuwen
Due to the addition of Chacha20-Poly1305 support to the inside-secure driver, it now depends on CRYPTO_CHACHA20POLY1305. Added reference. changes since v1: - added missing dependency to crypto/Kconfig changes since v2: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 3

[PATCHv3 1/3] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-13 Thread Pascal van Leeuwen
generic fallback is compiled as well changes since v2: - made switch entry SAFEXCEL_AES explit and added empty default, as requested by Antoine Tenart. Also needed to make SM4 patches apply. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers

[PATCHv2 3/3] crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL

2019-09-13 Thread Pascal van Leeuwen
Due to the addition of Chacha20-Poly1305 support to the inside-secure driver, it now depends on CRYPTO_CHACHA20POLY1305. Added reference. changes since v1: - added missing dependency to crypto/Kconfig Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 3 ++- 1 file changed, 2

[PATCHv2 2/3] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the Chacha20-Poly1305 cipher suite. It adds both the basic rfc7539(chacha20,poly1305) as well as the rfc7539esp(chacha20,poly1305) variant for IPsec ESP acceleration. changes since v1: - rebased on top of DES changes done to cryptodev/master Signed-off-by: Pascal van

[PATCHv2 1/3] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-13 Thread Pascal van Leeuwen
Added support for the CHACHA20 skcipher algorithm. Tested on an eip197c-iesb configuration in the Xilinx VCU118 devboard, passes all testmgr vectors plus the extra fuzzing tests. changes since v1: - rebased on top of DES changes done to cryptodev/master Signed-off-by: Pascal van Leeuwen

[PATCHv2 0/3] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-13 Thread Pascal van Leeuwen
applies on top of the earlier submitted "Add support for the CBCMAC" series. changes since v1: - rebased on top of DES library changes done on cryptodev/master - fixed crypto/Kconfig so that generic fallback is compiled as well Pascal van Leeuwen (3): crypto: inside-secure - Added suppo

RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 13, 2019 6:24 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; open list:HARDWARE RANDOM > NUMBER > GENERATOR CORE ; Antoine Tenart > ; Herbert Xu ; David > S. Miller > >

[PATCHv3 0/3] crypto: inside-secure - Add support for (HMAC) SM3

2019-09-13 Thread Pascal van Leeuwen
on top of the earlier submitted "Add support for the Chacha20 kcipher and the Chacha20-Poly..." series. changes since v1: - incorporated feedback by Antoine Tenart, see individual patches for details changes since v2: - allow compilation if CONFIG_CRYPTO_SM3 is not set Pascal van

[PATCHv3 2/3] crypto: inside-secure - Added support for HMAC-SM3 ahash

2019-09-13 Thread Pascal van Leeuwen
Added support for the hmac(sm3) ahash authentication algorithm changes since v1: - added Acked-by tag below, no changes to the source changes since v2: - nothing Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto

[PATCHv3 3/3] crypto: testmgr - Added testvectors for the hmac(sm3) ahash

2019-09-13 Thread Pascal van Leeuwen
Added testvectors for the hmac(sm3) ahash authentication algorithm changes since v1 & v2: -nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 56 2 files changed, 62 insertions(+) diff --g

[PATCHv3 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-13 Thread Pascal van Leeuwen
Added support for the SM3 ahash algorithm changes since v1: - moved definition of CONTEXT_CONTROL_CRYPTO_ALG_SM3 (0x7) up above 0xf changes since v2: - allow compilation if CONFIG_CRYPTO_SM3 is not set Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside

RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 13, 2019 5:27 PM > To: Pascal van Leeuwen > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE > ; > Antoine Tenart ; Herbert Xu > ; > David S. Miller ; Pascal Van Leeuwen > >

[PATCH 0/3] crypto: inside-secure - Added more authenc w/ (3)DES

2019-09-13 Thread Pascal van Leeuwen
This patchset adds the remaining authencs with DES or 3DES currently supported with vectors by testmgr. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development boardi as well as on the Macchiatobin board, including the testmgr extra tests. Pascal van

[PATCH 3/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des)), authenc(hmac(sha256),cbc(des)), authenc(hmac(sha384),cbc(des)) and authenc(hmac(sha512),cbc(des)) aead's Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + drivers/crypto/inside-s

[PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha1),cbc(des)) aead Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 45 ++ 3

[PATCH 2/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/3DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des3_ede)), authenc(hmac(sha256),cbc(des3_ede)), authenc(hmac(sha384),cbc(des3_ede)) and authenc(hmac(sha512),cbc(des3_ede)) aead's Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + dr

[PATCH 2/2] crypto: inside-secure - Add HMAC-SHA3 family of authentication algorithms

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for hmac(sha3-224), hmac(sha3-256), hmac(sha3-384) and hmac(sha3-512) authentication algorithms. The patch has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Signed-off-by: Pascal van Leeuwen

[PATCH 1/2] crypto: inside-secure - Add SHA3 family of basic hash algorithms

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for sha3-224, sha3-256, sha3-384 and sha3-512 basic hashes. The patch has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure

[PATCH 0/2] crypto: inside-secure - Add (HMAC) SHA3 support

2019-09-13 Thread Pascal van Leeuwen
This patchset adds support for all flavours of sha3-xxx and hmac(sha3-xxx) ahash algorithms. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Pascal van Leeuwen (2): crypto: inside-secure - Add SHA3

[PATCHv2 7/7] crypto: testmgr - Added testvectors for the rfc3686(ctr(sm4)) skcipher

2019-09-13 Thread Pascal van Leeuwen
Added testvectors for the rfc3686(ctr(sm4)) skcipher algorithm changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 29 + 2 files changed, 35 insertions(+) diff --git a/crypto/testmgr.c b/crypto

  1   2   3   4   >