> -----Original Message-----
> From: linux-crypto-ow...@vger.kernel.org <linux-crypto-ow...@vger.kernel.org>
> On Behalf Of
> YueHaibing
> Sent: Wednesday, October 9, 2019 2:06 PM
> To: Antoine Tenart <antoine.ten...@bootlin.com>; Herbert Xu
> <herb...@gondor.apana.org.au>
> Cc: YueHaibing <yuehaib...@huawei.com>; linux-crypto@vger.kernel.org; kernel-
> janit...@vger.kernel.org
> Subject: [PATCH -next] crypto: Use PTR_ERR_OR_ZERO in
> safexcel_xcbcmac_cra_init()
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Signed-off-by: YueHaibing <yuehaib...@huawei.com>
>
Acked-by: Pascal van Leeuwen <pvanleeu...@verimatrix.com>
> ---
> drivers/crypto/inside-secure/safexcel_hash.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/inside-secure/safexcel_hash.c
> b/drivers/crypto/inside-
> secure/safexcel_hash.c
> index 85c3a075f283..a07a2915fab1 100644
> --- a/drivers/crypto/inside-secure/safexcel_hash.c
> +++ b/drivers/crypto/inside-secure/safexcel_hash.c
> @@ -2109,10 +2109,7 @@ static int safexcel_xcbcmac_cra_init(struct crypto_tfm
> *tfm)
>
> safexcel_ahash_cra_init(tfm);
> ctx->kaes = crypto_alloc_cipher("aes", 0, 0);
> - if (IS_ERR(ctx->kaes))
> - return PTR_ERR(ctx->kaes);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(ctx->kaes);
>
Ah cool, you can do that in one go, didn't know that yet :-) Thanks!
> }
>
> static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm)
>
>
>
>
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
