Re: [PATCH v2] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-12-02 Thread Lukasz Stelmach
nced. I remove err_clock label at the same. > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Reported-by: Hulk Robot > Suggested-by: Lukasz Stelmach > Signed-off-by: Qinglang Miao > --- > v2: remobe useless label as

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-27 Thread Lukasz Stelmach
It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter balanced

Re: [PATCH] char: hw_random: Fix a reference count leak.

2020-06-15 Thread Lukasz Stelmach
It was <2020-06-13 sob 16:41>, when wu000...@umn.edu wrote: > From: Qiushi Wu > > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put_sync is not > called in error handling paths. Thus replace the jump target > "err_pm_get" by

Re: [PATCH] [v2] hwrng: exynos - Fix runtime PM imbalance on error

2020-05-22 Thread Lukasz Stelmach
d-off-by: Dinghao Liu > --- > > Changelog: > > v2: -- Remove unnecessary 'err_clock' label > --- > drivers/char/hw_random/exynos-trng.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Lukasz Stelmach Thank you. > diff --git a/drivers/ch

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-21 Thread Lukasz Stelmach
It was <2020-05-21 czw 13:00>, when Stefan Wahren wrote: > Hi Lukasz, > > Am 19.05.20 um 23:25 schrieb Łukasz Stelmach: >> The value was estimaded with ea_iid[1] using on 10485760 bytes read from >> the RNG via /dev/hwrng. The min-entropy value calculated using the most >> common value estimate (NI

Re: [PATCH] hwrng: exynos - fix runtime pm imbalance on error

2020-05-21 Thread Lukasz Stelmach
It was <2020-05-20 śro 21:19>, when Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- > driver

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 13:53>, when Stephan Mueller wrote: > Am Mittwoch, 20. Mai 2020, 12:44:33 CEST schrieb Lukasz Stelmach: >> It was <2020-05-20 śro 11:18>, when Stephan Mueller wrote: >>> Am Mittwoch, 20. Mai 2020, 11:10:32 CEST schrieb Lukasz Stelmach: >

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 11:18>, when Stephan Mueller wrote: > Am Mittwoch, 20. Mai 2020, 11:10:32 CEST schrieb Lukasz Stelmach: >> It was <2020-05-20 śro 08:23>, when Stephan Mueller wrote: >>> Am Dienstag, 19. Mai 2020, 23:25:51 CEST schrieb Łukasz Stelmach: >

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 08:23>, when Stephan Mueller wrote: > Am Dienstag, 19. Mai 2020, 23:25:51 CEST schrieb Łukasz Stelmach: > >> The value was estimaded with ea_iid[1] using on 10485760 bytes read from >> the RNG via /dev/hwrng. The min-entropy value calculated using the most >> common value est

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 11:10>, when Stephan Mueller wrote: > As I mentioned, all that is or seems to be analyzed here is the > quality of the cryptographic post-processing. Thus none of the data > can be used for getting an idea of the entropy content. > > That said, the ent value indeed looks too

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 10:32>, when Stephan Mueller wrote: > Am Freitag, 15. Mai 2020, 00:18:41 CEST schrieb Lukasz Stelmach: > >> I am running tests using SP800-90B tools and the first issue I can see >> is the warning that samples contain less than 1e6 bytes of data. I kn

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 00:18>, when Lukasz Stelmach wrote: > It was <2020-05-14 czw 22:20>, when Stephan Mueller wrote: >> Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: >> >> Hi Łukasz, >> >>> The value has been estimaded by

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-14 Thread Lukasz Stelmach
It was <2020-05-14 czw 22:20>, when Stephan Mueller wrote: > Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: > > Hi Łukasz, > >> The value has been estimaded by obtainig 1024 chunks of data 128 bytes >> (1024 bits) each from the generator and finding chunk with minimal >> entrop