Re: [PATCH] crypto: arm/crc32 - add kCFI annotations to asm routines

2024-06-11 Thread Linus Walleij
d. > > Cc: Kees Cook > Cc: Linus Walleij > Signed-off-by: Ard Biesheuvel Fixes: 1a4fec49efe5 ("ARM: 9392/2: Support CLANG CFI") Reviewed-by: Linus Walleij Thanks for helping to iron out the rough corners on these patches! Yours, Linus Walleij

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-03 Thread Linus Walleij
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote: > Running 'dt-validate -m' will flag any compatible strings missing a schema. > Fix all the errors found in DT binding examples. Most of these are just > typos. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Ch

Re: [PATCH] crypto: ux500 - Fix sparse endianness warnings

2020-09-12 Thread Linus Walleij
On Fri, Sep 4, 2020 at 10:27 AM Herbert Xu wrote: > This patch fixes a couple of sparse endianness warnings in the > ux500 driver. > > Signed-off-by: Herbert Xu Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/1] crypto: ux500: hash: Add namespacing to hash_init()

2020-06-29 Thread Linus Walleij
t 1 of > '__hash_init' from incompatible pointer type > [-Werror=incompatible-pointer-types] > 1362 | return hash_init(req); > > Fix this by namespacing the local hash_init() such that the > source of confusion is removed. > > Cc: Linus Walleij > Cc: Herber

Re: [PATCH 15/25] crypto: ixp4xx - switch to skcipher API

2019-10-16 Thread Linus Walleij
y drop the > blkcipher code in the near future. > > Cc: Linus Walleij > Cc: Imre Kaloz > Cc: Krzysztof Halasa > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 06/25] crypto: ux500 - switch to skcipher API

2019-10-16 Thread Linus Walleij
y drop the > blkcipher code in the near future. > > Cc: Linus Walleij > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 2/6] crypto: atmel-ecc: add support for ACPI probing on non-AT91 platforms

2019-05-24 Thread Linus Walleij
at the effective bus > rate should never exceed the maximum rate, unless we are dealing with > buggy firmware. Nonetheless, let's just use the existing plumbing to > discover the bus rate and keep the existing logic intact. > > Signed-off-by: Ard Biesheuvel Looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 4/5] crypto: atmel-i2c: add support for SHA204A random number generator

2019-05-09 Thread Linus Walleij
ent 96boards platforms is the random number generator. > > So let's implement a driver for the SHA204A, and for the time being, > implement support for the random number generator only. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 5/5] dt-bindings: add Atmel SHA204A I2C crypto processor

2019-05-09 Thread Linus Walleij
On Tue, Apr 30, 2019 at 6:29 PM Ard Biesheuvel wrote: > Add a compatible string for the Atmel SHA204A I2C crypto processor. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 3/5] crypto: atmel-ecc: factor out code that can be shared

2019-05-09 Thread Linus Walleij
mand queuing routines. > > Signed-off-by: Ard Biesheuvel This looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v5 3/6] crypto: Add Qcom prng driver

2018-07-14 Thread Linus Walleij
On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul wrote: > This ports the Qcom prng from older hw_random driver. > > No change of functionality and move from hw_random to crypto > APIs is done. > > Signed-off-by: Vinod Koul FWIW: Reviewed-by: Linus Walleij > +confi

[PATCH 5/9 v2] crypto: atmel-ecc: Create a config word reader

2018-06-28 Thread Linus Walleij
Rewrite the function atmel_ecc_init_read_cmd() into a more general atmel_ecc_init_read_config_word() function to read any word from the configuration zone, and use this parameterized with what we want to read out. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased --- drivers/cry

[PATCH 4/9 v2] crypto: atmel-ecc: Provide config zone defines

2018-06-28 Thread Linus Walleij
The config zone has 0x16 words of 4 bytes each, so provide some basic defines so that we can address these individually. Rename the last word to "footer", this is where we currently look to see if the configuration is locked. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Die

[PATCH 2/9 v2] crypto: atmel-ecc: Just warn on missing clock frequency

2018-06-28 Thread Linus Walleij
the probe continue with a warning if no clock frequency can be found, assuming it is safe. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Instead of silently ignoring the missing clock frequency, issue a warning and continue. --- drivers/crypto/atmel-ecc.c | 9 +++-- 1 file changed

[PATCH 9/9 v2] crypto: atmel-ecc: Break out lock check helper

2018-06-28 Thread Linus Walleij
This breaks out a lock status checker to be used with further refactorings. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased --- drivers/crypto/atmel-ecc.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/cry

[PATCH 1/9 v2] crypto: atmel-ecc: Make available for other platforms

2018-06-28 Thread Linus Walleij
This is a pure I2C driver, and this device appears on the 96boards Secure96 mezzanine card, so we want to enable the driver on other devices. Cut the Kconfig limitations to Atmel SoC only. Reviewed-by: Tudor Ambarus Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Collect Tudor's re

[PATCH 8/9 v2] crypto: atmel-ecc: Detail what is unlocked

2018-06-28 Thread Linus Walleij
Instead of just providing a broad error message about the chip being unlocked provide details on what is unlocked, one line per thing that can be locked: data and OTP and configuration are locked independently. Loose the overzealous defines. Signed-off-by: Linus Walleij --- ChangeLog v1->

[PATCH 6/9 v2] crypto: atmel-ecc: Marshal the command while sending

2018-06-28 Thread Linus Walleij
sense to provide the length of the data buffer used with the command. This avoids the hazzle to try to keep the command structure in the device endianness, we fix up the endianness when marshalling the command instead. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebase on other chan

[PATCH 7/9 v2] crypto: atmel-ecc: Print out serial number

2018-06-28 Thread Linus Walleij
This reads out the serial number of the crypto chip and prints it, also toss this into the entropy pool as it is device-unique data. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - kfree(cmd) was missed. Fix it with a goto construction. - Coding style fixes. --- drivers/crypto/atmel-ec

[PATCH 3/9 v2] crypto: atmel-ecc: More helpful error messages

2018-06-28 Thread Linus Walleij
Report errors once when they happen on the I2C bus so we get good information in cases such as when the wrong I2C address is used. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Strip some comments that are now obvious from the context with the error messages. - Do not print the exc

Re: [PATCH 4/9] crypto: atmel-ecc: Provide config zone defines

2018-06-28 Thread Linus Walleij
On Tue, Jun 12, 2018 at 2:59 PM Tudor Ambarus wrote: > On 06/05/2018 04:49 PM, Linus Walleij wrote: > > The config zone has 0x16 words of 4 bytes each, so provide > > some basic defines so that we can address these individually. > > Are you going to use all these defines?

Re: [PATCH 8/9] crypto: atmel-ecc: Detail what is unlocked

2018-06-28 Thread Linus Walleij
On Tue, Jun 12, 2018 at 3:25 PM Tudor Ambarus wrote: > On 06/05/2018 04:49 PM, Linus Walleij wrote: > > Instead of just providing a broad error message about the > > chip being unlocked provide details on what is unlocked, > > one line per thing that can be loc

Re: [PATCH 7/9] crypto: atmel-ecc: Print out serial number

2018-06-28 Thread Linus Walleij
serial[0], serial[1], serial[2], serial[3], serial[4], > > + serial[5], serial[6], serial[7], serial[8]); > > Why do you need the serial number printed out? Cuddly feeling I guess. If there is a problem with the device the user might want to report the serial number to the manufacturer? Yours, Linus Walleij

Re: [PATCH 6/9] crypto: atmel-ecc: Marshal the command while sending

2018-06-28 Thread Linus Walleij
efore we send the command. This is code duplication. Second problem: we have two instances of inlined cmd->param2 = cpu_to_le16(keyid); dealing with endianness instead of doing this as part of marshalling the command. This is also code duplication. Yours, Linus Walleij

Re: [PATCH 3/9] crypto: atmel-ecc: More helpful error messages

2018-06-28 Thread Linus Walleij
On Tue, Jun 12, 2018 at 2:36 PM Tudor Ambarus wrote: > On 06/05/2018 04:49 PM, Linus Walleij wrote: > > /* send the command */ > > I guess that this comment will become superfluous if you're going to add > an error message. OK stripped obvious comments. > >

Re: [PATCH 2/9] crypto: atmel-ecc: Silently ignore missing clock frequency

2018-06-28 Thread Linus Walleij
On Mon, Jun 11, 2018 at 11:46 AM Tudor Ambarus wrote: > On 06/05/2018 04:49 PM, Linus Walleij wrote: > > The Atmel ECC driver contains a check for the I2C bus clock > > frequency, so as to check that the I2C adapter in use > > satisfies the device specs. > > > >

[PATCH 7/9] crypto: atmel-ecc: Print out serial number

2018-06-05 Thread Linus Walleij
This reads out the serial number of the crypto chip and prints it, also toss this into the entropy pool as it is device-unique data. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers

[PATCH 5/9] crypto: atmel-ecc: Create a config word reader

2018-06-05 Thread Linus Walleij
Rewrite the function atmel_ecc_init_read_cmd() into a more general atmel_ecc_init_read_config_word() function to read any word from the configuration zone, and use this parameterized with what we want to read out. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 11 --- 1

[PATCH 9/9] crypto: atmel-ecc: Break out lock check helper

2018-06-05 Thread Linus Walleij
This breaks out a lock status checker to be used with further refactorings. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel

[PATCH 4/9] crypto: atmel-ecc: Provide config zone defines

2018-06-05 Thread Linus Walleij
The config zone has 0x16 words of 4 bytes each, so provide some basic defines so that we can address these individually. Rename the last word to "footer", this is where we currently look to see if the configuration is locked. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-

[PATCH 8/9] crypto: atmel-ecc: Detail what is unlocked

2018-06-05 Thread Linus Walleij
Instead of just providing a broad error message about the chip being unlocked provide details on what is unlocked, one line per thing that can be locked: data and OTP and configuration are locked independently. Loose the overzealous defines. Signed-off-by: Linus Walleij --- drivers/crypto/atmel

[PATCH 6/9] crypto: atmel-ecc: Marshal the command while sending

2018-06-05 Thread Linus Walleij
sense to provide the length of the data buffer used with the command. This avoids the hazzle to try to keep the command structure in the device endianness, we fix up the endianness when marshalling the command instead. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 71

[PATCH 3/9] crypto: atmel-ecc: More helpful error messages

2018-06-05 Thread Linus Walleij
Report errors once when they happen on the I2C bus so we get good information in cases such as when the wrong I2C address is used. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 2/9] crypto: atmel-ecc: Silently ignore missing clock frequency

2018-06-05 Thread Linus Walleij
the probe continue silently if no clock frequency can be found, assuming all is safe. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index

[PATCH 1/9] crypto: atmel-ecc: Make available for other platforms

2018-06-05 Thread Linus Walleij
This is a pure I2C driver, and this device appears on the 96boards Secure96 mezzanine card, so we want to enable the driver on other devices. Cut the Kconfig limitations to Atmel SoC only. Signed-off-by: Linus Walleij --- drivers/crypto/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a

Re: [PATCH] crypto: ux500/hash: Add empty export and import

2018-01-18 Thread Linus Walleij
On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny wrote: > Crypto framework will require async hash export/import, so add empty > functions to prevent OOPS. > > Signed-off-by: Kamil Konieczny Acked-by: Linus Walleij But why isn't the framework code just checking the vtable f

[PATCH] crypto: ux500: memmove the right size

2016-06-08 Thread Linus Walleij
The hash buffer is really HASH_BLOCK_SIZE bytes, someone must have thought that memmove takes n*u32 words by mistake. Tests work as good/bad as before after this patch. Cc: Joakim Bech Reported-by: David Binderman Signed-off-by: Linus Walleij --- drivers/crypto/ux500/hash/hash_core.c | 4

Re: linux-4.6/drivers/crypto/ux500/hash/hash_core.c: 2 * possible bad size ?

2016-06-08 Thread Linus Walleij
c b5 e0 3d [4.170501] cryp1 cryp1: successfully registered The simple tests always work, it's those stressful ones that create problems. Joakim: did you have a memory of this code working? Should I check the vendor tree for fixes? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-14 Thread Linus Walleij
y any "grown up" defconfigs. > > Signed-off-by: Daniel Thompson This is a fine driver, love the performance boost you reported and stand corrected on the likeness of the other Nomadik driver. Reviewed-by: Linus Walleij > +static int stm32_rng_read(struct hwrng *rng, void *data, size_t

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-04 Thread Linus Walleij
t;dev, 50); pm_runtime_use_autosuspend(&dev->dev);pm_runtime_put_autosuspend(). For a primecell check the usage in drivers/mmc/host/mmci.c for a complex usecase or e.g. drivers/hwtracing/coresight/coresight-tpiu.c for a simpler usecase. For the performance hints I guess you can even test whet

[PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-09 Thread Linus Walleij
is already mixed in. Incidentally this also gets rid of a rather ugly cross-dependence on the machine using an extern declaration. Cc: Stephen Warren Cc: Varun Wadekar Cc: Neil Horman Cc: linux-te...@vger.kernel.org Signed-off-by: Linus Walleij --- Only compile-tested as I don't have

Re: crypto: ux500: Fix logging, make arrays const, neatening

2013-07-22 Thread Linus Walleij
initions > > Signed-off-by: Joe Perches > --- > > On top of Masanari Iida's patch: > https://patchwork.kernel.org/patch/2828273/ Acked-by: Linus Walleij Have you tested this on hardware or is it compile-tested only? Yours, Linus Walleij -- To unsubscribe from this list: send t

Re: [PATCH 0/6] Various ux500 crypto updates

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 1:17 PM, Herbert Xu wrote: > On Tue, Jun 25, 2013 at 11:20:50AM +0200, Linus Walleij wrote: >> On Tue, Jun 25, 2013 at 10:54 AM, Fabio Baltieri >> wrote: >> >> > these are some fixes to issue pointed out by sparse and dmaengine API >&g

Re: [PATCH 0/6] Various ux500 crypto updates

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 10:54 AM, Fabio Baltieri wrote: > these are some fixes to issue pointed out by sparse and dmaengine API > udpates on the recently enabled ux500 hw crypto drivers. The series: Acked-by: Linus Walleij > These are based on recent linux-next, and can probably be a

Re: [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:17 AM, Lee Jones wrote: > On Wed, 15 May 2013, Linus Walleij wrote: > >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > Now DMA DT bindings exist and are in use by he MMC and UART drivers, it >> > should be possible to re

Re: [PATCH 05/39] ARM: ux500: Stop passing MMC's platform data for Device Tree boots

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:15 AM, Lee Jones wrote: > On Wed, 15 May 2013, Linus Walleij wrote: > >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > It was required to pass DMA channel configuration information to the >> > MMC driver before the new

Re: [PATCH 39/39] dmaengine: ste_dma40: Fetch disabled channels from DT

2013-05-30 Thread Linus Walleij
ely, so we may as well add the infrastructure. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 38/39] dmaengine: ste_dma40: Fetch the number of physical channels from DT

2013-05-30 Thread Linus Walleij
so we may as well add the infrastructure. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH 37/39] ARM: ux500: Stop passing DMA platform data though AUXDATA

2013-05-30 Thread Linus Walleij
nflict with all the AUXDATA changes in the devicetree branch. Oh well, I'll figure it out... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 36/39] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT

2013-05-30 Thread Linus Walleij
e will need to be tailored. Fortunately, these platforms will be DT > only, so this change has very little impact on platform data. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applie

Re: [PATCH 35/39] dmaengine: ste_dma40_ll: Replace meaningless register set with comment

2013-05-30 Thread Linus Walleij
gt; Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Tentatively applied. Missing Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-05-30 Thread Linus Walleij
_width (in Bytes) value. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with what I interpret as Vinod's ACK ("okay..." statement on last reply.) Yours, Linus Walleij -- To unsubscribe from thi

Re: [PATCH 33/39] dmaengine: ste_dma40_ll: Use the BIT macro to replace ugly '(1 << x)'s

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The aim is to make the code that little more readable. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Wall

Re: [PATCH 32/39] ARM: ux500: Remove recently unused stedma40_xfer_dir enums

2013-05-30 Thread Linus Walleij
s, but it seems it was implicitly ACKed in the discussion on patch 31. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 31/39] dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones

2013-05-30 Thread Linus Walleij
c: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 30/39] ARM: ux500: Replace ST-E's home-brew DMA direction definition with the generic one

2013-05-30 Thread Linus Walleij
ng your ACK on this patch, but have tentatively queued it anyway. Maybe you missed it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 29/39] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The aim is to make the code that little more readable. > > Acked-by: Vinod Koul > Acked-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied to my ux500-dma40 branch. Yours, L

Re: [PATCH 28/39] ARM: ux500: Remove empty function u8500_of_init_devices()

2013-05-30 Thread Linus Walleij
h. And this is looking real good now! Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 27/39] ARM: ux500: Remove ux500-musb platform registation when booting with DT

2013-05-30 Thread Linus Walleij
the musb stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 26/39] ARM: ux500: Add an auxdata entry for MUSB for clock-name look-up

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The recently DT:ed MUSB driver will require clock-name by device-name > look-up capability, until common clk has is properly supported by the > ux500 platform. > > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Sig

Re: [PATCH 25/39] usb: musb: ux500: add device tree probing support

2013-05-30 Thread Linus Walleij
org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...

Re: [PATCH 24/39] usb: musb: ux500: attempt to find channels by name before using pdata

2013-05-30 Thread Linus Walleij
step towards this. The next step will be to enable Device Tree > complete with name<->event_line mapping. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Fe

Re: [PATCH 23/39] usb: musb: ux500: harden checks for platform data

2013-05-30 Thread Linus Walleij
are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypt

Re: [PATCH 22/39] usb: musb: ux500: take the dma_mask from coherent_dma_mask

2013-05-30 Thread Linus Walleij
driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line &qu

Re: [PATCH 21/39] usb: musb: ux500: move the MUSB HDRC configuration into the driver

2013-05-30 Thread Linus Walleij
oting with either ATAGs or Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send th

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
tform data. This also removes quite a bit of complexity from the driver >> and will aid us when we come to enable the driver for Device Tree. >> >> Cc: Felipe Balbi >> Cc: linux-...@vger.kernel.org >> Acked-by: Linus Walleij >> Acked-by: Fabio Baltieri >>

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Felipe's ACK. Thanks! Linus Walle

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-29 Thread Linus Walleij
On Tue, May 28, 2013 at 6:27 PM, Felipe Balbi wrote: > On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: >> I can't merge any of this without Felipes ACKs in any >> case. > > Do you want to take this yourself ? I haven't fully read the series yet, &

Re: [PATCH 5/6] crypto: ux500/cryp - Enable DT probing of the driver

2013-05-24 Thread Linus Walleij
On Fri, May 24, 2013 at 10:32 AM, Lee Jones wrote: > On Fri, 24 May 2013, Linus Walleij wrote: >> On Thu, May 16, 2013 at 1:27 PM, Lee Jones wrote: >> >> > By providing an OF match table with a suitable compatible string, we >> > can ensure the ux500-crypt

Re: [PATCH 5/6] crypto: ux500/cryp - Enable DT probing of the driver

2013-05-23 Thread Linus Walleij
-crypto@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/crypto/ux500/cryp/cryp_core.c |6 ++ W00t! No binding document? OK I guess it's just reg, irq ... but still it's compulsory, right? Yours, Linus Walleij -- To unsubscribe from this list: send the line &

Re: [PATCH 5/6] crypto: ux500/cryp - Enable DT probing of the driver

2013-05-23 Thread Linus Walleij
-crypto@vger.kernel.org > Signed-off-by: Lee Jones Herbert, can I have your ACK on patch 5 & 6 in this series to take it through the ARM SoC tree? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord..

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-20 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones I have now gone over and collected ACKs etc for the patches up until here. No

Re: [PATCH 19/39] ARM: ux500: Register Cyrp and Hash platform drivers on Snowball

2013-05-20 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > These drivers are now operational and even use the latest common clk > and DMA APIs. There's no reason why we shouldn't start them up now. > > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied

Re: [PATCH 18/39] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog

2013-05-20 Thread Linus Walleij
; Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto"

Re: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-05-20 Thread Linus Walleij
ig() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Acked-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Thanks, Linus Walleij -- To unsubscribe from this

Re: [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it

2013-05-20 Thread Linus Walleij
l.org > Acked-by: Ulf Hansson > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 14/39] ARM: ux500: Stop passing Hash DMA channel config information though pdata

2013-05-20 Thread Linus Walleij
ch applied now that the deps are in! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-05-20 Thread Linus Walleij
ig() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it

2013-05-20 Thread Linus Walleij
.org > Acked-by: Arnd Bergmann > Acked-by: Ulf Hansson > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-20 Thread Linus Walleij
: Vinod Koul >> > > That needs up update! >> > >> > Ah, where did I get that from that? >> > >> > Was that my mistake, or was this in the MAINTAINERS file? >> Certainly not in MAINTAINERS file :) > > My bad then, sorry. > > Linus, >

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-16 Thread Linus Walleij
On Wed, May 15, 2013 at 10:14 PM, Fabio Baltieri wrote: > On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > For all ux500 based platforms the maximum number of end-points are used. >> > Mo

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-15 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones I guess this stuff is dependent on the stuff Fabio has recently sent to Felipe f

Re: [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it

2013-05-15 Thread Linus Walleij
l.org > Acked-by: Ulf Hansson > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones This patch also looks like -rc series stuff for the crypto tree. BTW: these two clk_prepare_enable() patches are Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the

Re: [PATCH 11/39] ARM: ux500: Remove unnecessary attributes from DMA channel request pdata

2013-05-15 Thread Linus Walleij
information are subsequently ignored by the driver, so we may > as well remove them. > > Signed-off-by: Lee Jones Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-05-15 Thread Linus Walleij
Vinod's ACK for the previous patches I can send an initial pull request on that and then follow up with the rest. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it

2013-05-15 Thread Linus Walleij
crypto tree? Else please convince Herbert to give his ACK on this before I apply it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/39] dmaengine: ste_dma40: Correct copy/paste error

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > 'struct stedma40_half_channel_info's header comment says that it's > called 'struct stedma40_chan_cfg'. Let's straighten that out. > > Signed-off-by: Lee Jones Patch tentatively applied waiting fo

Re: [PATCH 09/39] ARM: ux500: Remove DMA address look-up table

2013-05-15 Thread Linus Walleij
fit in well using Device Tree either. > > Signed-off-by: Lee Jones Good riddance. Patch tentatively applied. Awaiting Vinod's ACK for include/platform_data/*. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a mes

Re: [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading

2013-05-15 Thread Linus Walleij
) call to do device name matching, which will fail due to the > fact that Device Tree naming differs somewhat do the more traditional > conventions. > > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Cannot be applied due to dependency on 5/39. Yours, Linus Walleij -- To unsub

Re: [PATCH 08/39] dmaengine: ste_dma40: Remove redundant address fetching function

2013-05-15 Thread Linus Walleij
for Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/39] dmaengine: ste_dma40: Only use addresses passed as configuration information

2013-05-15 Thread Linus Walleij
levates a large burden from platform data in the way of a look-up > table. > > Signed-off-by: Lee Jones This should be the case even without patch 5 & 6 so patch tentatively applied. Waiting for Vinod's ACK on this though. Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH 05/39] ARM: ux500: Stop passing MMC's platform data for Device Tree boots

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > It was required to pass DMA channel configuration information to the > MMC driver before the new DMA API was in place. Now that it is, and > is fully compatible with Device Tree we can stop doing that. > > Reviewed-by: Linus Wa

Re: [PATCH 04/39] ARM: ux500: Stop passing UART's platform data for Device Tree boots

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > It was required to pass DMA channel configuration information to the > UART driver before the new DMA API was in place. Now that it is, and > is fully compatible with Device Tree we can stop doing that. > > Reviewed-by: Linus Wa

Re: [PATCH 03/39] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate

2013-05-15 Thread Linus Walleij
t I amended it. Besides, when I amend commit messages I make sure I really understand what is going on so no big deal... > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones I still need Vinod's ACK on this before I send it anywh

Re: [PATCH 01/39] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-05-15 Thread Linus Walleij
500-dma40 branch. This lacks an ACK from Vinod... I cannot get any of this stack of patches up to ARM SoC before I have Vinod's ACK on all hitting drivers/dma/* Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message t

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-15 Thread Linus Walleij
ed-off-by: Lee Jones You forgot to update the commit message, but I saw that you fixed what I asked for so I just went in and edited the commit message and applied it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a messa

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Linus Walleij
phys_addr_t :) OK! Sent a patch for this, check it out. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Linus Walleij
; if the dma engine resides behind an IOMMU. > > The best assumption we can make is that the dma engine driver knows > how to convert between the two. Interestingly the documentation for > dma_slave_config talks about "physical address", while the structure > itself uses a dma

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-25 Thread Linus Walleij
On Thu, Apr 25, 2013 at 3:44 PM, Lee Jones wrote: > On Thu, 25 Apr 2013, Linus Walleij wrote: >> On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones wrote: >> >> > The DMA controller currently takes configuration information from >> > information passed though dma_ch

Re: [PATCH 8/9] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog

2013-04-25 Thread Linus Walleij
; Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo

  1   2   >