Re: [PATCH] crypto: sa2ul - Select CRYPTO_AUTHENC

2020-09-06 Thread J, KEERTHY
On 9/7/2020 11:52 AM, Herbert Xu wrote: Resend with new subject. Thanks Herbert. Reviewed-by: Keerthy ---8<--- The sa2ul driver uses crypto_authenc_extractkeys and therefore must select CRYPTO_AUTHENC. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Report

Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error

2020-08-06 Thread J, KEERTHY
x2b25): undefined reference to `sha512_zero_message_hash' Thanks for catching this. Reviewed-by: Keerthy Signed-off-by: Randy Dunlap Reported-by: Randy Dunlap # 2020-07-29 Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Cc: Tero Kristo Cc: Keerthy

Re: [RESEND PATCH 01/10] dt-bindings: crypto: k3: Add sa2ul bindings documentation

2019-07-22 Thread Keerthy
On 22/07/19 11:59 PM, Rob Herring wrote: On Fri, Jun 28, 2019 at 09:57:36AM +0530, Keerthy wrote: The series adds Crypto hardware accelerator support for SA2UL. SA2UL stands for security accelerator ultra lite. The Security Accelerator (SA2_UL) subsystem provides hardware cryptographic

Re: [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support

2019-06-27 Thread Keerthy
On 28/06/19 10:44 AM, Eric Biggers wrote: On Fri, Jun 28, 2019 at 09:57:42AM +0530, Keerthy wrote: +static int sa_sham_update(struct ahash_request *req) +{ + return -ENOTSUPP; +} + +static int sa_sham_final(struct ahash_request *req) +{ + return sa_sham_digest(req); +} + +static

Re: [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver

2019-06-27 Thread Keerthy
On 28/06/19 10:55 AM, Eric Biggers wrote: On Fri, Jun 28, 2019 at 10:44:26AM +0530, keerthy wrote: On 6/28/2019 10:23 AM, Eric Biggers wrote: Hi Keerthy, On Fri, Jun 28, 2019 at 09:57:35AM +0530, Keerthy wrote: The series adds Crypto hardware accelerator support for SA2UL. SA2UL stands

Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

2019-06-27 Thread Keerthy
On 28/06/19 10:39 AM, Eric Biggers wrote: On Fri, Jun 28, 2019 at 09:57:40AM +0530, Keerthy wrote: The transform function can be used as is by other crypto drivers that need to transform the 256 bit key using cpu. Hence export it. What is this supposed to mean? SHA-256 is an unkeyed hash

Re: [RESEND PATCH 02/10] crypto: sa2ul: Add crypto driver

2019-06-27 Thread Keerthy
On 28/06/19 10:37 AM, Eric Biggers wrote: On Fri, Jun 28, 2019 at 09:57:37AM +0530, Keerthy wrote: The Security Accelerator (SA2_UL) subsystem provides hardware cryptographic acceleration for the following use cases: • Encryption and authentication for secure boot • Encryption and

Re: [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver

2019-06-27 Thread keerthy
On 6/28/2019 10:23 AM, Eric Biggers wrote: Hi Keerthy, On Fri, Jun 28, 2019 at 09:57:35AM +0530, Keerthy wrote: The series adds Crypto hardware accelerator support for SA2UL. SA2UL stands for security accelerator ultra lite. The Security Accelerator (SA2_UL) subsystem provides hardware

[RESEND PATCH 10/10] arm64: dts: k3-am6: Add crypto accelarator node

2019-06-27 Thread Keerthy
Add crypto accelarator node. Define the psil specific config node as well. This can be used in Packet Mode alone. Signed-off-by: Keerthy --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 33 1 file changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65

[RESEND PATCH 04/10] crypto: sa2ul: Add aead support for hmac(sha1)cbc(aes) algorithm

2019-06-27 Thread Keerthy
bytes is used for authetication and AES in CBC mode is used in conjunction for encryption/decryption. Signed-off-by: Keerthy --- drivers/crypto/sa2ul.c | 402 + 1 file changed, 402 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c

[RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support

2019-06-27 Thread Keerthy
hmac(sha1) HMAC algorithm support and the message digest size is 20 bytes. Signed-off-by: Keerthy --- drivers/crypto/sa2ul.c | 347 + 1 file changed, 347 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 9c9008e21867

[RESEND PATCH 06/10] crypto: sa2ul: Add hmac(sha256)cbc(aes) AEAD Algo support

2019-06-27 Thread Keerthy
32 bytes is used for authetication and AES in CBC mode is used in conjunction for encryption/decryption. Signed-off-by: Keerthy --- drivers/crypto/sa2ul.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto

[RESEND PATCH 02/10] crypto: sa2ul: Add crypto driver

2019-06-27 Thread Keerthy
: Keerthy --- drivers/crypto/Kconfig | 17 + drivers/crypto/Makefile |1 + drivers/crypto/sa2ul.c | 1151 +++ drivers/crypto/sa2ul.h | 384 + 4 files changed, 1553 insertions(+) create mode 100644 drivers/crypto/sa2ul.c create mode 100644 drivers

[RESEND PATCH 09/10] sa2ul: Add 3DES ECB & CBC Mode support

2019-06-27 Thread Keerthy
Triple DES (3DES), officially the Triple Data Encryption Algorithm (TDEA or Triple DEA), is a symmetric-key block cipher, which applies the DES cipher algorithm three times to each data block Add 3DES ECB(Electronic code book) & CBC(Cipher Block Chaining) Mode support. Signed-off-by: Kee

[RESEND PATCH 08/10] crypto: sa2ul: Add hmac(sha256) HMAC algorithm support

2019-06-27 Thread Keerthy
hmac(sha256) HMAC algorithm support and the message digest size is 32 bytes. Signed-off-by: Keerthy --- drivers/crypto/sa2ul.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index e3a1321f0666

[RESEND PATCH 01/10] dt-bindings: crypto: k3: Add sa2ul bindings documentation

2019-06-27 Thread Keerthy
authentication of content in applications requiring DRM (digital rights management) and content/asset protection The device includes one instantiation of SA2_UL named SA2_UL0 SA2UL needs on tx channel and a pair of rx dma channels. Signed-off-by: Keerthy --- .../devicetree/bindings/crypto

[RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

2019-06-27 Thread Keerthy
The transform function can be used as is by other crypto drivers that need to transform the 256 bit key using cpu. Hence export it. Signed-off-by: Keerthy --- crypto/sha256_generic.c | 3 ++- include/crypto/sha.h| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto

[RESEND PATCH 00/10] crypto: k3: Add sa2ul driver

2019-06-27 Thread Keerthy
top of: https://patchwork.kernel.org/project/linux-dmaengine/list/?series=114105 The above series adds couple of dmaengine APIs that are used by the sa2ul driver. Hence there is a hard dependency on the above series. Resending with linux-crypto list in Cc. Keerthy (10): dt-bindings: crypto: k3

[RESEND PATCH 03/10] crypto: sa2ul: Add AES ECB Mode support

2019-06-27 Thread Keerthy
ciphertext value and vice versa. In other words, the same plaintext value will always result in the same ciphertext value. Signed-off-by: Keerthy --- drivers/crypto/sa2ul.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers