Re: [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support

[Keerthy]

On 28/06/19 10:44 AM, Eric Biggers wrote:

On Fri, Jun 28, 2019 at 09:57:42AM +0530, Keerthy wrote:

+static int sa_sham_update(struct ahash_request *req)
+{
+       return -ENOTSUPP;
+}
+
+static int sa_sham_final(struct ahash_request *req)
+{
+       return sa_sham_digest(req);
+}
+
+static int sa_sham_finup(struct ahash_request *req)
+{
+       return sa_sham_digest(req);
+}

You can't just not support update().  You need to support update().

Okay. I will add that.

- Eric