Re: [PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce

Hi Rob, Thanks for your review. On Wed, 17 Mar 2021 at 03:58, Rob Herring wrote: > > On Wed, Mar 10, 2021 at 10:54:57AM +0530, Bhupesh Sharma wrote: > > Newer qcom chips support newer versions of the qce IP, so add > > new compatible strings for qcom-qce (in addition to the

Re: [PATCH 4/8] dt-bindings/clock: qcom: sm8250: Add gcc clocks for sm8250 crypto block

Hi Stephen, Thanks for the review. On Sun, 14 Mar 2021 at 02:45, Stephen Boyd wrote: > > Quoting Bhupesh Sharma (2021-03-09 21:24:59) > > This patch adds the global clock controller (gcc) clocks required > > $ git grep "This patch" -- Documentation/process/submit

[PATCH 8/8] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine.

kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/

[PATCH 7/8] drivers: crypto: qce: Enable support for crypto engine on sm8250.

Andy Gross Cc: Herbert Xu Cc: David S. Miller Cc: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- drivers/crypto/qce/

[PATCH 6/8] clk: qcom: Add gcc clocks for crypto block on sm8250

: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- drivers/clk/qcom/gcc-sm8250.c | 44 +++ 1

[PATCH 4/8] dt-bindings/clock: qcom: sm8250: Add gcc clocks for sm8250 crypto block

. Miller Cc: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- include/dt-bindings/clock/qcom,gcc-sm8250.h | 3 +++ 1 file

[PATCH 5/8] clk: qcom: clk-rpmh: Add CE clock on sm8250

c: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- drivers/clk/qcom/clk-rpmh.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 3/8] arm64/dts: qcom: sdm845: Use RPMH_CE_CLK macro directly

r.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm6

[PATCH 1/8] dt-bindings: qcom-qce: Add 'iommus' to required properties

c: David S. Miller Cc: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- Documentation/devicetree/bindings/crypto/qcom-q

[PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce

r.kernel.org Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- Documentation/devicetree/bindings/crypto/qcom-qce.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qco

[PATCH 0/8] Enable Qualcomm Crypto Engine on sm8250

Cc: linux-...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: bhupesh.li...@gmail.com Bhupesh Sharma (8): dt-bindings: qcom-qce: Add 'iommus' to required properties dt-bindings: crypto : Add new compatible strings for qcom-qce arm

Re: [PATCH v5 1/4] tee: add bus driver framework for TEE based devices

D(typec_device_id, mode); > > > > > > + DEVID(tee_client_device_id); > > > + DEVID_FIELD(tee_client_device_id, uuid); > > > + > > > return 0; > > > } > > > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > > > index a37af7d..d0e4172 100644 > > > --- a/scripts/mod/file2alias.c > > > +++ b/scripts/mod/file2alias.c > > > @@ -37,6 +37,9 @@ typedef unsigned char __u8; > > > typedef struct { > > > __u8 b[16]; > > > } uuid_le; > > > +typedef struct { > > > + __u8 b[16]; > > > +} uuid_t; > > > > > > /* Big exception to the "don't include kernel headers into userspace, > > > which > > > * even potentially has different endianness and word sizes, since > > > @@ -1287,6 +1290,21 @@ static int do_typec_entry(const char *filename, > > > void *symval, char *alias) > > > return 1; > > > } > > > > > > +/* Looks like: tee:uuid */ > > > +static int do_tee_entry(const char *filename, void *symval, char *alias) > > > +{ > > > + DEF_FIELD(symval, tee_client_device_id, uuid); > > > + > > > + sprintf(alias, > > > "tee:%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x", > > > + uuid.b[0], uuid.b[1], uuid.b[2], uuid.b[3], uuid.b[4], > > > + uuid.b[5], uuid.b[6], uuid.b[7], uuid.b[8], uuid.b[9], > > > + uuid.b[10], uuid.b[11], uuid.b[12], uuid.b[13], uuid.b[14], > > > + uuid.b[15]); > > > + > > > + add_wildcard(alias); > > > + return 1; > > > +} > > > + > > > /* Does namelen bytes of name exactly match the symbol? */ > > > static bool sym_is(const char *name, unsigned namelen, const char > > > *symbol) > > > { > > > @@ -1357,6 +1375,7 @@ static const struct devtable devtable[] = { > > > {"fslmc", SIZE_fsl_mc_device_id, do_fsl_mc_entry}, > > > {"tbsvc", SIZE_tb_service_id, do_tbsvc_entry}, > > > {"typec", SIZE_typec_device_id, do_typec_entry}, > > > + {"tee", SIZE_tee_client_device_id, do_tee_entry}, > > > }; > > > > > > /* Create MODULE_ALIAS() statements. > > > -- > > > 2.7.4 > > > With Daniel's inputs addressed, for this patch: Reviewed-by: Bhupesh Sharma Thanks

Re: [PATCH v4 1/4] tee: add bus driver framework for TEE based devices

tee_client_device_id id; > + struct device dev; > +}; > + > +#define to_tee_client_device(d) container_of(d, struct tee_client_device, > dev) > + > +/** > + * struct tee_client_driver - tee client driver > + * @id_table: device id table supported by this driver > + * @driver:driver structure > + */ > +struct tee_client_driver { > + const tee_client_device_id *id_table; > + struct device_driver driver; > +}; > + > +#define to_tee_client_driver(d) \ > + container_of(d, struct tee_client_driver, driver) > + > #endif /*__TEE_DRV_H*/ > -- > 2.7.4 > LGTM, if there are no further comments on this patch please free to add: Reviewed-by: Bhupesh Sharma Thanks.

Re: [PATCH v3 1/4] tee: add bus driver framework for TEE based devices

Hi Sumit, Thanks for the patch. Some nitpicks in-line: On 01/11/2019 05:17 PM, Sumit Garg wrote: Introduce a generic TEE bus driver concept for TEE based kernel drivers which would like to communicate with TEE based devices/services. In this TEE bus concept, devices/services are identified via

Re: [PATCH v1 2/2] hwrng: add OP-TEE based rng driver

Hi Sumit, Jens, On Wed, Jan 2, 2019 at 1:34 PM Jens Wiklander wrote: > > On Mon, Dec 31, 2018 at 11:24 AM Sumit Garg wrote: > > > > On Fri, 28 Dec 2018 at 20:16, Jens Wiklander > > wrote: > > > > > > Hi Sumit, > > > > > > On Fri, Dec 28, 2018 at 06:33:22PM +0530, Sumit Garg wrote: > > > > On F