[PATCH v2] ecc: delete a useless function declaration

2021-04-05 Thread Meng Yu
This function declaration has been added in 'ecc_curve.h', delete it in 'crypto/ecc.h'. Fixes: 4e6602916bc6(crypto: ecdsa - Add support for ECDSA ...) Signed-off-by: Meng Yu --- v1 -> v2: Modify the 'Fixes tag' from '14bb76768275' to '4e6602916bc6 '. --- crypto/ecc.h | 8 1 file chang

Re: [PATCH] ecc: delete a useless function declaration

2021-04-05 Thread yumeng
在 2021/4/2 18:34, Christophe Leroy 写道: Le 02/04/2021 à 11:55, Meng Yu a écrit : This function declaration has been added in 'ecc_curve.h', delete it in 'crypto/ecc.h'. Fixes: 14bb76768275(crypto: ecc - expose ecc curves) Fixes tag is wrong I think, should be 4e6602916bc6 Yes, you are

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-05 Thread yumeng
在 2021/4/2 18:22, Herbert Xu 写道: On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote: I think it is not a real bug, and soft fallback setkey can always catch the error. But our original intention was to make it don't go to 'xxx_set_pub_key' when the key is null, and it can return an error

Re: [PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO

2021-04-05 Thread Eric Biggers
On Mon, Apr 05, 2021 at 11:04:38AM -0400, Julian Braha wrote: > Currently, when a config option selects a > CRYPTO_LIB_* option while CRYPTO is disabled, > Kbuild gives an unmet dependency. However, > these config options do not actually need to > depend on CRYPTO. > > Signed-off-by: Julian Braha

Re: [PATCH 3/7] crypto: qce: Add mode for rfc4309

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > rf4309 is the specification that uses aes ccm algorithms with IPsec > security packets. Add a submode to identify rfc4309 ccm(aes) algorithm > in the crypto driver. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.h | 7 ++

Re: [PATCH 2/7] crypto: qce: common: Make result dump optional

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > Qualcomm crypto engine allows for IV registers and status register > to be concatenated to the output. This option is enabled by setting the > RESULTS_DUMP field in GOPROC register. This is useful for most of the > algorithms to either retriev

Re: [PATCH 6/7] crypto: qce: common: Add support for AEAD algorithms

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > Add register programming sequence for enabling AEAD > algorithms on the Qualcomm crypto engine. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 155 +++- > 1 file changed, 153 insertion

HI,

2021-04-05 Thread Vanina curt
How are you? I'm Vanina. I picked interest in you and I would like to know more about you and establish relationship with you. i will wait for your response. thank you.

Re: [PATCH 1/7] crypto: qce: common: Add MAC failed error checking

2021-04-05 Thread Bjorn Andersson
On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote: > MAC_FAILED gets set in the status register if authenthication fails > for ccm algorithms(during decryption). Add support to catch and flag > this error. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 11 --- >

Re: [PATCH 2/5] crypto: ccp: Reject SEV commands with mismatching command buffer

2021-04-05 Thread Tom Lendacky
On 4/5/21 11:33 AM, Sean Christopherson wrote: > On Mon, Apr 05, 2021, Tom Lendacky wrote: >> On 4/2/21 6:36 PM, Sean Christopherson wrote: >>> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c >>> index 6556d220713b..4c513318f16a 100644 >>> --- a/drivers/crypto/ccp/sev-de

Re: [PATCH 2/5] crypto: ccp: Reject SEV commands with mismatching command buffer

2021-04-05 Thread Tom Lendacky
On 4/2/21 6:36 PM, Sean Christopherson wrote: > WARN on and reject SEV commands that provide a valid data pointer, but do > not have a known, non-zero length. And conversely, reject commands that > take a command buffer but none is provided. > > Aside from sanity checking intput, disallowing a no

Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work inside netns

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote: > There is same problem found in linux 4.19.y as upstream commit. The > changes of crypto_user_* and cryptouser.h files from upstream patch are > merged into > crypto/crypto_user.c for backporting. > > Upstream commit: > commit 9

Re: [PATCH 3/5] crypto: ccp: Play nice with vmalloc'd memory for SEV command structs

2021-04-05 Thread Brijesh Singh
On 4/5/21 10:06 AM, Sean Christopherson wrote: > On Sun, Apr 04, 2021, Christophe Leroy wrote: >> Le 03/04/2021 à 01:37, Sean Christopherson a écrit : >>> @@ -152,11 +153,21 @@ static int __sev_do_cmd_locked(int cmd, void *data, >>> int *psp_ret) >>> sev = psp->sev_data; >>> buf_len = se

[PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO

2021-04-05 Thread Julian Braha
Currently, when a config option selects a CRYPTO_LIB_* option while CRYPTO is disabled, Kbuild gives an unmet dependency. However, these config options do not actually need to depend on CRYPTO. Signed-off-by: Julian Braha --- crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] backports: crypto user - make NETLINK_CRYPTO work inside netns

2021-04-05 Thread Jianmin Wang
There is same problem found in linux 4.19.y as upstream commit. The changes of crypto_user_* and cryptouser.h files from upstream patch are merged into crypto/crypto_user.c for backporting. Upstream commit: commit 91b05a7e7d8033a90a64f5fc0e3808db423e420a Author: Ondrej Mosnacek Dat