Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Sumit Garg
On Tue, 23 Mar 2021 at 22:04, Ahmad Fatoum wrote: > > Hello Horia, > > On 21.03.21 21:01, Horia Geantă wrote: > > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: > >> This patch series builds on top of Sumit's rework to have the CAAM as yet > >> another > >> trusted key backend. > >> > > Shouldn't the

Re: [PATCH] init/Kconfig: Support sign module with SM3 hash algorithm

2021-03-23 Thread Ard Biesheuvel
On Tue, 23 Mar 2021 at 09:36, Tianjia Zhang wrote: > > The kernel module signature supports the option to use the SM3 > secure hash (OSCCA GM/T 0004-2012 SM3). > > Signed-off-by: Tianjia Zhang A secure hash is not the same as a signature. Looking at the patch, the asymmetric algorithm that is us

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Mimi Zohar
On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote: > Hello Horia, > > On 21.03.21 21:48, Horia Geantă wrote: > > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: > > [...] > >> +struct trusted_key_ops caam_trusted_key_ops = { > >> + .migratable = 0, /* non-migratable */ > >> + .init = trusted_caam_

Re: [PATCH] init/Kconfig: Support sign module with SM3 hash algorithm

2021-03-23 Thread Randy Dunlap
On 3/23/21 1:35 AM, Tianjia Zhang wrote: > The kernel module signature supports the option to use the SM3 > secure hash (OSCCA GM/T 0004-2012 SM3). > > Signed-off-by: Tianjia Zhang > --- > Documentation/admin-guide/module-signing.rst | 5 +++-- > crypto/asymmetric_keys/pkcs7_parser.c| 7

Re: [PATCH v1 1/3] crypto: caam - add in-kernel interface for blob generator

2021-03-23 Thread Ahmad Fatoum
Hello Horia, On 21.03.21 21:46, Horia Geantă wrote: > On 3/16/2021 7:01 PM, Ahmad Fatoum wrote: >> +init_job_desc(desc, 0); >> +append_key_as_imm(desc, keymod, keymod_len, keymod_len, >> + CLASS_2 | KEY_DEST_CLASS_REG); >> +append_seq_in_ptr(desc, dma_in, length -

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Ahmad Fatoum
Hello Horia, On 21.03.21 21:01, Horia Geantă wrote: >> - [RFC] drivers: crypto: caam: key: Add caam_tk key type >>Franck added[3] a new "caam_tk" key type based on Udit's work. The key >>material stays within the kernel only, but can optionally be user-set >>instead of coming from RNG

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Ahmad Fatoum
Hello Horia, On 21.03.21 21:48, Horia Geantă wrote: > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: > [...] >> +struct trusted_key_ops caam_trusted_key_ops = { >> +.migratable = 0, /* non-migratable */ >> +.init = trusted_caam_init, >> +.seal = trusted_caam_seal, >> +.unseal = trusted_

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Ahmad Fatoum
Hello Horia, On 21.03.21 21:01, Horia Geantă wrote: > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: >> This patch series builds on top of Sumit's rework to have the CAAM as yet >> another >> trusted key backend. >> > Shouldn't the description under TRUSTED_KEYS (in security/keys/Kconfig) > be updated

[PATCH] init/Kconfig: Support sign module with SM3 hash algorithm

2021-03-23 Thread Tianjia Zhang
The kernel module signature supports the option to use the SM3 secure hash (OSCCA GM/T 0004-2012 SM3). Signed-off-by: Tianjia Zhang --- Documentation/admin-guide/module-signing.rst | 5 +++-- crypto/asymmetric_keys/pkcs7_parser.c| 7 +++ init/Kconfig |

Re: [PATCH -next] crypto: hisilicon/hpre: fix link error

2021-03-23 Thread tanghui20
There is a patch similar to yours that was send in advance, as follows: https://www.spinics.net/lists/linux-crypto/msg54238.html On 2021/3/23 15:27, Yang Yingliang wrote: Fix the follow link error by select config CRYPTO_ECC and CRYPTO_ECDH. ERROR: modpost: "ecc_get_curve25519" [drivers/crypto

[PATCH -next] crypto: hisilicon/hpre: fix link error

2021-03-23 Thread Yang Yingliang
Fix the follow link error by select config CRYPTO_ECC and CRYPTO_ECDH. ERROR: modpost: "ecc_get_curve25519" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined! ERROR: modpost: "ecc_get_curve" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined! ERROR: modpost: "crypto_ecdh_decode_key" [d