[PATCH] crypto: ccree - Delete non-standard algorithms

2020-07-27 Thread Herbert Xu
This patch deletes non-standard algorithms such as essiv512 and essiv4096 which have no corresponding generic implementation. Signed-off-by: Herbert Xu diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c index f5b75b6d9ad4a..83567b60d6908 100644 --- a/drivers/crypto/

Re: [PATCH 2/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-07-27 Thread David Miller
From: Srujana Challa Date: Mon, 27 Jul 2020 14:12:46 + > On our test setup, the build is always successful, as we are adding > "af/" subdirectory in ccflags list ([PATCH 4/4] crypto: marvell: > enable OcteonTX2 cpt options for build). A patch series must be fully bisectable, the tree must bu

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Ido Schimmel
On Mon, Jul 27, 2020 at 06:15:55PM +0200, Christoph Hellwig wrote: > I have to admit I didn't spot the difference between the good and the > bad output even after trying hard.. > > But can you try the patch below? > > --- > From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 >

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Jason A. Donenfeld
> From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Mon, 27 Jul 2020 17:42:27 +0200 > Subject: net: remove sockptr_advance > > sockptr_advance never properly worked. Replace it with _offset variants > of copy_from_sockptr and copy_to_sockptr.

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 06:16:32PM +0200, Jason A. Donenfeld wrote: > Maybe sockptr_advance should have some safety checks and sometimes > return -EFAULT? Or you should always use the implementation where > being a kernel address is an explicit bit of sockptr_t, rather than > being implicit? I alr

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Jason A. Donenfeld
On Mon, Jul 27, 2020 at 5:06 PM Christoph Hellwig wrote: > > On Mon, Jul 27, 2020 at 05:03:10PM +0200, Jason A. Donenfeld wrote: > > Hi Christoph, > > > > On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > > > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > > > ind

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
Can you try the patch below? --- >From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 27 Jul 2020 17:42:27 +0200 Subject: net: remove sockptr_advance sockptr_advance never properly worked. Replace it with _offset variants of copy_from_sockpt

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Christoph Hellwig
I have to admit I didn't spot the difference between the good and the bad output even after trying hard.. But can you try the patch below? --- >From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 27 Jul 2020 17:42:27 +0200 Subject: net: remov

[PATCH] ARM: multi_v7_defconfig: enable caam crypto module

2020-07-27 Thread Horia Geantă
caam crypto module is included in several ARMv7-based SoCs from i.MX, Layerscape, Vybrid families. Signed-off-by: Horia Geantă --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig in

Re: [PATCH] crypto: x86/curve25519 - Remove unused carry variables

2020-07-27 Thread Jason A. Donenfeld
On Mon, Jul 27, 2020 at 5:08 PM Karthik Bhargavan wrote: > > Removing unused variables is harmless. (GCC would do this automaticelly.) > So this change seems fine. Thanks for confirming. Hopefully we can get that change upstream in HACL* too, so that the code comes out the same. Acked-by: Jason

Re: [PATCH] crypto: x86/curve25519 - Remove unused carry variables

2020-07-27 Thread Karthik Bhargavan
Reviewed-by: Karthikeyan Bhargavan > On 27 Jul 2020, at 17:08, Karthik Bhargavan > wrote: > > Removing unused variables is harmless. (GCC would do this automaticelly.) > So this change seems fine. > > -Karthik > >> On 23 Jul 2020, at 12:05, Jason A. Donenfeld wrote: >> >> Hi Herbert, >> >

Re: [PATCH] crypto: x86/curve25519 - Remove unused carry variables

2020-07-27 Thread Karthik Bhargavan
Removing unused variables is harmless. (GCC would do this automaticelly.) So this change seems fine. -Karthik > On 23 Jul 2020, at 12:05, Jason A. Donenfeld wrote: > > Hi Herbert, > > On Thu, Jul 23, 2020 at 9:51 AM Herbert Xu > wrote: >> >> The carry variables are assigned but never used,

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 05:03:10PM +0200, Jason A. Donenfeld wrote: > Hi Christoph, > > On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > > index da933f99b5d517..42befbf12846c0 100644 > > --- a/net/ipv4/ip_sockglue

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Jason A. Donenfeld
Hi Christoph, On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > index da933f99b5d517..42befbf12846c0 100644 > --- a/net/ipv4/ip_sockglue.c > +++ b/net/ipv4/ip_sockglue.c > @@ -1422,7 +1422,8 @@ int ip_setsockopt(stru

RE: get rid of the address_space override in setsockopt v2

2020-07-27 Thread David Laight
From: Al Viro > Sent: 27 July 2020 14:48 > > On Mon, Jul 27, 2020 at 09:51:45AM +, David Laight wrote: > > > I'm sure there is code that processes options in chunks. > > This probably means it is possible to put a chunk boundary > > at the end of userspace and continue processing the very sta

RE: [PATCH 2/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-07-27 Thread Srujana Challa
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of David Miller > Sent: Saturday, July 25, 2020 8:45 AM > To: Srujana Challa > Cc: herb...@gondor.apana.org.au; net...@vger.kernel.org; linux- > cry...@vger.kernel.org; Suheil Chandran ; Naray

Re: get rid of the address_space override in setsockopt v2

2020-07-27 Thread Al Viro
On Mon, Jul 27, 2020 at 09:51:45AM +, David Laight wrote: > I'm sure there is code that processes options in chunks. > This probably means it is possible to put a chunk boundary > at the end of userspace and continue processing the very start > of kernel memory. > > At best this faults on the

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Ido Schimmel
On Mon, Jul 27, 2020 at 03:00:29PM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 03:15:05PM +0300, Ido Schimmel wrote: > > I see a regression with IPv6 flowlabel that I bisected to this patch. > > When passing '-F 0' to 'ping' the flow label should be random, yet it's > > the same every

RE: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread David Laight
From: Ido Schimmel > Sent: 27 July 2020 13:15 > On Thu, Jul 23, 2020 at 08:09:01AM +0200, Christoph Hellwig wrote: > > Pass a sockptr_t to prepare for set_fs-less handling of the kernel > > pointer from bpf-cgroup. > > > > Note that the get case is pretty weird in that it actually copies data > > b

crypto: aegis128: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t'

2020-07-27 Thread Andrea Righi
I'm experiencing this build error on arm64 after updating to gcc 10: crypto/aegis128-neon-inner.c: In function 'crypto_aegis128_init_neon': crypto/aegis128-neon-inner.c:151:3: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t' 151 | k ^ vld1q_u8(const0),

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 03:15:05PM +0300, Ido Schimmel wrote: > I see a regression with IPv6 flowlabel that I bisected to this patch. > When passing '-F 0' to 'ping' the flow label should be random, yet it's > the same every time after this patch. Can you send a reproducer? > > It seems that the

[PATCH] hwrng: imx-rngc - setup default RNG quality

2020-07-27 Thread Christian Eggers
When hw_random device's quality is non-zero, it will automatically fill the kernel's entropy pool at boot. For this purpose, one conservative quality value is being picked up as the default value. Signed-off-by: Christian Eggers --- drivers/char/hw_random/imx-rngc.c | 1 + 1 file changed, 1 ins

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Ido Schimmel
On Thu, Jul 23, 2020 at 08:09:01AM +0200, Christoph Hellwig wrote: > Pass a sockptr_t to prepare for set_fs-less handling of the kernel > pointer from bpf-cgroup. > > Note that the get case is pretty weird in that it actually copies data > back to userspace from setsockopt. > > Signed-off-by: Chr

[PATCH 2/3] hwrng: imx-rngc - make clock optional

2020-07-27 Thread Christian Eggers
On i.MX6 ULL the RNGB has no switchable clock. Signed-off-by: Christian Eggers --- drivers/char/hw_random/imx-rngc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index 9c47e431ce90..f9c5ddd0276b 100644

Re: [PATCH 1/3] ARM: dts: imx6ull: Add rngb node

2020-07-27 Thread Fabio Estevam
Hi Christian, On Mon, Jul 27, 2020 at 8:00 AM Christian Eggers wrote: > > The RNGB block on 6ull has no major differences, but it has no > switchable clock. Horia has already sent a patch series that adds imx6ull rngb support: https://lkml.org/lkml/2020/7/23/173

[PATCH 3/3] hwrng: imx-rngc - setup default RNG quality

2020-07-27 Thread Christian Eggers
When hw_random device's quality is non-zero, it will automatically fill the kernel's entropy pool at boot. For this purpose, one conservative quality value is being picked up as the default value. Signed-off-by: Christian Eggers --- drivers/char/hw_random/imx-rngc.c | 1 + 1 file changed, 1 ins

[PATCH] Support for RNGB on i.MX6 ULL

2020-07-27 Thread Christian Eggers
This small series adds support for the Random Number Generator on the i.MX6 ULL SoC.

[PATCH 1/3] ARM: dts: imx6ull: Add rngb node

2020-07-27 Thread Christian Eggers
The RNGB block on 6ull has no major differences, but it has no switchable clock. Signed-off-by: Christian Eggers --- arch/arm/boot/dts/imx6ull.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx6ull.dtsi b/arch/arm/boot/dts/imx6ull.dtsi index fcde7f77ae42..3d021b

[bug report] crypto: sa2ul - Add crypto driver

2020-07-27 Thread dan.carpenter
Hello Keerthy, The patch 7694b6ca649f: "crypto: sa2ul - Add crypto driver" from Jul 13, 2020, leads to the following static checker warning: drivers/crypto/sa2ul.c:1201 sa_run() error: 'mdptr' dereferencing possible ERR_PTR() drivers/crypto/sa2ul.c 1176 rxd->enc = req-

RE: get rid of the address_space override in setsockopt v2

2020-07-27 Thread David Laight
From: David Miller > Sent: 24 July 2020 23:44 > > From: Christoph Hellwig > Date: Thu, 23 Jul 2020 08:08:42 +0200 > > > setsockopt is the last place in architecture-independ code that still > > uses set_fs to force the uaccess routines to operate on kernel pointers. > > > > This series adds a ne

[PATCH] crypto: hifn_795x - switch from 'pci_' to 'dma_' API

2020-07-27 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'hifn_probe()' GFP_KERNEL can be used because it is