On 2019/9/4 18:25, Will Deacon wrote:
> On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
>> use it directly. hence just replace it.
>>
>> Signed-off-by: zhong jiang
>> ---
>> arch/arm64/crypto/aes-glue.c | 4 +---
>
On Wed, Sep 04, 2019 at 10:22:17PM -0700, Eric Biggers wrote:
>
> Okay, but what about external callers that pass in an error? (I mean, I don't
> actually see any currently, but the point of this patch is to allow it...)
> What would prevent the crash in scatterwalk_done() in that case?
With exte
On Wed, Sep 04, 2019 at 08:36:41AM +1000, Herbert Xu wrote:
> On Tue, Sep 03, 2019 at 08:50:20AM -0500, Eric Biggers wrote:
> >
> > Doesn't this re-introduce the same bug that my patch fixed -- that
> > scatterwalk_done() could be called after 0 bytes processed, causing a crash
> > in
> > scatterw
On Sun, Sep 01, 2019 at 10:35:23PM +0200, Hans de Goede wrote:
> Hi All,
>
> As promised here is a follow-up series to my earlier sha256 series.
>
> Note I have only compiled and tested this series on x86_64 !!
>
> All changes to architecture specific code on other archs have not even
> been te
On Sat, Aug 31, 2019 at 01:55:55PM +0200, Daniel Mack wrote:
> The timeriomem_rng driver only accesses the first 4 bytes of the given
> memory area and currently, it also forces that memory resource to be
> exactly 4 bytes in size.
>
> This, however, is problematic when used with device-trees that
Pascal van Leeuwen wrote:
> This patchset adds support for the AES-GCM and AES-CCM AEAD ciphersuites
> and the AES-CFB and AES-OFB feedback modes for AES.
>
> Pascal van Leeuwen (4):
> crypto: inside-secure - Added support for basic AES-GCM
> crypto: inside-secure - Added AES-CFB support
> cry
Pascal van Leeuwen wrote:
> Some minor cleanup changing e.g. "if (!x) A else B" to "if (x) B else A",
> merging some back-to-back if's with the same condition, collapsing some
> back-to-back assignments to the same variable and replacing some weird
> assignments with proper symbolics.
>
> Signed-
Pascal van Leeuwen wrote:
> Moved counter mode handling code in front as it doesn't depend on the
> rest of the code to be executed, it can just do its thing and exit.
>
> Signed-off-by: Pascal van Leeuwen
> ---
> drivers/crypto/inside-secure/safexcel_cipher.c | 25 ++---
> 1
Pascal van Leeuwen wrote:
> Instead of having a fixed value (of 300) all over the place, the value for
> for .cra_priority is now made into a define (SAFEXCEL_CRA_PRIORITY).
> This makes it easier to play with, e.g. during development.
>
> Signed-off-by: Pascal van Leeuwen
> ---
> drivers/crypto
Pascal van Leeuwen wrote:
> This patch adds support for the AES-XTS algorithm for HW that supports it.
>
> Pascal van Leeuwen (3):
> crypto: inside-secure - Move static cipher alg & mode settings to init
> crypto: inside-secure - Add support for the AES-XTS algorithm
> crypto: inside-secure -
On Wed, Aug 28, 2019 at 02:37:12PM +0800, Vic Wu wrote:
> From: Ryder Lee
>
> Move mtk_aes_find_dev() to right functions as nobody uses the
> 'cryp' under current flows.
>
> We can also avoid duplicate checks here and there in this way.
>
> Signed-off-by: Ryder Lee
> Signed-off-by: Vic Wu
> -
This patch fixes a number of warnings encountered when this driver
is built on a 64-bit platform with COMPILE_TEST.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c
b/drivers/crypto/ux500/cryp/cryp_core.c
index e966e9a64501..1628ae7a1467 100644
--- a/drivers/crypto/u
On Thu, Aug 29, 2019 at 01:30:29PM -0400, Daniel Jordan wrote:
> Hello,
>
> Everything in the Testing section has been rerun after the suggestion
> from Herbert last round. Thanks again to Steffen for giving this a run.
>
> Any comments welcome.
>
> Daniel
>
> v1[*] -> v2:
> - Updated patch
On Wed, Aug 28, 2019 at 06:14:21PM -0400, Daniel Jordan wrote:
>
> @@ -453,24 +456,15 @@ static void padata_free_pd(struct parallel_data *pd)
> /* Flush all objects out of the padata queues. */
> static void padata_flush_queues(struct parallel_data *pd)
> {
> - int cpu;
> - struct padata
Quoting Sebastian Andrzej Siewior (2019-09-04 04:00:38)
> On 2019-08-22 15:55:19 [+1000], Herbert Xu wrote:
> > Patch applied. Thanks.
> [ ff296293b3538 ("random: Support freezable kthreads in
> add_hwgenerator_randomness()") ]
>
> and since kthread_freezable_should_stop() has might_sleep() in i
The RFC4106 key derivation code instantiates an AES cipher transform
to encrypt only a single block before it is freed again. Switch to
the new AES library which is more suitable for such use cases.
Signed-off-by: Ard Biesheuvel
---
arch/x86/crypto/aesni-intel_glue.c | 17 ++---
1 fi
Hi Corentin,
Thanks for the review comments.
Please find my response/queries inline.
> -Original Message-
> From: Corentin Labbe
> Sent: Monday, September 2, 2019 12:29 PM
> To: Kalyani Akula
> Cc: herb...@gondor.apana.org.au; kstew...@linuxfoundation.org;
> gre...@linuxfoundation.org;
Zdravstvujte! Vas interesujut klientskie bazy dannyh?
Zdravstvujte! Vas interesujut klientskie bazy dannyh?
On 2019/9/4 20:26, Herbert Xu wrote:
> On Wed, Sep 04, 2019 at 05:10:34AM -0700, Ard Biesheuvel wrote:
>>
>> This is the reason we have so many empty static inline functions in
>> header files - it ensures that the symbols are declared even if the
>> only invocations are from dead code.
>
> Does t
On Wed, 4 Sep 2019 at 07:21, Harald Freudenberger wrote:
>
> On 22.08.19 12:24, Ard Biesheuvel wrote:
> > Fix a typo XTS_BLOCKSIZE -> XTS_BLOCK_SIZE, causing the build to
> > break.
> >
> > Signed-off-by: Ard Biesheuvel
> > ---
> > Apologies for the sloppiness.
> >
> > Herbert, could we please me
On 22.08.19 12:24, Ard Biesheuvel wrote:
> Fix a typo XTS_BLOCKSIZE -> XTS_BLOCK_SIZE, causing the build to
> break.
>
> Signed-off-by: Ard Biesheuvel
> ---
> Apologies for the sloppiness.
>
> Herbert, could we please merge this before cryptodev hits -next?
>
> arch/s390/crypto/aes_s390.c | 4 ++-
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.
Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics")
Signed-off-by: Wei Yongjun
---
drivers/crypto/cavium/zip/zip_main.c | 3 +++
1 file cha
On Wed, Sep 04, 2019 at 12:45:00PM +, Pascal Van Leeuwen wrote:
> So, with that patch you ONLY get a warning on that unused int rc, right?
>
> I do understand that one, that should have been inside an #ifdef as well.
> Everybody happy if I just fix that and leave the rest as is?
Yes please se
On Sun, 1 Sep 2019 at 13:35, Hans de Goede wrote:
>
> Hi All,
>
> As promised here is a follow-up series to my earlier sha256 series.
>
> Note I have only compiled and tested this series on x86_64 !!
>
> All changes to architecture specific code on other archs have not even
> been tested to compil
So, with that patch you ONLY get a warning on that unused int rc, right?
I do understand that one, that should have been inside an #ifdef as well.
Everybody happy if I just fix that and leave the rest as is?
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, September 4, 2019 2:27 PM
> To: Pascal Van Leeuwen
> Cc: YueHaibing ; antoine.ten...@bootlin.com;
> herb...@gondor.apana.org.au; da...@davemloft.net;
> pvanleeu...@insidesecure.com; linux-
> cry...@vger.kernel.org; linux-ker.
On Wed, Sep 04, 2019 at 05:27:19AM -0700, Ard Biesheuvel wrote:
>
> Did you try disabling CONFIG_PCI?
Indeed. Even with my patch if you compile with CONFIG_PCI you still
get a warning:
CC [M] drivers/crypto/inside-secure/safexcel.o
../drivers/crypto/inside-secure/safexcel.c: In function
\u2
On Wed, 4 Sep 2019 at 05:25, Pascal Van Leeuwen
wrote:
>
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Wednesday, September 4, 2019 2:11 PM
> > To: Pascal Van Leeuwen
> > Cc: YueHaibing ; antoine.ten...@bootlin.com;
> > herb...@gondor.apana.org.au; da...@davemloft.net;
> > p
On Wed, Sep 04, 2019 at 05:10:34AM -0700, Ard Biesheuvel wrote:
>
> This is the reason we have so many empty static inline functions in
> header files - it ensures that the symbols are declared even if the
> only invocations are from dead code.
Does this patch work?
---8<---
This patch adds stub
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, September 4, 2019 2:11 PM
> To: Pascal Van Leeuwen
> Cc: YueHaibing ; antoine.ten...@bootlin.com;
> herb...@gondor.apana.org.au; da...@davemloft.net;
> pvanleeu...@insidesecure.com; linux-
> cry...@vger.kernel.org; linux-ker.
On Wed, 4 Sep 2019 at 04:57, Pascal Van Leeuwen
wrote:
>
>
> > -Original Message-
> > From: linux-crypto-ow...@vger.kernel.org
> > On Behalf Of
> > YueHaibing
> > Sent: Tuesday, September 3, 2019 3:45 AM
> > To: antoine.ten...@bootlin.com; herb...@gondor.apana.org.au;
> > da...@davemlof
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org
> On Behalf Of
> YueHaibing
> Sent: Tuesday, September 3, 2019 3:45 AM
> To: antoine.ten...@bootlin.com; herb...@gondor.apana.org.au;
> da...@davemloft.net;
> pvanleeu...@insidesecure.com
> Cc: linux-crypto@vger.kernel.org
On 2019-08-22 15:55:19 [+1000], Herbert Xu wrote:
> Patch applied. Thanks.
[ ff296293b3538 ("random: Support freezable kthreads in
add_hwgenerator_randomness()") ]
and since kthread_freezable_should_stop() has might_sleep() in it, I get
this:
|: do not call blocking ops when !TASK_RUNNING; stat
Good day,
I'm currently experimenting with the use of kexec() to change the
currently-running kernel on my test machine (Intel PC). So far, so
good: I'm able to change the currently-running kernel and initrd image
via kexec, and am now attempting to live-boot an ISO image (i.e.
Ubuntu 18.04 Server
On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote:
> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
> use it directly. hence just replace it.
>
> Signed-off-by: zhong jiang
> ---
> arch/arm64/crypto/aes-glue.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions
This patch adds support for the AES-CMAC authentication algorithm.
Signed-off-by: Pascal van Leeuwen
---
drivers/crypto/inside-secure/safexcel.c | 1 +
drivers/crypto/inside-secure/safexcel.h | 1 +
drivers/crypto/inside-secure/safexcel_hash.c | 99
3 fil
This patch adds support for the AES-CBCMAC authentication algorithm.
Signed-off-by: Pascal van Leeuwen
---
drivers/crypto/inside-secure/safexcel.c | 1 +
drivers/crypto/inside-secure/safexcel.h | 1 +
drivers/crypto/inside-secure/safexcel_hash.c | 235 ++-
3
This patchset adds support for the (AES) CBCMAC family of authentication
algorithms: AES-CBCMAC, AES-XCBCMAC and AES-MAC
It has been verified with a Xilinx PCIE FPGA board as well as the Marvell
Armada A8K based Macchiatobin development board.
Pascal van Leeuwen (3):
crypto: inside-secure - Adde
This patch adds support for the AES XCBC authentication algorithm
Signed-off-by: Pascal van Leeuwen
---
drivers/crypto/inside-secure/safexcel.c | 1 +
drivers/crypto/inside-secure/safexcel.h | 1 +
drivers/crypto/inside-secure/safexcel_hash.c | 136 ++-
3 fi
40 matches
Mail list logo
