On Wed, Sep 04, 2019 at 10:22:17PM -0700, Eric Biggers wrote: > > Okay, but what about external callers that pass in an error? (I mean, I don't > actually see any currently, but the point of this patch is to allow it...) > What would prevent the crash in scatterwalk_done() in that case?
With external callers the pages are always mapped and therefore they have to be unmapped, regardless of whether the actual crypto succeeded or not. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
