Re: [GIT] Crypto Fixes for 5.3

2019-08-30 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Aug 2019 17:39:06 +1000: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e0f14b8ca3882988d15f0b1b853ae3c29d8c9a83 Thank you! -- Deet-doot-dot, I am a bot

Re: [GIT] Crypto Fixes for 5.3

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 12:39 AM Herbert Xu wrote: > > This push fixes a potential crash in the ccp driver. Btw, Herbert, can you add "pull" somewhere in your pull request email? It could be in the subject line (ie change the "[GIT]" to "[GIT PULL]") but it could also be anywhere in the email bo

Re: [PATCH v1 2/2] hwrng: npcm: add NPCM RNG driver

2019-08-30 Thread Milton Miller II
On August 28th around 11:28AM in some timezone, Tomer Maimon wrote >Add Nuvoton NPCM BMC Random Number Generator(RNG) driver. > >Signed-off-by: Tomer Maimon >--- > drivers/char/hw_random/Kconfig| 13 ++ > drivers/char/hw_random/Makefile | 1 + > drivers/char/hw_random/npcm-rng.c | 207 >+++

[PATCH] arm64: dts: imx8mq: Add CAAM node

2019-08-30 Thread Andrey Smirnov
Add node for CAAM - Cryptographic Acceleration and Assurance Module. Signed-off-by: Horia Geantă Signed-off-by: Andrey Smirnov Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Herbert Xu Cc: Shawn Guo Cc: Iuliana Prodan Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org --

Re: [PATCH v8 00/16] crypto: caam - Add i.MX8MQ support

2019-08-30 Thread Andrey Smirnov
On Fri, Aug 30, 2019 at 6:35 AM Iuliana Prodan wrote: > > On 8/30/2019 4:16 PM, Herbert Xu wrote: > > On Fri, Aug 30, 2019 at 09:15:12AM +, Iuliana Prodan wrote: > >> > >> Can you, please, add, also, the device tree patch ("arm64: dts: imx8mq: > >> Add CAAM node") in cryptodev tree? > >> Unfor

Re: [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-08-30 Thread Jarkko Sakkinen
On Fri, Aug 30, 2019 at 08:20:31PM +0300, Jarkko Sakkinen wrote: > On Fri, Aug 30, 2019 at 02:49:31PM +0530, Sumit Garg wrote: > > Any comments/feedback on this patch before I send next version of TEE > > patch-set with this patch included? > > Unfortunately don't have time before LPC to go deep w

Re: [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-08-30 Thread Jarkko Sakkinen
On Fri, Aug 30, 2019 at 02:49:31PM +0530, Sumit Garg wrote: > Any comments/feedback on this patch before I send next version of TEE > patch-set with this patch included? Unfortunately don't have time before LPC to go deep with the follow up. I will look into this in detail after LPC. /JArkko

Re: [PATCH v8 00/16] crypto: caam - Add i.MX8MQ support

2019-08-30 Thread Iuliana Prodan
On 8/30/2019 4:16 PM, Herbert Xu wrote: > On Fri, Aug 30, 2019 at 09:15:12AM +, Iuliana Prodan wrote: >> >> Can you, please, add, also, the device tree patch ("arm64: dts: imx8mq: >> Add CAAM node") in cryptodev tree? >> Unfortunately Shawn Guo wasn't cc-ed on this patch and, to have the >> com

Re: [PATCH v8 00/16] crypto: caam - Add i.MX8MQ support

2019-08-30 Thread Herbert Xu
On Fri, Aug 30, 2019 at 09:15:12AM +, Iuliana Prodan wrote: > > Can you, please, add, also, the device tree patch ("arm64: dts: imx8mq: > Add CAAM node") in cryptodev tree? > Unfortunately Shawn Guo wasn't cc-ed on this patch and, to have the > complete support for imx8mq, in kernel v5.4, we

[cryptodev:master 241/242] include/asm-generic/qspinlock.h:65:55: warning: pointer targets in passing argument 2 of 'atomic_try_cmpxchg' differ in signedness

2019-08-30 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 1cfdc0f0fa7a98ba0d551fd03d2c45d5a318 commit: 9ecf5ad522e09d6e11a7e0a0b1845622a480f478 [241/242] crypto: sha256 - Add missing MODULE_LICENSE() to lib/crypto/sha256.c config: x86_64-randco

[cryptodev:master 219/242] drivers/crypto/inside-secure/safexcel.c:840:9: error: implicit declaration of function 'pci_irq_vector'; did you mean 'rcu_irq_enter'?

2019-08-30 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 1cfdc0f0fa7a98ba0d551fd03d2c45d5a318 commit: 625f269a5a7a3643771320387e474bd0a61d9654 [219/242] crypto: inside-secure - add support for PCI based FPGA development board config: m68k-allm

Re: [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-08-30 Thread Sumit Garg
On Tue, 13 Aug 2019 at 13:24, Sumit Garg wrote: > > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusked keys > support in case platform

Re: [PATCH v8 00/16] crypto: caam - Add i.MX8MQ support

2019-08-30 Thread Iuliana Prodan
On 8/30/2019 11:23 AM, Herbert Xu wrote: > Andrey Smirnov wrote: >> Everyone: >> >> Picking up where Chris left off (I chatted with him privately >> beforehead), this series adds support for i.MX8MQ to CAAM driver. Just >> like [v1], this series is i.MX8MQ only. >> >> Feedback is welcome! >> Thank

[PATCH 2/4] crypto: inside-secure - Added AES-CFB support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for AES in 128 bit cipher feedback mode (AES-CFB). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 ++ drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 1/4] crypto: inside-secure - Added support for basic AES-GCM

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the basic AES-GCM AEAD cipher suite. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 +- drivers/crypto/inside-secure/safexcel.h| 7 +- drivers/crypto/inside-secure/safexcel_cipher.c | 226 -

[PATCH 4/4] crypto: inside-secure - Added support for basic AES-CCM

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the basic AES-CCM AEAD cipher suite. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 +- drivers/crypto/inside-secure/safexcel.h| 10 +- drivers/crypto/inside-secure/safexcel_cipher.c | 288 -

[PATCH 3/4] crypto: inside-secure - Added AES-OFB support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for AES in output feedback mode (AES-OFB). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 ++ drivers/crypto/inside-secure/safexcel_cipher.c | 36 ++

[PATCH 0/4] Add support for AES-GCM, AES-CFB, AES-OFB and AES-CCM

2019-08-30 Thread Pascal van Leeuwen
This patchset adds support for the AES-GCM and AES-CCM AEAD ciphersuites and the AES-CFB and AES-OFB feedback modes for AES. Pascal van Leeuwen (4): crypto: inside-secure - Added support for basic AES-GCM crypto: inside-secure - Added AES-CFB support crypto: inside-secure - Added AES-OFB sup

[PATCH] crypto: inside-secure - Minor optimization recognizing CTR is always AES

2019-08-30 Thread Pascal van Leeuwen
Moved counter mode handling code in front as it doesn't depend on the rest of the code to be executed, it can just do its thing and exit. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_cipher.c | 25 ++--- 1 file changed, 14 insertions(+), 11 dele

[PATCH] crypto: inside-secure - Minor code cleanup and optimizations

2019-08-30 Thread Pascal van Leeuwen
Some minor cleanup changing e.g. "if (!x) A else B" to "if (x) B else A", merging some back-to-back if's with the same condition, collapsing some back-to-back assignments to the same variable and replacing some weird assignments with proper symbolics. Signed-off-by: Pascal van Leeuwen --- driver

[PATCH] crypto: inside-secure - Made .cra_priority value a define

2019-08-30 Thread Pascal van Leeuwen
Instead of having a fixed value (of 300) all over the place, the value for for .cra_priority is now made into a define (SAFEXCEL_CRA_PRIORITY). This makes it easier to play with, e.g. during development. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.h| 3 ++

[PATCH 2/3] crypto: inside-secure - Add support for the AES-XTS algorithm

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the AES-XTS skcipher algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 + drivers/crypto/inside-secure/safexcel_cipher.c | 124 - 3 file

[PATCH 3/3] crypto: inside-secure - Only enable algorithms advertised by the hardware

2019-08-30 Thread Pascal van Leeuwen
This patch probes the supported algorithms from the hardware and only registers the ones that the hardware actually supports. This is necessary because this is a generic driver supposed to run on a wide variety of engines, which may or may not implement certain algorithms. Signed-off-by: Pascal va

[PATCH 0/3] crypto: inside-secure - Add AES-XTS cipher support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the AES-XTS algorithm for HW that supports it. Pascal van Leeuwen (3): crypto: inside-secure - Move static cipher alg & mode settings to init crypto: inside-secure - Add support for the AES-XTS algorithm crypto: inside-secure - Only enable algorithms advertised by

[PATCH 1/3] crypto: inside-secure - Move static cipher alg & mode settings to init

2019-08-30 Thread Pascal van Leeuwen
ctx->alg and ctx->mode were set from safexcel_send_req through the various safexcel_encrypt and _decrypt routines, but this makes little sense as these are static per ciphersuite. So moved to _init instead, in preparation of adding more ciphersuites. Signed-off-by: Pascal van Leeuwen --- drivers

Re: [PATCH -next] crypto: atmel - Fix -Wunused-const-variable warning

2019-08-30 Thread Herbert Xu
On Thu, Aug 22, 2019 at 10:44:44PM +0800, YueHaibing wrote: > drivers/crypto/atmel-i2c.h:68:3: warning: > error_list defined but not used [-Wunused-const-variable=] > > error_list is only used in atmel-i2c.c, > so just move the definition over there. > > Reported-by: Hulk Robot > Signed-off-by:

Re: [PATCH] crypto: sha256 - Add missing MODULE_LICENSE() to lib/crypto/sha256.c

2019-08-30 Thread Herbert Xu
On Sun, Aug 25, 2019 at 08:18:41PM +0200, Hans de Goede wrote: > lib/crypto/sha256.c / lib/crypto/libsha256.o may end up being a module, > so it needs a MODULE_LICENSE() line, add this. > > Signed-off-by: Hans de Goede > --- > lib/crypto/sha256.c | 3 +++ > 1 file changed, 3 insertions(+) Patch

Re: [PATCH] crypto: ccp - invoke fallback for XTS ciphertext stealing

2019-08-30 Thread Herbert Xu
On Thu, Aug 22, 2019 at 06:47:31PM +0300, Ard Biesheuvel wrote: > For correctness and compliance with the XTS-AES specification, we are > adding support for ciphertext stealing to XTS implementations, even > though no use cases are known that will be enabled by this. > > Since the ccp driver alrea

Re: [PATCH v2 -next] crypto: hisilicon: select CRYPTO_LIB_DES while compiling SEC driver

2019-08-30 Thread Herbert Xu
On Wed, Aug 28, 2019 at 04:07:40PM +0800, Mao Wenan wrote: > When CRYPTO_DEV_HISI_SEC=y, below compilation error is found after > 'commit 894b68d8be4b ("crypto: hisilicon/des - switch to new verification > routines")': > > drivers/crypto/hisilicon/sec/sec_algs.o: In function > `sec_alg_skcipher

Re: [PATCH -next] crypto: nx - remove unused variables 'nx_driver_string' and 'nx_driver_version'

2019-08-30 Thread Herbert Xu
On Thu, Aug 22, 2019 at 10:46:49PM +0800, YueHaibing wrote: > drivers/crypto/nx/nx.h:12:19: warning: > nx_driver_string defined but not used [-Wunused-const-variable=] > drivers/crypto/nx/nx.h:13:19: warning: > nx_driver_version defined but not used [-Wunused-const-variable=] > > They are never

Re: [PATCH -next] crypto: aegis128 - Fix -Wunused-const-variable warning

2019-08-30 Thread Herbert Xu
On Thu, Aug 22, 2019 at 10:41:38PM +0800, YueHaibing wrote: > crypto/aegis.h:27:32: warning: > crypto_aegis_const defined but not used [-Wunused-const-variable=] > > crypto_aegis_const is only used in aegis128-core.c, > just move the definition over there. > > Reported-by: Hulk Robot > Signed-o

Re: [PATCH v8 00/16] crypto: caam - Add i.MX8MQ support

2019-08-30 Thread Herbert Xu
Andrey Smirnov wrote: > Everyone: > > Picking up where Chris left off (I chatted with him privately > beforehead), this series adds support for i.MX8MQ to CAAM driver. Just > like [v1], this series is i.MX8MQ only. > > Feedback is welcome! > Thanks, > Andrey Smirnov > > Changes since [v7]: > >

Re: [PATCH] crypto: caam/qi - use print_hex_dump_debug function to print debug messages

2019-08-30 Thread Herbert Xu
On Tue, Aug 20, 2019 at 02:26:39PM +0300, Iuliana Prodan wrote: > Use print_hex_dump_debug function to print debug messages, instead of > print_hex_dump inside #ifdef DEBUG. > > Fixes: 6e005503199b ("crypto: caam - print debug messages at debug level") > Signed-off-by: Iuliana Prodan > --- > dri

Re: [PATCHv5 0/4] crypto: inside-secure - broaden driver scope

2019-08-30 Thread Herbert Xu
On Mon, Aug 19, 2019 at 04:40:22PM +0200, Pascal van Leeuwen wrote: > This is a first baby step towards making the inside-secure crypto driver > more broadly useful. The current driver only works for Marvell Armada HW > and requires proprietary firmware, only available under NDA from Marvell, > to

Re: [PATCH v13 0/6] crypto: switch to crypto API for ESSIV generation

2019-08-30 Thread Herbert Xu
On Mon, Aug 19, 2019 at 05:17:32PM +0300, Ard Biesheuvel wrote: > This series creates an ESSIV template that produces a skcipher or AEAD > transform based on a tuple of the form ',' (or > ',' > for the AEAD case). It exposes the encapsulated sync or async skcipher/aead by > passing through all ope

Re: [PATCH 0/2] drivers/crypto - s5p fixes

2019-08-30 Thread Herbert Xu
On Mon, Aug 19, 2019 at 05:22:24PM +0300, Ard Biesheuvel wrote: > Fix a couple of issues in the s5p crypto driver that were caught in fuzz > testing. > > Cc: Krzysztof Kozlowski > Cc: Vladimir Zapolskiy > Cc: Kamil Konieczny > Cc: linux-samsung-...@vger.kernel.org > > Ard Biesheuvel (2): > c

Re: [PATCH] crypto: picoxcell - Fix the name of the module in the description of CRYPTO_DEV_PICOXCELL

2019-08-30 Thread Herbert Xu
On Mon, Aug 19, 2019 at 07:18:33AM +0200, Christophe JAILLET wrote: > The help section says that the module will be called 'pipcoxcell_crypto'. > This is likely a typo. > Use 'picoxcell_crypto' instead > > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/Kconfig | 2 +- > 1 file changed,

Re: [PATCH] crypto: arm64/aegis128 - use explicit vector load for permute vectors

2019-08-30 Thread Herbert Xu
On Mon, Aug 19, 2019 at 05:15:00PM +0300, Ard Biesheuvel wrote: > When building the new aegis128 NEON code in big endian mode, Clang > complains about the const uint8x16_t permute vectors in the following > way: > > crypto/aegis128-neon-inner.c:58:40: warning: vector initializers are not >

Re: [PATCH 08/17] crypto: skcipher - add the ability to abort a skcipher walk

2019-08-30 Thread Herbert Xu
On Wed, Aug 21, 2019 at 05:32:44PM +0300, Ard Biesheuvel wrote: > After starting a skcipher walk, the only way to ensure that all > resources it has tied up are released is to complete it. In some > cases, it will be useful to be able to abort a walk cleanly after > it has started, so add this abil

[GIT] Crypto Fixes for 5.3

2019-08-30 Thread Herbert Xu
Hi Linus: This push fixes a potential crash in the ccp driver. The following changes since commit e2664ecbb2f26225ac6646876f2899558ffb2604: crypto: ccp - Ignore tag length when decrypting GCM ciphertext (2019-08-02 14:36:36 +1000) are available in the Git repository at: git://git.kernel