Re: [PATCH v4 2/3] dt-bindings: rng: add bindings for MediaTek ARMv8 SoCs

2019-07-23 Thread Neal Liu
On Tue, 2019-07-23 at 08:35 -0600, Rob Herring wrote: > On Mon, Jul 22, 2019 at 8:21 PM Neal Liu wrote: > > > > Please don't top post to lists. > > > Dear Rob, > > You can check my driver for detail: > > http://patchwork.kernel.org/patch/11012475/ or patchset 3/3 > > I could, or

Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions

2019-07-23 Thread Thiago Jung Bauermann
Hello Philipp, Philipp Rudo writes: > Hi Thiago, > > On Thu, 04 Jul 2019 15:57:34 -0300 > Thiago Jung Bauermann wrote: > >> Hello Philipp, >> >> Philipp Rudo writes: >> >> > Hi Thiago, >> > >> > >> > On Thu, 04 Jul 2019 03:42:57 -0300 >> > Thiago Jung Bauermann wrote: >> > >> >> Jessic

Re: [PATCH v2 1/3] mm: Introduce page_size()

2019-07-23 Thread Matthew Wilcox
On Tue, Jul 23, 2019 at 01:44:16PM -0700, Ira Weiny wrote: > > > Side note: why 2 checks for !page? > > > > Because page is assigned to after the first check ... > > Ah yea duh! Sorry it is a bit hard to follow. This is one of those users who really wants the VM to fall back automatically to an

Re: [PATCH v2 1/3] mm: Introduce page_size()

2019-07-23 Thread Ira Weiny
On Tue, Jul 23, 2019 at 11:14:13AM -0700, Matthew Wilcox wrote: > On Tue, Jul 23, 2019 at 10:58:38AM -0700, Ira Weiny wrote: > > > @@ -1092,7 +1092,7 @@ int chtls_sendmsg(struct sock *sk, struct msghdr > > > *msg, size_t size) > > > if (page && off == pg_size) { > > >

Re: [PATCH v2 1/3] mm: Introduce page_size()

2019-07-23 Thread Matthew Wilcox
On Tue, Jul 23, 2019 at 10:58:38AM -0700, Ira Weiny wrote: > > @@ -1092,7 +1092,7 @@ int chtls_sendmsg(struct sock *sk, struct msghdr > > *msg, size_t size) > > if (page && off == pg_size) { > > put_page(page); > > TCP_PAG

Re: [PATCH v2 1/3] mm: Introduce page_size()

2019-07-23 Thread Ira Weiny
On Tue, Jul 23, 2019 at 09:02:48AM -0700, Matthew Wilcox wrote: > On Mon, Jul 22, 2019 at 05:43:07PM -0700, Ira Weiny wrote: > > > diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c > > > b/drivers/crypto/chelsio/chtls/chtls_io.c > > > index 551bca6fef24..925be5942895 100644 > > > --- a/drivers/

Re: [PATCH v2 1/3] mm: Introduce page_size()

2019-07-23 Thread Matthew Wilcox
On Mon, Jul 22, 2019 at 05:43:07PM -0700, Ira Weiny wrote: > > diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c > > b/drivers/crypto/chelsio/chtls/chtls_io.c > > index 551bca6fef24..925be5942895 100644 > > --- a/drivers/crypto/chelsio/chtls/chtls_io.c > > +++ b/drivers/crypto/chelsio/chtls/cht

Re: [PATCH v6 04/14] crypto: caam - request JR IRQ as the last step

2019-07-23 Thread Horia Geanta
On 7/17/2019 6:25 PM, Andrey Smirnov wrote: > In order to avoid any risk of JR IRQ request being handled while some > of the resources used for that are not yet allocated move the code > requesting said IRQ to the endo of caam_jr_init(). No functional ^ typo > change in

Re: [PATCH v6 03/14] crypto: caam - convert caam_jr_init() to use devres

2019-07-23 Thread Horia Geanta
On 7/17/2019 6:25 PM, Andrey Smirnov wrote: > Use deveres to allocate all of the resources in caam_jr_init() (DMA > coherent and regular memory, IRQs) drop calls to corresponding > deallocation routines. No functional change intended. > > Signed-off-by: Andrey Smirnov Reviewed-by: Horia Geantă

Re: [PATCH v4 2/3] dt-bindings: rng: add bindings for MediaTek ARMv8 SoCs

2019-07-23 Thread Rob Herring
On Mon, Jul 22, 2019 at 8:21 PM Neal Liu wrote: > Please don't top post to lists. > Dear Rob, > You can check my driver for detail: > http://patchwork.kernel.org/patch/11012475/ or patchset 3/3 I could, or you could just answer my question. > > This driver is registered

Re: [PATCH v6 02/14] crypto: caam - simplfy clock initialization

2019-07-23 Thread Horia Geanta
On 7/17/2019 6:25 PM, Andrey Smirnov wrote: > Simplify clock initialization code by converting it to use clk-bulk, > devres and soc_device_match() match table. No functional change > intended. > Thanks. Two nitpicks below. > +static int init_clocks(struct device *dev, > +struc

[PATCH v2 2/2] crypto: user - fix potential warnings in cryptouser.h

2019-07-23 Thread Masahiro Yamada
Function definitions in headers are usually marked as 'static inline'. Since 'inline' is missing for crypto_reportstat(), if it were not referenced from a .c file that includes this header, it would produce a warning. Also, 'struct crypto_user_alg' is not declared in this header. I included ins

[PATCH v2 1/2] crypto: add header include guards

2019-07-23 Thread Masahiro Yamada
Add header include guards in case they are included multiple times. Signed-off-by: Masahiro Yamada --- Changes in v2: None include/crypto/sha1_base.h | 5 + include/crypto/sha256_base.h| 5 + include/crypto/sha512_base.h| 5 + include/crypto/sm3_base.h | 5 +

Re: [PATCH v5] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs

2019-07-23 Thread Horia Geanta
On 7/23/2019 12:14 PM, Vakul Garg wrote: > Add support of printing the dpseci frame queue statistics using debugfs. > > Signed-off-by: Vakul Garg Reviewed-by: Horia Geantă Thanks, Horia

Re: [PATCH v6 08/14] crypto: caam - make CAAM_PTR_SZ dynamic

2019-07-23 Thread Horia Geanta
On 7/17/2019 6:25 PM, Andrey Smirnov wrote: > In order to be able to configure CAAM pointer size at run-time, which > needed to support i.MX8MQ, which is 64-bit SoC with 32-bit pointer > size, convert CAAM_PTR_SZ to refer to a global variable of the same > name ("caam_ptr_sz") and adjust the rest o

RE: [PATCH v4] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs

2019-07-23 Thread Vakul Garg
> -Original Message- > From: Horia Geanta > Sent: Tuesday, July 23, 2019 2:38 PM > To: Vakul Garg ; linux-crypto@vger.kernel.org > Cc: Aymen Sghaier ; > herb...@gondor.apana.org.au > Subject: Re: [PATCH v4] crypto: caam/qi2 - Add printing dpseci fq stats using > debugfs > > On 7/23/2019

[PATCH v5] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs

2019-07-23 Thread Vakul Garg
Add support of printing the dpseci frame queue statistics using debugfs. Signed-off-by: Vakul Garg --- Changes since v4: - Corrected license header commenting style drivers/crypto/caam/Makefile | 1 + drivers/crypto/caam/caamalg_qi2.c| 5 +++ drivers/crypto/caam/caamalg_q

Re: [PATCH v4] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs

2019-07-23 Thread Horia Geanta
On 7/23/2019 11:42 AM, Vakul Garg wrote: > diff --git a/drivers/crypto/caam/dpseci-debugfs.c > b/drivers/crypto/caam/dpseci-debugfs.c > new file mode 100644 > index ..2e43ba9b7491 > --- /dev/null > +++ b/drivers/crypto/caam/dpseci-debugfs.c > @@ -0,0 +1,80 @@ > +/* SPDX-License-Identif

[PATCH v4] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs

2019-07-23 Thread Vakul Garg
Add support of printing the dpseci frame queue statistics using debugfs. Signed-off-by: Vakul Garg --- Please ignore PATCH v3. Changes since v2: - Replaced CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM_DEBUGFS with CONFIG_DEBUG_FS. drivers/crypto/caam/Makefile | 1 + drivers/cryp

[PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return

2019-07-23 Thread Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/crypto/nx/nx-842-po

[PATCH] crypto: qat - Silence smp_processor_id() warning

2019-07-23 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
From: Alexander Sverdlin It seems that smp_processor_id() is only used for a best-effort load-balancing, refer to qat_crypto_get_instance_node(). It's not feasible to disable preemption for the duration of the crypto requests. Therefore, just silence the warning. This commit is similar to e7a9b05

[PATCH] crypto: atmel-sha204a: Use device-managed registration API

2019-07-23 Thread Chuhong Yuan
Use devm_hwrng_register to get rid of manual unregistration. Signed-off-by: Chuhong Yuan --- drivers/crypto/atmel-sha204a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index ea0d2068ea4f..c96c14e7dab1 10064