On 7/23/2019 11:42 AM, Vakul Garg wrote:
> diff --git a/drivers/crypto/caam/dpseci-debugfs.c 
> b/drivers/crypto/caam/dpseci-debugfs.c
> new file mode 100644
> index 000000000000..2e43ba9b7491
> --- /dev/null
> +++ b/drivers/crypto/caam/dpseci-debugfs.c
> @@ -0,0 +1,80 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> +/* Copyright 2019 NXP
> + */

.c and .h files have different syntax, see:
https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax

> diff --git a/drivers/crypto/caam/dpseci-debugfs.h 
> b/drivers/crypto/caam/dpseci-debugfs.h
> new file mode 100644
> index 000000000000..1dbdb2587758
> --- /dev/null
> +++ b/drivers/crypto/caam/dpseci-debugfs.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> +/* Copyright 2019 NXP
> + */

Yet another nitpick: incorrect commenting style (for the 2nd comment)
https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting

Why not make it a single-line comment?

Sorry for not catching these earlier.

Horia

Reply via email to