Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-26 Thread Herbert Xu
Haren Myneni wrote: > > System gets checkstop if RxFIFO overruns with more requests than the > maximum possible number of CRBs in FIFO at the same time. The max number > of requests per window is controlled by window credits. So find max > CRBs from FIFO size and set it to receive window credi

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-26 Thread Samuel Neves
, On Wed, Jun 26, 2019 at 8:40 AM Milan Broz wrote: > > On 26/06/2019 09:15, Ard Biesheuvel wrote: > > > Thanks for the insight. So I guess we have consensus that MORUS should > > be removed. How about aegis128l and aegis256, which have been > > disregarded in favor of aegis128 by CAESAR (note tha

Re: [PATCH v2 2/2] crypto: doc - Fix formatting of new crypto engine content

2019-06-26 Thread Gary R Hook
On 6/25/19 7:13 PM, Joe Perches wrote: > On Tue, 2019-06-25 at 23:43 +, Hook, Gary wrote: >> Tidy up the formatting/grammar in crypto_engine.rst. Use bulleted lists >> where appropriate. > > Hi again Gary. Howdy! > >> diff --git a/Documentation/crypto/crypto_engine.rst >> b/Documentation/c

Re: [PATCH] crypto: ccp - Validate the the error value used to index error messages

2019-06-26 Thread Lendacky, Thomas
On 6/25/19 6:44 PM, Hook, Gary wrote: > The error code read from the queue status register is only 6 bits wide, > but we need to verify its value is within range before indexing the error > messages. Also, fill out the array with all possible entries so that any > unexpected error codes are report

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-26 Thread Milan Broz
On 26/06/2019 09:15, Ard Biesheuvel wrote: > Thanks for the insight. So I guess we have consensus that MORUS should > be removed. How about aegis128l and aegis256, which have been > disregarded in favor of aegis128 by CAESAR (note that I sent an > accelerated ARM/arm64 version of aegis128 based on

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-26 Thread Ard Biesheuvel
On Wed, 26 Jun 2019 at 09:00, Milan Broz wrote: > > On 25/06/2019 20:37, Ard Biesheuvel wrote: > > On Tue, 25 Jun 2019 at 19:12, Eric Biggers wrote: > >> > >> [+Cc Milan] > > I was discussing this with Ondra before he sent the reply, anyway comments > below: > > >> On Tue, Jun 25, 2019 at 04:52:

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-26 Thread Milan Broz
On 25/06/2019 20:37, Ard Biesheuvel wrote: > On Tue, 25 Jun 2019 at 19:12, Eric Biggers wrote: >> >> [+Cc Milan] I was discussing this with Ondra before he sent the reply, anyway comments below: >> On Tue, Jun 25, 2019 at 04:52:54PM +0200, Ard Biesheuvel wrote: >>> MORUS was not selected as a w