Re: [PATCH v2 00/26]crypto: AES cleanup

2019-06-25 Thread Eric Biggers
On Sat, Jun 22, 2019 at 09:34:01PM +0200, Ard Biesheuvel wrote: > This started out as an attempt to provide synchronous SIMD based GCM > on 32-bit ARM, but along the way, I ended up changing and cleaning up > so many things that it is more of a general AES cleanup now rather than > anything else. >

Re: [RFC PATCH 30/30] fs: cifs: move from the crypto cipher API to the new DES library interface

2019-06-25 Thread Eric Biggers
On Sat, Jun 22, 2019 at 02:31:12AM +0200, Ard Biesheuvel wrote: > Some legacy code in the CIFS driver uses single DES to calculate > some password hash, and uses the crypto cipher API to do so. Given > that there is no point in invoking an accelerated cipher for doing > 56-bit symmetric encryption

Re: [RFC PATCH 00/30] crypto: DES/3DES cleanup

2019-06-25 Thread Eric Biggers
On Sat, Jun 22, 2019 at 02:30:42AM +0200, Ard Biesheuvel wrote: > In my effort to remove crypto_alloc_cipher() invocations from non-crypto > code, i ran into a DES call in the CIFS driver. This is addressed in > patch #30. > > The other patches are cleanups for the quirky DES interface, and lots >

Re: [PATCH v2 2/2] crypto: doc - Fix formatting of new crypto engine content

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 23:43 +, Hook, Gary wrote: > Tidy up the formatting/grammar in crypto_engine.rst. Use bulleted lists > where appropriate. Hi again Gary. > diff --git a/Documentation/crypto/crypto_engine.rst > b/Documentation/crypto/crypto_engine.rst [] > +Before transferring any reques

[PATCH] crypto: ccp - Validate the the error value used to index error messages

2019-06-25 Thread Hook, Gary
The error code read from the queue status register is only 6 bits wide, but we need to verify its value is within range before indexing the error messages. Also, fill out the array with all possible entries so that any unexpected error codes are reported as "unknown". Fixes: 81422badb3907 ("crypt

[PATCH v2 2/2] crypto: doc - Fix formatting of new crypto engine content

2019-06-25 Thread Hook, Gary
Tidy up the formatting/grammar in crypto_engine.rst. Use bulleted lists where appropriate. Signed-off-by: Gary R Hook --- Documentation/crypto/crypto_engine.rst | 111 +--- 1 file changed, 73 insertions(+), 38 deletions(-) diff --git a/Documentation/crypto/crypto_en

[PATCH v2 0/2] Clean up crypto documentation

2019-06-25 Thread Hook, Gary
Tidy up the crypto documentation by filling in some variable descriptions, make some grammatical corrections, and enhance formatting. Changes since v1: - Remove patch with superfluous change to index (patch 2) - Remove unnecessary markup on function names in patch 3 - Un-add extraneous white sp

[PATCH v2 1/2] crypto: doc - Add parameter documentation

2019-06-25 Thread Hook, Gary
Fill in missing parameter descriptions for the compression algorithm, then pick them up to document for the compression_alg structure. Signed-off-by: Gary R Hook --- Documentation/crypto/api-skcipher.rst |2 +- include/linux/crypto.h| 11 +++ 2 files changed, 12 ins

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-25 Thread Ard Biesheuvel
On Tue, 25 Jun 2019 at 19:12, Eric Biggers wrote: > > [+Cc Milan] > > On Tue, Jun 25, 2019 at 04:52:54PM +0200, Ard Biesheuvel wrote: > > MORUS was not selected as a winner in the CAESAR competition, which > > is not surprising since it is considered to be cryptographically > > broken. (Note that

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-25 Thread Geert Uytterhoeven
Hi Ard, On Tue, Jun 25, 2019 at 5:58 PM Ard Biesheuvel wrote: > On Tue, 25 Jun 2019 at 17:27, Geert Uytterhoeven wrote: > > On Tue, Jun 25, 2019 at 4:53 PM Ard Biesheuvel > > wrote: > > > MORUS was not selected as a winner in the CAESAR competition, which > > > is not surprising since it is con

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-25 Thread Eric Biggers
[+Cc Milan] On Tue, Jun 25, 2019 at 04:52:54PM +0200, Ard Biesheuvel wrote: > MORUS was not selected as a winner in the CAESAR competition, which > is not surprising since it is considered to be cryptographically > broken. (Note that this is not an implementation defect, but a flaw > in the underl

Re: [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns

2019-06-25 Thread Michal Suchánek
On Tue, 25 Jun 2019 09:40:54 -0700 Eric Biggers wrote: Hello, > Hi Michal, > > The stack trace shows that crypto_remove_spawns() is being called from > crypto_unregister_instance(). Therefore, the instance should already be > registered and have initialized cra_users. Now, I don't claim to u

Re: [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns

2019-06-25 Thread Eric Biggers
Hi Michal, On Tue, Jun 25, 2019 at 09:16:24AM +0200, Michal Suchanek wrote: > Reportedly on Linux 4.12 the LTP testsuite crashes at pcrypt_aead01 > infrequently. > > To get it reproduce more frequently I tried > > n=0 ; while true ; do /opt/ltp/testcases/bin/pcrypt_aead01 >& /dev/null ; > n=$(

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-25 Thread Ard Biesheuvel
On Tue, 25 Jun 2019 at 17:27, Geert Uytterhoeven wrote: > > Hi Ard, > > On Tue, Jun 25, 2019 at 4:53 PM Ard Biesheuvel > wrote: > > MORUS was not selected as a winner in the CAESAR competition, which > > is not surprising since it is considered to be cryptographically > > broken. (Note that this

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Gary R Hook
On 6/25/19 8:52 AM, Jonathan Corbet wrote: > On Tue, 25 Jun 2019 13:33:27 + > Gary R Hook wrote: > >>> It's been "valid" since I wrote it...it's just not upstream yet :) I >>> expect it to be in 5.3, though. So the best way to refer to a kernel >>> function, going forward, is just function(

Re: [PATCH] crypto: morus - remove generic and x86 implementations

2019-06-25 Thread Geert Uytterhoeven
Hi Ard, On Tue, Jun 25, 2019 at 4:53 PM Ard Biesheuvel wrote: > MORUS was not selected as a winner in the CAESAR competition, which > is not surprising since it is considered to be cryptographically > broken. (Note that this is not an implementation defect, but a flaw > in the underlying algorith

Re: [PATCH 0/6] crypto: aegis128 - add NEON intrinsics version for ARM/arm64

2019-06-25 Thread Ard Biesheuvel
On Tue, 25 Jun 2019 at 16:07, Ondrej Mosnacek wrote: > > On Mon, Jun 24, 2019 at 6:57 PM Eric Biggers wrote: > > On Mon, Jun 24, 2019 at 09:38:12AM +0200, Ard Biesheuvel wrote: > > > Now that aegis128 has been announced as one of the winners of the CAESAR > > > competition, it's time to provide s

Re: [PATCH 0/6] crypto: aegis128 - add NEON intrinsics version for ARM/arm64

2019-06-25 Thread Ondrej Mosnacek
On Mon, Jun 24, 2019 at 6:57 PM Eric Biggers wrote: > On Mon, Jun 24, 2019 at 09:38:12AM +0200, Ard Biesheuvel wrote: > > Now that aegis128 has been announced as one of the winners of the CAESAR > > competition, it's time to provide some better support for it on arm64 (and > > 32-bit ARM *) > > >

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Jonathan Corbet
On Tue, 25 Jun 2019 13:33:27 + Gary R Hook wrote: > > It's been "valid" since I wrote it...it's just not upstream yet :) I > > expect it to be in 5.3, though. So the best way to refer to a kernel > > function, going forward, is just function() with no markup needed. > > So I'm unclear: >

Re: [PATCH 0/3] Clean up crypto documentation

2019-06-25 Thread Gary R Hook
On 6/24/19 3:37 PM, Jonathan Corbet wrote: > On Mon, 24 Jun 2019 13:29:42 -0700 > Joe Perches wrote: > >>> Finally, would you prefer a v2 of the patch set? Happy to do >>> whatever is preferred, of course. >> >> Whatever Jonathan decides is fine with me. >> Mine was just a plea to avoid unnecessa

Re: [PATCH 03/11] crypto: ccp - Expose the value of nqueues in DebugFS

2019-06-25 Thread Gary R Hook
On 6/24/19 4:59 PM, Lendacky, Thomas wrote: > On 6/24/19 2:28 PM, Hook, Gary wrote: >> Make module parameters readable in DebugFS. > > Not sure why you have this... you can access the module parameters in > /sys/module/ccp/parameters. You can then get/set them based on the > value in the module_p

Re: [PATCH 2/3] crypto: doc - Describe the crypto engine

2019-06-25 Thread Gary R Hook
On 6/24/19 5:03 PM, Eric Biggers wrote: > On Mon, Jun 24, 2019 at 07:07:49PM +, Hook, Gary wrote: >> Add a reference to the crypto engine documentation to >> the index. >> >> Signed-off-by: Gary R Hook >> --- >> Documentation/crypto/index.rst |1 + >> 1 file changed, 1 insertion(+) >> >

[PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns

2019-06-25 Thread Michal Suchanek
Reportedly on Linux 4.12 the LTP testsuite crashes at pcrypt_aead01 infrequently. To get it reproduce more frequently I tried n=0 ; while true ; do /opt/ltp/testcases/bin/pcrypt_aead01 >& /dev/null ; n=$(expr $n + 1) ; echo -ne $n\\r ; done but this is quite stable. However, holding ^C in the