Re: [PATCH v3] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Stephan Mueller
Am Freitag, 3. Mai 2019, 03:42:41 CEST schrieb Herbert Xu: Hi Herbert, > On Thu, May 02, 2019 at 06:38:12PM +0200, Stephan Müller wrote: > > +static int drbg_fips_continuous_test(struct drbg_state *drbg, > > +const unsigned char *entropy) > > +{ > > +#if IS_ENABLED

Re: [PATCH v3] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Herbert Xu
On Thu, May 02, 2019 at 06:38:12PM +0200, Stephan Müller wrote: > +static int drbg_fips_continuous_test(struct drbg_state *drbg, > + const unsigned char *entropy) > +{ > +#if IS_ENABLED(CONFIG_CRYPTO_FIPS) This should look like if (IS_ENABLED(CONFIG_CRYPTO

[PATCH v3] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Stephan Müller
Changes v3: * fix return code of drbg_fips_continuous_test in non-FIPS mode ---8<--- FIPS 140-2 section 4.9.2 requires a continuous self test of the noise source. Up to kernel 4.8 drivers/char/random.c provided this continuous self test. Afterwards it was moved to a location that is inconsistent

[PATCH v2] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Stephan Müller
Changes v2: * use IS_ENABLED macro * small fix in comment ---8<--- FIPS 140-2 section 4.9.2 requires a continuous self test of the noise source. Up to kernel 4.8 drivers/char/random.c provided this continuous self test. Afterwards it was moved to a location that is inconsistent with the FIPS 140-

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-05-02 Thread Horia Geanta
On 4/27/2019 8:03 PM, Eric Biggers wrote: > On Sat, Apr 27, 2019 at 03:24:38PM +, Horia Geanta wrote: >> On 4/26/2019 7:54 PM, Eric Biggers wrote: >>> Hi Horia, >>> >>> On Fri, Apr 26, 2019 at 04:35:05PM +, Horia Geanta wrote: On 4/12/2019 8:00 AM, Eric Biggers wrote: > So far I've

Re: [PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Stephan Mueller
Am Donnerstag, 2. Mai 2019, 14:48:11 CEST schrieb Herbert Xu: Hi Herbert, > Hi Stephan: > > On Thu, May 02, 2019 at 02:40:51PM +0200, Stephan Müller wrote: > > +static int drbg_fips_continuous_test(struct drbg_state *drbg, > > +const unsigned char *entropy) > > +{

Re: [PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Herbert Xu
Hi Stephan: On Thu, May 02, 2019 at 02:40:51PM +0200, Stephan Müller wrote: > > +static int drbg_fips_continuous_test(struct drbg_state *drbg, > + const unsigned char *entropy) > +{ > +#ifdef CONFIG_CRYPTO_FIPS Please use the IS_ENABLED macro from linux/kconfig.h

[PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

2019-05-02 Thread Stephan Müller
FIPS 140-2 section 4.9.2 requires a continuous self test of the noise source. Up to kernel 4.8 drivers/char/random.c provided this continuous self test. Afterwards it was moved to a location that is inconsistent with the FIPS 140-2 requirements. Thus, the FIPS 140-2 CTRNG is added to the DRBG when

[PATCH 4/4] MAINTAINERS: Maintainer for Chelsio crypto driver

2019-05-02 Thread Atul Gupta
Modified the maintainer name Signed-off-by: Atul Gupta --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf7..0d0dda5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4254,7 +4254,7 @@ F:drivers/infiniband/hw/cxgb3/ F:

[PATCH 3/4] crypto:chelsio count incomplete block in IV

2019-05-02 Thread Atul Gupta
The partial block should count as one and appropriately appended to IV. eg 499B for AES CTR should count 32 block than 31 and correct count value is updated in iv out. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/4] crypto:chelsio Fix softlockup with heavy I/O

2019-05-02 Thread Atul Gupta
removed un-necessary lock_chcr_dev to protect device state DETACH. lock is not required to protect I/O count Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 13 +++-- drivers/crypto/chelsio/chcr_core.c | 4 2 files changed, 3 insertions(+), 14 deletions(-) diff

[PATCH 1/4] crypto:chelsio Fix NULL pointer dereference

2019-05-02 Thread Atul Gupta
Do not request FW to generate cidx update if there is less space in tx queue to post new request. SGE DBP 1 pidx increment too large BUG: unable to handle kernel NULL pointer dereference at 0124 SGE error for queue 101 Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_ipsec.c

Re: [PATCH 1/5] i2c: acpi: permit bus speed to be discovered after enumeration

2019-05-02 Thread Mika Westerberg
On Tue, Apr 30, 2019 at 06:29:05PM +0200, Ard Biesheuvel wrote: > Currently, the I2C ACPI enumeration code only permits the max bus rate > to be discovered before enumerating the slaves on the bus. In some > cases, drivers for slave devices may require this information, e.g., > some ATmel crypto dr